| 36352bf5e38f45a70ee4f4fc132a38048d38206d |
|
26-Mar-2015 |
mtklein <mtklein@chromium.org> |
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}
NOPRESUBMIT=true
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002
Review URL: https://codereview.chromium.org/1037793002
/external/skia/tests/RecordDrawTest.cpp
|
| 23d8593f8127411d9d687b4565b34b4ecd6b11d3 |
|
07-Mar-2015 |
schenney <schenney@chromium.org> |
Update SkPicture cull rects with RTree information
When computed, the RTree for an SkPicture will have a root
bounds that reflects the best bounding information available,
rather than the best estimate at the time the picture recorder
is created. Given that creators frequently don't know ahead of
time what will be drawn, the RTree bound is often tighter.
Perf testing on Chrome indicates a small raster performance
advantage. For upcoming painting changes in Chrome the
performance advantage is much larger.
BUG=
Committed: https://skia.googlesource.com/skia/+/2dd3b6647dc726f36fd8774b3d0d2e83b493aeac
Review URL: https://codereview.chromium.org/971803002
/external/skia/tests/RecordDrawTest.cpp
|
| a0865b4620cc614586a5c02f258da2436ed3ab2b |
|
05-Mar-2015 |
joshualitt <joshualitt@google.com> |
Revert of Update SkPicture cull rects with RTree information (patchset #6 id:140001 of https://codereview.chromium.org/971803002/)
Reason for revert:
Might be breaking deps roll
Original issue's description:
> Update SkPicture cull rects with RTree information
>
> When computed, the RTree for an SkPicture will have a root
> bounds that reflects the best bounding information available,
> rather than the best estimate at the time the picture recorder
> is created. Given that creators frequently don't know ahead of
> time what will be drawn, the RTree bound is often tighter.
>
> Perf testing on Chrome indicates a small raster performance
> advantage. For upcoming painting changes in Chrome the
> performance advantage is much larger.
>
> BUG=
>
> Committed: https://skia.googlesource.com/skia/+/2dd3b6647dc726f36fd8774b3d0d2e83b493aeac
TBR=mtklein@google.com,schenney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/977413003
/external/skia/tests/RecordDrawTest.cpp
|
| 2dd3b6647dc726f36fd8774b3d0d2e83b493aeac |
|
05-Mar-2015 |
schenney <schenney@chromium.org> |
Update SkPicture cull rects with RTree information
When computed, the RTree for an SkPicture will have a root
bounds that reflects the best bounding information available,
rather than the best estimate at the time the picture recorder
is created. Given that creators frequently don't know ahead of
time what will be drawn, the RTree bound is often tighter.
Perf testing on Chrome indicates a small raster performance
advantage. For upcoming painting changes in Chrome the
performance advantage is much larger.
BUG=
Review URL: https://codereview.chromium.org/971803002
/external/skia/tests/RecordDrawTest.cpp
|
| bfd5bff75c0ce27a70f02e4b5578d66aa9d6e306 |
|
10-Feb-2015 |
mtklein <mtklein@chromium.org> |
Simplify SkBBH::insert API
No one's exploiting the ability to take ownership of the array anymore.
BUG=skia:
Review URL: https://codereview.chromium.org/913833002
/external/skia/tests/RecordDrawTest.cpp
|
| 72c9faab45124e08c85f70ca38536914862d947c |
|
09-Jan-2015 |
mtklein <mtklein@chromium.org> |
Fix up all the easy virtual ... SK_OVERRIDE cases.
This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.
for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end
BUG=skia:
Review URL: https://codereview.chromium.org/806653007
/external/skia/tests/RecordDrawTest.cpp
|
| 783fe16b8ed1cd1cff34eacc33296874a32f293b |
|
07-Jan-2015 |
robertphillips <robertphillips@google.com> |
Rename SkDrawPictureCallback to SkPicture::AbortCallback
Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c
Review URL: https://codereview.chromium.org/829983003
/external/skia/tests/RecordDrawTest.cpp
|
| 8ea6dabbb15ef276645b7a6ebab44a4a532ac990 |
|
07-Jan-2015 |
reed <reed@chromium.org> |
Revert of Rename SkDrawPictureCallback to SkPicture::AbortCallback (patchset #2 id:20001 of https://codereview.chromium.org/829983003/)
Reason for revert:
speculative revert to unblock DEPS roll
Original issue's description:
> Rename SkDrawPictureCallback to SkPicture::AbortCallback
>
> Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c
TBR=reed@google.com,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/824013004
/external/skia/tests/RecordDrawTest.cpp
|
| 7ef197255deb4e2fa64c03c7130d56ddf164e83c |
|
06-Jan-2015 |
robertphillips <robertphillips@google.com> |
Rename SkDrawPictureCallback to SkPicture::AbortCallback
Review URL: https://codereview.chromium.org/829983003
/external/skia/tests/RecordDrawTest.cpp
|
| 41af966ab338e95eee81ab618ab28195075338f7 |
|
05-Jan-2015 |
reed <reed@google.com> |
Revert of Revert of move remaining virtual draw methods to onDraw (patchset #1 id:1 of https://codereview.chromium.org/835913002/)
Reason for revert:
test to see if it wasn't this CL that broke chromeos
Original issue's description:
> Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/817723005/)
>
> Reason for revert:
> did this cause chromeos heap corruption on skp?
>
> Original issue's description:
> > move remaining virtual draw methods to onDraw
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419
>
> TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e87e383351e1547b21d96d02bcd0c3cbbe0837f1
TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com,reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/831253002
/external/skia/tests/RecordDrawTest.cpp
|
| e87e383351e1547b21d96d02bcd0c3cbbe0837f1 |
|
05-Jan-2015 |
reed <reed@chromium.org> |
Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/817723005/)
Reason for revert:
did this cause chromeos heap corruption on skp?
Original issue's description:
> move remaining virtual draw methods to onDraw
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419
TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/835913002
/external/skia/tests/RecordDrawTest.cpp
|
| 2e0f7d53bba5438c9bf11ee5ccae2c301e348419 |
|
05-Jan-2015 |
reed <reed@chromium.org> |
move remaining virtual draw methods to onDraw
BUG=skia:
Review URL: https://codereview.chromium.org/817723005
/external/skia/tests/RecordDrawTest.cpp
|
| d990e2f14f14c36c3d0beb303dd0953c7aa1fcfa |
|
22-Dec-2014 |
reed <reed@google.com> |
add testing flag to ignore saveLayer bounds
BUG=skia:
Review URL: https://codereview.chromium.org/819123003
/external/skia/tests/RecordDrawTest.cpp
|
| 9a5380dd358a9c559a41beef7cb368cd7f0ca51f |
|
16-Dec-2014 |
mtklein <mtklein@google.com> |
Revert of Use SkPaint::getFontBounds() for text bounding boxes in pictures. (patchset #1 id:1 of https://codereview.chromium.org/805983003/)
Reason for revert:
Test-Win7-ShuttleA-HD2000-x86-Debug-GDI
Original issue's description:
> Use SkPaint::getFontBounds() for text bounding boxes in pictures.
>
> Now that SkTextBlobs have landed, this is a perf no-op, but it at least lets us eliminate a bunch of questionable hacks.
>
> CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot,Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/02d2b9831579173e783569530ab7bae08de907e9
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/789793004
/external/skia/tests/RecordDrawTest.cpp
|
| 02d2b9831579173e783569530ab7bae08de907e9 |
|
16-Dec-2014 |
mtklein <mtklein@chromium.org> |
Use SkPaint::getFontBounds() for text bounding boxes in pictures.
Now that SkTextBlobs have landed, this is a perf no-op, but it at least lets us eliminate a bunch of questionable hacks.
CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot,Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot
BUG=skia:
Review URL: https://codereview.chromium.org/805983003
/external/skia/tests/RecordDrawTest.cpp
|
| 2ff1fcede1e9525285c5de1f35fb2dcb0fab32bd |
|
11-Dec-2014 |
reed <reed@google.com> |
Defer saves() until they're needed
patch from issue 759443006 at patchset 40001 (http://crrev.com/759443006#ps40001)
BUG=skia:
Review URL: https://codereview.chromium.org/767333002
/external/skia/tests/RecordDrawTest.cpp
|
| 3054be16dfdb0d06233770cbfc338958edef44ea |
|
10-Dec-2014 |
reed <reed@google.com> |
Remove canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul
patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001)
BUG=skia:
TBR=
re-landing after chrome fixes have landed
Review URL: https://codereview.chromium.org/784223007
/external/skia/tests/RecordDrawTest.cpp
|
| a8918a065075dece6e407cce0dfddf110e5d61a9 |
|
09-Dec-2014 |
reed <reed@google.com> |
Revert of remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul (patchset #3 id:40001 of https://codereview.chromium.org/790733003/)
Reason for revert:
need to update chrome first
Original issue's description:
> remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul
>
> patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001)
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2c1605a1fbaa2e35a27399a34254fb1200ec2ae6
TBR=fmalita@google.com,fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/791763002
/external/skia/tests/RecordDrawTest.cpp
|
| 2c1605a1fbaa2e35a27399a34254fb1200ec2ae6 |
|
09-Dec-2014 |
reed <reed@google.com> |
remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul
patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001)
BUG=skia:
Review URL: https://codereview.chromium.org/790733003
/external/skia/tests/RecordDrawTest.cpp
|
| 8eddfb50c0c9e4bcba6384a2ce39852b5fb5becb |
|
04-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip
This reverts commit af641a1c10f176cb9617026d3cc93c117a85d13d.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/783493002
/external/skia/tests/RecordDrawTest.cpp
|
| af641a1c10f176cb9617026d3cc93c117a85d13d |
|
03-Dec-2014 |
reed <reed@chromium.org> |
Revert "Change clear() to respect the clip"
This reverts commit 3729469d6a12266037b697c2192768545e097ab0.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/778563002
/external/skia/tests/RecordDrawTest.cpp
|
| 3729469d6a12266037b697c2192768545e097ab0 |
|
02-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip
patch from issue 769703002 at patchset 1 (http://crrev.com/769703002#ps1)
BUG=skia:
Review URL: https://codereview.chromium.org/772533004
/external/skia/tests/RecordDrawTest.cpp
|
| 1bdfd3f4f09e47364f76d3f08177b1ce844ac786 |
|
24-Nov-2014 |
reed <reed@google.com> |
option to return drawable from recording
patch from issue 747033005 at patchset 80001 (http://crrev.com/747033005#ps80001)
BUG=skia:
Review URL: https://codereview.chromium.org/732653004
/external/skia/tests/RecordDrawTest.cpp
|
| 158fcaa031d105dc999d9813fee8927db56a871c |
|
19-Nov-2014 |
tomhudson <tomhudson@chromium.org> |
Implement SkPicture::bytesUsed() for SkRecord backend
BUG=chromium:230419
R=mtklein@google.com,reed@google.com
Review URL: https://codereview.chromium.org/490253003
/external/skia/tests/RecordDrawTest.cpp
|
| 6be2aa9a251bf6022570a03140f956655b3ef1da |
|
18-Nov-2014 |
reed <reed@google.com> |
wip for drawables
Idea:
1. in its mutable recording state, keep a table of drawables on the side, and store an index in the record list.
2. In "immediate-mode" draw, just call the clients drawable directly (need access to our private list to turn the stored index into a proc)
3. when we "snap", we replace the list of drawables with a list of (sub) pictures, and then during playback of the snapped picture, we invoke a private drawable which just calls "drawPicture" on the index'd subpicture.
Review URL: https://codereview.chromium.org/727363003
/external/skia/tests/RecordDrawTest.cpp
|
| ad8aa1dcf36d64ddf849b914281713b901a01f49 |
|
12-Nov-2014 |
mtklein <mtklein@chromium.org> |
Clang incorrectly thinks this typedef is unused.
BUG=skia:3059
Review URL: https://codereview.chromium.org/715093003
/external/skia/tests/RecordDrawTest.cpp
|
| 4d52afef5cf90a2fed3bb69db71675c6450ab397 |
|
03-Nov-2014 |
robertphillips <robertphillips@google.com> |
Shrink saveLayer device bounds when it supplies an explicit bounds and has a complex paint
This CL shrinks the bound computed for saveLayers that possess both an explicit
bound and a complex paint (e.g., one that affects transparent black). In this
case the bound of the layer should be the clipped explicit bound rather then
the clip prior/after the saveLayer/restore block.
In the following the first bound is the currently computed bound
while the second is the new/desired one:
For a 100x100 picture
saveLayer (no bound, no paint) [ 0 0 100 100 ] [ 50 50 100 100 ]
setMatrix (translate 50, 50) [ 0 0 100 100 ] [ 50 50 100 100 ]
saveLayer (bound of 0, 0, 50, 50 - complex paint) [ 0 0 100 100 ] [ 50 50 100 100 ]
restore [ 0 0 100 100 ] [ 50 50 100 100 ]
restore [ 0 0 100 100 ] [ 50 50 100 100 ]
Review URL: https://codereview.chromium.org/696763002
/external/skia/tests/RecordDrawTest.cpp
|
| ed167acb7b494bf0aece05ac8a68b560782b027c |
|
30-Oct-2014 |
mtklein <mtklein@google.com> |
Revert of Use SkTypeface::getBounds() in bounding-box calculations. (patchset #5 id:80001 of https://codereview.chromium.org/680363003/)
Reason for revert:
Mac mini asserting
Original issue's description:
> Use SkTypeface::getBounds() in bounding-box calculations.
>
> This should produce tighter conservative bounding boxes for text than the
> approximation code it replaces.
>
> Recording performance is neutral on my desktop. Playback performance
> improves by up to 15% on text heavy pages, e.g.
>
> desk_pokemonwiki.skp_1 3.24ms -> 2.83ms 0.87x
> desk_baidu.skp_1 1.91ms -> 1.58ms 0.83x
>
> Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489
>
> CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/c51add674dfb89b988a7fbc05f41838c203f9dcd
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/690833002
/external/skia/tests/RecordDrawTest.cpp
|
| c51add674dfb89b988a7fbc05f41838c203f9dcd |
|
29-Oct-2014 |
mtklein <mtklein@chromium.org> |
Use SkTypeface::getBounds() in bounding-box calculations.
This should produce tighter conservative bounding boxes for text than the
approximation code it replaces.
Recording performance is neutral on my desktop. Playback performance
improves by up to 15% on text heavy pages, e.g.
desk_pokemonwiki.skp_1 3.24ms -> 2.83ms 0.87x
desk_baidu.skp_1 1.91ms -> 1.58ms 0.83x
Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489
CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot
Review URL: https://codereview.chromium.org/680363003
/external/skia/tests/RecordDrawTest.cpp
|
| 27f965a577262deb9182c6935f3af05bb52b817c |
|
29-Oct-2014 |
mtklein <mtklein@google.com> |
Revert of Use SkTypeface::getBounds() in bounding-box calculations. (patchset #3 id:40001 of https://codereview.chromium.org/680363003/)
Reason for revert:
http://build.chromium.org/p/client.skia/builders/Test-Win7-ShuttleA-HD2000-x86-Debug/builds/97/steps/nanobench/logs/stdio
Original issue's description:
> Use SkTypeface::getBounds() in bounding-box calculations.
>
> This should produce tighter conservative bounding boxes for text than the
> approximation code it replaces.
>
> Recording performance is neutral on my desktop. Playback performance
> improves by up to 15% on text heavy pages, e.g.
>
> desk_pokemonwiki.skp_1 3.24ms -> 2.83ms 0.87x
> desk_baidu.skp_1 1.91ms -> 1.58ms 0.83x
>
> Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/685173002
/external/skia/tests/RecordDrawTest.cpp
|
| bf8dc343df4fbdcb8af546eb68b640e011a33489 |
|
29-Oct-2014 |
mtklein <mtklein@chromium.org> |
Use SkTypeface::getBounds() in bounding-box calculations.
This should produce tighter conservative bounding boxes for text than the
approximation code it replaces.
Recording performance is neutral on my desktop. Playback performance
improves by up to 15% on text heavy pages, e.g.
desk_pokemonwiki.skp_1 3.24ms -> 2.83ms 0.87x
desk_baidu.skp_1 1.91ms -> 1.58ms 0.83x
Review URL: https://codereview.chromium.org/680363003
/external/skia/tests/RecordDrawTest.cpp
|
| 4477c3c0e6eb064772aefe8737425cd1c2ce557f |
|
27-Oct-2014 |
mtklein <mtklein@chromium.org> |
Cut down SkBBH API more.
- The expected case is now a single bulk-load insert() call instead of N;
- reserve() and flushDeferredInserts() can fold into insert() now;
- SkBBH subclasses may take ownership of the bounds
This appears to be a performance no-op on both my Mac and N5. I guess
even the simplest indirect branch predictor ("same as last time") can predict
the repeated virtual calls to SkBBH::insert() perfectly.
BUG=skia:
Review URL: https://codereview.chromium.org/670213002
/external/skia/tests/RecordDrawTest.cpp
|
| 234f036b3e731e06e616c5291157d3bb4fbfdee2 |
|
23-Oct-2014 |
sugoi <sugoi@chromium.org> |
Adding an option to render only the shadow in SkDropShadowImageFilter
This is basically how blink uses the filter. Currently, I can't use it for "ShadowOnly" mode with the filter at all, but instead of copying the code and risking to have the codepaths diverge, I'm simply going to add the option here.
BUG=skia:
Review URL: https://codereview.chromium.org/646213004
/external/skia/tests/RecordDrawTest.cpp
|
| 41966d49b0cc9dd2250dac4417ed3b365fb6d704 |
|
20-Oct-2014 |
mtklein <mtklein@chromium.org> |
Dilate approximated text bounds to squelch recent assertion failure.
This is once again an issue related to logo fonts, so I don't
see any easy way to add a regression test for this.
BUG=424824
Review URL: https://codereview.chromium.org/665103002
/external/skia/tests/RecordDrawTest.cpp
|
| 65151754b9fdb6a968d7307764c20655d1b680a0 |
|
16-Oct-2014 |
piotaixr <piotaixr@chromium.org> |
Override SkCanvas::drawImage() in SkRecorder.
BUG=skia:2947
Review URL: https://codereview.chromium.org/610003002
/external/skia/tests/RecordDrawTest.cpp
|
| 208d1704c2cc1161ea337a05155f2b9a04edd351 |
|
09-Oct-2014 |
mtklein <mtklein@chromium.org> |
Add SkBBoxHierarchy::reserve() as an optional size hint.
I want to play around with how SkTileGrid stores its tiles. Having a
cap on the number of insert() calls can be pretty handy.
While I'm at it, I gave flush() a default empty impl. Like reserve(),
it's really an optional hook for subclasses.
BUG=skia:
Review URL: https://codereview.chromium.org/639933003
/external/skia/tests/RecordDrawTest.cpp
|
| 8f8c25eabb97da8eda488895f04f2d12cb5ea4cf |
|
02-Oct-2014 |
mtklein <mtklein@chromium.org> |
Demote getCount, getDepth, and clear to RTree-only methods.
We use them only to test RTree.
BUG=skia:
Review URL: https://codereview.chromium.org/622773003
/external/skia/tests/RecordDrawTest.cpp
|
| 6bd41969a0f2283a7a7320bb0025551353c241ec |
|
02-Oct-2014 |
mtklein <mtklein@chromium.org> |
BBHs: void* data -> unsigned data
Now that the old backend's not using BBHs, we can specialize them for
SkRecord's needs. The only thing we really want to store is op index, which
should always be small enough to fit into an unsigned (unsigned also helps keep
it straight from other ints floating around).
This means we'll need half (32-bit) or a quarter (64-bit) the bytes in SkTileGrid,
because we don't have to store an extra int for ordering.
BUG=skia:2834
Review URL: https://codereview.chromium.org/617393004
/external/skia/tests/RecordDrawTest.cpp
|
| 8e393bf70ea2aab9ca31f52c15b518436c7b6055 |
|
01-Oct-2014 |
mtklein <mtklein@chromium.org> |
Don't adjust the bounds after a restore with the restore's paired saveLayer's paint.
It makes no sense for the paint from a saveLayer to effect anything outside its saveLayer/restore block. But as currently written, we'll adjust the clip bounds just after a restore by that paint.
Turns out the test I wrote for the last CL (which caused this bug) actually had the bug baked into its expectations. I've updated them and added some notes to explain.
BUG=418417
Review URL: https://codereview.chromium.org/623563002
/external/skia/tests/RecordDrawTest.cpp
|
| 271a030f5d0d3c59715fbeffb31c761279f3f8ca |
|
23-Sep-2014 |
Mike Klein <mtklein@chromium.org> |
We need to adjust the bounds of clip ops with SaveLayer paints too.
Before this CL, SkRecord only adjusted the bounds of draw ops for SaveLayers' paints.
That worked fine, but as a final step we intersect the bounds of draw ops with the
bounds of the current clip, essentially undoing all that work.
I think the right fix here is to also adjust the bounds of the clip ops.
BUG=skia:2957, 415468
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/595953002
/external/skia/tests/RecordDrawTest.cpp
|
| 4815fe5a0a497b676677fb4e4a0f05c511855490 |
|
16-Sep-2014 |
robertphillips <robertphillips@google.com> |
Fix bug in layer hoisting transition to SkRecord backend
Care must be taken when setting up the initial CTM matrix for partial SkRecord playbacks b.c. all the setMatrix calls will concatenate with the initial matrix (which may be different then the CTM that is required to draw correctly).
R=mtklein@google.com, bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/549143003
/external/skia/tests/RecordDrawTest.cpp
|
| 937c9c7eb4e06d4d3bc495e129c7b8103a5d6c0f |
|
03-Sep-2014 |
mtklein <mtklein@chromium.org> |
Fix drawPosText() bounds bug.
We didn't catch this in our local tests because we tend to use default
kUTF8_TextEncoding with single-byte characters, which means N == byteLength.
BUG=409110
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/531933002
/external/skia/tests/RecordDrawTest.cpp
|
| 00f30bdc9e34b013da54b4406f36556c5be8d041 |
|
02-Sep-2014 |
mtklein <mtklein@chromium.org> |
SkRecordPartialDraw with less code duplication
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/527423002
/external/skia/tests/RecordDrawTest.cpp
|
| 90e8457ab32bcc14b15876144ca47489d7b836ce |
|
28-Aug-2014 |
mtklein <mtklein@chromium.org> |
Increase test tolerance.
NOTREECHECKS=true
CQ_EXTRA_TRYBOTS=tryserver.skia:Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release-Trybot
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/516503003
/external/skia/tests/RecordDrawTest.cpp
|
| 5ff913269377d12bf78be70d6a74607eda2ee05d |
|
28-Aug-2014 |
Mike Klein <mtklein@google.com> |
More test debugging. Too close for decimal. I'm switching to hex.
BUG=skia:
Review URL: https://codereview.chromium.org/515753005
/external/skia/tests/RecordDrawTest.cpp
|
| 56fa44250365cd1cef9f57d642b3d6e90749f025 |
|
28-Aug-2014 |
Mike Klein <mtklein@google.com> |
Add some debugging to figure out what's up with failing Mac 10.8 Release bot.
BUG=skia:
Review URL: https://codereview.chromium.org/511013002
/external/skia/tests/RecordDrawTest.cpp
|
| 533eb782edaa0b6fece6166d3001edf72ec39f11 |
|
27-Aug-2014 |
mtklein <mtklein@chromium.org> |
Convert BBH APIs to use SkRect.
Still TODO: convert internals of SkTileGrid.cpp and SkRTree.cpp to work in floats too.
NOTREECHECKS=true
BUG=skia:1021
R=robertphillips@google.com, reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/511613002
/external/skia/tests/RecordDrawTest.cpp
|
| 62b67ae96e94fd22569b058a3bc4625b9f52ed56 |
|
18-Aug-2014 |
mtklein <mtklein@chromium.org> |
Start actually bounding some draw ops.
This covers most of the common draws.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/469213007
/external/skia/tests/RecordDrawTest.cpp
|
| a723b576aed31a6eb2bdda6388e6bd779d04c6b0 |
|
15-Aug-2014 |
mtklein <mtklein@chromium.org> |
SkRecordDraw: incorporate clip into BBH
NOTREECHECKS=true
BUG=skia:
R=robertphillips@google.com, senorblanco@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/474983002
/external/skia/tests/RecordDrawTest.cpp
|
| 5ad6ee1b2ce54f8e59b9f5a337c688a98a4b0f2a |
|
11-Aug-2014 |
mtklein <mtklein@chromium.org> |
Plumbing for using a BBH in SkRecordDraw.
For now this only creates a degenerate bounding box hierarchy where all ops
just have maximal bounds. I will flesh out FillBounds in future CL(s).
Not quite sure why QuadTree and TileGrid aren't drawing right---haven't even
looked at the diffs yet---so I've disabled those test modes for now. RTree
seems fine, so that'll at least get us coverage for all this new plumbing.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/454123003
/external/skia/tests/RecordDrawTest.cpp
|
| f4078ad1ec42f549369ac4f639aab18d00afae95 |
|
08-Aug-2014 |
mtklein <mtklein@chromium.org> |
SkRecord: Strip out cull-skipping and y-only drawPosTextH skipping.
These optimizations are outclassed by a general bounding-box hierarchy,
and are just going to make plugging that into SkRecordDraw more complicated.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/452983002
/external/skia/tests/RecordDrawTest.cpp
|
| c11530ea73b2a2fcb431df0f5c1887d08ac9113c |
|
24-Jun-2014 |
Mike Klein <mtklein@google.com> |
Tick off some TODOs:
- support fRecord in copy constructor
- support SkDrawPictureCallback
Moved SkDrawPictureCallback to its own header so
SkRecordDraw can include it without pulling in all of
SkPicture.
Adding an SkAutoSaveRestore to SkRecordDraw was the easiest
way to match the balance guarantees of the callback, and
probably not a bad idea in general. Updated its tests.
BUG=skia:
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/349973008
/external/skia/tests/RecordDrawTest.cpp
|
| a095041f5148dd1e71f38d0546335ed94199104b |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove SkRecorder's kWriteOnly mode.
I'm soon going to have SkRecorder start calling getTotalMatrix(), which
would be broken in write-only mode. That change is big and nebulous,
but it's clear kWriteOnly needs to go, so we might as well kill it now.
My notes in bench_playback about kWriteOnly mode being important were
probably overly cautious. I now think this is a fair enough comparison
even re-recording into a read-write canvas.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/290653004
git-svn-id: http://skia.googlecode.com/svn/trunk@14963 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tests/RecordDrawTest.cpp
|
| 0a98d870448f66ea0df7c37a47b38cf2d3b734e5 |
|
19-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Don't clobber initial transform with SetMatrix.
BUG=skia:2378
R=reed@google.com, mtklein@google.com, robertphillips@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/290883004
git-svn-id: http://skia.googlecode.com/svn/trunk@14778 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tests/RecordDrawTest.cpp
|
| 8dac8b18eea8a729062440b85285d19fc890bb1a |
|
30-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Backfill unit tests for SkRecord
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/251133008
git-svn-id: http://skia.googlecode.com/svn/trunk@14455 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tests/RecordDrawTest.cpp
|
| 705b1ff617ffe672e65d53bcaf3b690e8bb6b025 |
|
29-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Don't bother doing the empty clip check in SkRecordDraw.
On Mike's suggestion, I tested out not doing any empty-clip check at all in
SkRecordDraw, given that mostly we'll do that again anyway inside SkCanvas.
Most SKPs are identical to the status quo, whether bot or silk, played back in tiles
or full. Average playback performance, both arithmetic and geometric mean, is also
unchanged.
A handful of SKPs do draw faster or slower reliably, particularly when tiled. E.g. a
cnn tile draws about 40% faster, a cuteoverload tile about 20% slower. Their profiles
look pretty much the same before and after, so I can't really explain the changes.
I'd say, given that performance is mostly identical and very identical in bulk,
we might as well remove this code. It's nice to keep SkRecordDraw as dumb as possible.
BUG=skia:2378
R=reed@google.com, fmalita@chromium.org, mtklein@google.com, borenet@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/258183002
git-svn-id: http://skia.googlecode.com/svn/trunk@14433 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tests/RecordDrawTest.cpp
|
| 2e0c32af0508a1e544c9953ea2fe128dbae7d429 |
|
28-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Start using type traits in src/record instead of macros.
Simplified skip logic by always running clip commands. No performance difference on bot or silk SKPs.
BUG=skia:2378
R=bungeman@google.com, fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/258693006
git-svn-id: http://skia.googlecode.com/svn/trunk@14410 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tests/RecordDrawTest.cpp
|
| ad8ce572f69633ffebe2fa486275d82a5e9a71fe |
|
21-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
anticipate more optimizations by renaming some files and methods
also, call the new SkRecordOptimize in bench_playback
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/243243003
git-svn-id: http://skia.googlecode.com/svn/trunk@14277 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tests/RecordDrawTest.cpp
|
| c4b21e6c03a6cdb03e116b9f510eb10cf8daedb1 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Mark our territory with (C).
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/235253002
git-svn-id: http://skia.googlecode.com/svn/trunk@14158 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tests/RecordDrawTest.cpp
|
| ff2de7cb94847f7e6ad3f5c0047eb6b4815eee2e |
|
10-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkRecordDraw: don't bother clipping an empty clip down further
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com, fmalita@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/231933003
git-svn-id: http://skia.googlecode.com/svn/trunk@14126 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tests/RecordDrawTest.cpp
|
| d9ce2be6b24b1c89d13c2edb63c3462b0f5c6aa3 |
|
10-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkRecordDraw: skip draw ops when the clip is empty
- Adds tests for SkRecordDraw's two main features: cull- and clip- based skipping.
- Adds full SkCanvas semantic mode to SkRecorder, so it can be used as a target for SkRecordDraw.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/231653002
git-svn-id: http://skia.googlecode.com/svn/trunk@14124 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tests/RecordDrawTest.cpp
|