| a9d9a392380952006303d83c35a63a32dffd0b36 |
|
06-Mar-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Read pixels in BGRA non-premul mode in few tests
The tests assert on Sk_ColorGREEN, which is in BRGA non-premul. Read the
pixels in same color format.
Currently the tests pass on all platforms because GREEN is fully opaque
and the component stays in the same place both on BGRA and
RGBA. However, hypothetically somebody could copy-paste the assertion
for further tests but use, say, RED. This creates latent error that is
only visible on some platforms like mac.
Review URL: https://codereview.chromium.org/989463002
/external/skia/tests/SkImageTest.cpp
|
| a9baa652bb329b5a286e1638938f63433701efca |
|
05-Mar-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Revert of Add image as a draw type that can be filtered (patchset #4 id:60001 of https://codereview.chromium.org/960783003/)
Reason for revert:
Fails on mac for some reason.
Also is a bit wrong, but this should not be reason for the failure..
Original issue's description:
> Add image as a draw type that can be filtered
>
> Add image as a draw type that can be filtered.
>
> This is needed when SkImage is added as an object to be drawn so that
> the draw is forwarded to SkBaseDevice. This would be used in making
> filters use SkImages.
>
> BUG=skia:3388
>
> Committed: https://skia.googlesource.com/skia/+/fa77eb1e51b9317ff993d1be504ada173b561e5f
TBR=reed@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3388
Review URL: https://codereview.chromium.org/980273002
/external/skia/tests/SkImageTest.cpp
|
| fa77eb1e51b9317ff993d1be504ada173b561e5f |
|
05-Mar-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Add image as a draw type that can be filtered
Add image as a draw type that can be filtered.
This is needed when SkImage is added as an object to be drawn so that
the draw is forwarded to SkBaseDevice. This would be used in making
filters use SkImages.
BUG=skia:3388
Review URL: https://codereview.chromium.org/960783003
/external/skia/tests/SkImageTest.cpp
|
| 73953e7d00f0a75a98e985ceed88059d35945327 |
|
24-Feb-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Make SkNewImageFromBitmap take pixel ref origin into account
Make SkNewImageFromBitmap take pixel ref origin into account.
BUG=skia:3388
Review URL: https://codereview.chromium.org/951483002
/external/skia/tests/SkImageTest.cpp
|