History log of /external/skia/tools/skpdiff/skpdiff_util.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
6b87df2997980218308954ade47df7fdd6680bc7 06-Oct-2014 tfarina <tfarina@chromium.org> Fix usage of SK_BUILD_* defines.

Since we just 'define' them, but not attribute anything to them, like
'1' for example, cpp expands it to nothing and that breaks the "#if"
clauses.

To fix that, uses "#if defined(...)" which will correctly check if your
macro name was defined or not.

BUG=skia:2850
TEST=make most
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/628763005
/external/skia/tools/skpdiff/skpdiff_util.cpp
49f085dddff10473b6ebf832a974288300224e60 05-Sep-2014 bsalomon <bsalomon@google.com> "NULL !=" = NULL

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/544233002
/external/skia/tools/skpdiff/skpdiff_util.cpp
a8e2e1504b9af6ba791637f228debaa23953064a 29-Jul-2014 tfarina <tfarina@chromium.org> Cleanup: Rename SkOSPath functions.

Mostly for brevity and matches better with Python:

Python | Old C++ | New C++
os.path.join | SkOSPath::SkPathJoin | SkOSPath::Join
os.path.basename | SkOSPath::SkBasename | SkOSPath::Basename

BUG=None
TEST=make all
R=mtklein@google.com, bsalomon@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/428443002
/external/skia/tools/skpdiff/skpdiff_util.cpp
9ac68ee2594f28dfc1bd16a4bf004b1a4f6f228d 20-Jun-2014 mtklein <mtklein@chromium.org> Move BenchTimer to tools as Timer

This breaks a bunch of circular dependencies between tools and gm and bench.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed

CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot
R=tfarina@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/344213003
/external/skia/tools/skpdiff/skpdiff_util.cpp
9e64b78ff687edd24c55c0e26942411468032d32 20-Jun-2014 mtklein <mtklein@google.com> Revert of Move BenchTimer to tools as Timer (https://codereview.chromium.org/344213003/)

Reason for revert:
GpuTimer broken

Original issue's description:
> Move BenchTimer to tools as Timer
>
> This breaks a bunch of circular dependencies between tools and gm and bench.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed

R=tfarina@chromium.org, mtklein@chromium.org
TBR=mtklein@chromium.org, tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/346753003
/external/skia/tools/skpdiff/skpdiff_util.cpp
4ed75287aed6371c6e4a41ffcc78c8a49c9810ed 20-Jun-2014 mtklein <mtklein@chromium.org> Move BenchTimer to tools as Timer

This breaks a bunch of circular dependencies between tools and gm and bench.

BUG=skia:
R=tfarina@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/344213003
/external/skia/tools/skpdiff/skpdiff_util.cpp
adacc7067ad617cdc7bbef39192ca80f4b4d27f9 14-Oct-2013 robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Start cleaning up 64bit Win warnings

https://codereview.chromium.org/27192003/



git-svn-id: http://skia.googlecode.com/svn/trunk@11764 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/skpdiff/skpdiff_util.cpp
a479aa1366734f80360a00e3020f5b148cb3c060 02-Aug-2013 zachr@google.com <zachr@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> fix skpdiff viewer bug when using relative paths

BUG=skia:1463
R=djsollen@google.com

Review URL: https://codereview.chromium.org/21601002

git-svn-id: http://skia.googlecode.com/svn/trunk@10515 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/skpdiff/skpdiff_util.cpp
5b3e2b96227f21d9643ca1678d777fd23767756d 22-Jul-2013 zachr@google.com <zachr@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> move skpdiff into tools

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19608005

git-svn-id: http://skia.googlecode.com/svn/trunk@10249 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/skpdiff/skpdiff_util.cpp
904f86e6aae156df06c2d1a02cf7e91ecfda5d86 22-Jul-2013 zachr@google.com <zachr@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Revert "migrate skpdiff to tools"

This reverts commit 58a7ec70ce6b4548793a2ddc37c63d3d44edbc36.

git-svn-id: http://skia.googlecode.com/svn/trunk@10226 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/skpdiff/skpdiff_util.cpp
a54aaf7fba0dae99305715b8f9d46a875eb6b5a6 22-Jul-2013 zachr@google.com <zachr@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> migrate skpdiff to tools

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19671002

git-svn-id: http://skia.googlecode.com/svn/trunk@10225 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/skpdiff/skpdiff_util.cpp