| 37214cd8af79110b7c8bd82855625287237d30ec |
|
06-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adding a custom function to support legacy API compatibility
Bug: 3210604
Change-Id: I6e9a20ec7887375b67c42a28cff54e2e9d399ea6
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|
| 468ecb9591c35466d0a89b96d205da636a6f66a1 |
|
21-Sep-2009 |
Wei Huang <weih@google.com> |
fix failing test.
Change-Id: I11fc145464e29364dbf302c1e607a07031e1821d
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|
| 948a119c94f8b69760437c7d1e784b498cd9b766 |
|
20-Sep-2009 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Revert the default phone number comparation algorithm.
Now developers have to explicitly set the third argument of PHONE_NUMBERS_COMPARE() into 1,
when they want to use "strict" phone number comparation algorithm, which was used in Donut.
In default, PHONE_NUMBER_COMPARE() now uses "loose" phone number comparation algorithm,
which had been used in Cupcake.
Internal issue id: 1892808
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|
| b3b8a9dac508afdbac8de93a31a752c60e34e254 |
|
01-Sep-2009 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fix the implementation of phone_number_compare in accordance with the tests in PhoneNumberUtils.java.
Due to the Thailand's special case, the code became a little nastier than before, but I believe it is inevitable...
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|
| 0d04c4caa9c0464f555eed458abf2ac7d997ad7d |
|
01-Sep-2009 |
Wei Huang <weih@google.com> |
fix bug 2015059: where the native sqlite comparison method phone_number_compare() treated all alpha addresses as the same phone number.
- changed phone_number_compare() to handle alpha chars. Before this change the algorithm skipped over all non-dialable chars for
comparison, and thus treating "foo" and "bar" as the same addresses. now we don't skip any char that's alpha. This would treat
"foo" and "bar" as separate addresses, as well as treating "1-800-flowers" and "800-flowers" as the same number.
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|
| b020ccd8772182ddfccba30b5adbc500982b59c1 |
|
21-Jul-2009 |
Daisuke Miyakawa <dmiyakawa@google.com> |
One more test, which is succesful (and should be successful), but unexpectedly...
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|
| cfdd4a7238fb93f2144f48dd814d786414eb025d |
|
21-Jul-2009 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fix a bug in which "16\d+6" matches 166 and the number is handled as Thailand one...
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|
| f06f5fa351ded0b9e04e15efa7e34f0f085fc9df |
|
07-Jul-2009 |
Daisuke Miyakawa <dmiyakawa@google.com> |
"Rewrite" PhoneNumberUtil so that it compares two phone strings using as many characters as possible, unlike the previous implementation.
Unlike the change 5480, this considers the NDD-problem mentioned in the internal issue 1949010.
This time, 1-650-555-1234 and 650-555-1234 match each other.
Added tests for the cases.
related internal issue: 1868702, 1949010
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|
| ab3ee7de06d0451d0a34cbd982006f62928e4b48 |
|
07-Jul-2009 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Revert ""Rewrite" PhoneNumberUtil so that it compares two phone strings using as many characters as possible, unlike the previous implementation."
This reverts commit de43094477419f8a190a6f97b47d346827310a02.
related internal issue: 1949010
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|
| de43094477419f8a190a6f97b47d346827310a02 |
|
26-Jun-2009 |
Daisuke Miyakawa <dmiyakawa@google.com> |
"Rewrite" PhoneNumberUtil so that it compares two phone strings using as many characters as possible, unlike the previous implementation.
The new implementation considers country code seriously.
To confirm this change does not do something wrong, I also created another change (https://android-git.corp.google.com/g/Gerrit#change,4036).
All tests related to PhoneNumberUtils pass, including Thailand's ugly buggy behavior around country code handling :-P
Also Add tests for PhoneNumberUtils, which can be executed in the usual workstation like this:
> g++ -Wall external/sqlite/android/PhoneNumberUtils.cpp external/sqlite/android/PhoneNumberUtilsTest.cpp
> ./a.out
This change fixes the internal bug 1868702.
/external/sqlite/android/PhoneNumberUtilsTest.cpp
|