| 33a48fcaa7ae76a2bf85c5de80a5df2a2d4818c4 |
|
07-Jun-2013 |
Preeti Ahuja <preetia@codeaurora.org> |
Stk: Ensure that APDU input length does NOT exceed 255 Bytes.
- Depending on the encoding , the number of characters that
can be stored in 255 bytes varies. See details below.
- detect the current encoding used and enforce max length
Details:
As per TS 102.223 Annex C, Structure of CAT communications,
the APDU length can be max 255 bytes. This leaves only 239 bytes for
user input string. CMD details TLV + Device IDs TLV + Result TLV + Other
details of TextString TLV not including user input take 16 bytes.
If UCS2 encoding is used, maximum 118 UCS2 chars can be encoded in 238
bytes.Each UCS2 char takes 2 bytes. Byte Order Mask(BOM), 0xFEFF takes
2 bytes.
If GSM 7 bit default(use 8 bits to represent a 7 bit char) format is
used,maximum 239 chars can be encoded in 239 bytes since each char takes
1 byte.
No issues for GSM 7 bit packed format encoding.
Change-Id: If5ead7ffa742d67718986b9bce1db05f615c1db4
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|
| 734900afa3a8e35d3a75786dc59f91b6f3136157 |
|
14-Jun-2013 |
Preeti Ahuja <preetia@codeaurora.org> |
Usat Phase 2 feature and Screen status
This change combines below 3 fixes.
1) Usat Phase 2 fixes
Added changes to support Idle screen, Language Selection.
This also includes change to support Idle screen status information.
Fix to address alpha display for proactive commands
2) Telephony: Correct terminal response sent for Idle mode text cmd
When a proactive command : SET_UP_IDLE_MODE_TEXT arrives with
empty text and non-self explanatory icon, terminal response
:CMD_DATA_NOT_UNDERSTOOD should be sent back to the UICC as
per the SAT spec
3) The GCF Testcase GCF-PTCRB SAT/USAT 27.22.4.1.1seq1.2 expects a
screen busy response if the ME is not in idle screen and if the
display text message is a low priority message. Hence sending screen busy
response instead of RESPONSE_TIMEOUT. In present implementation a
USER_RESPONSE_TIMEOUT response is sent for all timeout cases.
Bug: 17553408
Change-Id: If7fb74a451d53a4475475ac570fa8ae9d1a08a3b
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|
| eca4a2ab310bf8d96cf98b5e880e2f8eef7ffeb6 |
|
14-Feb-2013 |
Sandeep Gutta <sangutta@codeaurora.org> |
STK: Handle ICC refresh and card removal, and hotswap fix
--- Register for ICC refresh and let CatService's clients know when
an ICC refresh occurs.
Monitor card status. When card status moves to absent/present let
clients know.
Don't dispose CatService based on the number of applications.
Instead dispose it when UiccCard goes away
This helps avoid the race condition in the following scenario:
1. Radio is on and card is present
2. Turn Radio Off
3. Turn Radio On
4. Proactive command received
If CatService was disposed when card goes away on radio off
then it is possible for the unsol proactive command to be received
before Catservice is up and running on radio on.
--- Dispose objects properly for hotswap
During hotswap, CatService object is disposed and new object
is created. However RilMessageDecoder still holds reference to
old object of CatService, and hence sends decoded command
to old object of CatService leading to stk failure. In this fix
below objects are disposed properly when CatService is disposed.
1) RilMessageDecoder
2) CommandParamsFactory
3) IconLoader
Change-Id: Iee4ab009a0f9708a1ee2d87460e60765e46b4229
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|
| 22d85a8e3a575a6d01d2c788587971657dfe20c6 |
|
23-Feb-2013 |
Wink Saville <wink@google.com> |
Clean up member variables.
Change-Id: Ib60f350131ade626aca682407ea0b4377b16f6c6
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|
| cbaa45bbf2cab852b6c9c3a887e9f803d4e857ea |
|
23-Feb-2013 |
Wink Saville <wink@google.com> |
Clean up
- Add @Overrides where needed.
- Update javadoc comments
- Remove extra semi-colons
- Rename DataConnection.java to DataConnectionBase.java
- Rename GsmDataConnection.java to DataConnection.java
- Add defaults to switch statements
- Remove/fix most "if (false)" statements. Fixed by using a CONSTANT
- Fix hidden variables by hoisting to base class or renaming
- Tweak some debug output
Change-Id: If38de2fdeaacafbf40cdfd7f84dc5c52030ba2a3
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|
| 9edadf11a7ac700a529f49e46822e2983ed551e4 |
|
16-Jan-2013 |
Sanny Shang <sanny.shang@sonymobile.com> |
Wrong terminal response for proactive command length errors
This fix is at least reported by an internal test suite
written with the 3gpp specification as base, can not
guarantee that it exists "in the wild" however the
specification is clear.
According to 3gpp11.14, chapter 6.10.6 "Length errors",
If the total lengths of the SIMPLE-TLV data objects are not
consistent with the length given in the BER-TLV data object,
then the whole BER-TLV data object shall be rejected. The
result field in the TERMINAL RESPONSE shall have the error
condition "Command data not understood by ME".
Change-Id: I128442ea4755679b0e5524a31c01b3c690e45ab0
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|
| 86968438e444728053137c764cc37cf9c0a15d16 |
|
09-Aug-2012 |
Siddartha Pothapragada <spotha@codeaurora.org> |
CatService: Add support for GET_CHANNEL_STATUS p-cmd.
Change-Id: Ib0782748fdbdc94e5c13cffadb40556e3f324eff
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|
| d720945f2be5ea5fe0faf67e67d9ea0e184eba67 |
|
01-Aug-2012 |
Alex Yakavenka <ayakav@codeaurora.org> |
Telephony: Move uicc classes into uicc package
Reduce constructor visibility to package where
possible
Dependent Changes:
I3b718b9aea1f21c7906c8243b4ca0db6af495a08
I80204a2f3dc57cac875abeab390bb9db7a636ff7
Ib9c19e8b157dc7ec74eb14baca5bd3b5caf08c47
Change-Id: Ib4f43374c041cb5eaf2e3883e5ea28b2eb2c9a69
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|
| deb8ccd0fbeae2b2f21f8a4ccc1139a79cccc71e |
|
28-Nov-2012 |
jangeon.kim <jangeon.kim@lge.com> |
simcard: With Kazakh Beeline SIM card, there isn't STK menu
IccFileHandler.java is modified to fix an erroneous EF_IMG file path
information. The other is CommandParamsFactory.java file, which is modified
to ignore the result of reading EF_IMG file.
This Beeline SIM card returned an error status word when the mobile device
accessed the EF_IMG file in this SIM card.
(I think this Beeline SIM card does not support EF_IMG file.)
As a result, This error result stoped processing the setup menu proactive
command, and there was no STK menu.
So, I modified the CommandParamsFactory.java file to ignore the result of
EF_IMG file read operation.
After applying this modification, The STK menu was successfully displayed.
(This issue was resolved by these modified files.)
I think there will be no critical problem even if the EF_IMG(Icon image) file
is ignored.
Bug: 7585989
Change-Id: I16e3c077779811e3d4c46cd6e003771f3e1efde2
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|
| 0825495a331bb44df395a0cdb79fab85e68db5d5 |
|
12-Jul-2012 |
Wink Saville <wink@google.com> |
Create telephony-common
telephony-common was created by moving some of
frameworks/base/telephony
to:
frameworks/opt/telephony
Change-Id: I32cbb5eec1fa239c1587e055c8f7ef4fc48fb62c
/frameworks/opt/telephony/src/java/com/android/internal/telephony/cat/CommandParamsFactory.java
|