History log of /frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
a4b5c35036e68c7551dd77641ceec17b92c6368d 19-Aug-2015 Chris Banes <chrisbanes@google.com> Fix AppCompatDialogFragment crashing

We now model PhoneWindow in when it reads the theme
window flags. Added a unit test too

BUG: 23336734

Change-Id: I990bd91d29d1009e0e18f976c7b3c542782660e6
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
c9b517a68ed7070d4edcdd5be818540d81b43db0 20-Aug-2015 Chris Banes <chrisbanes@google.com> Fix button on Gingerbread when using Toolbar

BUG: 23379766
Change-Id: I64e4a42e1f10a3f7726258f768ea45e1da3a6781
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
d2f8851a0a27ea6a2ddf5a88097f3d10eed38485 03-Aug-2015 Chris Banes <chrisbanes@google.com> Fix crash caused when clicking on list menu item

Caused by an recursion on the closePanel() method,
which leads to a crash. Fixed by using the correct
Window.Callback to dispatch to.

BUG: 22879253
Change-Id: Ia352b67975a90e32c7c9b36cb79a6986bef7fbb9
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
8ba0fdde8e91fd59808ce3453eef079e54915ce8 28-Jul-2015 Chris Banes <chrisbanes@google.com> Fix ActionMode not being inset correctly

Caused by the new action mode animations delaying
the call to setVisibility(VISIBLE), without delaying
the call to requestApplyInsets. This means that the
resulting call to onApplyInsets() happens with the action
mode view being GONE.

BUG: 22651908
Change-Id: I6e8ad429fccb8f73abd339d821a1d792b6f2d565
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
beb1c4e9453c0cd6153f85872ee912e4b0cef42c 22-Jul-2015 Chris Banes <chrisbanes@google.com> am 66bc56b8: Merge "Fix detection of root view within inflate() call" into lmp-mr1-ub-dev

* commit '66bc56b89cb906e4a152ef574b2de44693049e04':
Fix detection of root view within inflate() call
66bc56b89cb906e4a152ef574b2de44693049e04 22-Jul-2015 Chris Banes <chrisbanes@google.com> Merge "Fix detection of root view within inflate() call" into lmp-mr1-ub-dev
871e1fd7971cf8802beb5c2323d4257f2b278c22 21-Jul-2015 Chris Banes <chrisbanes@google.com> am c63438dc: Merge "Fix KEYCODE_MENU not being dispatched to an Activity" into lmp-mr1-ub-dev

* commit 'c63438dce2904355f08ad2b57a8386d474b309be':
Fix KEYCODE_MENU not being dispatched to an Activity
4d95686e7ade79bfb1081047e90de4bf2affbbca 20-Jul-2015 Chris Banes <chrisbanes@google.com> Fix KEYCODE_MENU not being dispatched to an Activity

Also fix onPanelClosed() not being called, by moving
the related logic closer to that of PhoneWindow.

BUG: 22596497
Change-Id: Ia1b66b92646aceb49ed58b913c05984e81503124
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
d95c99933cb57a5678afeff01d91269be61e2502 08-Jul-2015 Chris Banes <chrisbanes@google.com> Fix detection of root view within inflate() call

This CL expandes the simplistic isAttachedToWindow()
check with additional checks on the parents.

BUG: 21792119

Change-Id: Ie69e7c681bb4a8bed5fd03fe80843a53ece15f28
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
6e511d12ff3a713dc56a3b8a50b246b9a0fe6cdf 25-Jun-2015 Doris Liu <tianliu@google.com> Merge "Add enter/exit animation for window provided CAB - support version" into mnc-dev
c04ae73a9793cdad7784fd543f3b7ad32cc8dbed 24-Jun-2015 Doris Liu <tianliu@google.com> Add enter/exit animation for window provided CAB - support version

Bug: 21886856
Change-Id: I9a88ef337adf27b728185cb6fc27328b338a7818
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
4e0a0984e80ced79b8aa3cf71fc261044ecc08a6 23-Jun-2015 Chris Banes <chrisbanes@google.com> am 5ba742a3: Merge "Fix leak for MenuInflater + setSupportActionBar" into lmp-mr1-ub-dev

* commit '5ba742a37d06a0961f20e41c18cc6f8f4d5fd514':
Fix leak for MenuInflater + setSupportActionBar
5ba742a37d06a0961f20e41c18cc6f8f4d5fd514 23-Jun-2015 Chris Banes <chrisbanes@google.com> Merge "Fix leak for MenuInflater + setSupportActionBar" into lmp-mr1-ub-dev
4f5b17adf5017c497b20decab1ba308e088d7ac1 22-Jun-2015 Chris Banes <chrisbanes@google.com> am 56606fdf: Merge "Improve "does not support current theme" exception" into lmp-mr1-ub-dev

* commit '56606fdfdbdf57b691d76a0234b83e6a3788069f':
Improve "does not support current theme" exception
725df1cf793a42aa8f1175c69668419b92f3512f 22-Jun-2015 Chris Banes <chrisbanes@google.com> Improve "does not support current theme" exception

BUG: 21950315

Change-Id: Ic4b378ab8712e4f045365e0bd18c5f52cc229964
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
5ecdb2c5042da49d36d7cda3fa08f1d9151a1fbd 22-Jun-2015 Chris Banes <chrisbanes@google.com> Fix leak for MenuInflater + setSupportActionBar

Caused when there are multiple calls to
setSupportActionBar(). getMenuInflater() will
instantiate and keep an instance to the first
Toolbar (and it's container, etc).

BUG: 21638877
Change-Id: I4c79b4832534b06e7ab2819e78e303dde4a7d76a
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
2a5e18155a210d06ebb142059746becb31f67945 18-Jun-2015 Chris Banes <chrisbanes@google.com> Merge commit '62d9aaed' into manualmerge

Change-Id: I22d22d6a496759a98b81c3f1bf1c226b48fa8e17
9a767d6b502f9289c58216f4e3c622ec2c5dfbd6 18-Jun-2015 Chris Banes <chrisbanes@google.com> am 1d0e76a0: Fix List Menu not responding to dpad events

* commit '1d0e76a0ba8bfc5e280203a56e10be95dd959a51':
Fix List Menu not responding to dpad events
62d9aaed232f8669e79a01ae1c4f6d077ba59984 18-Jun-2015 Chris Banes <chrisbanes@google.com> Merge "Fix memory leak in ToolbarActionBar" into lmp-mr1-ub-dev
1d0e76a0ba8bfc5e280203a56e10be95dd959a51 18-Jun-2015 Chris Banes <chrisbanes@google.com> Fix List Menu not responding to dpad events

We were not giving the view a chance to consume
the KeyEvents.

Change-Id: If7a78db824a3ec5c2e3032fef5805bfbda85e881
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
8d4765883ff24f0f79bf64fea23d4687d50cec85 18-Jun-2015 Chris Banes <chrisbanes@google.com> Fix memory leak in ToolbarActionBar

Caused when there are multiple calls to
setSupportActionBar() (i.e. fragments). ToolbarActionBar
currently just wraps the Window's current Callback. Which
means that for every setSupportActionBar() call, we're
re-wrapping a ToolbarActionBar Window.Callback wrapper.

This CL fixes it by making sure that we always wrap the
correct 'root' Window.Callback.

BUG: 21914909

Change-Id: I8f21b94d60eb488630b1fe7377ba62d3608accef
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
96a9d498bc35b27ec24ae419ca9127e9fe3dbb7d 10-Jun-2015 Chris Banes <chrisbanes@google.com> am 0ef64908: Merge "Fix options list menu when Toolbar doesn\'t have items" into lmp-mr1-ub-dev

* commit '0ef64908166d67a58e073d36e783c775f6512b35':
Fix options list menu when Toolbar doesn't have items
eba6361c28fad482737765413aed1290da67f2da 08-Jun-2015 Chris Banes <chrisbanes@google.com> Add hasWindowFeature() to AppCompatDelegate

BUG: 17879624
Change-Id: I3d2aa9d542ae116fdbe9dd3673bd126f434946d0
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
c7102743e3f30a50c4725c336b5f019f6e7b91c4 08-Jun-2015 Chris Banes <chrisbanes@google.com> Add hasWindowFeature() to AppCompatDelegate DO NOT MERGE

BUG: 17879624
Change-Id: I3d2aa9d542ae116fdbe9dd3673bd126f434946d0
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
8122ad54f129c2214631fad86cabda82815cc0d8 08-Jun-2015 Chris Banes <chrisbanes@google.com> Fix window decor Action Bar init

BUG: 21575069

Change-Id: I2e9919c36f221c968bc38c8d7ba4e476f41b45f7
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
88c0ac5649d6b82c882e2de4bc4f043b107a4428 02-Jun-2015 Chris Banes <chrisbanes@google.com> Move our Window flags handling closer to PhoneWindow

Fixes some issues around stack overflows for certain
flag combinations.

BUG: 21575069
Change-Id: I6f6c98863f7cfb4510cbeeb8a1be6e16c6de509f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
6094d733a9bcc923491937532255f79eb23fab90 09-Jun-2015 Chris Banes <chrisbanes@google.com> Fix options list menu when Toolbar doesn't have items

When using a ToolbarActionBar, and there are 0 non-actions
items, it will return null in onCreatePanelView. This then
means that the 'window' will show it's list menu. As the
'window' doesn't know what is an action item or not,
it shows all items.

This CL fixes it by disabling the window list menu view
when a ToolbarActionBar is used. ToolbarActionBar's own
list menu view is unaffected.

BUG: 21718389
Change-Id: I8e8cb7915cc27abcf1e06a0ef09ac14129c4adce
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
1282e55f13234e9275cd76d3e02559e1eabf12e3 08-Jun-2015 Chris Banes <chrisbanes@google.com> Fix window decor Action Bar init

BUG: 21575069

Change-Id: I2e9919c36f221c968bc38c8d7ba4e476f41b45f7
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
85d77caf73c0bfe957304951f94f88650a064efb 08-Jun-2015 Chris Banes <chrisbanes@google.com> Merge "Move our Window flags handling closer to PhoneWindow DO NOT MERGE" into lmp-mr1-ub-dev
559fa14454cc053127b3b96c0e63c48c06937e38 03-Jun-2015 Chris Banes <chrisbanes@google.com> Revert the previous fix for stealing KEYCODE_MENU

We now just steal those events if we can actually
handle them.

BUG: 20529185
Change-Id: I09119b9efcd24e15b39990a22a7da55257ebfd96
(cherry picked from commit a6624356b85f8a31c5d951c92ce39ef1070fd9db)
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
a6624356b85f8a31c5d951c92ce39ef1070fd9db 03-Jun-2015 Chris Banes <chrisbanes@google.com> Revert the previous fix for stealing KEYCODE_MENU DO NOT MERGE

We now just steal those events if we can actually
handle them.

BUG: 20529185
Change-Id: I09119b9efcd24e15b39990a22a7da55257ebfd96
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
0c4414fd7d27eef2a3545cb36db29070f8a3ea77 02-Jun-2015 Chris Banes <chrisbanes@google.com> Move our Window flags handling closer to PhoneWindow DO NOT MERGE

Fixes some issues around stack overflows for certain
flag combinations.

BUG: 21575069
Change-Id: I6f6c98863f7cfb4510cbeeb8a1be6e16c6de509f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
c291e9cf854ce5e131e0cff9485b61703dfc132b 15-May-2015 Chris Banes <chrisbanes@google.com> am da4f4e9b: Merge "Re-add deprecated app:theme functionality" into lmp-mr1-ub-dev

* commit 'da4f4e9b73c2bd1b843d999e2b07ed71b0fc93df':
Re-add deprecated app:theme functionality
484705a5e6fdc1f6ef746b822716a45f82652ab9 14-May-2015 Chris Banes <chrisbanes@google.com> Re-add deprecated app:theme functionality

BUG: 21128917
Change-Id: Ib922c8c9fe218859c8ca15d625ef58ec8d46fb56
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
d25af35061a9f20d59b25329d613c62c20184dad 04-May-2015 Chris Banes <chrisbanes@google.com> Window.Callback passthrough fixes

We currently do not proxy onMenuOpened or onPanelClosed
events to the Activity because we overload the FEATURE_ACTION_BAR
ID internally. From v11+, those methods in Activity do special
handling and try and init it's own Action Bar (which usually results
in a crash).

To fix this, we now use our own special feature IDs:
FEATURE_SUPPORT_ACTION_BAR and FEATURE_SUPPORT_ACTION_BAR_OVERLAY.
Meaning, we can now pass the calls through without the default impl
blowing up.

We still accept the normal window feature IDs for requestWindowFeature()
but we log an info message.

BUG: 20816353

Change-Id: Ieea6d451279469b9de7bd96a17e5338600fdf9d8
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
0e4289d8af2b80828e4f68f77a9dbafa24319d48 05-May-2015 Chris Banes <chrisbanes@google.com> am 959ed6af: Merge "Add ViewCompat.isAttachedToWindow()" into lmp-mr1-ub-dev

* commit '959ed6af05f77e9924fc908176c733d6e3260c8e':
Add ViewCompat.isAttachedToWindow()
ce611065e0a3f766381c7eee6106e24d9d58adc5 05-May-2015 Chris Banes <chrisbanes@google.com> am ce0734df: Merge "Don\'t inherit a parent\'s context if view is layout root" into lmp-mr1-ub-dev

* commit 'ce0734df1fffcd9c85530ae236a2a4aa7047ce7b':
Don't inherit a parent's context if view is layout root
f6610f183f0afe6e392dea804474f722d82083fd 04-May-2015 Chris Banes <chrisbanes@google.com> Add ViewCompat.isAttachedToWindow()

BUG: 20695142
Change-Id: Ibdff3d24721e9ed94de9c00813fe9528a734267d
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
e183f2600fb31c69eceacc1c263cd56f12489a65 01-May-2015 Chris Banes <chrisbanes@google.com> Don't inherit a parent's context if view is layout root

Previously AppCompat would make an inflated view
inherit a parent's context, regardless of whether it
was the root view. This is different to the framework
functionality which only allows children to inherit.

BUG: 20695142

Change-Id: I9ec90654a08824f7ee64b73ba76bdc0ee3ea28fc
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
9ce997cacea4174be69c927244e14b1eddb24192 28-Apr-2015 Chris Banes <chrisbanes@google.com> am 535c5737: Fix StackOverflowError if wrong theme features are enabled

* commit '535c5737ba868a622d7783d57f7078ab285717c0':
Fix StackOverflowError if wrong theme features are enabled
535c5737ba868a622d7783d57f7078ab285717c0 28-Apr-2015 Chris Banes <chrisbanes@google.com> Fix StackOverflowError if wrong theme features are enabled

BUG: 20650250
Change-Id: I2761c3184c5eb58f9c2383dc959728efd0002699
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
6b3b79ba1d58edad9b8e9246674af56cc34fce73 27-Apr-2015 Chris Banes <chrisbanes@google.com> am 8d2f1762: Merge "Don\'t allow an Action Bar to be created for floating windows" into lmp-mr1-ub-dev

* commit '8d2f17620af0015114d2a740b6cb9dfb6e88adfb':
Don't allow an Action Bar to be created for floating windows
a9279663ecb98b85bf95a5ba1ebc145756fc13a2 27-Apr-2015 Chris Banes <chrisbanes@google.com> Don't allow an Action Bar to be created for floating windows

BUG: 20624627
Change-Id: I9d3505b03d099ff8e09558094136094ad2e26213
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
f5829201b976fc650789accc22f325a2541ed478 13-Apr-2015 Chris Banes <chrisbanes@google.com> Action Mode fixes - M edition

- CABs from floating windows now display correctly
- We now let TYPE_FLOATING framework CABs through to
the window (when enabled)

BUG: 20171499
BUG: 20022929

Change-Id: I56b6f16ee62fc8f0f210da480ad1577863321470
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
547a80d347e0dc9751bbe3cf91f947477145bdba 13-Apr-2015 Chris Banes <chrisbanes@google.com> Action Mode fixes

- Added a switch to disable native CAB handling
- They now use the correct theme
- Using a better way to intercept framework CABs
- We now only intercept on v14+.

BUG: 20171499
BUG: 20022929
BUG: 20208108

Depends on Iacffdf908b98739770f13665732d7755b14b9a25

Change-Id: Ia64beb77ba0a08186e4cdea4544cd9880bf4a4d9
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
d8b7157eae680353a2821dca3c9e52b3aaf737a5 05-Mar-2015 Chris Banes <chrisbanes@google.com> Fix AppCompat's Dialogs being larger than the framework impls

Due to the fact that we measure at a lower level, so
we need to take padding higher in the hierarchy
into account.

BUG: 19509863
Change-Id: Icf0be74c2791383571b4d90e2d759e18139826da
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
2cccf609662389d6a23dbc0711d5fb2e826e8c63 18-Feb-2015 Chris Banes <chrisbanes@google.com> Rename and move all of the tint widgets

They're public so shouldn't live in the internal package.
I've also stopped setting the setting the platform widget styles
(e.g. android:editTextStyle) and instead provide our own versions.
On Lollipop, we set these the default framework styles.

This fixes the times where the framework widgets are used but with
the untinted material style (e.g. Preferences).

BUG: 19407610
BUG: 19300319

Change-Id: I5dbdee240cbf28d4dc9b05f5c56b386d83b18df3
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
c3365672ee81bc515194d70f4239f8946dfc0b22 20-Feb-2015 Chris Banes <chrisbanes@google.com> Merge "Add AppCompat AlertDialog" into lmp-mr1-ub-dev
19eaf14cb3cca613f984a32be2fab2534427fb29 05-Feb-2015 Chris Banes <chrisbanes@google.com> Add AppCompat AlertDialog

Material themed, working back to API 7. Needed
because of AlertDialog's themes/styles are private.

BUG: 19192875

Change-Id: I4c6bf11be127c705389f0cb79df4a983d638f6f3
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
498356fea126122c3e3720a419969055cb889428 11-Feb-2015 Chris Banes <chrisbanes@google.com> Fix support Fragment inflation from layouts

Seems that the recent refactoring broke Fragment inflation.
The problem is that FragmentActivity needs it's onCreateView()
called on all API levels, rather than delegating to
Activity.onCreateView()

BUG: 19340311
Change-Id: Ifd45967e1def086a11203913fa1acb23e32191a2
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
a73cf65dff6d7fa58907e614f95e1d3679de0a79 04-Feb-2015 Chris Banes <chrisbanes@google.com> Ensure Buttons have a disabled text color state

BUG: 19252982
Change-Id: Iacb4416e01468678cb0997340128f19fe2015927
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
0f58401dc72db8ea2a201e3c0220f6529f2a7b33 04-Feb-2015 Chris Banes <chrisbanes@google.com> Add AppCompat specific windowNoTitle attribute

More useful now that we support Dialogs. Also reworked
the sub decor code to match more closely to the framework.

BUG: 19194408
Change-Id: If48a338e583dddedfd620993aed92bca5e253781
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
436e191f80e197712dd1a7f1f7c61acfff8b1f04 22-Jan-2015 Chris Banes <chrisbanes@google.com> Ensure we dismiss the options menu on item click

BUG: 19104258
Change-Id: I72937d5882c5a476ea1688b1b8564e356271ef1f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
16e8d4dd91083260223c007c797e46bc8f631055 23-Dec-2014 Chris Banes <chrisbanes@google.com> Material Dialog themes

Lots of changes needed for this, building upon the
refactoring CL. AppCompatDelegate can now handle Dialogs
as well as Activitys (which was easy after the refactor).

This was needed so that we can install a custom decor
for Dialogs.

Also added borderless button styles as they were
needed for Dialogs.

Change-Id: I88a7e4de5de85477982e401c832aeae732f81647
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
f3ad1351d8b40ec5defe35e79d3430ad3c384b6d 27-Nov-2014 Chris Banes <chrisbanes@google.com> Refactor AppCompat's Activity structure

- The activity delegates now have a public abstract class
called AppCompatDelegate. Any Activity can create one,
but they must call through to the delegate at certain
lifecycle methods.
- Related, I've reduced the number of manual lifecycle
calls needed by using Window.Callback where possible.
- Activities can implement the the new AppCompatActivityCallback
interface to receive certain callbacks.
- AppCompatActivity does all of this automatically
- ActionBarActivity is now a deprecated alias for AppCompatActivity
- Removed support for the v4 Drawer Toggle
- Remove our internal callback in favor of using Window.Callback
directly

BUG: 18547959

Change-Id: I8ece4372fa2abbc5b5246544643fafe0e22874be
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java