History log of /packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
5f1f618eb3df6b9a2f8554e97e8410467b642653 15-Apr-2015 Paul Rohde <codelogic@google.com> Send a warmup burst to the camera before attaching the preview.

This reduces startup jank by submitting a warmup burst of n
frames to the camera before the preview surface is attached to
the camera. This ensures the large internal buffers are
allocated by the HAL before the preview stream is attached. The
change will delay the preview by n frames in exchange for a
smoother preview once the preview is actually shown.

Bug: 19076469

Change-Id: I5abb8b49a64c35686c014001a45239f4eccfe34d
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
ffae1b53110ddae98b810bdb9a5c9dc210d96551 01-Apr-2015 Paul Rohde <codelogic@google.com> Defer the ZSL stream by 500 ms

This forces the preview to start before the ZSL stream is
attached, and then attaches the ZSL stream to the repeating
request after a 500ms delay to give the system time to allocate
the underlying buffers for the ZSL image readers.

Bug: 19076469
Change-Id: I75ea28ead5b009e0f65f5f00c0522bcb2219cb22
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
cee1a391dd8f5e0a57f6fae5b0ec3849f2a20871 31-Mar-2015 Paul Rohde <codelogic@google.com> Report jank for simple capture module cameras.

This clarifies the jank statistics by explicitly including a
report if the jank detector is installed.

Bug: 19987252

Change-Id: Ie8e4b9826eb0e3152d7f8358728019d1a81e787b
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
bb27cc628ee84737c72b0368b8b27a5bf8609b56 24-Mar-2015 Paul Rohde <codelogic@google.com> Read and enable face detection when available in capture module.

Bug: 19715640

Change-Id: I719cc92800a73ec3eaa27044fda09f64e1b9d946
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
5ca7d2642881f3cf06adb2532e0d5950524a34f4 07-Mar-2015 Puneet Lall <puneetl@google.com> Optimize ZSL for auto-flash mode

Cache the most recent converged AE state to enable more
auto-flash pictures to be taken with zero shutter lag.

Bug: 19151363
Change-Id: I7d4bd5a67d4cddb7a1f733844e1a080acfacf7f4
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
c44b7c47dbb8f53a6401285c4ca9218326d21a7e 10-Mar-2015 Puneet Lall <puneetl@google.com> Reset existing AF scan upon tap-to-focus

* Interrupts existing, in-progress AF scans upon tap-to-focus
(triggerFocusAndMeterAtPoint).
* Removes pending delayed-af-resets upon subsequent tap-to-focus
to fix the case in which a user triggers AF twice within <3 seconds
which previously resulted in the AF mode returning to
continuous_picture shortly after the second AF scan.
* Removes dependencies on CameraUtil and static Settings3A
methods, and refactors FrameServerImpl to enable unit-testing.

Bug: 18935538
Change-Id: I0c2d5d92d2b07efdc11de8388e42b931d3ea89d0
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
ccb0c17a104801a994c901d1c89c9d99005782ed 06-Mar-2015 Puneet Lall <puneetl@google.com> Fix ready-state issue when commands are queued

Ensure that the FrameServer is marked as unavailable if a command is
queued, waiting to acquire access.

Bug: 19367334
Change-Id: Id7b1639c6c3a7e65c75002b9f6f8f24c7515e932
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
66b942a3d20aac65454961ef2bc219ca560b9fba 03-Mar-2015 Puneet Lall <puneetl@google.com> Add error handling for repeating preview workaround

Adds error handling to show a dialog if the workaround for the repeating
preview (bug: 19061883) fails.

Bug: 19565931
Change-Id: Iabc3b4fdbc6977b0e1828243e80138385a3ef522
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
81308a22b0f64c6667f6c23adee9da520415bcb6 03-Mar-2015 Puneet Lall <puneetl@google.com> Filter out duplicate calls to ready state listener

* Adds a FilteredCallback to filter out callback invocations with
duplicate values.
* Simplifies ready-state calculations.

Bug: 19535852
Change-Id: I8376c13f24ff7a4f6f2d347f363746c2a6466601
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
8f51086c8177056345de996963515c4bd3415254 19-Feb-2015 Sascha Haeberling <haeberling@google.com> Centralize logic for Camera API feature determination.

Bug: 19179276

This captures camera capabilities in a centralized class and allows
them to be overridden by GServices in the field or using adb.

Since this is not it's own class it would be trivial to create another
instance for testing and pass that into CameraActivity or even to change
these values using a UI before the actual Activity is started.

Change-Id: I74262c8467f631c7b5e42b02d269d5f401d4e9e7
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
0db8a2fd5cc02753d42f34a1c858b980c6c277bb 20-Feb-2015 Paul Rohde <codelogic@google.com> HDR Scene mode support for CaptureModule.

Bug: 18622877 N4 HDR Scene support.
Bug: 19269257 HDR+ flash setting persistance.

Change-Id: Ibac3d6513a1e14d8a2ffaf6208509133d31a8fb8
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
270990a7e3fcd1cf71b652c9ad1cc46598ddf4b3 19-Feb-2015 Puneet Lall <puneetl@google.com> Reset the camera after detecting repeated failure

Bug: 19061883
Change-Id: I913334e19fc248010bdeb2dab4ae1a6d05427f40
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
251c60cbdfc6b221510a43dd25543ea16f9f582b 17-Feb-2015 Puneet Lall <puneetl@google.com> Disable AE precapture trigger when flash is off

Bug: 19407066
Change-Id: I9d5ec0271510fe6ff5615767fc3523ba5e287bc3
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
b6c4a314d0a0a185e6d987298ef9b7f4db8a6a2f 11-Feb-2015 Senpo Hu <senpo@google.com> Enable exposure compensation in CaptureModule.

* Expose camera exposure compensation capabilities in OneCameraCharacteristics.
* Turn off exposure compensation on Nexus 6 (API level 21).

Bug: 18523154
Change-Id: I551f19945f5a64a09a76b3a0777664d16a9b2ba2
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
401990916915791be14c65694ce3507eac3ec82d 17-Feb-2015 Paul Rohde <codelogic@google.com> Merge "Read focus range from CameraCharacteristics." into ub-camera-haleakala
aca904e29aea542b6e6a4fcc837759a57a270a49 12-Feb-2015 Paul Rohde <codelogic@google.com> Read focus range from CameraCharacteristics.

- Remove hardcoded focus range values.
- Explicitly provide a lens range and range checks.

Bug: 19356651

Change-Id: Ied2513b5a654a00af07e76a66e72aac50ffc9c42
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
eb0aa6a261bd2b2009efb279c29c5bed97b9a334 12-Feb-2015 I-Jong Lin <ijonglin@google.com> Merge "N4 CaptureModule not closing" into ub-camera-haleakala
b4b27f2c7738cd5e3f31a281d66a33f4698810b3 16-Jan-2015 Shashi Shekhar <shashishekhar@google.com> Port burst to use FrameServer.

Port burst to frameserver
- simplifies burst interfaces
- removes burst methods from OneCamera.
- locks orientation when burst is running.
- Deletes most old code for burst integration.
- Removes frame distributor preview forwarding, instead frames are
streamed using a surface texture the Surface for which is passed
as a output target to the create capture session.
- Deletes FrameDistributor, now the low-res frames are streamed to a new
surface specifically setup for burst.

Change-Id: I50f2955bb48610a7e284f9609cd70b8e4e1f1059
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
25de24b2930d176a3957cb6865564e9e334175d6 12-Feb-2015 I-Jong Lin <ijonglin@google.com> N4 CaptureModule not closing

N4 CaptureModule was not wired up properly to close the device when it
closed. There's still an issue that the synchronization is incorrect,
i.e. we don't guarentee close has completed before we open it again.
There's a fix so that we can use OnCameraAvailable listener to only open
the camera when it is available.

Bug: 19332637
Change-Id: Ie88acb3a9f75a5896606dd660c005de0dc82dc3c
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
f68a39a0ad362ff0543e11e3f0ce11741a7de48c 05-Feb-2015 I-Jong Lin <ijonglin@google.com> Add JPEG Orientation into N4 CaptureRequests

Wired up the SimpleOneCameraFactory to dynamically decorate
the JPEG capture request with the proper orientation so that
the framework does the proper orientation.

Paired with ag/629241.

Bug: 19122922
Change-Id: If206b0d18979ddc4ed9ab6df7ce4d22ba01534a8
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
c3adc0558139f6b7424f8be1116c246455bdf6ab 06-Feb-2015 Puneet Lall <puneetl@google.com> Implement ready-state for non-zsl cameras

Bug: 18934542
Change-Id: I028177a0ea02d8477083ffca8b40d03be5f444ac
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
1318feb043f89f8309a7d4cf53ccaa7a58939c98 06-Feb-2015 Puneet Lall <puneetl@google.com> Rename ImageStreamFactory to ManagedImageReader

Improves documentation for the internal camera2 wrapper API.

Change-Id: I62d0c9aa52f5254c45fc06f2792f92b9b90e3e31
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
5cbdddd3ba0241b60dbd7a0ab44cfc08dc5e8fc9 05-Feb-2015 Puneet Lall <puneetl@google.com> Add support for non-ZSL, non-legacy cameras

Bug: 19178315
Change-Id: Icc73563cdf708efe70bfc814c279850e1a690cf3
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
61eeaa75d8bf863e53c7a308ea7ee29e2cc90202 04-Feb-2015 I-Jong Lin <ijonglin@google.com> Nexus 4 Camera Start-up Fix

Issue revolves around the fact that the camera ZSL template was invalid for
Nexus4, and Nexus4 did not support ConvergedImage Picture taker. Turned
those things off for the Nexus 4 and now it works.

Bug: 19123014
Change-Id: I5aef58a0f0c7e9396e999d6b7ab2736e4565b73f
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
1738db31add0aea5a6a6f2c137ca6fc476a10237 30-Jan-2015 Puneet Lall <puneetl@google.com> Fix bug in counting open images

Bug: 19156045

AndroidImageReaderProxy previously would return an instance of itself
via onImageAvailable. This caused a problem because it bypassed the
LoggingImageReaderProxy and CloseWhenDoneImageReaderProxy decorators.

This change also includes additional minor fixes for potential issues,
specifically, it also synchronizes access to each android.media.Image
and ImageReader because they are not thread-safe.

Change-Id: I0d76c07ae37b09cdec40f7d7789b49f7397fb414
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
a8c94d5c059db2598caca676f0cab47a997ef631 23-Jan-2015 Puneet Lall <puneetl@google.com> Enable testing of ZslSharedImageReaderFactory

* Migrate from CloseableHandlerThread to HandlerFactory to remove all
direct dependencies on the platform.

Change-Id: I3d6aca94cd6f9559596d157b86c174bfb8801f90
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
b8397360d318edf3093b20b2b102207d76730e1b 14-Jan-2015 Puneet Lall <puneetl@google.com> Close ImageReaders after the camera is closed

Bug: 18841114
Change-Id: Ifc0b79e70059efd8f8ace2c29243406b524ad918
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
386c5b885b99f67f9c0a7380f4be153f28333089 09-Jan-2015 Puneet Lall <puneetl@google.com> Apply flash setting changes to the AE mode

Bug: 17216526

Change-Id: If6c03102f04ad2ba54e1a045a3ab7445aaa5b595
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
4961ad31d9a877e3a68566fb5d4b33b7f79ce44e 08-Jan-2015 Puneet Lall <puneetl@google.com> Filter ZSL images based on frame metadata

Introduces a new metadatasynchronizer package with functionality for
retrieving metadata (TotalCaptureResults) for images which have been added to
the zsl ringbuffer.

To enable unit-testing, proxy objects for CaptureRequest, CaptureResult,
and TotalCaptureResult have been added, so they can now be mocked.

Bug: 18964540

Change-Id: I8374350e09d33f54ff241f23fd005013ed26dab0
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
8a09cc29b273e35128a03794e82dd4f329d35cc9 08-Jan-2015 Puneet Lall <puneetl@google.com> Change ImageSaver interface to support processing bursts and thumbnails

Bug: 18908116

Change-Id: I14863011de5c3a575bfb54758824ccfaa04cf200
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
5aa7eb2930b813c97f3754d93fe7fa978651887b 08-Jan-2015 Senpo Hu <senpo@google.com> Instantiate a ImageSaver.Builder in CaptureModule.

We will need different image savers for capture intent.
Since we plan to create a separate module for capture intent,
this change allows modules to be able to choose a different builder.

Bug: 18726217
Change-Id: I5871263123b06958d902cc8e3a4d911f14c83e66
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java
d8463954727c9f8b688e69476439830cadb7b45a 30-Dec-2014 Puneet Lall <puneetl@google.com> Refactor camera factories to reduce code duplication

Change-Id: I5f5c899f595dbbaa9fa181c5caa092d4bad69f07
/packages/apps/Camera2/src/com/android/camera/one/v2/SimpleOneCameraFactory.java