History log of /packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
ecf356c15143ab0583c64682de16d94a57f7dd1c 20-Sep-2013 Mathew Inwood <mathewi@google.com> Remove content provider querying from the search app.

The global search API that is used for this is being deprecated, since it
has long been beset by performance problems. Remove all related code from
the search app.

Bug: 10487397

Change-Id: Ifa91b50d784cb469cb39d6008284aa44ff54e62b
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
fd4a4cbc1143a734d357897531daa7105db6459b 11-Nov-2010 Mathew Inwood <mathewi@google.com> Refactor suggestions adapters for clustering of results.

This allows an alternative SuggestionsView to be based on an
ExpandableListView instead of a regular list view.

Skeleton ExpnadableListView based classes added, but not functional
yet.

Bug: 3162608
Change-Id: Ic78e9397ed00423855732e5dcc1dd4d4136d6a90
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
fdb80c2962c88ac62dcd7ee7f2fab1857b61506b 18-Oct-2010 Mathew Inwood <mathewi@google.com> Add option to limit suggestions displayed by space available.

This effectively makes the suggestions list non-scrollable, by
limiting the number of suggestions to the number that can fit in the
available space.

Also fixed an issue in RankAwarePromoted whereby it would promote too
many suggestions if the promoted list was non-empty before hand.

Bug: 3086387

Change-Id: Iae5740fbd32b104c73b1b7dbf446c7e61a3e2e6a
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
aa7d79792baca59eb7afe00ea27abc5176ddd34b 06-Aug-2010 Mathew Inwood <mathewi@google.com> Some tidying up in SearchActivity with new 2-pane implementation.

All (most) code that deals with SuggestionsAdapter or SuggesionsView now handles
the two views & adpaters properly.

Change-Id: Ib791f5aa2acdc31d664340e1e861afb672b2e94d
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
66ee1cc883f77fee930587503ecdcd8d18f12b23 06-Jul-2010 Mathew Inwood <mathewi@google.com> Made query refinement button usuable with trackball/dpad.

This required moving handing of suggestion clicks from SuggestionsView into the views within the list. Moving the focus between the query refinement button and the suggestion itself is done manually.

Bug: 2816727.

Change-Id: I0b69311b2d30c66a28f5447dc9e0e5f6dab3b704
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
839a9fd2828f37c9dc8345f93aefa5b8ad2f857f 17-Jun-2010 Bjorn Bringert <bringert@android.com> Drop "query jamming" feature from QSB

Before, QSB put the text of web suggestions in the query field when
selecting a suggestion with the DPAD or trackball. The code for this
was complex and error-prone (see for example http://b/issue?id=2515755
and http://b/issue?id=2748984). Now there is an on-screen button to
put the suggestion text in the query field. Thus we should remove this
feature.

Bug http://b/issue?id=2776271

Change-Id: Iebafc24cffca0c7cf113e426564ad22bb93da738
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
18959800eddb7127e4fd9b24e91458d0584cc257 28-May-2010 Mathew Inwood <mathewi@google.com> Added ability to add extra views overlaying the search edit text box.

For bug: http://b/issue?id=2602198

Change-Id: Ibcaa6aaaad0e4a00ab28aed7680760f3b63847af
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
1aef21f8a84380351c7dd7c9bf66f80659d0d42e 27-May-2010 Mathew Inwood <mathewi@google.com> Refactored & simplified header/footer handling in SearchActivity.

Change-Id: I225e0d1b84ab7bc9ae0707cd1ff53fa00d1c1ba4
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
1a9de3a4cfc0d6142c961ae11f940f1f77910afd 06-May-2010 Mathew Inwood <mathewi@google.com> Use more columns in CorpusSelectionDialog when in landscape mode.

bug: http://b/issue?id=2641580
Change-Id: I23a88091b0b739ef12b6c0a828d771e1eec98cfc
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
145693e12b77c193a65b7eaa038a272dd1f48f33 22-Apr-2010 Bjorn Bringert <bringert@android.com> Add query refine button to query suggestions

Also allows suggestions with no text2 to use 2 lines for
text1, to better support the long queries that query refinement
works best for.

Bug: http://b/issue?id=2290886
Change-Id: I253f2a770f490ee76524b07eae8907a2f22f63fe
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
b5fc08b7f16a32d3865f44b7f26d8aaa5304a2ad 19-Mar-2010 Bjorn Bringert <bringert@android.com> Disable debug logging and remove unused imports and classes

Fixes http://b/issue?id=2410136

Change-Id: I2416c9b6c1b9e819ec17d7954b6b70bf106f0414
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
5c8bb23b605edf07f0e6f5aa6b0841753ffbf6c7 06-Mar-2010 Bjorn Bringert <bringert@android.com> Fix suggestion selection handling

This change addresses two problems with how suggestion selection
events were fired:

- When a suggestion was selected with the trackball, and focus then
moved away from the suggestions list, and back in, no selection
event was fired. This is because ListView retains the selection
position. This is worked around by firing selection events
on suggestion list focus changes when the list view already
has a selected position.

- If the suggestion list changes so that the old selection is no
longer valid (only happens when the suggestion list becomes shorter),
ListView changes the selection so that the position is still valid.
Before, this triggered a suggestion selection event. We now suppress
all selection events that happen when the list does not have focus.

Fixes http://b/issue?id=2464727

Change-Id: Ibfbed15bf136ab8f9c9d4172c014c152e56c5089
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
dbdffd8316e75bc2813dbbcbef13d357970e8c84 23-Feb-2010 Bjorn Bringert <bringert@android.com> Add missing pieces for suggestions footer change.

This should have been part of I332c0566fedecccaae194304310c1f13d7201e2d
but I missed a git commit

Change-Id: Id670c164aeb89814b700e3f0e93206686704efb6
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
883c1bf364e38c5b133afb55f8493a14b65f4dd4 19-Feb-2010 Bjorn Bringert <bringert@android.com> Add a suggestions footer view

Also, refactor source and corpus creation. This turned out not
to be needed to fix the bug, but I think it was a good thing anyway.

Also, include a suggestion type in the qsb_click log.
This is only set for Genie suggestions at the moment.

Fixes http://b/issue?id=2445622

Change-Id: I332c0566fedecccaae194304310c1f13d7201e2d
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
fde948e69f59589cf0d217ea414af7947de600bb 11-Feb-2010 Bjorn Bringert <bringert@android.com> Merge Google and Browser sources and call them Web

This required a gigantic refactoring of QuickSearchBox to work nicely.

This change also reduces the number of promoted source to 3,
since Web is now one source instead of two.

As a side effect of the recatoring, VoiceSearch now searches
the selected corpus (fixes http://b/issue?id=2438309)

Fixes http://b/issue?id=2365770

Change-Id: Ife8d40ef62ea004e8d0f20a60e9196fc589f01fc
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
7b9d59cd76eecd7645072c6728e2faf9ff9e180a 20-Jan-2010 Bjorn Bringert <bringert@android.com> Suggestion selection and IME hiding fixes

Changes:

- Selecting a suggestion puts SuggestionCursor.getSuggestionDisplayQuery() in the search box.

- Moving back up to search box restores the user's query.

- DPAD left keeps selected query, focuses search box and move cursor to the start of the query.

- DPAD right keeps selected query, focuses search box and move cursor to the end of the query.

- Input method only hides when focus moves to suggestions.

- Input method shows up when moving focus back to query.

Fixes http://b/issue?id=2380828

Change-Id: I0d1b7ce1bcc72d275d6cd57d75ee7f5c509fc5bc
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
713194910648268c094fa81b81f40ce2f7e39333 18-Dec-2009 Bjorn Bringert <bringert@android.com> Use list UI with corpus selector

TODO: The corpus selection window has the wrong vertical position.
TODO: Suggestion icon clicks don't work.
TODO: The corpus selector does not show focused and pressed states.

Change-Id: I950308f5f32e11f39dabedfcacdd8e78701e6a57
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
782dd228e78e9294692d639597f96c26283968bb 16-Dec-2009 Bjorn Bringert <bringert@android.com> Fix suggestion key, click and selection handling.

Typing on the suggestions list and pressing action keys
still doesn't work.

I also made SuggestionData mutable and got rid of the builder.
This this is only for tests anyway, it was annoying to have to
add every field in 6+ places in this class.

Change-Id: I17c287b217fc1a03567123ddbd48638657b2f5cf
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java
185bb2e3881452c084fde44d9bee657f65881b0e 04-Dec-2009 Bjorn Bringert <bringert@android.com> Make tab order stable

- Overhauls suggestions handling to make tab order stable.

- Refactors SuggestionsView to split it into some
general tab components (TabView, TabAdapter), and
QSB-specific parts (SuggestionsView, SuggestionsAdapter,
SuggestionCursorAdapter).

- Moves UI code to .ui subpackage.

- Converts some error and warning logs to exceptions to make
them easier to find during development and dogfooding.

- Recycles suggestion views.

This code is currently pretty slow.

TODO: Don't populate views that aren't visible.
TODO: Delay update until the currently visible source reports.
TODO: Batch updates.

Change-Id: If42889d20499c34d94e1dc0acdc12a3ae53a23b0
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/ui/SuggestionsView.java