History log of /system/bt/stack/srvc/srvc_dis.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
f8027005333c88a2f097cfd70d15c3d54c7764ae 12-Mar-2015 Chris Manton <cmanton@google.com> Demote, cleanup and extend observed logging
/system/bt/stack/srvc/srvc_dis.c
9b57f0802ec52f9169ebbd164c6f104724190ec1 25-Jul-2014 Adam Hampson <ahampson@google.com> Bluetooth: DIS: Only read the requested DIS characteristics

The BLE HID code only uses the PNP_ID characteristic from DIS.
Previously the DIS client would read all DIS characteristics
when a read request was made. This change allows the DIS user to
request certain DIS characteristics.

Bug: 16521059

Change-Id: I09c24718bb2e2da73c518b64c3cbdd07e7d6cf27
Signed-off-by: Adam Hampson <ahampson@google.com>
/system/bt/stack/srvc/srvc_dis.c
eaf796f1dc6a0e719c8f957f629b35c4faf2c01a 28-Jun-2014 Mike J. Chen <mjchen@google.com> Fix GKI buffer leak with discovery information service reading

If the discovery information service of the LE client has
the fields model number, serial number, fw version, etc,
the service would allocate PKI buffer and never do anything
with it, so it would leak. It looks like it should have
been assigned the a callback string array, however fixing
that still doesn't fix the leak because the code that receives
the string array, bta_hh_le_dis_cback(), never uses it and
never frees it.

I believe the semantic is that the string arrays are kept around
as a cache in the srvc engine connection structure,
so it's the srvc engine dealloc of the callback structure that
needs to also free the string buffers if they have been allocated.
After fixing the string array allocation, add code to free the
string array entries if they are not null.

Also fixed an off by one error in DIS_SrUpdate() that would also lead
to a GKI buffer leak.

Improve two string termination cases to use a simple set of the
last entry in the char array instead of memsetting the whole array
when most of it will be filled by a following memcpy.

Change-Id: I7905cd771dbbe166e3c2b42e019bac9f5a312877
Signed-off-by: Mike J. Chen <mjchen@google.com>
/system/bt/stack/srvc/srvc_dis.c
4dcde90649cc51ca815a50d338a73adb408ab258 28-Jun-2014 Matthew Xie <mattx@google.com> resolved conflicts for merge of b44cc59d to master

Change-Id: I74c86dd5a13d4cc0b225a4b1d516904c4382db74
b44cc59d286ad255e872c60df02e032bd8d9d75b 04-May-2014 Sharvil Nanavati <sharvil@google.com> Logging cleanup: AVRC, MCA, GATT, and SMP.

Change-Id: I6d1e61ff023b5fd19f144955cff16831cc18c6e6
/system/bt/stack/srvc/srvc_dis.c
0454bb7bb51f578dfffc618c47e586fc74a0d6b0 28-May-2014 Adam Hampson <ahampson@google.com> Initialize the DIS client before requesting DIS UUIDs from peer

Bug: 15308663

Change-Id: I586c486f838e1742db1785e79ca1451b33b21367
Signed-off-by: Adam Hampson <ahampson@google.com>
/system/bt/stack/srvc/srvc_dis.c
7fa4fba6f59f97df00aff07dbe8fb21b114b3c2c 17-Apr-2014 Ganesh Ganapathi Batta <ganeshg@broadcom.com> Merge BT 4.1 features

The features include:
- LE Peripheral Mode
- Link Layer topology (LE Central & Peripheral Concurrency)
- Dual Mode Topology (Ability to choose LE transport when connecting with
other Dual Mode devices)
- Fast advertising Interval
- Limited Discovery Time Changes
- GAP Authentication and Lost Bond
- Dual Mode Addressing
- Common Profile and Service Error Code
- 32 bit UUIDs

Change-Id: Ic6701da4cf6aaa390ff2c8816b43157f36b7fb42

Conflicts:
stack/btu/btu_hcif.c
/system/bt/stack/srvc/srvc_dis.c
8fe58875ce67c6e1099e7ba2339dcd2b979491b0 17-Apr-2014 Ganesh Ganapathi Batta <ganeshg@broadcom.com> Merge BT 4.1 features

The features include:
- LE Peripheral Mode
- Link Layer topology (LE Central & Peripheral Concurrency)
- Dual Mode Topology (Ability to choose LE transport when connecting with
other Dual Mode devices)
- Fast advertising Interval
- Limited Discovery Time Changes
- GAP Authentication and Lost Bond
- Dual Mode Addressing
- Common Profile and Service Error Code
- 32 bit UUIDs

Change-Id: Ic6701da4cf6aaa390ff2c8816b43157f36b7fb42
/system/bt/stack/srvc/srvc_dis.c
5cd8bff2dd0337cb52bf48f312e3d2d55a8882fb 01-Feb-2014 Mike J. Chen <mjchen@google.com> Major warnings cleanup

Mostly fixing unused parameter warnings.
A few other warnings also fixed like possible use of
unitialized variables (no real issue found, just compiler couldn't
follow the path), signed vs unsigned warning.

Also fixed some typos, indent issues, removal of dead code, etc.

Change-Id: I95eb887aefc4d559d7921f71a0af5f3bfb01ac01
Signed-off-by: Mike J. Chen <mjchen@google.com>
/system/bt/stack/srvc/srvc_dis.c
dbba0e652e0ce23dd691df3c03979ec6e32c8db3 08-Nov-2013 Matthew Xie <mattx@google.com> Replace Broadcom proprietary license header with apache 2 header

bug 11591406

Change-Id: Ibb9c6b3865e6d757236f1c5896775bb6f28e47be
/system/bt/stack/srvc/srvc_dis.c
2e7fa68bfd9723b7ec7b6b0b128d89f31a2e06ee 09-Aug-2013 Andre Eisenbach <andre@broadcom.com> LE: Add support for the HID-over-GATT profile (1/3)

bug:8330048
Change-Id: I5727161b0a87700487bee96cdffa8fd169034204
/system/bt/stack/srvc/srvc_dis.c