History log of /system/core/adb/adb.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
1cddc2092f544c5eac339e59746436facfdd5dc7 18-Jun-2015 Elliott Hughes <enh@google.com> Ignore ro.adb.secure in user builds.

Require authorization by default, and remove the ability to override
that in user builds. (userdebug and eng are still free to do whatever
they want.)

Bug: http://b/21862859
Change-Id: Ibf8af375be5bf1141c1ad481eee7a59fb10a7adb
(cherry picked from commit 5cba504215ea91187cc36ec7aec5dce1b0f4b0fe)
/system/core/adb/adb.cpp
e1a55004e9fa46055c59f86e952e9e457c36c3f2 02-May-2015 Elliott Hughes <enh@google.com> Add WriteFdFmt and clean up more code.

Also say *which* device wasn't found.

Bug: http://b/20666660
Change-Id: I50e234ad89e39ae0a8995083c0b642c61275c5a3
(cherry picked from commit ab52c181fa4c1c9891644635dc5653cda5b90e2b)
/system/core/adb/adb.cpp
92af733ee202caa3b5475fe27fcc81582f11e7c8 01-May-2015 Elliott Hughes <enh@google.com> More adb buffer fixes.

This patch factors out a lot of the basic protocol code: sending OKAY,
sending FAIL, and sending a length-prefixed string.

ADB_TRACE has been non-optional for a long time, so let's just remove
the #ifs.

Also actually build the device tracker test tool (and remove its duplicate).

Bug: http://b/20666660
Change-Id: I6c7d59f18707bdc62ca69dea45547617f9f31fc6
(cherry picked from commit e67f1f87d9b1188ec8617035db7006c37ee7b21e)
/system/core/adb/adb.cpp
0156589846117bccb2fbec6b3141cc21bc86c638 30-Apr-2015 Elliott Hughes <enh@google.com> Add missing 'else' to fix all devices showing up as "host".

Bug: http://b/20705355
Change-Id: I4f7830278f0c2bc87d95d148d85455b8da894645
(cherry picked from commit 3ce9575af76fa6dc110506080434303b9459abf4)
/system/core/adb/adb.cpp
d81f75ae41b2eed4ae7b0911f250778f3e6ec9c2 25-Apr-2015 Elliott Hughes <enh@google.com> Remove strtok from adb.

Also fix android::base::Split to behave like Java, Python, and google3.

(cherry picked from commit 8d5fa6da44d56511b3e173bc463cbc65ff221b4a)

Change-Id: I9388ae37ee8dd4a4a6c2a9a19f068b70d9a78353
/system/core/adb/adb.cpp
7b506090e1ac51f4990f17621c6e33847b0632a2 20-Apr-2015 Elliott Hughes <enh@google.com> Always explain why bind(2) failed.

This has confused several people lately.

Bug: http://b/20219978
Change-Id: I2537ceb83bff0b3166c230c728d4389a983db858
/system/core/adb/adb.cpp
7be29c819b4fb8bf9b1d4b69a4333f8765de0281 17-Apr-2015 Elliott Hughes <enh@google.com> Show $ADB_VENDOR_KEYS if authentication fails.

Incorrectly set $ADB_VENDOR_KEYS is the most likely cause of failed
adb connections. Make it easier to debug such problems by including
the value in use in the error message.

Bug: 20165551
Change-Id: I64c1d98ae6d3fb40eea9e1f0ddcfcf4f2d9d7318
/system/core/adb/adb.cpp
8743ef98414b336f222327253f2cde6bf6aee386 20-Mar-2015 Dan Albert <danalbert@google.com> Additional cleanup of start_device_log.

Addresses nnk's post commit review comments on
https://android-review.googlesource.com/#/c/139381/

Remove unneeded code for creating /data/adb.

Add an O_CLOEXEC.

Move the closing of stdin out to main().

Append the pid of the current process to the log file to avoid
clobbering the log if the process crashes and restarts within the same
second.

Change-Id: Ide0be86b4b33256486634c29ba02efaf10cf913d
/system/core/adb/adb.cpp
ea2175ab6bae74409620374a96fc9a0097a1845c 09-Mar-2015 Dan Albert <danalbert@google.com> Use text based trace masks for adbd.

Previously the adbd trace mask had to be set as raw hex rather than
with the colon separated list. We all have better things to do than
memorize bitmasks, so make adbd use the same trace mask setting code
as adb.

Change-Id: I0bf0ab61c070d06d1cc2acf1ed90b2b77ccd261b
/system/core/adb/adb.cpp
3313426fad9eaaf53017cdbde889ebcec91358ec 19-Mar-2015 Dan Albert <danalbert@google.com> File header cleanup.

* sysdeps.h should always be included first.
* TRACE_TAG needs to be defined before anything is included.
* Some files were missing copyright headers.
* Save precious bytes on my SSD by removing useless whitespace.

Change-Id: I88980e6e00b5be1093806cf286740d9e4a033b94
/system/core/adb/adb.cpp
bac3474a8256cb32a29e8d46f78cad95a5502692 26-Feb-2015 Dan Albert <danalbert@google.com> Move adb to C++.

I keep trying to clean things up and needing std::strings. Might as
well just do this now.

usb_linux_client.c is going to stay as C because GCC isn't smart
enough to deal with the designated initializers it uses (though for
some reason it is in C mode).

The Darwin files are staying as C because I don't have a way to test
that they build.

The Windows files are staying as C because while I can actually build
for them, it's slow and painful.

Change-Id: I75367d29205a9049d34460032b3bb36384f43941
/system/core/adb/adb.cpp