f140227beb6d9e78955a7676dc0dd3f793f72017 |
|
17-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Don't directly reference hidden View fields Remove references to hidden view properties and fields where 100% analogous unhidden equivalents exist. * isLayoutRtl() * mContext Bug: 18777272 Change-Id: I1cc69fd846893087787f5cf340bf2a0ee6571f42
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
d690dff231dd5a81b9bd7563838455f24e49c75c |
|
03-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Change text colors to reflect their state The editor's text color suffered from two conflicting problems 1) It didn't all pass GAR 2) The difference between hint text and regular text is too subtle to differentiate at a glance Changes 1) Once a LabeledEditorView is non-empty, the text color of the spinner should no longer be the hint text color 2) Once an editor field is focused, all fields in the same EditKindSection get a slightly darker color. Since the various name editors, don't actually belong to a EditKindSection extra work needed to be done for them. 3) Drop down lists use non hint colors Read only editor continues to use the darker hint color. There is no need to strongly distinquish hint colors from non hint colors in the read only editor. Bug: 18004959 Change-Id: Ia6b16ab882b2fcb9113c2ac880e741f62115a1f9
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
043fba637b421dcd554c634f769f0e883fb5ff8b |
|
30-Oct-2014 |
Brian Attwell <brianattwell@google.com> |
Material design of common edit screen fields The normal edit screen fields, such as phone number and location, have been updated to look like the new Material design mocks. I expect this to be the largest CL needed to finish b/18004959. Aspects of the Editor that haven't been touched in this CL - readonly editor - collapse nickname and phonetic name into StructuredNameEditorView. Then make sure the layout is correct - photo editor - Material insert/delete interpolators (maybe fast_out_slow_in) - account header Some complicated/weird parts of the CL: -KindSectionView no longer displays an "Add details" button. Instead it always shows an additional empty row for each mimeType. The logic that handles this is mostly inside #updateEmptyEditors(). A lot of code could be deleted from RawContactEditorView because of this. -LabeledEditorView's adapter displays TextView's inside Spinner. In order to make the TextViews look like EditTexts, I set the EditText's background (so the 9patch padding is used) and then later remove the background. -Instead of keeping an expansion_view_container in every single field, I only kept it where it was needed. As a result, I needed to add null checks into the TextFieldsEditorView base class. -I made an effort to reduce the depth of the view hierarchy and reduce the use of LinearLayout weights for performance reasons, when it was easy to do so Bug: 18004959 Change-Id: I5934ca189b66468834faf3bb995b172ae2f90bed
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
9813b71d3a6a2e0baba96cda72ee55415e523166 |
|
21-Feb-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE in setGroupMetaData Check that listView is non-null before dereferencing it. Catch case in onClick() where popup was dismissed but mPopup wasn't cleared. Bug:13136064 Change-Id: I8f826ae969434c4dce88c5fb506b5ed2cc9ea04b
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
f54c9f2c84a88e046e29123fa65b19040e5a457b |
|
10-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Handle null returns from insertChild insertChild() returns null whenever kind is null. Don't crash in these cases. Bug:12490438 Change-Id: Idf1cd8fa9d6dfe6a2f91f3ff656663f0692f4a3f
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
cd321f65f1e50409812976380ad1f0fdb3fa35cb |
|
28-Oct-2013 |
Yorke Lee <yorkelee@google.com> |
Move ContactLoader related code to ContactsCommon This CL simply moves classes from Contacts into ContactsCommon. This is needed so that Dialer can use ContactLoader related code for b/11294679. A ContactLoader will also be needed in the future to allow InCallUI to download hi-res photos while in call. Bug: 11294679 Change-Id: Ia033f3ea2406a907a4e71290c9ce810a5583dab8
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
619ac169e45bf547a2cbcd8a9775bb234f45c00f |
|
20-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Use single method to handle all popup.dismiss() logic. Refactor to reduce duplicate code. Bug: 7902358 Change-Id: I6395635eba435ef6ebe4a34125d9a310c18f7e93
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
738ff8623dc77dd91a1b9023861e924ba5e4c27e |
|
30-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move ValuesDelta to ContactsCommon. Bug: 6993891 Change-Id: I8b065c55100a152f72cccea5b62f10a8e30161c2
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
aa690d4949b8105e5bcf10569b7cf4fae36741de |
|
29-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Prefactor RawContactDelta.ValuesDelta into top level class. Making ValuesDelta into top level class so we do not have to move RawContactDelta into ContactsCommon. ValuesDelta is used by CustomContactListFilterActivity which needs to be moved. Bug: 6993891 Change-Id: If7371cf08ac0e14218fb790c96856e971fa613ec
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
ba09d4cc21d55181c1760e7994f0225939f4999d |
|
15-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Use Objects from guava library. Switch com.android.internal.util.Objects to com.google.common.base.Objects. Bug: 6948882 Change-Id: I0adcff2e02e2dfbdfaa323ac72e0d42c1cbc979c
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
428f008513d1591cc08fcfe2cf0c9237fb313241 |
|
14-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move dependencies of AccountTypeManager into ContactsCommon. Moving dependencies in preparation to move AccountTypeManager. Bug: 6993891 Change-Id: I804cdbe64b9b8111ed286037943d593e11dc4044
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data This refactoring abstracts out the need to directly refer to Contacts database columns throughout the code. Instead, all of this information is retained in getter/setter methods within the Contact, RawContact, and DataItem classes and sub-classes. ContactLoader.Result class has been pulled to the top level as the Contact class. The Entity class has been removed and replaced with a RawContact class, with getters/setters to raw contact information. Renamed EntityDelta to RawContactDelta for better understandability as well as adding getters/setters for specific fields in the ValuesDelta nested class within EntityDelta. EntityDeltaList and EntityModifier have been renamed to RawContactDeltaList and RawContactModifier with the methods using the RawContact class directly rather than the Entity class. Data items for a raw contact are represented by a DataItem object with specialized getters/setters for subclasses of DataItem. (e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper around ContentValues. This abstracts away the ContactsContract column fields into getters/setters. The above refactoring is accompanied with changes throughout the codebase to use the new Contact, RawContact, and DataItem classes. Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix. Changed import order to be in accordance with style guide: http://source.android.com/source/code-style.html#order-import-statements Static imports will be placed at the top since most existing files used that convention. It is also a style that can be handled by both eclipse and intellij. Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
b03e6a266e3a4181d22e6be4f3fa0c5dd158d7e1 |
|
04-May-2012 |
Maurice Chu <mochu@google.com> |
Fixed group editing popup from contact editor Removed checkbox next to the last "Create new group" option in popup and removed square brackets in string. After creating a new group, the view shows the popup again with the newly create group visible and checked. This is accomplished via a listener interface to the GroupCreationDialogFragment. The tricky part to this is if the user changes device orientation while the GroupCreationDialogFragment is open. The ContactEditorFragment will save the resource id of the RawContactEditorView (since there can be many via joins) and the view id of the GroupMembershipView which is the listener. Bug: 6013015 Change-Id: Ia50a68fb6f4631995ae913182765efb24ef227ec
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
6d172800844a3f23a918a099c90c10701159bf77 |
|
26-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Added one flag, fixed two bugs Bug:6009417 Bug:6009184 Change-Id: I40e495b26cda43deaddd7794a1d09bb69cc77581
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
d91320306dc1054e063e705e08416be0d5b98edb |
|
15-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Use the Context of the Builder instead of the Activity's Also I don't like fluent interfaces Bug:6007797 Change-Id: Ia5888025ad6c89f7cd20f57f058567432c820f7a
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
93a0025b87079e0d36431a2c096f96e145053a28 |
|
12-Jan-2012 |
Makoto Onuki <omakoto@google.com> |
Fix for crash in contact card with null group name Also supress showing "null" on the group editor. Bug 5698683 Bug 5847463 Change-Id: I25bf497e719e2beed4fac32a2913a65022fe8fc7
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
d85b98628ad7434d51b4bbf7c92b41917fd234e7 |
|
26-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add overscroll effect to all lists - Add list view style with overscroll = always to all activity themes Bug: 5279577 Change-Id: I091c9d316f2d78a41836a95a06fd56705be7150b
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
9574314dd24a045761453b51244fa75a1da36f6e |
|
11-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
String changes Bug: 5150725 Change-Id: I5b9cb06fe20db37f3d9af6a8e06b35277df3580f
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
fd70903236883f47b21f23b8cb49a1ccacdfcdf1 |
|
02-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Pixel perfect work for phone contact editor - Always show account header for raw contacts - Align text fields and titles along the left margin - Align spinners - Use "Add new" as the default text if there's no value in Event or Groups field yet - Restyle account header - Use primary/secondary colors everywhere - Non-editable contact fixes: remove "not editable on this device" and replace it with a toast when the user clicks on the header, restyle item_read_only_field Bug: 5097095 Change-Id: I94a6c91b05344028b64c62735fb4559f9944529d
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets. This is primarily a replacement of the Android Account object in most parts of the app with a new AccountWithDataSet object that extends Account (by adding an additional attribute, the data set). This also includes a major refactoring of the AccountTypeManager, both to allow it to handle data sets and to allow for non-sync-adapter packages to be referenced by the sync adapters for an account and registered as sources of contact data. Attributes of the sync adapter that would typically come from the authenticator can be parsed out of the Contacts XML for these packages. Bug 5077096 Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
a7c3d4d726b91f645431af14d8cceadd2245f4ce |
|
15-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Restyle contact editor header - Move account switcher to top of editor - Make account header always displayed (even on existing contacts) - Take out hack for font size of structured name and just make it text appearance large - Align photo side by side the structured name - Move over honeycomb style of group membership item over to phone resouces folder - Center "Add another field" button on the phone Change-Id: I548edc3f1a2a0c20e83e4a28a10e110e51f8c12c
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
405671a7b42d97ebf7ae7c0eeb4721f881139673 |
|
29-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move DataKind outside AccountTypes Bug: 4184675 Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
2b95e624bc35851987fb621091f20263d635d31a |
|
25-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Changing group membership item hight to 48dip Bug: 3383867 Change-Id: Ie849084ecaf1b9c5ddb11d6313a284963511660f
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
ba3c2e541b17bc68ff86ed402e7ee2c0a84f7d80 |
|
23-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adjusting padding and fonts in contact detail Change-Id: Ia7d2a01e72c38a6aa9e7a72ef380c7b5fcf149f2
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
135b44c8604e375699e22594e65f0daec14f5bbe |
|
19-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Changing event and group membership from TextEdit to Button Bug: 3362537 Change-Id: I262bb546f03a7ce40c681e0f0077f97508359a21
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
02bb1252aa990813fa9e86ad75c458acc15e6801 |
|
06-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Removing progress dialog when saving a contact Bug: 3253127 Change-Id: Ifd3b58f202fea76596880fb6de9f8acc46a32d79
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|
18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 |
|
03-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming a couple of packages Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/editor/GroupMembershipView.java
|