History log of /packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
499378ad2961c34f18cf1c508d68e17e3d53722a 26-Jun-2015 Santos Cordon <santoscordon@google.com> Update to using CONFIGURE_PHONE_ACCOUNT

Continue supporting old format for existing app.

Bug: 21573551
Change-Id: If98f96a41f148f5dabd5f0549e3cdb2ef776c0fc
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
0db72b85bb057844277e8fe319815a05337521a4 20-Jun-2015 Yorke Lee <yorkelee@google.com> Fix NPE in PhoneAccountSettingsFragment

Bug: 21958275
Change-Id: I95d9632ed3795ae7408d1fe73288f69012038f5f
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
e822bb564453c906cc780af7de21ae28086f2664 12-Jun-2015 Yorke Lee <yorkelee@google.com> Remove connection manager picker from Telephony

Bug: 21499143
Change-Id: Id5609c87e81e1c34c0fc272ba0e248febacda980
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
0db135df689b874d7e881d8b6595021c23addf14 21-May-2015 Santos Cordon <santoscordon@google.com> Dont include "Emergency Calls" account in phone settings.

Bug: 20885214
Change-Id: Ic5b9127e53764f3e87774f5ad42c071e5cd153bc
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
8bc2e2394705f37569b6baaaec866fe90074eb2b 19-May-2015 Santos Cordon <santoscordon@google.com> Fix phone account preference removal in telephony.

Additionally add/maintain following behavior changes:
For multi-SIM devices:
- Always show the account list (even if only SIM-based accounts)
- Always list the SIM accounts
For single-SIM devices
- If there are no 3rd party (3P) accounts, do not show the account
list nor any options (make-calls-with, enable-accounts-list)
- If there are only disabled 3P accounts, show the "enable accounts"
preference but do not list any accounts (including SIM)
- If there is at least one enabled 3P account display all options
and list all accounts, including SIM-based accounts.

Bug: 20303449
Change-Id: I0d36a2fab0abea01853003ef60cce48cf4f1f6c6
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
e50b1903f2e84de2d23c035f8444cb83e1ae6226 04-May-2015 Santos Cordon <santoscordon@google.com> Add an enable/disable phone-account preference.

Preference exists in telecom app and this just adds an intent-preference
to link to it.

This change also shifts the SIP Phone Account ID from the sip Uri,
which can be inconsistent in odd cases, to the profileName, which is
what the SipProfile code itself uses as an ID.

Bug: 20303449
Change-Id: I08ce910c18c94b59a190f49c26c05d5c700e5bf2
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
a3d9425d041a5f4df28583d086c1837e0d8b0b6f 13-May-2015 Santos Cordon <santoscordon@google.com> [3/4] Use new Icon class in PhoneAccount.

Bug: 21088522
Change-Id: Ie18af3226dce5df296d643bd67cd66cea0a59a9b
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
6781b0c2375a905614781f8503bfd601f4020340 28-Apr-2015 Santos Cordon <santoscordon@google.com> Adding settings for connection services.

1) List all connection services in phone account settings.
2) Add icon to the settings listings
3) Adds code for SIP phone accounts to handle the standard
telecom CONFIGURE_CONNECTION_SERVICE intent. This means
that when a user clicks on the listed SIP account, they
will be taken to thats SIP profile's settings.
4) Added code to SipProfileDb to retrieve a single profile
by Uri.
5) Updated SipSettings to refresh list onResume(). This
allows deletes and updates made from the phone account
list to reflect the legacy Sip Profile Setting activity.

Bug: 20303449
Change-Id: If8dd98d17422c2f34a1ff1d3abd4c8e9fd81b496
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
857239b020588af9319bcfe803092ef60f82ac47 14-Apr-2015 Yorke Lee <yorkelee@google.com> Follow TelecomManager API change

Bug: 20160799
Change-Id: Iad6fa08b4e57a190fb7c9a2b1d68cf198af495b2
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
785ca2a973844e3a6871d1f9dd7b0ea934cf8dc3 18-Dec-2014 Andrew Lee <anwlee@google.com> Update SubscriptionInfo and mPhone for new intents.

+ Handle updates when there's a new intent, even if the activity
already exists.
+ Set FLAG_ACTIVITY_CLEAR_TOP so the intent is delivered to
onNewIntent().

Bug: 18724707
Change-Id: I78861a9acfa459cded01aa0ebf9c1fb3c5415bf6
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
6fee2cbd833f5c588036425d97c169d6d6c25ef8 10-Dec-2014 Andrew Lee <anwlee@google.com> Move TtyMode into its own ListPreference class.

This allows the class and behaviors to be reused in
CallFeaturesSetting and PhoneAccountSettingsActivity.

Adjust logic so that for MSIM devices, TTY appers in the
PhoneAccountSettingsFragment instead of CallFeaturesSetting.

Bug: 16844188
Change-Id: Ifcc70d674a59f0195b00155ca346f03677ade8d2
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
26970ad6596084f8e1c458ce7629d3e128b6b6ab 08-Dec-2014 Sailesh Nepal <sail@google.com> Revert call settings switch style UI

For b/18489902 we added a new switch style preference when
only one call assistant was present.

We need to revert this because it encourages people to
disable the Nova call assistant just to turn off Wi-Fi
calling.

Bug: 18667522, 18489902
Change-Id: I5738095ec7acb74d9cb9178362a13f1fa9a2cc4d
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
7b2c6e230ef6df2ae7863dc61b632a25393707ee 26-Nov-2014 Evan Charlton <evanc@google.com> Start the configure intent with the right user

When opening the ConnectionService's CONFIGURE activity, make sure
to direct it to the correct user.

Additionally, register SIM/SIP PhoneAccounts as MULTI_USER so that
secondary users can use them.

Finally, differentiate between work profile PhoneAccounts so that
they can be correctly identified by the user.

Bug: 17421902
Bug: 17421044
Bug: 18278824
Change-Id: I673904a7ae038c88688bba62642e93174e55c308
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
6944b0f0854fd8a6f70beb33078eeaf82f093651 24-Nov-2014 Sailesh Nepal <sail@google.com> Fix Telephony build

Change-Id: Ida0043d2e5ce4082663b321a2e260d05105af61c
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
bb9b54c3af3d72abb27e2d0bad2b347f9e7b0a50 22-Nov-2014 Sailesh Nepal <sail@google.com> Hide "Make calls with" item for 1 account

We were using getAllPhoneAccountsCount to see if the "Make
calls with" item should be hidden. This doesn't work because
this includes accounts like connection managers.

Fix is to use getCallCapablePhoneAccounts instead.

Bug: 18489902
Change-Id: Iccd307951b54142a9a0edabbc747cddbba471881
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
f211f688da2c6d8230b10c5edd9de068e4a39296 24-Nov-2014 Sailesh Nepal <sail@google.com> Merge "Hide call assistant configure item if necessary" into lmp-mr1-dev
be890cfe4322ac4d4e02889b40159d3b6787bc78 21-Nov-2014 Sailesh Nepal <sail@google.com> Hide call assistant configure item if necessary

With this CL we hide the configure item if:
- no call assistant is set
- or if the selected call assistant doesn't have a
configure component

Bug: 18473946
Change-Id: If44e07544b05841b17b0d89597e91894450f143b
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
7258f5c542673834266f51503a931dfe43ea8a0d 24-Nov-2014 Sailesh Nepal <sail@google.com> Merge "Simplify call assistant setting" into lmp-mr1-dev
3eb40fcf9c7d3f80e36f429175d7d838f1537e88 21-Nov-2014 Sailesh Nepal <sail@google.com> Simplify call assistant setting

If there's only a single call assistant then we don't
show a list anymore. Instead we show a simple ON/OFF
button.

Bug: 18473946
Change-Id: I7dca50ada80b2203bd8d646bb510418646382df8
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
3ab207e3711ebd717f9cfe7412018c51ae1c8131 20-Nov-2014 Wink Saville <wink@google.com> Additional changes to SubscriptionManager API as per API council.

bug: 17575308
Change-Id: Idd98aa46c15a9219ccf28091c62602ac8bf16c62
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
0ea038be6610481204d8d68bcbce4703f2a7b177 21-Nov-2014 Andrew Lee <anwlee@google.com> Use activity as context.

Instead of using the activity's application context.

This fixes an error where a settings list item was showing up as
white text and was barely readable.

Bug: 18232725
Change-Id: I54788ffdb63e57bf3b6641d4d7280085550c9b5e
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
e9fe49dbda2ecdc880cb0929e86c15b0335127dc 20-Nov-2014 Wink Saville <wink@google.com> Revert "Additional changes to SubscriptionManager API as per API council."

This reverts commit 88fd66a22ab781927556a34cdb7b14179efea917.

Change-Id: Ia6353137c665ca048bb1b02dee7bd581dec9973f
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
88fd66a22ab781927556a34cdb7b14179efea917 19-Nov-2014 Wink Saville <wink@google.com> Additional changes to SubscriptionManager API as per API council.

bug: 17575308
Change-Id: I7773965094510999bfce8fc6b2b31ba6ce496653
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
0f3b5fcda1b76fbd6042f9a6f81f69d0b44bc3ee 11-Nov-2014 Wink Saville <wink@google.com> Update SubscriptionManager API as per API council.

bug: 17575308
Change-Id: Ib39a60e4f75981a466e9d606ec627756efad018d
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
e4d6c246212f1480752d8dd17e0999439770cca0 07-Nov-2014 Sailesh Nepal <sail@google.com> Merge "Set package name before starting call assistant activity" into lmp-mr1-dev
defacc8899ccdf8764f3c28f31235932b46f19ad 07-Nov-2014 Sailesh Nepal <sail@google.com> Set package name before starting call assistant activity

Setting package name is necessary to make sure the correct
app is launched.

Bug: 18294259
Change-Id: I2b2684e81f5be6e72cb13ae44bc095352f4f7c8a
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
1aa87b9090804cc96bb7a8dac13b647907d28a6c 07-Nov-2014 Andrew Lee <anwlee@google.com> Delete some unused references.

Bug: 17019623
Change-Id: I1cb520e8293c73f81db61308dc994255cefdcc25
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
5ed870cca68496757c2335d37d3818e9aa0006b6 29-Oct-2014 Andrew Lee <anwlee@google.com> Add MSIM support for FDN.

Show title and get the Phone object to modify FDN settings for
according to subscription..

+ Add helper to provide common functionality for setting/getting
extras, getting the appropriate phone for a given subscription id,
and other miscellaneous things.

+ Show the subscription label in actionbar title of Call settings,
FDN settings, and FDN list. I didn't do this for edit/delete because
they have really long titles, and the context didn't seem necessary
at that point.

+ Pass the subscription label/id along in intents to the various FDN
setting activities.

+ Get the correct phone, so FDN setting changes are SIM-specific.

+ Take into account subscription id when providing a Uri for
modifying FDN settings, so that FDN contacts can be modified on a
per-sim basis.

- Delete some unused strings.

Bug: 18233666
Bug: 18232723
Bug: 18114923
Change-Id: I05c7149382adb7e7af36d38bab8a6875d5b20609
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
f8c4cb35e162a5ee9c75081e651d1521adc49e27 04-Nov-2014 Stuart Scott <stuartscott@google.com> Use CharSequence for DisplayName

Change-Id: Ib18a4d255fd2eb50125b71c89fb7ff5ba4abd690
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
4877971c60edc399874a98b8b1ece6714964587d 30-Oct-2014 Stuart Scott <stuartscott@google.com> Clean up public API of SubInfoRecord.

bug: 17575308
Change-Id: I5fad0008ef57188d6b13ebbf4b6ce304b0e67fce
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
787a8cb70963e01282ca5db869e51e05e1d60011 30-Oct-2014 Andrew Lee <anwlee@google.com> Add voicemail settings activity and fragment.

These are just stubs for now; in subsequent CLs, I will move the
settings/logic from CallFeatureSettings to these files.

Removed the comment in PhoneAccountSettingsActivity; the current
vision is that the activity will remain. This is particularly
useful because on Multi-SIM phones, we will want to be able to
launch phone accounts directly with an intent.

Bug: 17019623
Change-Id: Ie3f4aeca848f348e0e38af3dbd8bce0bd9f97667
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
e3c15213a991df51d35e42926d47a629f55fbb63 28-Oct-2014 Andrew Lee <anwlee@google.com> Add list of accounts in Phone Account Settings.

+ Add new constants to define SubId/SubLabels on intent which opens
the call settings.
+ Add an "accounts" preference category to phone account settings.
+ Add preferences to this new performance category for each
subscription.
+ Configure these preferences to launch an intent to start call
settings, containing the id and label of the subscription.

Bug: 18114923
Change-Id: I989bf3480418c9ac003dce677ec7b3585e82a551
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
16e0ff2349d98e109a974bb0aae624f9818d0709 24-Oct-2014 Jay Shrauner <shrauner@google.com> Prevent crash when activity is no longer running

Use application context in preferences callback to update sip settings.

Bug:18107404
Change-Id: I4221ce34c5674466855cc40621c78956e1bd8b9e
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
829e46ecc3fa122b6c5f29d2771a62e89eedd1a7 09-Oct-2014 Andrew Lee <anwlee@google.com> Handle out of index sip call options.

If the sip call option reported by sip shared preferences is not
found, force it to be SIP_ADDRESS_ONLY as a default.

I'm inferring that the trace in this bug happened because of an
invalid value set for the sip call option, so that it isn't
found as one of the possible values.

I'm supposing this could happen if a phone had the deprecated
SIP_ASK_ME_EACH_TIME value set (which is no longer a valid option).

Not positive if it's what's happening in this bug, but it seemed
like a reasonable case to safeguard against.

Bug: 17885832
Change-Id: I6d66ae3c4de7ccea38de3959a1f84cdfe2e114e1
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
1e58e41b50b337ba00605b9a56f4fa49cacb1708 07-Oct-2014 Nancy Chen <nancychen@google.com> Fix incorrect PreferenceScreen key for SIP account settings

The key to the SIP accounts settings category is incorrect which causes
a crash when we try to remove it. This happens if SIP calls are not
supported by the phone.

Bug: 17887879
Change-Id: I8dafd6f22056e0819fa5bd23e4511bf1139191fd
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
39f4a2538f7cbbb13035dc2901edffa62dcc8336 25-Sep-2014 Andrew Lee <anwlee@google.com> Fix possible NPE in phone account settings.

Bug: 17487262
Change-Id: Idec945380fe1d0e79812885962a19f88f903e5d6
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
4d37f5279f2896d16ec3d4e10ec4dcba63e86c3c 24-Sep-2014 Andrew Lee <anwlee@google.com> Move SIP settings to phone account settings.

+ Moved "SIP accounts" and "Receive incoming calls" settings from
the SIP settings creen to the Phone account settings screen.
+ To facilitate this, I moved some helper functions which used to
be in SipSettings to SipUtil. Their logical innards are for the
most part unchanged.
- Removed "SIP settings" preference screen added in call settings.
- Removed "Receive incoming calls" from SipSettings activity.
- Deleted unused SIP settings layout.
+ Changed back button behavior in SIP settings activity so that
back takes it to phone account settings, rather than call feature
settings.
+ Made some necessary classes/functions in sip/ public. Ihab said
that these were this way because of some refactoring at some point,
and it should be fine to make them public to achieve the necessary
class accessibility to facilitate this CL.

Bug: 17487262
Change-Id: I8e24abf624cadf9afc7aeff28781802732fef07d
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java
ce8ae2af29acbf5cfa9509b0770615e317ff03a0 10-Sep-2014 Andrew Lee <anwlee@google.com> Reorganize phone account settings.

+ Added new fragment for phone account settings.
+ Added new activity for phone account settings, which launches this
fragment. I would have prefered to specify a fragment on the
PreferenceScreen in call_feature_setting.xml, but I couldn't get it
to work so I dispatch an intent to start a new activity instead. I
think the preferred option doesn't work because CallFeatureSetting
is still stuck in the old PreferenceActivity model.
+ Added new activity to the manifest file.
+ Moved the default outgoing call, call assistant, and "use SIP
calling settings" into new PhoneAccountSettingsFragment.
- Deleting code for implementing those in CallFeaturesSetting.
+ Added code to AccountSelectionPreference to disable updating of the
summary, and firing and event after the value has been changed when
an account is selected.

Bug: 17487262
Change-Id: I126806ef8e70f8323a7ff143863dacffeb502eaa
/packages/services/Telephony/src/com/android/phone/settings/PhoneAccountSettingsFragment.java