History log of /system/core/fastboot/usb_windows.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
ae7bf0959bd3f79afbf365e41f015ed1c304afdc 06-Nov-2014 Christopher Ferris <cferris@google.com> Fix adb/fastboot windows compilations.

Many of the windows files where not including stdlib.h even though they
are using malloc/free calls.

Change-Id: If6959df9909d9d9928e9f4a2a96018166361cf3c
/system/core/fastboot/usb_windows.c
5957c1ffe79b34d8b1859f9f11644d1007193cbc 30-Apr-2014 Mark Salyzyn <salyzyn@google.com> fastboot: turn on -Werror

- Deal with a missing initializer issue
- Deal with some -Wunused issues
- Deal with some signed/unsigned issues
- switch to usleep from sleep to facilitate win_sdk compile

Change-Id: I64e32a5b0782aeed9582f489e866173c4df1afbf
/system/core/fastboot/usb_windows.c
bbb7981e49048a657d724bfda9465cdfe7c03a87 07-Aug-2012 Jiebing Li <jiebing.li@intel.com> Fastboot: fix fastboot timeout issue of Windows host side

Normally fastboot follows the procedure that host sends a command
to device and device sends back response after the command
is executed.

But sometimes device spends too long time to execute the command
so that timeout error occurs before host receives the response.

This patch fixes the issue by aligning with the solution of ADB.
ADB commit id: 1c4b760a5d41de3196572d50d1404e453174cf9a

Change-Id: I50e6bf428ea38219b64cca6ab82db22af28e0264
Author: Jiebing Li <jiebing.li@intel.com>
Signed-off-by: Bo Huang <bo.b.huang@intel.com>
/system/core/fastboot/usb_windows.c
157b00171a06f9ac2fd25ee3a86e801e896713d6 02-Oct-2013 Mark Wachsler <wachsler@google.com> Wait for device to disappear after reboot-bootloader.

(Linux only for now) With fastboot reading serial numbers from sysfs, it had
become possible for a fastboot command issued immediately after rebooting
the bootloader to fail, because sysfs still thought the device was online.
To prevent this, after reboot-bootloader we wait for the device to disconnect.

Also made usb_read and usb_write fail immediately if the descriptor has been
closed; this prevents an incorrect error message ("Bad file descriptor")
when errors from fb_getvar are ignored (e.g., by fb_format_supported).

Also removed unused fd param from filter_usb_device, and simplified logic
in usb_write by using do/while instead of a special case for len == 0.

Change-Id: I799b857eab411fd8ad25f5777fc61c685152ea86
/system/core/fastboot/usb_windows.c
a61bcad58ba1f7359183a333ee58303ed67e4a2f 02-May-2012 Scott Anderson <saa@android.com> resolved conflicts for merge of 13081c69 to master

Change-Id: I631e466fc53e9b0f4a39f24f959b4ae9b626bdda
13081c6915220db03886b177f1a8e0b2c63467c9 06-Apr-2012 Scott Anderson <saa@android.com> fastboot: Add ability to specify device path

For manufacturing and testing, there is a need to talk to
whatever device is connected to a given port on the host. This
change modifies fastboot's "-s" option to take either a serial
number or a device path. The device paths of the connected
devices can be listed using "fastboot -l devices" whose output
will resemble:

016B75D60A00600D usb:2-5 fastboot
AD3C12020173 usb:1-4.3 fastboot

The second column lists the device paths. If the -l option is
not given, the output from "fastboot devices" will be the same as
it used to be (i.e. the paths will not be printed).

Finally, note that the format of the device paths are platform
dependent. The example above is from Linux. On OS-X, the paths
will be "usb:" followed by hex digits. For Windows, the device
paths will be printed as "????????????" and the -s option will
not be able to select a device until someone implements the
underlying functionality in usb_windows.c.

Change-Id: I1f01b8f47acd32edb0ac18db107316a2c923bbde
Signed-off-by: Scott Anderson <saa@android.com>
/system/core/fastboot/usb_windows.c
5ae3f93f3bafbeb1fc9a3324475c58c725749c5e 28-Feb-2012 Anatol Pomazau <anatol@google.com> Remove trailing whitespaces

Change-Id: I6f83333a6ee0fbc562a12bb9555c43a44c98768e
/system/core/fastboot/usb_windows.c
913eb8bf874fcec647667bd7113da65b6e38488a 08-Mar-2011 David Krause <david.krause@motorola.com> Enlarge USB bulk transfer size for faster downloads

The default USB transfer bulk is fixed as 4096 in fastboot util code for
Windows and Linux. Enlarging the bulk size can greatly improve the image
download speed via USB.

For Windows, adjust the max bulk size to 1MB to maximize the USB transfer
speed. With this change, the USB transfer speed can be doubled to 20MB/s.

For Linux, adjust the max bulk size to 16384 to maximize the USB transfer
speed according to MAX_USBFS_BUFFER_SIZE definition in drivers/usb/core/devio.c.

For OSX, the maxLenToSend is already 1MB in code.

Change-Id: If6af8c6301f6f6c2ef345e37241706f16d8f5cda
/system/core/fastboot/usb_windows.c
b4add9b74525210478bac702d27fdaf9cf7ab18f 07-Oct-2009 Elliott Hughes <enh@google.com> Make fastboot say "no permissions" for non-writable devices.

Without this patch, "adb devices" will say "no permissions" when it sees
a device it can't write to, but "fastboot devices" will silently ignore it.
This is confusing to n00bs, especially since it doesn't seem to be widely
known that a device's USB id might be different in the bootloader (meaning
two udev rules are needed). It can also be confusing if you're sshed in,
when you can't access the device because you won't be in the "plugdev"
group, but "fastboot devices" won't make this clear.

I'm not sure about the Mac OS and Windows changes. AIUI, devices are always
writable on those platforms, but I don't use either, so I can't test this.
This patch shouldn't alter the behavior on either of those platforms.
/system/core/fastboot/usb_windows.c
dd7bc3319deb2b77c5d07a51b7d6cd7e11b5beb0 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/system/core/fastboot/usb_windows.c
e54eebbf1a908d65ee8cf80bab62821c05666d70 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/system/core/fastboot/usb_windows.c
4f6e8d7a00cbeda1e70cc15be9c4af1018bdad53 21-Oct-2008 The Android Open Source Project <initial-contribution@android.com> Initial Contribution
/system/core/fastboot/usb_windows.c