History log of /system/core/logcat/logcat.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
d98f4e8af5076e6a9dbd4ddc2c375cb7bcda8cd8 09-Jun-2015 Riley Andrews <riandrews@google.com> Lower the priority of the threads in logd/logcat.

sched_batch implies only a penalty to latency in scheduling, but
does not imply that the process will be given less cpu time. Increase
the nice level to 10 to prioritize it below ui threads.

Bug: 21696721
Change-Id: I075af059dc755402f7df9b0d7a66cca921ff04b2
/system/core/logcat/logcat.cpp
5d332907f0f845227847c31a122578dc910f1072 15-May-2015 Mark Salyzyn <salyzyn@google.com> liblog: logcat: Add printable format modifier

(cherry pick from commit b932b2f8bac124b088edc93966281cca4567dc54)

- added printable format modifier:
logcat -v printable
- opencoded borrowed individual utf8 validity checking algorithm
from utf8_length() in libutils/Unicode.cpp
- if considered basic one-character ASCII, use popular \x escape
sequences for non-printable
- logprint convert to C comments to drop mixed-mode

Bug: 19000361
Change-Id: I122a5b8fb41216fc0bc816178c0b768f3df56586
/system/core/logcat/logcat.cpp
cdb468abb38bb75aaad5d4c6699a824559cf272a 02-Jun-2015 Mark Salyzyn <salyzyn@google.com> logcat: -f run in background

(cherry pick from commit 3ef730c57f88ac24b0d6b021e43fc344d602fe36)

- if saving to file, set SP_BACKGROUND policy
- if saving to file, set BATCH priority
- sort include files

Bug: 19608716
Change-Id: I00acb8b8db0d2ff9ff36c97f9e74604d31938376
/system/core/logcat/logcat.cpp
117c3220400bcffce74470ebcf2179d6845cb78b 27-May-2015 Mark Salyzyn <salyzyn@google.com> logcat: -f flag to continue

(cherry pick from commit f3555d9427425c2cba9600ceffb49305c440aa4a)

On startup, check the current logging content, then grab logs from
that time forward rather than restarting from the beginning. Add
support for reading tail time down to the nano-second.

Bonus, permits us to create a logcatd logpersist daemon

Bug: 19608716
Change-Id: Iaab58de4c02b7f97c69de12cf954fedc2163059e
/system/core/logcat/logcat.cpp
79c3815ca191033bd97e7d4458970b606f661a18 06-May-2015 Mark Salyzyn <salyzyn@google.com> logcat: liblog: Add "usec" format argument

(cherry pick from commit e1f2004ecc05ce2d5d4313d16c7791594643f2ef)

- Add additional 3 digits of time precision for time output
adding in the reporting of usec
- Remove trailing space in header file

Change-Id: Ifb560850b8e01080e126fbaeab640db71cce3eea
/system/core/logcat/logcat.cpp
77d7e81c1c06fe47b07c3252cb21de86dbaedcd5 13-Apr-2015 Mark Salyzyn <salyzyn@google.com> logcat: build regression

printflike checks for NULL fmt at compile time, checks for
NULL at runtime are optimized out. Regression as a result
of commit 5976303aa6e55a9e81eadb35d50f458052e3fa24.

Change-Id: Ia4e7ee4b6cb2adf1e6609c70e79684855f76e6fc
/system/core/logcat/logcat.cpp
5976303aa6e55a9e81eadb35d50f458052e3fa24 10-Apr-2015 Traian Schiau <traianx.schiau@intel.com> logcat: Minor fixes

Remove -r default value implementation (since is not functional).
Check the status of some memory allocations.
Make sure that the pruning buffer is set to NULL if we get to the end of the loop.
Make sure that the file status is successfully retrieved before using the size.
Add strtouia - string to unsigned argument.
Add logcat_panic with/without printing an error message and help.
Play nicer with the android namespace.

Change-Id: Id4c37cf64968128424e29bf1725f6c9a5924a0e2
Signed-off-by: Traian Schiau <traianx.schiau@intel.com>
/system/core/logcat/logcat.cpp
bba894af3f4260dcabfee902d4e3836a606da9b8 09-Mar-2015 Mark Salyzyn <salyzyn@google.com> logcat: fortify help on filterspec

Bug: 19620794
Change-Id: I572ffb62d39d884d5102b0846a95b1a8216f3d41
/system/core/logcat/logcat.cpp
5f6738af4897f11d5a6674cffefdfcd2b46c5890 27-Feb-2015 Mark Salyzyn <salyzyn@google.com> logcat: remove dead label code

Change-Id: I12d6aa4ebf48f06faf9435b4ffedfd309629cf3b
/system/core/logcat/logcat.cpp
9421b0c0600030f84c81b05e708e2d7b1a3f9b1c 26-Feb-2015 Mark Salyzyn <salyzyn@google.com> logcat: do not stop on unexpected log ID

We are changing the log read API to allow event notification
regarding logging system data loss. We would like these out
of band events to be reported.

Change-Id: I9e802113604d8cc0fc9adff0d1e014bbc40914fe
/system/core/logcat/logcat.cpp
7c975ac3a471d4c7f6a7246558e5e9295118a97d 15-Dec-2014 Mark Salyzyn <salyzyn@google.com> logcat: add pstore read

Used to pull the Android log messages after a reboot.
A companion to the pstore console logs. Adding the -L
flag triggers this behavior.

Change-Id: Icce2dc00bcbb26975bea604420c6be397869e804
/system/core/logcat/logcat.cpp
7b30ff8d8768241af0e036e4d9296d07b2dde66a 26-Jan-2015 Mark Salyzyn <salyzyn@google.com> logcat: Add -D print dividers flag

Permits a single thread to collect several log buffer and
to separate them out into named buckets by keying off the
dividers ---------

Change-Id: I5a92c67383a73ea566cb9b9732d26d88d9c41c66
/system/core/logcat/logcat.cpp
2d3f38a6b8e724749b59d201a01b35fa0951141e 26-Jan-2015 Mark Salyzyn <salyzyn@google.com> liblog: introduce ANDROID_LOG_* flags

Move away from using POSIX open(2) flags and introduce ANDROID_LOG_* flags to
replace them. Add security by preventing random mode flags from getting into
underlying POSIX calls. ANDROID_LOG_* flags overlap POSIX O_* flag definitions.

Change-Id: Ib32bb64c287e8bf150be62242e1ba46bb37839fc
/system/core/logcat/logcat.cpp
d0bd1b1b58a31c193889eef1b427e9fd3f77b782 11-Oct-2014 Mark Salyzyn <salyzyn@google.com> logcat: use liblog to determine -b all list

- This is done to prevent the administrivia of adjusting
logcat sources every time a new log id is added.

Change-Id: I0074afb00694c2c00f6c3a66e58c15691146a6c5
/system/core/logcat/logcat.cpp
eba7344fc1aca4ae232b881fdf6c5b16e6f59bc9 17-Oct-2014 Aristidis Papaioannou <aristidis@google.com> Made suffix length of rotated logcat files constant.

The suffix now uses as many digits as needed to cover the maximum number
of rotated files.

eg, for 20 files it would use 2 digits: log_file.{01,02,03,...,20}

Change-Id: I4709b3cf4bf88c209db3c4d9e24a3a4731c98bae
/system/core/logcat/logcat.cpp
649fc605f8094c06a38251466ccb15a722e8a91f 16-Sep-2014 Mark Salyzyn <salyzyn@google.com> logcat: -v format defaults to threadtime

Change-Id: Iafddf83b0507a667e0395d38ec9afaed67319018
/system/core/logcat/logcat.cpp
ead88fca6e7178ed8b6e89701a5842a3e34a0a3f 17-Oct-2010 Pierre Zurek <pierrezurek@gmail.com> liblog: logcat: colored output.

This patch adds a new '-v color' option to logcat so that the output is
colored similar to the ones in DDMS. Simply type "adb logcat -v color"
to use it. Works well with bash in gnome-terminal. NO GUARANTEE IT WILL
WORK ON A NON xterm STYLE TERMINAL.

Signed-off-by: Michael Zimmermann <sigmaepsilon92@gmail.com>
Signed-off-by: Mark Salyzyn <salyzyn@google.com>
Change-Id: I9189c5f27fed991579edbcbc6834536eb8112152
/system/core/logcat/logcat.cpp
190b7ac9d2a06b49d20d1b0d8eb5c9251636288f 01-Sep-2014 Mark Salyzyn <salyzyn@google.com> logcat: document help tail from time

(cherry picked from commit 6a594683ec8aa2c8cee98a95f502772db515e60e)

Bug: 17323719
Change-Id: Id057dde60e699c946828f4aeabedf1728b3bc877
/system/core/logcat/logcat.cpp
0b2dac4f3f289448e5728e6c2f7d9ac04cdafdeb 07-Jul-2014 Mark Salyzyn <salyzyn@google.com> logcat: parse failure for -n <KBsize> and -r <rotate limit>

Bug: https://code.google.com/p/android/issues/detail?id=72867
Change-Id: Id0c988543ecfccc5054d15d4195ef578468d50af
/system/core/logcat/logcat.cpp
e4369d68a255790ff0ed21ba31d3dcbb520df09d 27-May-2014 Mark Salyzyn <salyzyn@google.com> logd: logcat: debuggerd: audit logs to events and main

- auditd spawn log copy to events and main
- logcat delete events as one of the default logs
- debuggerd do not collect events.
- squish multiple spaces
- switch from strcpy to memmove for overlapping buffers

BUG: 14626551
Change-Id: I89b30273ce931ed2b25a53ea9be48e77f4c1bbf4
/system/core/logcat/logcat.cpp
989980c55d9a11766b8698a97ce5eef3d8cfa286 14-May-2014 Mark Salyzyn <salyzyn@google.com> logd: logcat: debuggerd: auditd logs to events

- auditd switch to recording logs to events log id
- logcat add events as one of the default logs
- debuggerd collect events log as well.

ToDo: debuggerd & bugreport collect intermixed logs.

BUG: 14626551
Change-Id: I958f0e729b7596748be57488a38824db5645be7b
/system/core/logcat/logcat.cpp
671e343c7d9c832eca093325c0b8b934c47a83b4 06-May-2014 Mark Salyzyn <salyzyn@google.com> logd: logcat: Add persist.logd.size group of properties

- logd Add persist.logd.size (global), persist.logd.size.<logid>
- logcat report a more flexible multiplier in -g command.

Bug: 14563261
Bug: 14469172
Change-Id: Ie389caa14ad3ae3d4a3a3cc463425bb9dbc5e483
/system/core/logcat/logcat.cpp
5045f575252ce3d25304ba26cec299395c02152c 30-Apr-2014 Mark Salyzyn <salyzyn@google.com> liblog: logcat: Move library print test into gTest

Change-Id: Icd33808d4c974625f4fd0a126a90a2b4c90c8315
/system/core/logcat/logcat.cpp
b149e245c8ccd90b52227f3d07ab572080afac53 30-Apr-2014 Mark Salyzyn <salyzyn@google.com> logcat: turn on -Werror

- Deal with some -Wunused issues

Change-Id: Ic4ab9a49f13e156a73d40266e413dee3e6396178
/system/core/logcat/logcat.cpp
99f47a9e7c4374f2bbfc18e4a97aa7848245ea33 07-Apr-2014 Mark Salyzyn <salyzyn@google.com> logd: liblog: logcat: debuggerd: Add LOG_ID_CRASH

Change-Id: Iea453764a1a4fc1661f461f10c641c30150e4d20
/system/core/logcat/logcat.cpp
bbbe14f758d7b9f147daf82a59b317b087631c01 11-Apr-2014 Mark Salyzyn <salyzyn@google.com> logcat: Better help message for white and black list

Change-Id: Ia739260b4e0fcf8062ad9166fd65b1d6e7bb446c
/system/core/logcat/logcat.cpp
1c950479393d42d18829d4009dbdb3a7f03acbb7 02-Apr-2014 Mark Salyzyn <salyzyn@google.com> logd: liblog: logcat: enable prune features for user

- Enable whitelist, blacklist and logsize tuneables for user

Change-Id: Id0c283844c71c5263a8cfbebf2e550f7ac415858
/system/core/logcat/logcat.cpp
22e287df0dfbc6e10c02f570d2fc0c42a2a6b7aa 21-Mar-2014 Mark Salyzyn <salyzyn@google.com> logcat: white and blacklist failure

- logcat improperly squashes out count
- logcat test enhanced to catch failure
- logd places entries in ascending sorted order

Change-Id: If39d8e2c40852b520c98e7840034ab63c2538e5d
/system/core/logcat/logcat.cpp
fff04e3014f3ba516544be4ed345ddcf8ddac7fb 17-Mar-2014 Mark Salyzyn <salyzyn@google.com> logcat: improve error messages

Bug: 13464830
Change-Id: Ia8783fa2422e444bcdfca8d0153cf6e7634612bb
/system/core/logcat/logcat.cpp
fa3716b2501ccddc8e0cd30f6343692b8deb7639 15-Feb-2014 Mark Salyzyn <salyzyn@google.com> logd: liblog: logcat: Arbitrary time to tail

Change-Id: I10e8d92c933e31ee11e78d2d1114261a30c4be0e
/system/core/logcat/logcat.cpp
dfa7a07f5be656cfafdb4e75916bc9dcd9e592e7 11-Feb-2014 Mark Salyzyn <salyzyn@google.com> logd: liblog: logcat: Add LogWhiteBlackList

- liblog android_logger_get_log_size and android_logger_get_readable_size
adjusted to return long instead of int because of -G flag extending range

NB: ifdef'd only for userdebug and eng builds

- liblog Add android_logger_[sg]et_prune_list and android_logger_set_log_size
- logcat Add -P, -p and -G flags
- logd Add LogWhiteBlackList and configurable log size

(cherry picked from commit 18a5432158ad43b8faefe4950b30e760200ce0b4)

Change-Id: I1572338c1b34bd968ad7867857ef708156ec3b6a
/system/core/logcat/logcat.cpp
34facab86b0fe7ec613de92b46b637f864fb0682 06-Feb-2014 Mark Salyzyn <salyzyn@google.com> logd: liblog: logcat: Add Statistics

- logd add statistical collection and formatting
- liblog add android_logger_get_statistics call
- logcat add -S flag
- logcat add -b all

(cherry picked from commit 51a29c8dc445e4fb89860561933e54a231e6ffb4)

Change-Id: I521753b1969ecd4590c956aeeb1557d101059d67
/system/core/logcat/logcat.cpp
5d3d1f17dbcb01aedd510b5435ebdaf1d6afc138 09-Dec-2013 Mark Salyzyn <salyzyn@google.com> logcat: Add -T flag (-t w/o assumption of -d)

(cherry picked from commit de02546e3d7c9c307e3d87e0a7fe8bb39b363a72)

Change-Id: I49763e2db83755e0b7b12dfa3f83a3957c54d389
/system/core/logcat/logcat.cpp
65772ca7d7b61b111e75fb0f66f43966f0794bbd 13-Dec-2013 Mark Salyzyn <salyzyn@google.com> logcat: Add logcat test suite

(cherry picked from commit 2807db9a269baaa7b3f67c337d3312877ba90aa0)

Change-Id: Ic4c84b88b8d899965c9765bdc3ee223ef73ba7d1
/system/core/logcat/logcat.cpp
95132e97e57b055c5103619ce2487d07f30e63db 22-Nov-2013 Mark Salyzyn <salyzyn@google.com> logcat: Incorporate liblog reading API

(cherry picked from commit a1062c728a04e0de6e86a138d98eaff12f14fb41)

Change-Id: I1e1a55d13ac55350e8d54bfe92b392de07f26a5d
/system/core/logcat/logcat.cpp
ccecf1425412beb2bc3bb38d470293fdc244d6f1 16-Jan-2014 Elliott Hughes <enh@google.com> system/core 64-bit cleanup.

This cleans up most of the size-related problems in system/core.
There are still a few changes needed for a clean 64-bit build,
but they look like they might require changes to things like the
fastboot protocol.

Change-Id: I1560425a289fa158e13e2e3173cc3e71976f92c0
/system/core/logcat/logcat.cpp
9227bd385504ace739d4451a6c5dc3d777b5bf21 24-Jul-2013 Colin Cross <ccross@android.com> Move liblog headers to system/core/include/log

Move the liblog headers to log/ instead of cutils/ to complete
the separation of libcutils and liblog. cutils/log.h still
exists and includes log/log.h in order to support the many existing
modules that use cutils/log.h.

Change-Id: I2758c9f4aedcb809ca7ba8383d0f55041dd44345
/system/core/logcat/logcat.cpp
80b221cb22f37446e76829d2dd0e8953a32f3bda 13-Aug-2012 Edwin Vane <edwin.vane@intel.com> Fixed an unused param warning in logcat

Changed a function to actually use its parameter instead of a global
variable. All callers of the function pass the global variable as an
argument anyway so behaviour is unchanged.

Change-Id: Ib84d45c17d2213c4d441bf2f423feca14e7aa2f4
Author: Edwin Vane <edwin.vane@intel.com>
Reviewed-by: Ariel J Bernal <ariel.j.bernal@intel.com>
/system/core/logcat/logcat.cpp
274c31ab6b646b52dfe0f69a9e30077795065d0a 23-Feb-2012 Nick Kralevich <nnk@google.com> fix "logcat -c ; logcat -d" hang.

Change-Id: I1dc3633fc7228a6ff8ed0da4572f40055a28ceb2
/system/core/logcat/logcat.cpp
46070505e771fb539748936dd6ac68aa77b9f422 17-Oct-2011 Nick Kralevich <nnk@google.com> logcat: add sanity check

Sanity check that the length we get back from the kernel matches
how much data we actually received.

Change-Id: I5cfd80321ab41459bb514dfde2da57413a7bd9e6
/system/core/logcat/logcat.cpp
4bf3c02e026077d14a4512c7c2f71937da3c2d50 01-Oct-2011 Kenny Root <kroot@google.com> Add checking for log entry format

The log tag may be zero length if corrupted, so check for this
condition.

Change-Id: I7616226dabe78a85859b0ab53aca08f734dbdd84
/system/core/logcat/logcat.cpp
ba9608ff633724ded86aab7a9a401c87c7faafa1 18-Jun-2010 Wink Saville <wink@google.com> Update the help text to reflect new capabilities of -b parameter.

The -b parameter now support specifying multiple ring buffers
and the results are interleaved. In addition a new ring buffer
has been created, 'system', and the default is now -b main -b system.

Change-Id: Ibc25a31fb8fe21d75dda4598a83cf3426f759eb1
/system/core/logcat/logcat.cpp
50844525a31fa41d7d432efb3c0355b38adb2f5f 18-Mar-2010 Mathias Agopian <mathias@google.com> fix [2483384] logcat crash when malloc debug is enabled

fix a couple of uninitialized variables

Change-Id: I1f7552ecb20d85dbf0fec5cae9778a70ff9281a2
/system/core/logcat/logcat.cpp
d1d3b6dbedd720349aef3e93c4f61a43ffe5ada3 12-Mar-2010 Dan Egnor <egnor@google.com> Add '-t N' flag to logcat, to print only the last N lines of logcat
(to be used in capturing a merged mini logcat for crash reports)

Change-Id: I68149eb80f2f79812f43b07d80fbea822476859e
/system/core/logcat/logcat.cpp
e2bf2ea4d2846031edfc52b942ad53e5467243f6 01-Mar-2010 Joe Onorato <joeo@android.com> Make logcat print both the main and system buffers by default. Make SLOGx macros work.
/system/core/logcat/logcat.cpp
6fa09a066d6b6898a394a3ccf6c32111665cdbcb 26-Feb-2010 Joe Onorato <joeo@android.com> Allow logcat to take multiple -b options, and interleave the results.
/system/core/logcat/logcat.cpp
dd7bc3319deb2b77c5d07a51b7d6cd7e11b5beb0 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/system/core/logcat/logcat.cpp
e54eebbf1a908d65ee8cf80bab62821c05666d70 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/system/core/logcat/logcat.cpp
1b8e5a6b14ca850920e19b3dfae41e6494475c1a 13-Feb-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //branches/cupcake/...@131421
/system/core/logcat/logcat.cpp
4f6e8d7a00cbeda1e70cc15be9c4af1018bdad53 21-Oct-2008 The Android Open Source Project <initial-contribution@android.com> Initial Contribution
/system/core/logcat/logcat.cpp