method_verifier.cc revision daaf3265806eb2eadb2e03302bd68022fab5ca28
1/* 2 * Copyright (C) 2011 The Android Open Source Project 3 * 4 * Licensed under the Apache License, Version 2.0 (the "License"); 5 * you may not use this file except in compliance with the License. 6 * You may obtain a copy of the License at 7 * 8 * http://www.apache.org/licenses/LICENSE-2.0 9 * 10 * Unless required by applicable law or agreed to in writing, software 11 * distributed under the License is distributed on an "AS IS" BASIS, 12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 13 * See the License for the specific language governing permissions and 14 * limitations under the License. 15 */ 16 17#include "method_verifier-inl.h" 18 19#include <iostream> 20 21#include "base/logging.h" 22#include "base/mutex-inl.h" 23#include "class_linker.h" 24#include "compiler_callbacks.h" 25#include "dex_file-inl.h" 26#include "dex_instruction-inl.h" 27#include "dex_instruction_utils.h" 28#include "dex_instruction_visitor.h" 29#include "gc/accounting/card_table-inl.h" 30#include "indenter.h" 31#include "intern_table.h" 32#include "leb128.h" 33#include "mirror/art_field-inl.h" 34#include "mirror/art_method-inl.h" 35#include "mirror/class.h" 36#include "mirror/class-inl.h" 37#include "mirror/dex_cache-inl.h" 38#include "mirror/object-inl.h" 39#include "mirror/object_array-inl.h" 40#include "reg_type-inl.h" 41#include "register_line-inl.h" 42#include "runtime.h" 43#include "scoped_thread_state_change.h" 44#include "handle_scope-inl.h" 45#include "verifier/dex_gc_map.h" 46 47namespace art { 48namespace verifier { 49 50static constexpr bool kTimeVerifyMethod = !kIsDebugBuild; 51static constexpr bool gDebugVerify = false; 52// TODO: Add a constant to method_verifier to turn on verbose logging? 53 54void PcToRegisterLineTable::Init(RegisterTrackingMode mode, InstructionFlags* flags, 55 uint32_t insns_size, uint16_t registers_size, 56 MethodVerifier* verifier) { 57 DCHECK_GT(insns_size, 0U); 58 register_lines_.reset(new RegisterLine*[insns_size]()); 59 size_ = insns_size; 60 for (uint32_t i = 0; i < insns_size; i++) { 61 bool interesting = false; 62 switch (mode) { 63 case kTrackRegsAll: 64 interesting = flags[i].IsOpcode(); 65 break; 66 case kTrackCompilerInterestPoints: 67 interesting = flags[i].IsCompileTimeInfoPoint() || flags[i].IsBranchTarget(); 68 break; 69 case kTrackRegsBranches: 70 interesting = flags[i].IsBranchTarget(); 71 break; 72 default: 73 break; 74 } 75 if (interesting) { 76 register_lines_[i] = RegisterLine::Create(registers_size, verifier); 77 } 78 } 79} 80 81PcToRegisterLineTable::~PcToRegisterLineTable() { 82 for (size_t i = 0; i < size_; i++) { 83 delete register_lines_[i]; 84 if (kIsDebugBuild) { 85 register_lines_[i] = nullptr; 86 } 87 } 88} 89 90// Note: returns true on failure. 91ALWAYS_INLINE static inline bool FailOrAbort(MethodVerifier* verifier, bool condition, 92 const char* error_msg, uint32_t work_insn_idx) { 93 if (kIsDebugBuild) { 94 // In a debug build, abort if the error condition is wrong. 95 DCHECK(condition) << error_msg << work_insn_idx; 96 } else { 97 // In a non-debug build, just fail the class. 98 if (!condition) { 99 verifier->Fail(VERIFY_ERROR_BAD_CLASS_HARD) << error_msg << work_insn_idx; 100 return true; 101 } 102 } 103 104 return false; 105} 106 107static void SafelyMarkAllRegistersAsConflicts(MethodVerifier* verifier, RegisterLine* reg_line) { 108 if (verifier->IsConstructor()) { 109 // Before we mark all regs as conflicts, check that we don't have an uninitialized this. 110 reg_line->CheckConstructorReturn(verifier); 111 } 112 reg_line->MarkAllRegistersAsConflicts(verifier); 113} 114 115MethodVerifier::FailureKind MethodVerifier::VerifyMethod( 116 mirror::ArtMethod* method, bool allow_soft_failures, std::string* error ATTRIBUTE_UNUSED) { 117 Thread* self = Thread::Current(); 118 StackHandleScope<3> hs(self); 119 mirror::Class* klass = method->GetDeclaringClass(); 120 auto h_dex_cache(hs.NewHandle(klass->GetDexCache())); 121 auto h_class_loader(hs.NewHandle(klass->GetClassLoader())); 122 auto h_method = hs.NewHandle(method); 123 return VerifyMethod(self, method->GetDexMethodIndex(), method->GetDexFile(), h_dex_cache, 124 h_class_loader, klass->GetClassDef(), method->GetCodeItem(), h_method, 125 method->GetAccessFlags(), allow_soft_failures, false); 126} 127 128 129MethodVerifier::FailureKind MethodVerifier::VerifyClass(Thread* self, 130 mirror::Class* klass, 131 bool allow_soft_failures, 132 std::string* error) { 133 if (klass->IsVerified()) { 134 return kNoFailure; 135 } 136 bool early_failure = false; 137 std::string failure_message; 138 const DexFile& dex_file = klass->GetDexFile(); 139 const DexFile::ClassDef* class_def = klass->GetClassDef(); 140 mirror::Class* super = klass->GetSuperClass(); 141 std::string temp; 142 if (super == nullptr && strcmp("Ljava/lang/Object;", klass->GetDescriptor(&temp)) != 0) { 143 early_failure = true; 144 failure_message = " that has no super class"; 145 } else if (super != nullptr && super->IsFinal()) { 146 early_failure = true; 147 failure_message = " that attempts to sub-class final class " + PrettyDescriptor(super); 148 } else if (class_def == nullptr) { 149 early_failure = true; 150 failure_message = " that isn't present in dex file " + dex_file.GetLocation(); 151 } 152 if (early_failure) { 153 *error = "Verifier rejected class " + PrettyDescriptor(klass) + failure_message; 154 if (Runtime::Current()->IsAotCompiler()) { 155 ClassReference ref(&dex_file, klass->GetDexClassDefIndex()); 156 Runtime::Current()->GetCompilerCallbacks()->ClassRejected(ref); 157 } 158 return kHardFailure; 159 } 160 StackHandleScope<2> hs(self); 161 Handle<mirror::DexCache> dex_cache(hs.NewHandle(klass->GetDexCache())); 162 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(klass->GetClassLoader())); 163 return VerifyClass(self, &dex_file, dex_cache, class_loader, class_def, allow_soft_failures, error); 164} 165 166MethodVerifier::FailureKind MethodVerifier::VerifyClass(Thread* self, 167 const DexFile* dex_file, 168 Handle<mirror::DexCache> dex_cache, 169 Handle<mirror::ClassLoader> class_loader, 170 const DexFile::ClassDef* class_def, 171 bool allow_soft_failures, 172 std::string* error) { 173 DCHECK(class_def != nullptr); 174 const uint8_t* class_data = dex_file->GetClassData(*class_def); 175 if (class_data == nullptr) { 176 // empty class, probably a marker interface 177 return kNoFailure; 178 } 179 ClassDataItemIterator it(*dex_file, class_data); 180 while (it.HasNextStaticField() || it.HasNextInstanceField()) { 181 it.Next(); 182 } 183 size_t error_count = 0; 184 bool hard_fail = false; 185 ClassLinker* linker = Runtime::Current()->GetClassLinker(); 186 int64_t previous_direct_method_idx = -1; 187 while (it.HasNextDirectMethod()) { 188 self->AllowThreadSuspension(); 189 uint32_t method_idx = it.GetMemberIndex(); 190 if (method_idx == previous_direct_method_idx) { 191 // smali can create dex files with two encoded_methods sharing the same method_idx 192 // http://code.google.com/p/smali/issues/detail?id=119 193 it.Next(); 194 continue; 195 } 196 previous_direct_method_idx = method_idx; 197 InvokeType type = it.GetMethodInvokeType(*class_def); 198 mirror::ArtMethod* method = 199 linker->ResolveMethod(*dex_file, method_idx, dex_cache, class_loader, 200 NullHandle<mirror::ArtMethod>(), type); 201 if (method == nullptr) { 202 DCHECK(self->IsExceptionPending()); 203 // We couldn't resolve the method, but continue regardless. 204 self->ClearException(); 205 } 206 StackHandleScope<1> hs(self); 207 Handle<mirror::ArtMethod> h_method(hs.NewHandle(method)); 208 MethodVerifier::FailureKind result = VerifyMethod(self, 209 method_idx, 210 dex_file, 211 dex_cache, 212 class_loader, 213 class_def, 214 it.GetMethodCodeItem(), 215 h_method, 216 it.GetMethodAccessFlags(), 217 allow_soft_failures, 218 false); 219 if (result != kNoFailure) { 220 if (result == kHardFailure) { 221 hard_fail = true; 222 if (error_count > 0) { 223 *error += "\n"; 224 } 225 *error = "Verifier rejected class "; 226 *error += PrettyDescriptor(dex_file->GetClassDescriptor(*class_def)); 227 *error += " due to bad method "; 228 *error += PrettyMethod(method_idx, *dex_file); 229 } 230 ++error_count; 231 } 232 it.Next(); 233 } 234 int64_t previous_virtual_method_idx = -1; 235 while (it.HasNextVirtualMethod()) { 236 self->AllowThreadSuspension(); 237 uint32_t method_idx = it.GetMemberIndex(); 238 if (method_idx == previous_virtual_method_idx) { 239 // smali can create dex files with two encoded_methods sharing the same method_idx 240 // http://code.google.com/p/smali/issues/detail?id=119 241 it.Next(); 242 continue; 243 } 244 previous_virtual_method_idx = method_idx; 245 InvokeType type = it.GetMethodInvokeType(*class_def); 246 mirror::ArtMethod* method = 247 linker->ResolveMethod(*dex_file, method_idx, dex_cache, class_loader, 248 NullHandle<mirror::ArtMethod>(), type); 249 if (method == nullptr) { 250 DCHECK(self->IsExceptionPending()); 251 // We couldn't resolve the method, but continue regardless. 252 self->ClearException(); 253 } 254 StackHandleScope<1> hs(self); 255 Handle<mirror::ArtMethod> h_method(hs.NewHandle(method)); 256 MethodVerifier::FailureKind result = VerifyMethod(self, 257 method_idx, 258 dex_file, 259 dex_cache, 260 class_loader, 261 class_def, 262 it.GetMethodCodeItem(), 263 h_method, 264 it.GetMethodAccessFlags(), 265 allow_soft_failures, 266 false); 267 if (result != kNoFailure) { 268 if (result == kHardFailure) { 269 hard_fail = true; 270 if (error_count > 0) { 271 *error += "\n"; 272 } 273 *error = "Verifier rejected class "; 274 *error += PrettyDescriptor(dex_file->GetClassDescriptor(*class_def)); 275 *error += " due to bad method "; 276 *error += PrettyMethod(method_idx, *dex_file); 277 } 278 ++error_count; 279 } 280 it.Next(); 281 } 282 if (error_count == 0) { 283 return kNoFailure; 284 } else { 285 return hard_fail ? kHardFailure : kSoftFailure; 286 } 287} 288 289MethodVerifier::FailureKind MethodVerifier::VerifyMethod(Thread* self, uint32_t method_idx, 290 const DexFile* dex_file, 291 Handle<mirror::DexCache> dex_cache, 292 Handle<mirror::ClassLoader> class_loader, 293 const DexFile::ClassDef* class_def, 294 const DexFile::CodeItem* code_item, 295 Handle<mirror::ArtMethod> method, 296 uint32_t method_access_flags, 297 bool allow_soft_failures, 298 bool need_precise_constants) { 299 MethodVerifier::FailureKind result = kNoFailure; 300 uint64_t start_ns = kTimeVerifyMethod ? NanoTime() : 0; 301 302 MethodVerifier verifier(self, dex_file, dex_cache, class_loader, class_def, code_item, 303 method_idx, method, method_access_flags, true, allow_soft_failures, 304 need_precise_constants, true); 305 if (verifier.Verify()) { 306 // Verification completed, however failures may be pending that didn't cause the verification 307 // to hard fail. 308 CHECK(!verifier.have_pending_hard_failure_); 309 if (verifier.failures_.size() != 0) { 310 if (VLOG_IS_ON(verifier)) { 311 verifier.DumpFailures(VLOG_STREAM(verifier) << "Soft verification failures in " 312 << PrettyMethod(method_idx, *dex_file) << "\n"); 313 } 314 result = kSoftFailure; 315 } 316 } else { 317 // Bad method data. 318 CHECK_NE(verifier.failures_.size(), 0U); 319 CHECK(verifier.have_pending_hard_failure_); 320 verifier.DumpFailures(LOG(INFO) << "Verification error in " 321 << PrettyMethod(method_idx, *dex_file) << "\n"); 322 if (gDebugVerify) { 323 std::cout << "\n" << verifier.info_messages_.str(); 324 verifier.Dump(std::cout); 325 } 326 result = kHardFailure; 327 } 328 if (kTimeVerifyMethod) { 329 uint64_t duration_ns = NanoTime() - start_ns; 330 if (duration_ns > MsToNs(100)) { 331 LOG(WARNING) << "Verification of " << PrettyMethod(method_idx, *dex_file) 332 << " took " << PrettyDuration(duration_ns); 333 } 334 } 335 return result; 336} 337 338MethodVerifier* MethodVerifier::VerifyMethodAndDump(Thread* self, std::ostream& os, uint32_t dex_method_idx, 339 const DexFile* dex_file, 340 Handle<mirror::DexCache> dex_cache, 341 Handle<mirror::ClassLoader> class_loader, 342 const DexFile::ClassDef* class_def, 343 const DexFile::CodeItem* code_item, 344 Handle<mirror::ArtMethod> method, 345 uint32_t method_access_flags) { 346 MethodVerifier* verifier = new MethodVerifier(self, dex_file, dex_cache, class_loader, 347 class_def, code_item, dex_method_idx, method, 348 method_access_flags, true, true, true, true); 349 verifier->Verify(); 350 verifier->DumpFailures(os); 351 os << verifier->info_messages_.str(); 352 // Only dump and return if no hard failures. Otherwise the verifier may be not fully initialized 353 // and querying any info is dangerous/can abort. 354 if (verifier->have_pending_hard_failure_) { 355 delete verifier; 356 return nullptr; 357 } else { 358 verifier->Dump(os); 359 return verifier; 360 } 361} 362 363MethodVerifier::MethodVerifier(Thread* self, 364 const DexFile* dex_file, Handle<mirror::DexCache> dex_cache, 365 Handle<mirror::ClassLoader> class_loader, 366 const DexFile::ClassDef* class_def, 367 const DexFile::CodeItem* code_item, uint32_t dex_method_idx, 368 Handle<mirror::ArtMethod> method, uint32_t method_access_flags, 369 bool can_load_classes, bool allow_soft_failures, 370 bool need_precise_constants, bool verify_to_dump, 371 bool allow_thread_suspension) 372 : self_(self), 373 reg_types_(can_load_classes), 374 work_insn_idx_(-1), 375 dex_method_idx_(dex_method_idx), 376 mirror_method_(method), 377 method_access_flags_(method_access_flags), 378 return_type_(nullptr), 379 dex_file_(dex_file), 380 dex_cache_(dex_cache), 381 class_loader_(class_loader), 382 class_def_(class_def), 383 code_item_(code_item), 384 declaring_class_(nullptr), 385 interesting_dex_pc_(-1), 386 monitor_enter_dex_pcs_(nullptr), 387 have_pending_hard_failure_(false), 388 have_pending_runtime_throw_failure_(false), 389 new_instance_count_(0), 390 monitor_enter_count_(0), 391 can_load_classes_(can_load_classes), 392 allow_soft_failures_(allow_soft_failures), 393 need_precise_constants_(need_precise_constants), 394 has_check_casts_(false), 395 has_virtual_or_interface_invokes_(false), 396 verify_to_dump_(verify_to_dump), 397 allow_thread_suspension_(allow_thread_suspension) { 398 self->SetVerifier(this); 399 DCHECK(class_def != nullptr); 400} 401 402MethodVerifier::~MethodVerifier() { 403 Thread::Current()->ClearVerifier(this); 404 STLDeleteElements(&failure_messages_); 405} 406 407void MethodVerifier::FindLocksAtDexPc(mirror::ArtMethod* m, uint32_t dex_pc, 408 std::vector<uint32_t>* monitor_enter_dex_pcs) { 409 Thread* self = Thread::Current(); 410 StackHandleScope<3> hs(self); 411 Handle<mirror::DexCache> dex_cache(hs.NewHandle(m->GetDexCache())); 412 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(m->GetClassLoader())); 413 Handle<mirror::ArtMethod> method(hs.NewHandle(m)); 414 MethodVerifier verifier(self, m->GetDexFile(), dex_cache, class_loader, &m->GetClassDef(), 415 m->GetCodeItem(), m->GetDexMethodIndex(), method, m->GetAccessFlags(), 416 false, true, false, false); 417 verifier.interesting_dex_pc_ = dex_pc; 418 verifier.monitor_enter_dex_pcs_ = monitor_enter_dex_pcs; 419 verifier.FindLocksAtDexPc(); 420} 421 422static bool HasMonitorEnterInstructions(const DexFile::CodeItem* const code_item) { 423 const Instruction* inst = Instruction::At(code_item->insns_); 424 425 uint32_t insns_size = code_item->insns_size_in_code_units_; 426 for (uint32_t dex_pc = 0; dex_pc < insns_size;) { 427 if (inst->Opcode() == Instruction::MONITOR_ENTER) { 428 return true; 429 } 430 431 dex_pc += inst->SizeInCodeUnits(); 432 inst = inst->Next(); 433 } 434 435 return false; 436} 437 438void MethodVerifier::FindLocksAtDexPc() { 439 CHECK(monitor_enter_dex_pcs_ != nullptr); 440 CHECK(code_item_ != nullptr); // This only makes sense for methods with code. 441 442 // Quick check whether there are any monitor_enter instructions at all. 443 if (!HasMonitorEnterInstructions(code_item_)) { 444 return; 445 } 446 447 // Strictly speaking, we ought to be able to get away with doing a subset of the full method 448 // verification. In practice, the phase we want relies on data structures set up by all the 449 // earlier passes, so we just run the full method verification and bail out early when we've 450 // got what we wanted. 451 Verify(); 452} 453 454mirror::ArtField* MethodVerifier::FindAccessedFieldAtDexPc(mirror::ArtMethod* m, 455 uint32_t dex_pc) { 456 Thread* self = Thread::Current(); 457 StackHandleScope<3> hs(self); 458 Handle<mirror::DexCache> dex_cache(hs.NewHandle(m->GetDexCache())); 459 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(m->GetClassLoader())); 460 Handle<mirror::ArtMethod> method(hs.NewHandle(m)); 461 MethodVerifier verifier(self, m->GetDexFile(), dex_cache, class_loader, &m->GetClassDef(), 462 m->GetCodeItem(), m->GetDexMethodIndex(), method, m->GetAccessFlags(), 463 true, true, false, true); 464 return verifier.FindAccessedFieldAtDexPc(dex_pc); 465} 466 467mirror::ArtField* MethodVerifier::FindAccessedFieldAtDexPc(uint32_t dex_pc) { 468 CHECK(code_item_ != nullptr); // This only makes sense for methods with code. 469 470 // Strictly speaking, we ought to be able to get away with doing a subset of the full method 471 // verification. In practice, the phase we want relies on data structures set up by all the 472 // earlier passes, so we just run the full method verification and bail out early when we've 473 // got what we wanted. 474 bool success = Verify(); 475 if (!success) { 476 return nullptr; 477 } 478 RegisterLine* register_line = reg_table_.GetLine(dex_pc); 479 if (register_line == nullptr) { 480 return nullptr; 481 } 482 const Instruction* inst = Instruction::At(code_item_->insns_ + dex_pc); 483 return GetQuickFieldAccess(inst, register_line); 484} 485 486mirror::ArtMethod* MethodVerifier::FindInvokedMethodAtDexPc(mirror::ArtMethod* m, 487 uint32_t dex_pc) { 488 Thread* self = Thread::Current(); 489 StackHandleScope<3> hs(self); 490 Handle<mirror::DexCache> dex_cache(hs.NewHandle(m->GetDexCache())); 491 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(m->GetClassLoader())); 492 Handle<mirror::ArtMethod> method(hs.NewHandle(m)); 493 MethodVerifier verifier(self, m->GetDexFile(), dex_cache, class_loader, &m->GetClassDef(), 494 m->GetCodeItem(), m->GetDexMethodIndex(), method, m->GetAccessFlags(), 495 true, true, false, true); 496 return verifier.FindInvokedMethodAtDexPc(dex_pc); 497} 498 499mirror::ArtMethod* MethodVerifier::FindInvokedMethodAtDexPc(uint32_t dex_pc) { 500 CHECK(code_item_ != nullptr); // This only makes sense for methods with code. 501 502 // Strictly speaking, we ought to be able to get away with doing a subset of the full method 503 // verification. In practice, the phase we want relies on data structures set up by all the 504 // earlier passes, so we just run the full method verification and bail out early when we've 505 // got what we wanted. 506 bool success = Verify(); 507 if (!success) { 508 return nullptr; 509 } 510 RegisterLine* register_line = reg_table_.GetLine(dex_pc); 511 if (register_line == nullptr) { 512 return nullptr; 513 } 514 const Instruction* inst = Instruction::At(code_item_->insns_ + dex_pc); 515 const bool is_range = (inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE_QUICK); 516 return GetQuickInvokedMethod(inst, register_line, is_range, false); 517} 518 519bool MethodVerifier::Verify() { 520 // If there aren't any instructions, make sure that's expected, then exit successfully. 521 if (code_item_ == nullptr) { 522 if ((method_access_flags_ & (kAccNative | kAccAbstract)) == 0) { 523 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "zero-length code in concrete non-native method"; 524 return false; 525 } else { 526 return true; 527 } 528 } 529 // Sanity-check the register counts. ins + locals = registers, so make sure that ins <= registers. 530 if (code_item_->ins_size_ > code_item_->registers_size_) { 531 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad register counts (ins=" << code_item_->ins_size_ 532 << " regs=" << code_item_->registers_size_; 533 return false; 534 } 535 // Allocate and initialize an array to hold instruction data. 536 insn_flags_.reset(new InstructionFlags[code_item_->insns_size_in_code_units_]()); 537 // Run through the instructions and see if the width checks out. 538 bool result = ComputeWidthsAndCountOps(); 539 // Flag instructions guarded by a "try" block and check exception handlers. 540 result = result && ScanTryCatchBlocks(); 541 // Perform static instruction verification. 542 result = result && VerifyInstructions(); 543 // Perform code-flow analysis and return. 544 result = result && VerifyCodeFlow(); 545 // Compute information for compiler. 546 if (result && Runtime::Current()->IsCompiler()) { 547 result = Runtime::Current()->GetCompilerCallbacks()->MethodVerified(this); 548 } 549 return result; 550} 551 552std::ostream& MethodVerifier::Fail(VerifyError error) { 553 switch (error) { 554 case VERIFY_ERROR_NO_CLASS: 555 case VERIFY_ERROR_NO_FIELD: 556 case VERIFY_ERROR_NO_METHOD: 557 case VERIFY_ERROR_ACCESS_CLASS: 558 case VERIFY_ERROR_ACCESS_FIELD: 559 case VERIFY_ERROR_ACCESS_METHOD: 560 case VERIFY_ERROR_INSTANTIATION: 561 case VERIFY_ERROR_CLASS_CHANGE: 562 if (Runtime::Current()->IsAotCompiler() || !can_load_classes_) { 563 // If we're optimistically running verification at compile time, turn NO_xxx, ACCESS_xxx, 564 // class change and instantiation errors into soft verification errors so that we re-verify 565 // at runtime. We may fail to find or to agree on access because of not yet available class 566 // loaders, or class loaders that will differ at runtime. In these cases, we don't want to 567 // affect the soundness of the code being compiled. Instead, the generated code runs "slow 568 // paths" that dynamically perform the verification and cause the behavior to be that akin 569 // to an interpreter. 570 error = VERIFY_ERROR_BAD_CLASS_SOFT; 571 } else { 572 // If we fail again at runtime, mark that this instruction would throw and force this 573 // method to be executed using the interpreter with checks. 574 have_pending_runtime_throw_failure_ = true; 575 576 // We need to save the work_line if the instruction wasn't throwing before. Otherwise we'll 577 // try to merge garbage. 578 // Note: this assumes that Fail is called before we do any work_line modifications. 579 const uint16_t* insns = code_item_->insns_ + work_insn_idx_; 580 const Instruction* inst = Instruction::At(insns); 581 int opcode_flags = Instruction::FlagsOf(inst->Opcode()); 582 583 if ((opcode_flags & Instruction::kThrow) == 0 && CurrentInsnFlags()->IsInTry()) { 584 saved_line_->CopyFromLine(work_line_.get()); 585 } 586 } 587 break; 588 // Indication that verification should be retried at runtime. 589 case VERIFY_ERROR_BAD_CLASS_SOFT: 590 if (!allow_soft_failures_) { 591 have_pending_hard_failure_ = true; 592 } 593 break; 594 // Hard verification failures at compile time will still fail at runtime, so the class is 595 // marked as rejected to prevent it from being compiled. 596 case VERIFY_ERROR_BAD_CLASS_HARD: { 597 if (Runtime::Current()->IsAotCompiler()) { 598 ClassReference ref(dex_file_, dex_file_->GetIndexForClassDef(*class_def_)); 599 Runtime::Current()->GetCompilerCallbacks()->ClassRejected(ref); 600 } 601 have_pending_hard_failure_ = true; 602 break; 603 } 604 } 605 failures_.push_back(error); 606 std::string location(StringPrintf("%s: [0x%X] ", PrettyMethod(dex_method_idx_, *dex_file_).c_str(), 607 work_insn_idx_)); 608 std::ostringstream* failure_message = new std::ostringstream(location, std::ostringstream::ate); 609 failure_messages_.push_back(failure_message); 610 return *failure_message; 611} 612 613std::ostream& MethodVerifier::LogVerifyInfo() { 614 return info_messages_ << "VFY: " << PrettyMethod(dex_method_idx_, *dex_file_) 615 << '[' << reinterpret_cast<void*>(work_insn_idx_) << "] : "; 616} 617 618void MethodVerifier::PrependToLastFailMessage(std::string prepend) { 619 size_t failure_num = failure_messages_.size(); 620 DCHECK_NE(failure_num, 0U); 621 std::ostringstream* last_fail_message = failure_messages_[failure_num - 1]; 622 prepend += last_fail_message->str(); 623 failure_messages_[failure_num - 1] = new std::ostringstream(prepend, std::ostringstream::ate); 624 delete last_fail_message; 625} 626 627void MethodVerifier::AppendToLastFailMessage(std::string append) { 628 size_t failure_num = failure_messages_.size(); 629 DCHECK_NE(failure_num, 0U); 630 std::ostringstream* last_fail_message = failure_messages_[failure_num - 1]; 631 (*last_fail_message) << append; 632} 633 634bool MethodVerifier::ComputeWidthsAndCountOps() { 635 const uint16_t* insns = code_item_->insns_; 636 size_t insns_size = code_item_->insns_size_in_code_units_; 637 const Instruction* inst = Instruction::At(insns); 638 size_t new_instance_count = 0; 639 size_t monitor_enter_count = 0; 640 size_t dex_pc = 0; 641 642 while (dex_pc < insns_size) { 643 Instruction::Code opcode = inst->Opcode(); 644 switch (opcode) { 645 case Instruction::APUT_OBJECT: 646 case Instruction::CHECK_CAST: 647 has_check_casts_ = true; 648 break; 649 case Instruction::INVOKE_VIRTUAL: 650 case Instruction::INVOKE_VIRTUAL_RANGE: 651 case Instruction::INVOKE_INTERFACE: 652 case Instruction::INVOKE_INTERFACE_RANGE: 653 has_virtual_or_interface_invokes_ = true; 654 break; 655 case Instruction::MONITOR_ENTER: 656 monitor_enter_count++; 657 break; 658 case Instruction::NEW_INSTANCE: 659 new_instance_count++; 660 break; 661 default: 662 break; 663 } 664 size_t inst_size = inst->SizeInCodeUnits(); 665 insn_flags_[dex_pc].SetIsOpcode(); 666 dex_pc += inst_size; 667 inst = inst->RelativeAt(inst_size); 668 } 669 670 if (dex_pc != insns_size) { 671 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "code did not end where expected (" 672 << dex_pc << " vs. " << insns_size << ")"; 673 return false; 674 } 675 676 new_instance_count_ = new_instance_count; 677 monitor_enter_count_ = monitor_enter_count; 678 return true; 679} 680 681bool MethodVerifier::ScanTryCatchBlocks() { 682 uint32_t tries_size = code_item_->tries_size_; 683 if (tries_size == 0) { 684 return true; 685 } 686 uint32_t insns_size = code_item_->insns_size_in_code_units_; 687 const DexFile::TryItem* tries = DexFile::GetTryItems(*code_item_, 0); 688 689 for (uint32_t idx = 0; idx < tries_size; idx++) { 690 const DexFile::TryItem* try_item = &tries[idx]; 691 uint32_t start = try_item->start_addr_; 692 uint32_t end = start + try_item->insn_count_; 693 if ((start >= end) || (start >= insns_size) || (end > insns_size)) { 694 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad exception entry: startAddr=" << start 695 << " endAddr=" << end << " (size=" << insns_size << ")"; 696 return false; 697 } 698 if (!insn_flags_[start].IsOpcode()) { 699 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 700 << "'try' block starts inside an instruction (" << start << ")"; 701 return false; 702 } 703 uint32_t dex_pc = start; 704 const Instruction* inst = Instruction::At(code_item_->insns_ + dex_pc); 705 while (dex_pc < end) { 706 insn_flags_[dex_pc].SetInTry(); 707 size_t insn_size = inst->SizeInCodeUnits(); 708 dex_pc += insn_size; 709 inst = inst->RelativeAt(insn_size); 710 } 711 } 712 // Iterate over each of the handlers to verify target addresses. 713 const uint8_t* handlers_ptr = DexFile::GetCatchHandlerData(*code_item_, 0); 714 uint32_t handlers_size = DecodeUnsignedLeb128(&handlers_ptr); 715 ClassLinker* linker = Runtime::Current()->GetClassLinker(); 716 for (uint32_t idx = 0; idx < handlers_size; idx++) { 717 CatchHandlerIterator iterator(handlers_ptr); 718 for (; iterator.HasNext(); iterator.Next()) { 719 uint32_t dex_pc= iterator.GetHandlerAddress(); 720 if (!insn_flags_[dex_pc].IsOpcode()) { 721 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 722 << "exception handler starts at bad address (" << dex_pc << ")"; 723 return false; 724 } 725 if (!CheckNotMoveResult(code_item_->insns_, dex_pc)) { 726 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 727 << "exception handler begins with move-result* (" << dex_pc << ")"; 728 return false; 729 } 730 insn_flags_[dex_pc].SetBranchTarget(); 731 // Ensure exception types are resolved so that they don't need resolution to be delivered, 732 // unresolved exception types will be ignored by exception delivery 733 if (iterator.GetHandlerTypeIndex() != DexFile::kDexNoIndex16) { 734 mirror::Class* exception_type = linker->ResolveType(*dex_file_, 735 iterator.GetHandlerTypeIndex(), 736 dex_cache_, class_loader_); 737 if (exception_type == nullptr) { 738 DCHECK(self_->IsExceptionPending()); 739 self_->ClearException(); 740 } 741 } 742 } 743 handlers_ptr = iterator.EndDataPointer(); 744 } 745 return true; 746} 747 748bool MethodVerifier::VerifyInstructions() { 749 const Instruction* inst = Instruction::At(code_item_->insns_); 750 751 /* Flag the start of the method as a branch target, and a GC point due to stack overflow errors */ 752 insn_flags_[0].SetBranchTarget(); 753 insn_flags_[0].SetCompileTimeInfoPoint(); 754 755 uint32_t insns_size = code_item_->insns_size_in_code_units_; 756 for (uint32_t dex_pc = 0; dex_pc < insns_size;) { 757 if (!VerifyInstruction(inst, dex_pc)) { 758 DCHECK_NE(failures_.size(), 0U); 759 return false; 760 } 761 /* Flag instructions that are garbage collection points */ 762 // All invoke points are marked as "Throw" points already. 763 // We are relying on this to also count all the invokes as interesting. 764 if (inst->IsBranch()) { 765 insn_flags_[dex_pc].SetCompileTimeInfoPoint(); 766 // The compiler also needs safepoints for fall-through to loop heads. 767 // Such a loop head must be a target of a branch. 768 int32_t offset = 0; 769 bool cond, self_ok; 770 bool target_ok = GetBranchOffset(dex_pc, &offset, &cond, &self_ok); 771 DCHECK(target_ok); 772 insn_flags_[dex_pc + offset].SetCompileTimeInfoPoint(); 773 } else if (inst->IsSwitch() || inst->IsThrow()) { 774 insn_flags_[dex_pc].SetCompileTimeInfoPoint(); 775 } else if (inst->IsReturn()) { 776 insn_flags_[dex_pc].SetCompileTimeInfoPointAndReturn(); 777 } 778 dex_pc += inst->SizeInCodeUnits(); 779 inst = inst->Next(); 780 } 781 return true; 782} 783 784bool MethodVerifier::VerifyInstruction(const Instruction* inst, uint32_t code_offset) { 785 bool result = true; 786 switch (inst->GetVerifyTypeArgumentA()) { 787 case Instruction::kVerifyRegA: 788 result = result && CheckRegisterIndex(inst->VRegA()); 789 break; 790 case Instruction::kVerifyRegAWide: 791 result = result && CheckWideRegisterIndex(inst->VRegA()); 792 break; 793 } 794 switch (inst->GetVerifyTypeArgumentB()) { 795 case Instruction::kVerifyRegB: 796 result = result && CheckRegisterIndex(inst->VRegB()); 797 break; 798 case Instruction::kVerifyRegBField: 799 result = result && CheckFieldIndex(inst->VRegB()); 800 break; 801 case Instruction::kVerifyRegBMethod: 802 result = result && CheckMethodIndex(inst->VRegB()); 803 break; 804 case Instruction::kVerifyRegBNewInstance: 805 result = result && CheckNewInstance(inst->VRegB()); 806 break; 807 case Instruction::kVerifyRegBString: 808 result = result && CheckStringIndex(inst->VRegB()); 809 break; 810 case Instruction::kVerifyRegBType: 811 result = result && CheckTypeIndex(inst->VRegB()); 812 break; 813 case Instruction::kVerifyRegBWide: 814 result = result && CheckWideRegisterIndex(inst->VRegB()); 815 break; 816 } 817 switch (inst->GetVerifyTypeArgumentC()) { 818 case Instruction::kVerifyRegC: 819 result = result && CheckRegisterIndex(inst->VRegC()); 820 break; 821 case Instruction::kVerifyRegCField: 822 result = result && CheckFieldIndex(inst->VRegC()); 823 break; 824 case Instruction::kVerifyRegCNewArray: 825 result = result && CheckNewArray(inst->VRegC()); 826 break; 827 case Instruction::kVerifyRegCType: 828 result = result && CheckTypeIndex(inst->VRegC()); 829 break; 830 case Instruction::kVerifyRegCWide: 831 result = result && CheckWideRegisterIndex(inst->VRegC()); 832 break; 833 } 834 switch (inst->GetVerifyExtraFlags()) { 835 case Instruction::kVerifyArrayData: 836 result = result && CheckArrayData(code_offset); 837 break; 838 case Instruction::kVerifyBranchTarget: 839 result = result && CheckBranchTarget(code_offset); 840 break; 841 case Instruction::kVerifySwitchTargets: 842 result = result && CheckSwitchTargets(code_offset); 843 break; 844 case Instruction::kVerifyVarArgNonZero: 845 // Fall-through. 846 case Instruction::kVerifyVarArg: { 847 if (inst->GetVerifyExtraFlags() == Instruction::kVerifyVarArgNonZero && inst->VRegA() <= 0) { 848 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid arg count (" << inst->VRegA() << ") in " 849 "non-range invoke"; 850 return false; 851 } 852 uint32_t args[Instruction::kMaxVarArgRegs]; 853 inst->GetVarArgs(args); 854 result = result && CheckVarArgRegs(inst->VRegA(), args); 855 break; 856 } 857 case Instruction::kVerifyVarArgRangeNonZero: 858 // Fall-through. 859 case Instruction::kVerifyVarArgRange: 860 if (inst->GetVerifyExtraFlags() == Instruction::kVerifyVarArgRangeNonZero && 861 inst->VRegA() <= 0) { 862 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid arg count (" << inst->VRegA() << ") in " 863 "range invoke"; 864 return false; 865 } 866 result = result && CheckVarArgRangeRegs(inst->VRegA(), inst->VRegC()); 867 break; 868 case Instruction::kVerifyError: 869 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected opcode " << inst->Name(); 870 result = false; 871 break; 872 } 873 if (inst->GetVerifyIsRuntimeOnly() && Runtime::Current()->IsAotCompiler() && !verify_to_dump_) { 874 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "opcode only expected at runtime " << inst->Name(); 875 result = false; 876 } 877 return result; 878} 879 880inline bool MethodVerifier::CheckRegisterIndex(uint32_t idx) { 881 if (idx >= code_item_->registers_size_) { 882 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "register index out of range (" << idx << " >= " 883 << code_item_->registers_size_ << ")"; 884 return false; 885 } 886 return true; 887} 888 889inline bool MethodVerifier::CheckWideRegisterIndex(uint32_t idx) { 890 if (idx + 1 >= code_item_->registers_size_) { 891 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "wide register index out of range (" << idx 892 << "+1 >= " << code_item_->registers_size_ << ")"; 893 return false; 894 } 895 return true; 896} 897 898inline bool MethodVerifier::CheckFieldIndex(uint32_t idx) { 899 if (idx >= dex_file_->GetHeader().field_ids_size_) { 900 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad field index " << idx << " (max " 901 << dex_file_->GetHeader().field_ids_size_ << ")"; 902 return false; 903 } 904 return true; 905} 906 907inline bool MethodVerifier::CheckMethodIndex(uint32_t idx) { 908 if (idx >= dex_file_->GetHeader().method_ids_size_) { 909 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad method index " << idx << " (max " 910 << dex_file_->GetHeader().method_ids_size_ << ")"; 911 return false; 912 } 913 return true; 914} 915 916inline bool MethodVerifier::CheckNewInstance(uint32_t idx) { 917 if (idx >= dex_file_->GetHeader().type_ids_size_) { 918 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad type index " << idx << " (max " 919 << dex_file_->GetHeader().type_ids_size_ << ")"; 920 return false; 921 } 922 // We don't need the actual class, just a pointer to the class name. 923 const char* descriptor = dex_file_->StringByTypeIdx(idx); 924 if (descriptor[0] != 'L') { 925 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "can't call new-instance on type '" << descriptor << "'"; 926 return false; 927 } 928 return true; 929} 930 931inline bool MethodVerifier::CheckStringIndex(uint32_t idx) { 932 if (idx >= dex_file_->GetHeader().string_ids_size_) { 933 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad string index " << idx << " (max " 934 << dex_file_->GetHeader().string_ids_size_ << ")"; 935 return false; 936 } 937 return true; 938} 939 940inline bool MethodVerifier::CheckTypeIndex(uint32_t idx) { 941 if (idx >= dex_file_->GetHeader().type_ids_size_) { 942 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad type index " << idx << " (max " 943 << dex_file_->GetHeader().type_ids_size_ << ")"; 944 return false; 945 } 946 return true; 947} 948 949bool MethodVerifier::CheckNewArray(uint32_t idx) { 950 if (idx >= dex_file_->GetHeader().type_ids_size_) { 951 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad type index " << idx << " (max " 952 << dex_file_->GetHeader().type_ids_size_ << ")"; 953 return false; 954 } 955 int bracket_count = 0; 956 const char* descriptor = dex_file_->StringByTypeIdx(idx); 957 const char* cp = descriptor; 958 while (*cp++ == '[') { 959 bracket_count++; 960 } 961 if (bracket_count == 0) { 962 /* The given class must be an array type. */ 963 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 964 << "can't new-array class '" << descriptor << "' (not an array)"; 965 return false; 966 } else if (bracket_count > 255) { 967 /* It is illegal to create an array of more than 255 dimensions. */ 968 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 969 << "can't new-array class '" << descriptor << "' (exceeds limit)"; 970 return false; 971 } 972 return true; 973} 974 975bool MethodVerifier::CheckArrayData(uint32_t cur_offset) { 976 const uint32_t insn_count = code_item_->insns_size_in_code_units_; 977 const uint16_t* insns = code_item_->insns_ + cur_offset; 978 const uint16_t* array_data; 979 int32_t array_data_offset; 980 981 DCHECK_LT(cur_offset, insn_count); 982 /* make sure the start of the array data table is in range */ 983 array_data_offset = insns[1] | (((int32_t) insns[2]) << 16); 984 if ((int32_t) cur_offset + array_data_offset < 0 || 985 cur_offset + array_data_offset + 2 >= insn_count) { 986 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid array data start: at " << cur_offset 987 << ", data offset " << array_data_offset 988 << ", count " << insn_count; 989 return false; 990 } 991 /* offset to array data table is a relative branch-style offset */ 992 array_data = insns + array_data_offset; 993 /* make sure the table is 32-bit aligned */ 994 if ((reinterpret_cast<uintptr_t>(array_data) & 0x03) != 0) { 995 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unaligned array data table: at " << cur_offset 996 << ", data offset " << array_data_offset; 997 return false; 998 } 999 uint32_t value_width = array_data[1]; 1000 uint32_t value_count = *reinterpret_cast<const uint32_t*>(&array_data[2]); 1001 uint32_t table_size = 4 + (value_width * value_count + 1) / 2; 1002 /* make sure the end of the switch is in range */ 1003 if (cur_offset + array_data_offset + table_size > insn_count) { 1004 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid array data end: at " << cur_offset 1005 << ", data offset " << array_data_offset << ", end " 1006 << cur_offset + array_data_offset + table_size 1007 << ", count " << insn_count; 1008 return false; 1009 } 1010 return true; 1011} 1012 1013bool MethodVerifier::CheckBranchTarget(uint32_t cur_offset) { 1014 int32_t offset; 1015 bool isConditional, selfOkay; 1016 if (!GetBranchOffset(cur_offset, &offset, &isConditional, &selfOkay)) { 1017 return false; 1018 } 1019 if (!selfOkay && offset == 0) { 1020 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "branch offset of zero not allowed at" 1021 << reinterpret_cast<void*>(cur_offset); 1022 return false; 1023 } 1024 // Check for 32-bit overflow. This isn't strictly necessary if we can depend on the runtime 1025 // to have identical "wrap-around" behavior, but it's unwise to depend on that. 1026 if (((int64_t) cur_offset + (int64_t) offset) != (int64_t) (cur_offset + offset)) { 1027 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "branch target overflow " 1028 << reinterpret_cast<void*>(cur_offset) << " +" << offset; 1029 return false; 1030 } 1031 const uint32_t insn_count = code_item_->insns_size_in_code_units_; 1032 int32_t abs_offset = cur_offset + offset; 1033 if (abs_offset < 0 || 1034 (uint32_t) abs_offset >= insn_count || 1035 !insn_flags_[abs_offset].IsOpcode()) { 1036 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid branch target " << offset << " (-> " 1037 << reinterpret_cast<void*>(abs_offset) << ") at " 1038 << reinterpret_cast<void*>(cur_offset); 1039 return false; 1040 } 1041 insn_flags_[abs_offset].SetBranchTarget(); 1042 return true; 1043} 1044 1045bool MethodVerifier::GetBranchOffset(uint32_t cur_offset, int32_t* pOffset, bool* pConditional, 1046 bool* selfOkay) { 1047 const uint16_t* insns = code_item_->insns_ + cur_offset; 1048 *pConditional = false; 1049 *selfOkay = false; 1050 switch (*insns & 0xff) { 1051 case Instruction::GOTO: 1052 *pOffset = ((int16_t) *insns) >> 8; 1053 break; 1054 case Instruction::GOTO_32: 1055 *pOffset = insns[1] | (((uint32_t) insns[2]) << 16); 1056 *selfOkay = true; 1057 break; 1058 case Instruction::GOTO_16: 1059 *pOffset = (int16_t) insns[1]; 1060 break; 1061 case Instruction::IF_EQ: 1062 case Instruction::IF_NE: 1063 case Instruction::IF_LT: 1064 case Instruction::IF_GE: 1065 case Instruction::IF_GT: 1066 case Instruction::IF_LE: 1067 case Instruction::IF_EQZ: 1068 case Instruction::IF_NEZ: 1069 case Instruction::IF_LTZ: 1070 case Instruction::IF_GEZ: 1071 case Instruction::IF_GTZ: 1072 case Instruction::IF_LEZ: 1073 *pOffset = (int16_t) insns[1]; 1074 *pConditional = true; 1075 break; 1076 default: 1077 return false; 1078 break; 1079 } 1080 return true; 1081} 1082 1083bool MethodVerifier::CheckSwitchTargets(uint32_t cur_offset) { 1084 const uint32_t insn_count = code_item_->insns_size_in_code_units_; 1085 DCHECK_LT(cur_offset, insn_count); 1086 const uint16_t* insns = code_item_->insns_ + cur_offset; 1087 /* make sure the start of the switch is in range */ 1088 int32_t switch_offset = insns[1] | ((int32_t) insns[2]) << 16; 1089 if ((int32_t) cur_offset + switch_offset < 0 || cur_offset + switch_offset + 2 > insn_count) { 1090 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid switch start: at " << cur_offset 1091 << ", switch offset " << switch_offset 1092 << ", count " << insn_count; 1093 return false; 1094 } 1095 /* offset to switch table is a relative branch-style offset */ 1096 const uint16_t* switch_insns = insns + switch_offset; 1097 /* make sure the table is 32-bit aligned */ 1098 if ((reinterpret_cast<uintptr_t>(switch_insns) & 0x03) != 0) { 1099 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unaligned switch table: at " << cur_offset 1100 << ", switch offset " << switch_offset; 1101 return false; 1102 } 1103 uint32_t switch_count = switch_insns[1]; 1104 int32_t keys_offset, targets_offset; 1105 uint16_t expected_signature; 1106 if ((*insns & 0xff) == Instruction::PACKED_SWITCH) { 1107 /* 0=sig, 1=count, 2/3=firstKey */ 1108 targets_offset = 4; 1109 keys_offset = -1; 1110 expected_signature = Instruction::kPackedSwitchSignature; 1111 } else { 1112 /* 0=sig, 1=count, 2..count*2 = keys */ 1113 keys_offset = 2; 1114 targets_offset = 2 + 2 * switch_count; 1115 expected_signature = Instruction::kSparseSwitchSignature; 1116 } 1117 uint32_t table_size = targets_offset + switch_count * 2; 1118 if (switch_insns[0] != expected_signature) { 1119 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 1120 << StringPrintf("wrong signature for switch table (%x, wanted %x)", 1121 switch_insns[0], expected_signature); 1122 return false; 1123 } 1124 /* make sure the end of the switch is in range */ 1125 if (cur_offset + switch_offset + table_size > (uint32_t) insn_count) { 1126 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid switch end: at " << cur_offset 1127 << ", switch offset " << switch_offset 1128 << ", end " << (cur_offset + switch_offset + table_size) 1129 << ", count " << insn_count; 1130 return false; 1131 } 1132 /* for a sparse switch, verify the keys are in ascending order */ 1133 if (keys_offset > 0 && switch_count > 1) { 1134 int32_t last_key = switch_insns[keys_offset] | (switch_insns[keys_offset + 1] << 16); 1135 for (uint32_t targ = 1; targ < switch_count; targ++) { 1136 int32_t key = (int32_t) switch_insns[keys_offset + targ * 2] | 1137 (int32_t) (switch_insns[keys_offset + targ * 2 + 1] << 16); 1138 if (key <= last_key) { 1139 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid packed switch: last key=" << last_key 1140 << ", this=" << key; 1141 return false; 1142 } 1143 last_key = key; 1144 } 1145 } 1146 /* verify each switch target */ 1147 for (uint32_t targ = 0; targ < switch_count; targ++) { 1148 int32_t offset = (int32_t) switch_insns[targets_offset + targ * 2] | 1149 (int32_t) (switch_insns[targets_offset + targ * 2 + 1] << 16); 1150 int32_t abs_offset = cur_offset + offset; 1151 if (abs_offset < 0 || 1152 abs_offset >= (int32_t) insn_count || 1153 !insn_flags_[abs_offset].IsOpcode()) { 1154 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid switch target " << offset 1155 << " (-> " << reinterpret_cast<void*>(abs_offset) << ") at " 1156 << reinterpret_cast<void*>(cur_offset) 1157 << "[" << targ << "]"; 1158 return false; 1159 } 1160 insn_flags_[abs_offset].SetBranchTarget(); 1161 } 1162 return true; 1163} 1164 1165bool MethodVerifier::CheckVarArgRegs(uint32_t vA, uint32_t arg[]) { 1166 if (vA > Instruction::kMaxVarArgRegs) { 1167 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid arg count (" << vA << ") in non-range invoke)"; 1168 return false; 1169 } 1170 uint16_t registers_size = code_item_->registers_size_; 1171 for (uint32_t idx = 0; idx < vA; idx++) { 1172 if (arg[idx] >= registers_size) { 1173 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid reg index (" << arg[idx] 1174 << ") in non-range invoke (>= " << registers_size << ")"; 1175 return false; 1176 } 1177 } 1178 1179 return true; 1180} 1181 1182bool MethodVerifier::CheckVarArgRangeRegs(uint32_t vA, uint32_t vC) { 1183 uint16_t registers_size = code_item_->registers_size_; 1184 // vA/vC are unsigned 8-bit/16-bit quantities for /range instructions, so there's no risk of 1185 // integer overflow when adding them here. 1186 if (vA + vC > registers_size) { 1187 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid reg index " << vA << "+" << vC 1188 << " in range invoke (> " << registers_size << ")"; 1189 return false; 1190 } 1191 return true; 1192} 1193 1194bool MethodVerifier::VerifyCodeFlow() { 1195 uint16_t registers_size = code_item_->registers_size_; 1196 uint32_t insns_size = code_item_->insns_size_in_code_units_; 1197 1198 if (registers_size * insns_size > 4*1024*1024) { 1199 LOG(WARNING) << "warning: method is huge (regs=" << registers_size 1200 << " insns_size=" << insns_size << ")"; 1201 } 1202 /* Create and initialize table holding register status */ 1203 reg_table_.Init(kTrackCompilerInterestPoints, 1204 insn_flags_.get(), 1205 insns_size, 1206 registers_size, 1207 this); 1208 1209 1210 work_line_.reset(RegisterLine::Create(registers_size, this)); 1211 saved_line_.reset(RegisterLine::Create(registers_size, this)); 1212 1213 /* Initialize register types of method arguments. */ 1214 if (!SetTypesFromSignature()) { 1215 DCHECK_NE(failures_.size(), 0U); 1216 std::string prepend("Bad signature in "); 1217 prepend += PrettyMethod(dex_method_idx_, *dex_file_); 1218 PrependToLastFailMessage(prepend); 1219 return false; 1220 } 1221 /* Perform code flow verification. */ 1222 if (!CodeFlowVerifyMethod()) { 1223 DCHECK_NE(failures_.size(), 0U); 1224 return false; 1225 } 1226 return true; 1227} 1228 1229std::ostream& MethodVerifier::DumpFailures(std::ostream& os) { 1230 DCHECK_EQ(failures_.size(), failure_messages_.size()); 1231 for (size_t i = 0; i < failures_.size(); ++i) { 1232 os << failure_messages_[i]->str() << "\n"; 1233 } 1234 return os; 1235} 1236 1237void MethodVerifier::Dump(std::ostream& os) { 1238 if (code_item_ == nullptr) { 1239 os << "Native method\n"; 1240 return; 1241 } 1242 { 1243 os << "Register Types:\n"; 1244 Indenter indent_filter(os.rdbuf(), kIndentChar, kIndentBy1Count); 1245 std::ostream indent_os(&indent_filter); 1246 reg_types_.Dump(indent_os); 1247 } 1248 os << "Dumping instructions and register lines:\n"; 1249 Indenter indent_filter(os.rdbuf(), kIndentChar, kIndentBy1Count); 1250 std::ostream indent_os(&indent_filter); 1251 const Instruction* inst = Instruction::At(code_item_->insns_); 1252 for (size_t dex_pc = 0; dex_pc < code_item_->insns_size_in_code_units_; 1253 dex_pc += inst->SizeInCodeUnits()) { 1254 RegisterLine* reg_line = reg_table_.GetLine(dex_pc); 1255 if (reg_line != nullptr) { 1256 indent_os << reg_line->Dump(this) << "\n"; 1257 } 1258 indent_os << StringPrintf("0x%04zx", dex_pc) << ": " << insn_flags_[dex_pc].ToString() << " "; 1259 const bool kDumpHexOfInstruction = false; 1260 if (kDumpHexOfInstruction) { 1261 indent_os << inst->DumpHex(5) << " "; 1262 } 1263 indent_os << inst->DumpString(dex_file_) << "\n"; 1264 inst = inst->Next(); 1265 } 1266} 1267 1268static bool IsPrimitiveDescriptor(char descriptor) { 1269 switch (descriptor) { 1270 case 'I': 1271 case 'C': 1272 case 'S': 1273 case 'B': 1274 case 'Z': 1275 case 'F': 1276 case 'D': 1277 case 'J': 1278 return true; 1279 default: 1280 return false; 1281 } 1282} 1283 1284bool MethodVerifier::SetTypesFromSignature() { 1285 RegisterLine* reg_line = reg_table_.GetLine(0); 1286 int arg_start = code_item_->registers_size_ - code_item_->ins_size_; 1287 size_t expected_args = code_item_->ins_size_; /* long/double count as two */ 1288 1289 DCHECK_GE(arg_start, 0); /* should have been verified earlier */ 1290 // Include the "this" pointer. 1291 size_t cur_arg = 0; 1292 if (!IsStatic()) { 1293 // If this is a constructor for a class other than java.lang.Object, mark the first ("this") 1294 // argument as uninitialized. This restricts field access until the superclass constructor is 1295 // called. 1296 const RegType& declaring_class = GetDeclaringClass(); 1297 if (IsConstructor() && !declaring_class.IsJavaLangObject()) { 1298 reg_line->SetRegisterType(this, arg_start + cur_arg, 1299 reg_types_.UninitializedThisArgument(declaring_class)); 1300 } else { 1301 reg_line->SetRegisterType(this, arg_start + cur_arg, declaring_class); 1302 } 1303 cur_arg++; 1304 } 1305 1306 const DexFile::ProtoId& proto_id = 1307 dex_file_->GetMethodPrototype(dex_file_->GetMethodId(dex_method_idx_)); 1308 DexFileParameterIterator iterator(*dex_file_, proto_id); 1309 1310 for (; iterator.HasNext(); iterator.Next()) { 1311 const char* descriptor = iterator.GetDescriptor(); 1312 if (descriptor == nullptr) { 1313 LOG(FATAL) << "Null descriptor"; 1314 } 1315 if (cur_arg >= expected_args) { 1316 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected " << expected_args 1317 << " args, found more (" << descriptor << ")"; 1318 return false; 1319 } 1320 switch (descriptor[0]) { 1321 case 'L': 1322 case '[': 1323 // We assume that reference arguments are initialized. The only way it could be otherwise 1324 // (assuming the caller was verified) is if the current method is <init>, but in that case 1325 // it's effectively considered initialized the instant we reach here (in the sense that we 1326 // can return without doing anything or call virtual methods). 1327 { 1328 const RegType& reg_type = ResolveClassAndCheckAccess(iterator.GetTypeIdx()); 1329 if (!reg_type.IsNonZeroReferenceTypes()) { 1330 DCHECK(HasFailures()); 1331 return false; 1332 } 1333 reg_line->SetRegisterType(this, arg_start + cur_arg, reg_type); 1334 } 1335 break; 1336 case 'Z': 1337 reg_line->SetRegisterType(this, arg_start + cur_arg, reg_types_.Boolean()); 1338 break; 1339 case 'C': 1340 reg_line->SetRegisterType(this, arg_start + cur_arg, reg_types_.Char()); 1341 break; 1342 case 'B': 1343 reg_line->SetRegisterType(this, arg_start + cur_arg, reg_types_.Byte()); 1344 break; 1345 case 'I': 1346 reg_line->SetRegisterType(this, arg_start + cur_arg, reg_types_.Integer()); 1347 break; 1348 case 'S': 1349 reg_line->SetRegisterType(this, arg_start + cur_arg, reg_types_.Short()); 1350 break; 1351 case 'F': 1352 reg_line->SetRegisterType(this, arg_start + cur_arg, reg_types_.Float()); 1353 break; 1354 case 'J': 1355 case 'D': { 1356 if (cur_arg + 1 >= expected_args) { 1357 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected " << expected_args 1358 << " args, found more (" << descriptor << ")"; 1359 return false; 1360 } 1361 1362 const RegType* lo_half; 1363 const RegType* hi_half; 1364 if (descriptor[0] == 'J') { 1365 lo_half = ®_types_.LongLo(); 1366 hi_half = ®_types_.LongHi(); 1367 } else { 1368 lo_half = ®_types_.DoubleLo(); 1369 hi_half = ®_types_.DoubleHi(); 1370 } 1371 reg_line->SetRegisterTypeWide(this, arg_start + cur_arg, *lo_half, *hi_half); 1372 cur_arg++; 1373 break; 1374 } 1375 default: 1376 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected signature type char '" 1377 << descriptor << "'"; 1378 return false; 1379 } 1380 cur_arg++; 1381 } 1382 if (cur_arg != expected_args) { 1383 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected " << expected_args 1384 << " arguments, found " << cur_arg; 1385 return false; 1386 } 1387 const char* descriptor = dex_file_->GetReturnTypeDescriptor(proto_id); 1388 // Validate return type. We don't do the type lookup; just want to make sure that it has the right 1389 // format. Only major difference from the method argument format is that 'V' is supported. 1390 bool result; 1391 if (IsPrimitiveDescriptor(descriptor[0]) || descriptor[0] == 'V') { 1392 result = descriptor[1] == '\0'; 1393 } else if (descriptor[0] == '[') { // single/multi-dimensional array of object/primitive 1394 size_t i = 0; 1395 do { 1396 i++; 1397 } while (descriptor[i] == '['); // process leading [ 1398 if (descriptor[i] == 'L') { // object array 1399 do { 1400 i++; // find closing ; 1401 } while (descriptor[i] != ';' && descriptor[i] != '\0'); 1402 result = descriptor[i] == ';'; 1403 } else { // primitive array 1404 result = IsPrimitiveDescriptor(descriptor[i]) && descriptor[i + 1] == '\0'; 1405 } 1406 } else if (descriptor[0] == 'L') { 1407 // could be more thorough here, but shouldn't be required 1408 size_t i = 0; 1409 do { 1410 i++; 1411 } while (descriptor[i] != ';' && descriptor[i] != '\0'); 1412 result = descriptor[i] == ';'; 1413 } else { 1414 result = false; 1415 } 1416 if (!result) { 1417 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected char in return type descriptor '" 1418 << descriptor << "'"; 1419 } 1420 return result; 1421} 1422 1423bool MethodVerifier::CodeFlowVerifyMethod() { 1424 const uint16_t* insns = code_item_->insns_; 1425 const uint32_t insns_size = code_item_->insns_size_in_code_units_; 1426 1427 /* Begin by marking the first instruction as "changed". */ 1428 insn_flags_[0].SetChanged(); 1429 uint32_t start_guess = 0; 1430 1431 /* Continue until no instructions are marked "changed". */ 1432 while (true) { 1433 if (allow_thread_suspension_) { 1434 self_->AllowThreadSuspension(); 1435 } 1436 // Find the first marked one. Use "start_guess" as a way to find one quickly. 1437 uint32_t insn_idx = start_guess; 1438 for (; insn_idx < insns_size; insn_idx++) { 1439 if (insn_flags_[insn_idx].IsChanged()) 1440 break; 1441 } 1442 if (insn_idx == insns_size) { 1443 if (start_guess != 0) { 1444 /* try again, starting from the top */ 1445 start_guess = 0; 1446 continue; 1447 } else { 1448 /* all flags are clear */ 1449 break; 1450 } 1451 } 1452 // We carry the working set of registers from instruction to instruction. If this address can 1453 // be the target of a branch (or throw) instruction, or if we're skipping around chasing 1454 // "changed" flags, we need to load the set of registers from the table. 1455 // Because we always prefer to continue on to the next instruction, we should never have a 1456 // situation where we have a stray "changed" flag set on an instruction that isn't a branch 1457 // target. 1458 work_insn_idx_ = insn_idx; 1459 if (insn_flags_[insn_idx].IsBranchTarget()) { 1460 work_line_->CopyFromLine(reg_table_.GetLine(insn_idx)); 1461 } else if (kIsDebugBuild) { 1462 /* 1463 * Sanity check: retrieve the stored register line (assuming 1464 * a full table) and make sure it actually matches. 1465 */ 1466 RegisterLine* register_line = reg_table_.GetLine(insn_idx); 1467 if (register_line != nullptr) { 1468 if (work_line_->CompareLine(register_line) != 0) { 1469 Dump(std::cout); 1470 std::cout << info_messages_.str(); 1471 LOG(FATAL) << "work_line diverged in " << PrettyMethod(dex_method_idx_, *dex_file_) 1472 << "@" << reinterpret_cast<void*>(work_insn_idx_) << "\n" 1473 << " work_line=" << work_line_->Dump(this) << "\n" 1474 << " expected=" << register_line->Dump(this); 1475 } 1476 } 1477 } 1478 if (!CodeFlowVerifyInstruction(&start_guess)) { 1479 std::string prepend(PrettyMethod(dex_method_idx_, *dex_file_)); 1480 prepend += " failed to verify: "; 1481 PrependToLastFailMessage(prepend); 1482 return false; 1483 } 1484 /* Clear "changed" and mark as visited. */ 1485 insn_flags_[insn_idx].SetVisited(); 1486 insn_flags_[insn_idx].ClearChanged(); 1487 } 1488 1489 if (gDebugVerify) { 1490 /* 1491 * Scan for dead code. There's nothing "evil" about dead code 1492 * (besides the wasted space), but it indicates a flaw somewhere 1493 * down the line, possibly in the verifier. 1494 * 1495 * If we've substituted "always throw" instructions into the stream, 1496 * we are almost certainly going to have some dead code. 1497 */ 1498 int dead_start = -1; 1499 uint32_t insn_idx = 0; 1500 for (; insn_idx < insns_size; 1501 insn_idx += Instruction::At(code_item_->insns_ + insn_idx)->SizeInCodeUnits()) { 1502 /* 1503 * Switch-statement data doesn't get "visited" by scanner. It 1504 * may or may not be preceded by a padding NOP (for alignment). 1505 */ 1506 if (insns[insn_idx] == Instruction::kPackedSwitchSignature || 1507 insns[insn_idx] == Instruction::kSparseSwitchSignature || 1508 insns[insn_idx] == Instruction::kArrayDataSignature || 1509 (insns[insn_idx] == Instruction::NOP && (insn_idx + 1 < insns_size) && 1510 (insns[insn_idx + 1] == Instruction::kPackedSwitchSignature || 1511 insns[insn_idx + 1] == Instruction::kSparseSwitchSignature || 1512 insns[insn_idx + 1] == Instruction::kArrayDataSignature))) { 1513 insn_flags_[insn_idx].SetVisited(); 1514 } 1515 1516 if (!insn_flags_[insn_idx].IsVisited()) { 1517 if (dead_start < 0) 1518 dead_start = insn_idx; 1519 } else if (dead_start >= 0) { 1520 LogVerifyInfo() << "dead code " << reinterpret_cast<void*>(dead_start) 1521 << "-" << reinterpret_cast<void*>(insn_idx - 1); 1522 dead_start = -1; 1523 } 1524 } 1525 if (dead_start >= 0) { 1526 LogVerifyInfo() << "dead code " << reinterpret_cast<void*>(dead_start) 1527 << "-" << reinterpret_cast<void*>(insn_idx - 1); 1528 } 1529 // To dump the state of the verify after a method, do something like: 1530 // if (PrettyMethod(dex_method_idx_, *dex_file_) == 1531 // "boolean java.lang.String.equals(java.lang.Object)") { 1532 // LOG(INFO) << info_messages_.str(); 1533 // } 1534 } 1535 return true; 1536} 1537 1538bool MethodVerifier::CodeFlowVerifyInstruction(uint32_t* start_guess) { 1539 // If we're doing FindLocksAtDexPc, check whether we're at the dex pc we care about. 1540 // We want the state _before_ the instruction, for the case where the dex pc we're 1541 // interested in is itself a monitor-enter instruction (which is a likely place 1542 // for a thread to be suspended). 1543 if (monitor_enter_dex_pcs_ != nullptr && work_insn_idx_ == interesting_dex_pc_) { 1544 monitor_enter_dex_pcs_->clear(); // The new work line is more accurate than the previous one. 1545 for (size_t i = 0; i < work_line_->GetMonitorEnterCount(); ++i) { 1546 monitor_enter_dex_pcs_->push_back(work_line_->GetMonitorEnterDexPc(i)); 1547 } 1548 } 1549 1550 /* 1551 * Once we finish decoding the instruction, we need to figure out where 1552 * we can go from here. There are three possible ways to transfer 1553 * control to another statement: 1554 * 1555 * (1) Continue to the next instruction. Applies to all but 1556 * unconditional branches, method returns, and exception throws. 1557 * (2) Branch to one or more possible locations. Applies to branches 1558 * and switch statements. 1559 * (3) Exception handlers. Applies to any instruction that can 1560 * throw an exception that is handled by an encompassing "try" 1561 * block. 1562 * 1563 * We can also return, in which case there is no successor instruction 1564 * from this point. 1565 * 1566 * The behavior can be determined from the opcode flags. 1567 */ 1568 const uint16_t* insns = code_item_->insns_ + work_insn_idx_; 1569 const Instruction* inst = Instruction::At(insns); 1570 int opcode_flags = Instruction::FlagsOf(inst->Opcode()); 1571 1572 int32_t branch_target = 0; 1573 bool just_set_result = false; 1574 if (gDebugVerify) { 1575 // Generate processing back trace to debug verifier 1576 LogVerifyInfo() << "Processing " << inst->DumpString(dex_file_) << "\n" 1577 << work_line_->Dump(this) << "\n"; 1578 } 1579 1580 /* 1581 * Make a copy of the previous register state. If the instruction 1582 * can throw an exception, we will copy/merge this into the "catch" 1583 * address rather than work_line, because we don't want the result 1584 * from the "successful" code path (e.g. a check-cast that "improves" 1585 * a type) to be visible to the exception handler. 1586 */ 1587 if ((opcode_flags & Instruction::kThrow) != 0 && CurrentInsnFlags()->IsInTry()) { 1588 saved_line_->CopyFromLine(work_line_.get()); 1589 } else if (kIsDebugBuild) { 1590 saved_line_->FillWithGarbage(); 1591 } 1592 1593 1594 // We need to ensure the work line is consistent while performing validation. When we spot a 1595 // peephole pattern we compute a new line for either the fallthrough instruction or the 1596 // branch target. 1597 std::unique_ptr<RegisterLine> branch_line; 1598 std::unique_ptr<RegisterLine> fallthrough_line; 1599 1600 /* 1601 * If we are in a constructor, and we currently have an UninitializedThis type 1602 * in a register somewhere, we need to make sure it isn't overwritten. 1603 */ 1604 bool track_uninitialized_this = false; 1605 size_t uninitialized_this_loc = 0; 1606 if (IsConstructor()) { 1607 track_uninitialized_this = work_line_->GetUninitializedThisLoc(this, &uninitialized_this_loc); 1608 } 1609 1610 switch (inst->Opcode()) { 1611 case Instruction::NOP: 1612 /* 1613 * A "pure" NOP has no effect on anything. Data tables start with 1614 * a signature that looks like a NOP; if we see one of these in 1615 * the course of executing code then we have a problem. 1616 */ 1617 if (inst->VRegA_10x() != 0) { 1618 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "encountered data table in instruction stream"; 1619 } 1620 break; 1621 1622 case Instruction::MOVE: 1623 work_line_->CopyRegister1(this, inst->VRegA_12x(), inst->VRegB_12x(), kTypeCategory1nr); 1624 break; 1625 case Instruction::MOVE_FROM16: 1626 work_line_->CopyRegister1(this, inst->VRegA_22x(), inst->VRegB_22x(), kTypeCategory1nr); 1627 break; 1628 case Instruction::MOVE_16: 1629 work_line_->CopyRegister1(this, inst->VRegA_32x(), inst->VRegB_32x(), kTypeCategory1nr); 1630 break; 1631 case Instruction::MOVE_WIDE: 1632 work_line_->CopyRegister2(this, inst->VRegA_12x(), inst->VRegB_12x()); 1633 break; 1634 case Instruction::MOVE_WIDE_FROM16: 1635 work_line_->CopyRegister2(this, inst->VRegA_22x(), inst->VRegB_22x()); 1636 break; 1637 case Instruction::MOVE_WIDE_16: 1638 work_line_->CopyRegister2(this, inst->VRegA_32x(), inst->VRegB_32x()); 1639 break; 1640 case Instruction::MOVE_OBJECT: 1641 work_line_->CopyRegister1(this, inst->VRegA_12x(), inst->VRegB_12x(), kTypeCategoryRef); 1642 break; 1643 case Instruction::MOVE_OBJECT_FROM16: 1644 work_line_->CopyRegister1(this, inst->VRegA_22x(), inst->VRegB_22x(), kTypeCategoryRef); 1645 break; 1646 case Instruction::MOVE_OBJECT_16: 1647 work_line_->CopyRegister1(this, inst->VRegA_32x(), inst->VRegB_32x(), kTypeCategoryRef); 1648 break; 1649 1650 /* 1651 * The move-result instructions copy data out of a "pseudo-register" 1652 * with the results from the last method invocation. In practice we 1653 * might want to hold the result in an actual CPU register, so the 1654 * Dalvik spec requires that these only appear immediately after an 1655 * invoke or filled-new-array. 1656 * 1657 * These calls invalidate the "result" register. (This is now 1658 * redundant with the reset done below, but it can make the debug info 1659 * easier to read in some cases.) 1660 */ 1661 case Instruction::MOVE_RESULT: 1662 work_line_->CopyResultRegister1(this, inst->VRegA_11x(), false); 1663 break; 1664 case Instruction::MOVE_RESULT_WIDE: 1665 work_line_->CopyResultRegister2(this, inst->VRegA_11x()); 1666 break; 1667 case Instruction::MOVE_RESULT_OBJECT: 1668 work_line_->CopyResultRegister1(this, inst->VRegA_11x(), true); 1669 break; 1670 1671 case Instruction::MOVE_EXCEPTION: { 1672 // We do not allow MOVE_EXCEPTION as the first instruction in a method. This is a simple case 1673 // where one entrypoint to the catch block is not actually an exception path. 1674 if (work_insn_idx_ == 0) { 1675 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "move-exception at pc 0x0"; 1676 break; 1677 } 1678 /* 1679 * This statement can only appear as the first instruction in an exception handler. We verify 1680 * that as part of extracting the exception type from the catch block list. 1681 */ 1682 const RegType& res_type = GetCaughtExceptionType(); 1683 work_line_->SetRegisterType(this, inst->VRegA_11x(), res_type); 1684 break; 1685 } 1686 case Instruction::RETURN_VOID: 1687 if (!IsConstructor() || work_line_->CheckConstructorReturn(this)) { 1688 if (!GetMethodReturnType().IsConflict()) { 1689 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "return-void not expected"; 1690 } 1691 } 1692 break; 1693 case Instruction::RETURN: 1694 if (!IsConstructor() || work_line_->CheckConstructorReturn(this)) { 1695 /* check the method signature */ 1696 const RegType& return_type = GetMethodReturnType(); 1697 if (!return_type.IsCategory1Types()) { 1698 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected non-category 1 return type " 1699 << return_type; 1700 } else { 1701 // Compilers may generate synthetic functions that write byte values into boolean fields. 1702 // Also, it may use integer values for boolean, byte, short, and character return types. 1703 const uint32_t vregA = inst->VRegA_11x(); 1704 const RegType& src_type = work_line_->GetRegisterType(this, vregA); 1705 bool use_src = ((return_type.IsBoolean() && src_type.IsByte()) || 1706 ((return_type.IsBoolean() || return_type.IsByte() || 1707 return_type.IsShort() || return_type.IsChar()) && 1708 src_type.IsInteger())); 1709 /* check the register contents */ 1710 bool success = 1711 work_line_->VerifyRegisterType(this, vregA, use_src ? src_type : return_type); 1712 if (!success) { 1713 AppendToLastFailMessage(StringPrintf(" return-1nr on invalid register v%d", vregA)); 1714 } 1715 } 1716 } 1717 break; 1718 case Instruction::RETURN_WIDE: 1719 if (!IsConstructor() || work_line_->CheckConstructorReturn(this)) { 1720 /* check the method signature */ 1721 const RegType& return_type = GetMethodReturnType(); 1722 if (!return_type.IsCategory2Types()) { 1723 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "return-wide not expected"; 1724 } else { 1725 /* check the register contents */ 1726 const uint32_t vregA = inst->VRegA_11x(); 1727 bool success = work_line_->VerifyRegisterType(this, vregA, return_type); 1728 if (!success) { 1729 AppendToLastFailMessage(StringPrintf(" return-wide on invalid register v%d", vregA)); 1730 } 1731 } 1732 } 1733 break; 1734 case Instruction::RETURN_OBJECT: 1735 if (!IsConstructor() || work_line_->CheckConstructorReturn(this)) { 1736 const RegType& return_type = GetMethodReturnType(); 1737 if (!return_type.IsReferenceTypes()) { 1738 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "return-object not expected"; 1739 } else { 1740 /* return_type is the *expected* return type, not register value */ 1741 DCHECK(!return_type.IsZero()); 1742 DCHECK(!return_type.IsUninitializedReference()); 1743 const uint32_t vregA = inst->VRegA_11x(); 1744 const RegType& reg_type = work_line_->GetRegisterType(this, vregA); 1745 // Disallow returning uninitialized values and verify that the reference in vAA is an 1746 // instance of the "return_type" 1747 if (reg_type.IsUninitializedTypes()) { 1748 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "returning uninitialized object '" 1749 << reg_type << "'"; 1750 } else if (!return_type.IsAssignableFrom(reg_type)) { 1751 if (reg_type.IsUnresolvedTypes() || return_type.IsUnresolvedTypes()) { 1752 Fail(VERIFY_ERROR_NO_CLASS) << " can't resolve returned type '" << return_type 1753 << "' or '" << reg_type << "'"; 1754 } else { 1755 bool soft_error = false; 1756 // Check whether arrays are involved. They will show a valid class status, even 1757 // if their components are erroneous. 1758 if (reg_type.IsArrayTypes() && return_type.IsArrayTypes()) { 1759 return_type.CanAssignArray(reg_type, reg_types_, class_loader_, &soft_error); 1760 if (soft_error) { 1761 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "array with erroneous component type: " 1762 << reg_type << " vs " << return_type; 1763 } 1764 } 1765 1766 if (!soft_error) { 1767 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "returning '" << reg_type 1768 << "', but expected from declaration '" << return_type << "'"; 1769 } 1770 } 1771 } 1772 } 1773 } 1774 break; 1775 1776 /* could be boolean, int, float, or a null reference */ 1777 case Instruction::CONST_4: { 1778 int32_t val = static_cast<int32_t>(inst->VRegB_11n() << 28) >> 28; 1779 work_line_->SetRegisterType(this, inst->VRegA_11n(), 1780 DetermineCat1Constant(val, need_precise_constants_)); 1781 break; 1782 } 1783 case Instruction::CONST_16: { 1784 int16_t val = static_cast<int16_t>(inst->VRegB_21s()); 1785 work_line_->SetRegisterType(this, inst->VRegA_21s(), 1786 DetermineCat1Constant(val, need_precise_constants_)); 1787 break; 1788 } 1789 case Instruction::CONST: { 1790 int32_t val = inst->VRegB_31i(); 1791 work_line_->SetRegisterType(this, inst->VRegA_31i(), 1792 DetermineCat1Constant(val, need_precise_constants_)); 1793 break; 1794 } 1795 case Instruction::CONST_HIGH16: { 1796 int32_t val = static_cast<int32_t>(inst->VRegB_21h() << 16); 1797 work_line_->SetRegisterType(this, inst->VRegA_21h(), 1798 DetermineCat1Constant(val, need_precise_constants_)); 1799 break; 1800 } 1801 /* could be long or double; resolved upon use */ 1802 case Instruction::CONST_WIDE_16: { 1803 int64_t val = static_cast<int16_t>(inst->VRegB_21s()); 1804 const RegType& lo = reg_types_.FromCat2ConstLo(static_cast<int32_t>(val), true); 1805 const RegType& hi = reg_types_.FromCat2ConstHi(static_cast<int32_t>(val >> 32), true); 1806 work_line_->SetRegisterTypeWide(this, inst->VRegA_21s(), lo, hi); 1807 break; 1808 } 1809 case Instruction::CONST_WIDE_32: { 1810 int64_t val = static_cast<int32_t>(inst->VRegB_31i()); 1811 const RegType& lo = reg_types_.FromCat2ConstLo(static_cast<int32_t>(val), true); 1812 const RegType& hi = reg_types_.FromCat2ConstHi(static_cast<int32_t>(val >> 32), true); 1813 work_line_->SetRegisterTypeWide(this, inst->VRegA_31i(), lo, hi); 1814 break; 1815 } 1816 case Instruction::CONST_WIDE: { 1817 int64_t val = inst->VRegB_51l(); 1818 const RegType& lo = reg_types_.FromCat2ConstLo(static_cast<int32_t>(val), true); 1819 const RegType& hi = reg_types_.FromCat2ConstHi(static_cast<int32_t>(val >> 32), true); 1820 work_line_->SetRegisterTypeWide(this, inst->VRegA_51l(), lo, hi); 1821 break; 1822 } 1823 case Instruction::CONST_WIDE_HIGH16: { 1824 int64_t val = static_cast<uint64_t>(inst->VRegB_21h()) << 48; 1825 const RegType& lo = reg_types_.FromCat2ConstLo(static_cast<int32_t>(val), true); 1826 const RegType& hi = reg_types_.FromCat2ConstHi(static_cast<int32_t>(val >> 32), true); 1827 work_line_->SetRegisterTypeWide(this, inst->VRegA_21h(), lo, hi); 1828 break; 1829 } 1830 case Instruction::CONST_STRING: 1831 work_line_->SetRegisterType(this, inst->VRegA_21c(), reg_types_.JavaLangString()); 1832 break; 1833 case Instruction::CONST_STRING_JUMBO: 1834 work_line_->SetRegisterType(this, inst->VRegA_31c(), reg_types_.JavaLangString()); 1835 break; 1836 case Instruction::CONST_CLASS: { 1837 // Get type from instruction if unresolved then we need an access check 1838 // TODO: check Compiler::CanAccessTypeWithoutChecks returns false when res_type is unresolved 1839 const RegType& res_type = ResolveClassAndCheckAccess(inst->VRegB_21c()); 1840 // Register holds class, ie its type is class, on error it will hold Conflict. 1841 work_line_->SetRegisterType(this, inst->VRegA_21c(), 1842 res_type.IsConflict() ? res_type 1843 : reg_types_.JavaLangClass()); 1844 break; 1845 } 1846 case Instruction::MONITOR_ENTER: 1847 work_line_->PushMonitor(this, inst->VRegA_11x(), work_insn_idx_); 1848 break; 1849 case Instruction::MONITOR_EXIT: 1850 /* 1851 * monitor-exit instructions are odd. They can throw exceptions, 1852 * but when they do they act as if they succeeded and the PC is 1853 * pointing to the following instruction. (This behavior goes back 1854 * to the need to handle asynchronous exceptions, a now-deprecated 1855 * feature that Dalvik doesn't support.) 1856 * 1857 * In practice we don't need to worry about this. The only 1858 * exceptions that can be thrown from monitor-exit are for a 1859 * null reference and -exit without a matching -enter. If the 1860 * structured locking checks are working, the former would have 1861 * failed on the -enter instruction, and the latter is impossible. 1862 * 1863 * This is fortunate, because issue 3221411 prevents us from 1864 * chasing the "can throw" path when monitor verification is 1865 * enabled. If we can fully verify the locking we can ignore 1866 * some catch blocks (which will show up as "dead" code when 1867 * we skip them here); if we can't, then the code path could be 1868 * "live" so we still need to check it. 1869 */ 1870 opcode_flags &= ~Instruction::kThrow; 1871 work_line_->PopMonitor(this, inst->VRegA_11x()); 1872 break; 1873 1874 case Instruction::CHECK_CAST: 1875 case Instruction::INSTANCE_OF: { 1876 /* 1877 * If this instruction succeeds, we will "downcast" register vA to the type in vB. (This 1878 * could be a "upcast" -- not expected, so we don't try to address it.) 1879 * 1880 * If it fails, an exception is thrown, which we deal with later by ignoring the update to 1881 * dec_insn.vA when branching to a handler. 1882 */ 1883 const bool is_checkcast = (inst->Opcode() == Instruction::CHECK_CAST); 1884 const uint32_t type_idx = (is_checkcast) ? inst->VRegB_21c() : inst->VRegC_22c(); 1885 const RegType& res_type = ResolveClassAndCheckAccess(type_idx); 1886 if (res_type.IsConflict()) { 1887 // If this is a primitive type, fail HARD. 1888 mirror::Class* klass = dex_cache_->GetResolvedType(type_idx); 1889 if (klass != nullptr && klass->IsPrimitive()) { 1890 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "using primitive type " 1891 << dex_file_->StringByTypeIdx(type_idx) << " in instanceof in " 1892 << GetDeclaringClass(); 1893 break; 1894 } 1895 1896 DCHECK_NE(failures_.size(), 0U); 1897 if (!is_checkcast) { 1898 work_line_->SetRegisterType(this, inst->VRegA_22c(), reg_types_.Boolean()); 1899 } 1900 break; // bad class 1901 } 1902 // TODO: check Compiler::CanAccessTypeWithoutChecks returns false when res_type is unresolved 1903 uint32_t orig_type_reg = (is_checkcast) ? inst->VRegA_21c() : inst->VRegB_22c(); 1904 const RegType& orig_type = work_line_->GetRegisterType(this, orig_type_reg); 1905 if (!res_type.IsNonZeroReferenceTypes()) { 1906 if (is_checkcast) { 1907 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "check-cast on unexpected class " << res_type; 1908 } else { 1909 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "instance-of on unexpected class " << res_type; 1910 } 1911 } else if (!orig_type.IsReferenceTypes()) { 1912 if (is_checkcast) { 1913 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "check-cast on non-reference in v" << orig_type_reg; 1914 } else { 1915 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "instance-of on non-reference in v" << orig_type_reg; 1916 } 1917 } else { 1918 if (is_checkcast) { 1919 work_line_->SetRegisterType(this, inst->VRegA_21c(), res_type); 1920 } else { 1921 work_line_->SetRegisterType(this, inst->VRegA_22c(), reg_types_.Boolean()); 1922 } 1923 } 1924 break; 1925 } 1926 case Instruction::ARRAY_LENGTH: { 1927 const RegType& res_type = work_line_->GetRegisterType(this, inst->VRegB_12x()); 1928 if (res_type.IsReferenceTypes()) { 1929 if (!res_type.IsArrayTypes() && !res_type.IsZero()) { // ie not an array or null 1930 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "array-length on non-array " << res_type; 1931 } else { 1932 work_line_->SetRegisterType(this, inst->VRegA_12x(), reg_types_.Integer()); 1933 } 1934 } else { 1935 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "array-length on non-array " << res_type; 1936 } 1937 break; 1938 } 1939 case Instruction::NEW_INSTANCE: { 1940 const RegType& res_type = ResolveClassAndCheckAccess(inst->VRegB_21c()); 1941 if (res_type.IsConflict()) { 1942 DCHECK_NE(failures_.size(), 0U); 1943 break; // bad class 1944 } 1945 // TODO: check Compiler::CanAccessTypeWithoutChecks returns false when res_type is unresolved 1946 // can't create an instance of an interface or abstract class */ 1947 if (!res_type.IsInstantiableTypes()) { 1948 Fail(VERIFY_ERROR_INSTANTIATION) 1949 << "new-instance on primitive, interface or abstract class" << res_type; 1950 // Soft failure so carry on to set register type. 1951 } 1952 const RegType& uninit_type = reg_types_.Uninitialized(res_type, work_insn_idx_); 1953 // Any registers holding previous allocations from this address that have not yet been 1954 // initialized must be marked invalid. 1955 work_line_->MarkUninitRefsAsInvalid(this, uninit_type); 1956 // add the new uninitialized reference to the register state 1957 work_line_->SetRegisterType(this, inst->VRegA_21c(), uninit_type); 1958 break; 1959 } 1960 case Instruction::NEW_ARRAY: 1961 VerifyNewArray(inst, false, false); 1962 break; 1963 case Instruction::FILLED_NEW_ARRAY: 1964 VerifyNewArray(inst, true, false); 1965 just_set_result = true; // Filled new array sets result register 1966 break; 1967 case Instruction::FILLED_NEW_ARRAY_RANGE: 1968 VerifyNewArray(inst, true, true); 1969 just_set_result = true; // Filled new array range sets result register 1970 break; 1971 case Instruction::CMPL_FLOAT: 1972 case Instruction::CMPG_FLOAT: 1973 if (!work_line_->VerifyRegisterType(this, inst->VRegB_23x(), reg_types_.Float())) { 1974 break; 1975 } 1976 if (!work_line_->VerifyRegisterType(this, inst->VRegC_23x(), reg_types_.Float())) { 1977 break; 1978 } 1979 work_line_->SetRegisterType(this, inst->VRegA_23x(), reg_types_.Integer()); 1980 break; 1981 case Instruction::CMPL_DOUBLE: 1982 case Instruction::CMPG_DOUBLE: 1983 if (!work_line_->VerifyRegisterTypeWide(this, inst->VRegB_23x(), reg_types_.DoubleLo(), 1984 reg_types_.DoubleHi())) { 1985 break; 1986 } 1987 if (!work_line_->VerifyRegisterTypeWide(this, inst->VRegC_23x(), reg_types_.DoubleLo(), 1988 reg_types_.DoubleHi())) { 1989 break; 1990 } 1991 work_line_->SetRegisterType(this, inst->VRegA_23x(), reg_types_.Integer()); 1992 break; 1993 case Instruction::CMP_LONG: 1994 if (!work_line_->VerifyRegisterTypeWide(this, inst->VRegB_23x(), reg_types_.LongLo(), 1995 reg_types_.LongHi())) { 1996 break; 1997 } 1998 if (!work_line_->VerifyRegisterTypeWide(this, inst->VRegC_23x(), reg_types_.LongLo(), 1999 reg_types_.LongHi())) { 2000 break; 2001 } 2002 work_line_->SetRegisterType(this, inst->VRegA_23x(), reg_types_.Integer()); 2003 break; 2004 case Instruction::THROW: { 2005 const RegType& res_type = work_line_->GetRegisterType(this, inst->VRegA_11x()); 2006 if (!reg_types_.JavaLangThrowable(false).IsAssignableFrom(res_type)) { 2007 Fail(res_type.IsUnresolvedTypes() ? VERIFY_ERROR_NO_CLASS : VERIFY_ERROR_BAD_CLASS_SOFT) 2008 << "thrown class " << res_type << " not instanceof Throwable"; 2009 } 2010 break; 2011 } 2012 case Instruction::GOTO: 2013 case Instruction::GOTO_16: 2014 case Instruction::GOTO_32: 2015 /* no effect on or use of registers */ 2016 break; 2017 2018 case Instruction::PACKED_SWITCH: 2019 case Instruction::SPARSE_SWITCH: 2020 /* verify that vAA is an integer, or can be converted to one */ 2021 work_line_->VerifyRegisterType(this, inst->VRegA_31t(), reg_types_.Integer()); 2022 break; 2023 2024 case Instruction::FILL_ARRAY_DATA: { 2025 /* Similar to the verification done for APUT */ 2026 const RegType& array_type = work_line_->GetRegisterType(this, inst->VRegA_31t()); 2027 /* array_type can be null if the reg type is Zero */ 2028 if (!array_type.IsZero()) { 2029 if (!array_type.IsArrayTypes()) { 2030 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid fill-array-data with array type " 2031 << array_type; 2032 } else { 2033 const RegType& component_type = reg_types_.GetComponentType(array_type, GetClassLoader()); 2034 DCHECK(!component_type.IsConflict()); 2035 if (component_type.IsNonZeroReferenceTypes()) { 2036 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid fill-array-data with component type " 2037 << component_type; 2038 } else { 2039 // Now verify if the element width in the table matches the element width declared in 2040 // the array 2041 const uint16_t* array_data = insns + (insns[1] | (((int32_t) insns[2]) << 16)); 2042 if (array_data[0] != Instruction::kArrayDataSignature) { 2043 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid magic for array-data"; 2044 } else { 2045 size_t elem_width = Primitive::ComponentSize(component_type.GetPrimitiveType()); 2046 // Since we don't compress the data in Dex, expect to see equal width of data stored 2047 // in the table and expected from the array class. 2048 if (array_data[1] != elem_width) { 2049 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "array-data size mismatch (" << array_data[1] 2050 << " vs " << elem_width << ")"; 2051 } 2052 } 2053 } 2054 } 2055 } 2056 break; 2057 } 2058 case Instruction::IF_EQ: 2059 case Instruction::IF_NE: { 2060 const RegType& reg_type1 = work_line_->GetRegisterType(this, inst->VRegA_22t()); 2061 const RegType& reg_type2 = work_line_->GetRegisterType(this, inst->VRegB_22t()); 2062 bool mismatch = false; 2063 if (reg_type1.IsZero()) { // zero then integral or reference expected 2064 mismatch = !reg_type2.IsReferenceTypes() && !reg_type2.IsIntegralTypes(); 2065 } else if (reg_type1.IsReferenceTypes()) { // both references? 2066 mismatch = !reg_type2.IsReferenceTypes(); 2067 } else { // both integral? 2068 mismatch = !reg_type1.IsIntegralTypes() || !reg_type2.IsIntegralTypes(); 2069 } 2070 if (mismatch) { 2071 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "args to if-eq/if-ne (" << reg_type1 << "," 2072 << reg_type2 << ") must both be references or integral"; 2073 } 2074 break; 2075 } 2076 case Instruction::IF_LT: 2077 case Instruction::IF_GE: 2078 case Instruction::IF_GT: 2079 case Instruction::IF_LE: { 2080 const RegType& reg_type1 = work_line_->GetRegisterType(this, inst->VRegA_22t()); 2081 const RegType& reg_type2 = work_line_->GetRegisterType(this, inst->VRegB_22t()); 2082 if (!reg_type1.IsIntegralTypes() || !reg_type2.IsIntegralTypes()) { 2083 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "args to 'if' (" << reg_type1 << "," 2084 << reg_type2 << ") must be integral"; 2085 } 2086 break; 2087 } 2088 case Instruction::IF_EQZ: 2089 case Instruction::IF_NEZ: { 2090 const RegType& reg_type = work_line_->GetRegisterType(this, inst->VRegA_21t()); 2091 if (!reg_type.IsReferenceTypes() && !reg_type.IsIntegralTypes()) { 2092 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "type " << reg_type 2093 << " unexpected as arg to if-eqz/if-nez"; 2094 } 2095 2096 // Find previous instruction - its existence is a precondition to peephole optimization. 2097 uint32_t instance_of_idx = 0; 2098 if (0 != work_insn_idx_) { 2099 instance_of_idx = work_insn_idx_ - 1; 2100 while (0 != instance_of_idx && !insn_flags_[instance_of_idx].IsOpcode()) { 2101 instance_of_idx--; 2102 } 2103 if (FailOrAbort(this, insn_flags_[instance_of_idx].IsOpcode(), 2104 "Unable to get previous instruction of if-eqz/if-nez for work index ", 2105 work_insn_idx_)) { 2106 break; 2107 } 2108 } else { 2109 break; 2110 } 2111 2112 const Instruction* instance_of_inst = Instruction::At(code_item_->insns_ + instance_of_idx); 2113 2114 /* Check for peep-hole pattern of: 2115 * ...; 2116 * instance-of vX, vY, T; 2117 * ifXXX vX, label ; 2118 * ...; 2119 * label: 2120 * ...; 2121 * and sharpen the type of vY to be type T. 2122 * Note, this pattern can't be if: 2123 * - if there are other branches to this branch, 2124 * - when vX == vY. 2125 */ 2126 if (!CurrentInsnFlags()->IsBranchTarget() && 2127 (Instruction::INSTANCE_OF == instance_of_inst->Opcode()) && 2128 (inst->VRegA_21t() == instance_of_inst->VRegA_22c()) && 2129 (instance_of_inst->VRegA_22c() != instance_of_inst->VRegB_22c())) { 2130 // Check the type of the instance-of is different than that of registers type, as if they 2131 // are the same there is no work to be done here. Check that the conversion is not to or 2132 // from an unresolved type as type information is imprecise. If the instance-of is to an 2133 // interface then ignore the type information as interfaces can only be treated as Objects 2134 // and we don't want to disallow field and other operations on the object. If the value 2135 // being instance-of checked against is known null (zero) then allow the optimization as 2136 // we didn't have type information. If the merge of the instance-of type with the original 2137 // type is assignable to the original then allow optimization. This check is performed to 2138 // ensure that subsequent merges don't lose type information - such as becoming an 2139 // interface from a class that would lose information relevant to field checks. 2140 const RegType& orig_type = work_line_->GetRegisterType(this, instance_of_inst->VRegB_22c()); 2141 const RegType& cast_type = ResolveClassAndCheckAccess(instance_of_inst->VRegC_22c()); 2142 2143 if (!orig_type.Equals(cast_type) && 2144 !cast_type.IsUnresolvedTypes() && !orig_type.IsUnresolvedTypes() && 2145 cast_type.HasClass() && // Could be conflict type, make sure it has a class. 2146 !cast_type.GetClass()->IsInterface() && 2147 (orig_type.IsZero() || 2148 orig_type.IsStrictlyAssignableFrom(cast_type.Merge(orig_type, ®_types_)))) { 2149 RegisterLine* update_line = RegisterLine::Create(code_item_->registers_size_, this); 2150 if (inst->Opcode() == Instruction::IF_EQZ) { 2151 fallthrough_line.reset(update_line); 2152 } else { 2153 branch_line.reset(update_line); 2154 } 2155 update_line->CopyFromLine(work_line_.get()); 2156 update_line->SetRegisterType(this, instance_of_inst->VRegB_22c(), cast_type); 2157 if (!insn_flags_[instance_of_idx].IsBranchTarget() && 0 != instance_of_idx) { 2158 // See if instance-of was preceded by a move-object operation, common due to the small 2159 // register encoding space of instance-of, and propagate type information to the source 2160 // of the move-object. 2161 uint32_t move_idx = instance_of_idx - 1; 2162 while (0 != move_idx && !insn_flags_[move_idx].IsOpcode()) { 2163 move_idx--; 2164 } 2165 if (FailOrAbort(this, insn_flags_[move_idx].IsOpcode(), 2166 "Unable to get previous instruction of if-eqz/if-nez for work index ", 2167 work_insn_idx_)) { 2168 break; 2169 } 2170 const Instruction* move_inst = Instruction::At(code_item_->insns_ + move_idx); 2171 switch (move_inst->Opcode()) { 2172 case Instruction::MOVE_OBJECT: 2173 if (move_inst->VRegA_12x() == instance_of_inst->VRegB_22c()) { 2174 update_line->SetRegisterType(this, move_inst->VRegB_12x(), cast_type); 2175 } 2176 break; 2177 case Instruction::MOVE_OBJECT_FROM16: 2178 if (move_inst->VRegA_22x() == instance_of_inst->VRegB_22c()) { 2179 update_line->SetRegisterType(this, move_inst->VRegB_22x(), cast_type); 2180 } 2181 break; 2182 case Instruction::MOVE_OBJECT_16: 2183 if (move_inst->VRegA_32x() == instance_of_inst->VRegB_22c()) { 2184 update_line->SetRegisterType(this, move_inst->VRegB_32x(), cast_type); 2185 } 2186 break; 2187 default: 2188 break; 2189 } 2190 } 2191 } 2192 } 2193 2194 break; 2195 } 2196 case Instruction::IF_LTZ: 2197 case Instruction::IF_GEZ: 2198 case Instruction::IF_GTZ: 2199 case Instruction::IF_LEZ: { 2200 const RegType& reg_type = work_line_->GetRegisterType(this, inst->VRegA_21t()); 2201 if (!reg_type.IsIntegralTypes()) { 2202 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "type " << reg_type 2203 << " unexpected as arg to if-ltz/if-gez/if-gtz/if-lez"; 2204 } 2205 break; 2206 } 2207 case Instruction::AGET_BOOLEAN: 2208 VerifyAGet(inst, reg_types_.Boolean(), true); 2209 break; 2210 case Instruction::AGET_BYTE: 2211 VerifyAGet(inst, reg_types_.Byte(), true); 2212 break; 2213 case Instruction::AGET_CHAR: 2214 VerifyAGet(inst, reg_types_.Char(), true); 2215 break; 2216 case Instruction::AGET_SHORT: 2217 VerifyAGet(inst, reg_types_.Short(), true); 2218 break; 2219 case Instruction::AGET: 2220 VerifyAGet(inst, reg_types_.Integer(), true); 2221 break; 2222 case Instruction::AGET_WIDE: 2223 VerifyAGet(inst, reg_types_.LongLo(), true); 2224 break; 2225 case Instruction::AGET_OBJECT: 2226 VerifyAGet(inst, reg_types_.JavaLangObject(false), false); 2227 break; 2228 2229 case Instruction::APUT_BOOLEAN: 2230 VerifyAPut(inst, reg_types_.Boolean(), true); 2231 break; 2232 case Instruction::APUT_BYTE: 2233 VerifyAPut(inst, reg_types_.Byte(), true); 2234 break; 2235 case Instruction::APUT_CHAR: 2236 VerifyAPut(inst, reg_types_.Char(), true); 2237 break; 2238 case Instruction::APUT_SHORT: 2239 VerifyAPut(inst, reg_types_.Short(), true); 2240 break; 2241 case Instruction::APUT: 2242 VerifyAPut(inst, reg_types_.Integer(), true); 2243 break; 2244 case Instruction::APUT_WIDE: 2245 VerifyAPut(inst, reg_types_.LongLo(), true); 2246 break; 2247 case Instruction::APUT_OBJECT: 2248 VerifyAPut(inst, reg_types_.JavaLangObject(false), false); 2249 break; 2250 2251 case Instruction::IGET_BOOLEAN: 2252 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Boolean(), true, false); 2253 break; 2254 case Instruction::IGET_BYTE: 2255 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Byte(), true, false); 2256 break; 2257 case Instruction::IGET_CHAR: 2258 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Char(), true, false); 2259 break; 2260 case Instruction::IGET_SHORT: 2261 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Short(), true, false); 2262 break; 2263 case Instruction::IGET: 2264 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Integer(), true, false); 2265 break; 2266 case Instruction::IGET_WIDE: 2267 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.LongLo(), true, false); 2268 break; 2269 case Instruction::IGET_OBJECT: 2270 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.JavaLangObject(false), false, 2271 false); 2272 break; 2273 2274 case Instruction::IPUT_BOOLEAN: 2275 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Boolean(), true, false); 2276 break; 2277 case Instruction::IPUT_BYTE: 2278 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Byte(), true, false); 2279 break; 2280 case Instruction::IPUT_CHAR: 2281 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Char(), true, false); 2282 break; 2283 case Instruction::IPUT_SHORT: 2284 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Short(), true, false); 2285 break; 2286 case Instruction::IPUT: 2287 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Integer(), true, false); 2288 break; 2289 case Instruction::IPUT_WIDE: 2290 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.LongLo(), true, false); 2291 break; 2292 case Instruction::IPUT_OBJECT: 2293 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.JavaLangObject(false), false, 2294 false); 2295 break; 2296 2297 case Instruction::SGET_BOOLEAN: 2298 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Boolean(), true, true); 2299 break; 2300 case Instruction::SGET_BYTE: 2301 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Byte(), true, true); 2302 break; 2303 case Instruction::SGET_CHAR: 2304 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Char(), true, true); 2305 break; 2306 case Instruction::SGET_SHORT: 2307 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Short(), true, true); 2308 break; 2309 case Instruction::SGET: 2310 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Integer(), true, true); 2311 break; 2312 case Instruction::SGET_WIDE: 2313 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.LongLo(), true, true); 2314 break; 2315 case Instruction::SGET_OBJECT: 2316 VerifyISFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.JavaLangObject(false), false, 2317 true); 2318 break; 2319 2320 case Instruction::SPUT_BOOLEAN: 2321 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Boolean(), true, true); 2322 break; 2323 case Instruction::SPUT_BYTE: 2324 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Byte(), true, true); 2325 break; 2326 case Instruction::SPUT_CHAR: 2327 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Char(), true, true); 2328 break; 2329 case Instruction::SPUT_SHORT: 2330 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Short(), true, true); 2331 break; 2332 case Instruction::SPUT: 2333 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Integer(), true, true); 2334 break; 2335 case Instruction::SPUT_WIDE: 2336 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.LongLo(), true, true); 2337 break; 2338 case Instruction::SPUT_OBJECT: 2339 VerifyISFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.JavaLangObject(false), false, 2340 true); 2341 break; 2342 2343 case Instruction::INVOKE_VIRTUAL: 2344 case Instruction::INVOKE_VIRTUAL_RANGE: 2345 case Instruction::INVOKE_SUPER: 2346 case Instruction::INVOKE_SUPER_RANGE: { 2347 bool is_range = (inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE || 2348 inst->Opcode() == Instruction::INVOKE_SUPER_RANGE); 2349 bool is_super = (inst->Opcode() == Instruction::INVOKE_SUPER || 2350 inst->Opcode() == Instruction::INVOKE_SUPER_RANGE); 2351 mirror::ArtMethod* called_method = VerifyInvocationArgs(inst, METHOD_VIRTUAL, is_range, 2352 is_super); 2353 const RegType* return_type = nullptr; 2354 if (called_method != nullptr) { 2355 StackHandleScope<1> hs(self_); 2356 Handle<mirror::ArtMethod> h_called_method(hs.NewHandle(called_method)); 2357 mirror::Class* return_type_class = h_called_method->GetReturnType(can_load_classes_); 2358 if (return_type_class != nullptr) { 2359 return_type = ®_types_.FromClass(h_called_method->GetReturnTypeDescriptor(), 2360 return_type_class, 2361 return_type_class->CannotBeAssignedFromOtherTypes()); 2362 } else { 2363 DCHECK(!can_load_classes_ || self_->IsExceptionPending()); 2364 self_->ClearException(); 2365 } 2366 } 2367 if (return_type == nullptr) { 2368 uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 2369 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx); 2370 uint32_t return_type_idx = dex_file_->GetProtoId(method_id.proto_idx_).return_type_idx_; 2371 const char* descriptor = dex_file_->StringByTypeIdx(return_type_idx); 2372 return_type = ®_types_.FromDescriptor(GetClassLoader(), descriptor, false); 2373 } 2374 if (!return_type->IsLowHalf()) { 2375 work_line_->SetResultRegisterType(this, *return_type); 2376 } else { 2377 work_line_->SetResultRegisterTypeWide(*return_type, return_type->HighHalf(®_types_)); 2378 } 2379 just_set_result = true; 2380 break; 2381 } 2382 case Instruction::INVOKE_DIRECT: 2383 case Instruction::INVOKE_DIRECT_RANGE: { 2384 bool is_range = (inst->Opcode() == Instruction::INVOKE_DIRECT_RANGE); 2385 mirror::ArtMethod* called_method = VerifyInvocationArgs(inst, METHOD_DIRECT, 2386 is_range, false); 2387 const char* return_type_descriptor; 2388 bool is_constructor; 2389 const RegType* return_type = nullptr; 2390 if (called_method == nullptr) { 2391 uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 2392 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx); 2393 is_constructor = strcmp("<init>", dex_file_->StringDataByIdx(method_id.name_idx_)) == 0; 2394 uint32_t return_type_idx = dex_file_->GetProtoId(method_id.proto_idx_).return_type_idx_; 2395 return_type_descriptor = dex_file_->StringByTypeIdx(return_type_idx); 2396 } else { 2397 is_constructor = called_method->IsConstructor(); 2398 return_type_descriptor = called_method->GetReturnTypeDescriptor(); 2399 StackHandleScope<1> hs(self_); 2400 Handle<mirror::ArtMethod> h_called_method(hs.NewHandle(called_method)); 2401 mirror::Class* return_type_class = h_called_method->GetReturnType(can_load_classes_); 2402 if (return_type_class != nullptr) { 2403 return_type = ®_types_.FromClass(return_type_descriptor, 2404 return_type_class, 2405 return_type_class->CannotBeAssignedFromOtherTypes()); 2406 } else { 2407 DCHECK(!can_load_classes_ || self_->IsExceptionPending()); 2408 self_->ClearException(); 2409 } 2410 } 2411 if (is_constructor) { 2412 /* 2413 * Some additional checks when calling a constructor. We know from the invocation arg check 2414 * that the "this" argument is an instance of called_method->klass. Now we further restrict 2415 * that to require that called_method->klass is the same as this->klass or this->super, 2416 * allowing the latter only if the "this" argument is the same as the "this" argument to 2417 * this method (which implies that we're in a constructor ourselves). 2418 */ 2419 const RegType& this_type = work_line_->GetInvocationThis(this, inst, is_range); 2420 if (this_type.IsConflict()) // failure. 2421 break; 2422 2423 /* no null refs allowed (?) */ 2424 if (this_type.IsZero()) { 2425 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unable to initialize null ref"; 2426 break; 2427 } 2428 2429 /* must be in same class or in superclass */ 2430 // const RegType& this_super_klass = this_type.GetSuperClass(®_types_); 2431 // TODO: re-enable constructor type verification 2432 // if (this_super_klass.IsConflict()) { 2433 // Unknown super class, fail so we re-check at runtime. 2434 // Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "super class unknown for '" << this_type << "'"; 2435 // break; 2436 // } 2437 2438 /* arg must be an uninitialized reference */ 2439 if (!this_type.IsUninitializedTypes()) { 2440 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Expected initialization on uninitialized reference " 2441 << this_type; 2442 break; 2443 } 2444 2445 /* 2446 * Replace the uninitialized reference with an initialized one. We need to do this for all 2447 * registers that have the same object instance in them, not just the "this" register. 2448 */ 2449 work_line_->MarkRefsAsInitialized(this, this_type); 2450 } 2451 if (return_type == nullptr) { 2452 return_type = ®_types_.FromDescriptor(GetClassLoader(), return_type_descriptor, 2453 false); 2454 } 2455 if (!return_type->IsLowHalf()) { 2456 work_line_->SetResultRegisterType(this, *return_type); 2457 } else { 2458 work_line_->SetResultRegisterTypeWide(*return_type, return_type->HighHalf(®_types_)); 2459 } 2460 just_set_result = true; 2461 break; 2462 } 2463 case Instruction::INVOKE_STATIC: 2464 case Instruction::INVOKE_STATIC_RANGE: { 2465 bool is_range = (inst->Opcode() == Instruction::INVOKE_STATIC_RANGE); 2466 mirror::ArtMethod* called_method = VerifyInvocationArgs(inst, 2467 METHOD_STATIC, 2468 is_range, 2469 false); 2470 const char* descriptor; 2471 if (called_method == nullptr) { 2472 uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 2473 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx); 2474 uint32_t return_type_idx = dex_file_->GetProtoId(method_id.proto_idx_).return_type_idx_; 2475 descriptor = dex_file_->StringByTypeIdx(return_type_idx); 2476 } else { 2477 descriptor = called_method->GetReturnTypeDescriptor(); 2478 } 2479 const RegType& return_type = reg_types_.FromDescriptor(GetClassLoader(), descriptor, false); 2480 if (!return_type.IsLowHalf()) { 2481 work_line_->SetResultRegisterType(this, return_type); 2482 } else { 2483 work_line_->SetResultRegisterTypeWide(return_type, return_type.HighHalf(®_types_)); 2484 } 2485 just_set_result = true; 2486 } 2487 break; 2488 case Instruction::INVOKE_INTERFACE: 2489 case Instruction::INVOKE_INTERFACE_RANGE: { 2490 bool is_range = (inst->Opcode() == Instruction::INVOKE_INTERFACE_RANGE); 2491 mirror::ArtMethod* abs_method = VerifyInvocationArgs(inst, 2492 METHOD_INTERFACE, 2493 is_range, 2494 false); 2495 if (abs_method != nullptr) { 2496 mirror::Class* called_interface = abs_method->GetDeclaringClass(); 2497 if (!called_interface->IsInterface() && !called_interface->IsObjectClass()) { 2498 Fail(VERIFY_ERROR_CLASS_CHANGE) << "expected interface class in invoke-interface '" 2499 << PrettyMethod(abs_method) << "'"; 2500 break; 2501 } 2502 } 2503 /* Get the type of the "this" arg, which should either be a sub-interface of called 2504 * interface or Object (see comments in RegType::JoinClass). 2505 */ 2506 const RegType& this_type = work_line_->GetInvocationThis(this, inst, is_range); 2507 if (this_type.IsZero()) { 2508 /* null pointer always passes (and always fails at runtime) */ 2509 } else { 2510 if (this_type.IsUninitializedTypes()) { 2511 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "interface call on uninitialized object " 2512 << this_type; 2513 break; 2514 } 2515 // In the past we have tried to assert that "called_interface" is assignable 2516 // from "this_type.GetClass()", however, as we do an imprecise Join 2517 // (RegType::JoinClass) we don't have full information on what interfaces are 2518 // implemented by "this_type". For example, two classes may implement the same 2519 // interfaces and have a common parent that doesn't implement the interface. The 2520 // join will set "this_type" to the parent class and a test that this implements 2521 // the interface will incorrectly fail. 2522 } 2523 /* 2524 * We don't have an object instance, so we can't find the concrete method. However, all of 2525 * the type information is in the abstract method, so we're good. 2526 */ 2527 const char* descriptor; 2528 if (abs_method == nullptr) { 2529 uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 2530 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx); 2531 uint32_t return_type_idx = dex_file_->GetProtoId(method_id.proto_idx_).return_type_idx_; 2532 descriptor = dex_file_->StringByTypeIdx(return_type_idx); 2533 } else { 2534 descriptor = abs_method->GetReturnTypeDescriptor(); 2535 } 2536 const RegType& return_type = reg_types_.FromDescriptor(GetClassLoader(), descriptor, false); 2537 if (!return_type.IsLowHalf()) { 2538 work_line_->SetResultRegisterType(this, return_type); 2539 } else { 2540 work_line_->SetResultRegisterTypeWide(return_type, return_type.HighHalf(®_types_)); 2541 } 2542 just_set_result = true; 2543 break; 2544 } 2545 case Instruction::NEG_INT: 2546 case Instruction::NOT_INT: 2547 work_line_->CheckUnaryOp(this, inst, reg_types_.Integer(), reg_types_.Integer()); 2548 break; 2549 case Instruction::NEG_LONG: 2550 case Instruction::NOT_LONG: 2551 work_line_->CheckUnaryOpWide(this, inst, reg_types_.LongLo(), reg_types_.LongHi(), 2552 reg_types_.LongLo(), reg_types_.LongHi()); 2553 break; 2554 case Instruction::NEG_FLOAT: 2555 work_line_->CheckUnaryOp(this, inst, reg_types_.Float(), reg_types_.Float()); 2556 break; 2557 case Instruction::NEG_DOUBLE: 2558 work_line_->CheckUnaryOpWide(this, inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2559 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2560 break; 2561 case Instruction::INT_TO_LONG: 2562 work_line_->CheckUnaryOpToWide(this, inst, reg_types_.LongLo(), reg_types_.LongHi(), 2563 reg_types_.Integer()); 2564 break; 2565 case Instruction::INT_TO_FLOAT: 2566 work_line_->CheckUnaryOp(this, inst, reg_types_.Float(), reg_types_.Integer()); 2567 break; 2568 case Instruction::INT_TO_DOUBLE: 2569 work_line_->CheckUnaryOpToWide(this, inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2570 reg_types_.Integer()); 2571 break; 2572 case Instruction::LONG_TO_INT: 2573 work_line_->CheckUnaryOpFromWide(this, inst, reg_types_.Integer(), 2574 reg_types_.LongLo(), reg_types_.LongHi()); 2575 break; 2576 case Instruction::LONG_TO_FLOAT: 2577 work_line_->CheckUnaryOpFromWide(this, inst, reg_types_.Float(), 2578 reg_types_.LongLo(), reg_types_.LongHi()); 2579 break; 2580 case Instruction::LONG_TO_DOUBLE: 2581 work_line_->CheckUnaryOpWide(this, inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2582 reg_types_.LongLo(), reg_types_.LongHi()); 2583 break; 2584 case Instruction::FLOAT_TO_INT: 2585 work_line_->CheckUnaryOp(this, inst, reg_types_.Integer(), reg_types_.Float()); 2586 break; 2587 case Instruction::FLOAT_TO_LONG: 2588 work_line_->CheckUnaryOpToWide(this, inst, reg_types_.LongLo(), reg_types_.LongHi(), 2589 reg_types_.Float()); 2590 break; 2591 case Instruction::FLOAT_TO_DOUBLE: 2592 work_line_->CheckUnaryOpToWide(this, inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2593 reg_types_.Float()); 2594 break; 2595 case Instruction::DOUBLE_TO_INT: 2596 work_line_->CheckUnaryOpFromWide(this, inst, reg_types_.Integer(), 2597 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2598 break; 2599 case Instruction::DOUBLE_TO_LONG: 2600 work_line_->CheckUnaryOpWide(this, inst, reg_types_.LongLo(), reg_types_.LongHi(), 2601 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2602 break; 2603 case Instruction::DOUBLE_TO_FLOAT: 2604 work_line_->CheckUnaryOpFromWide(this, inst, reg_types_.Float(), 2605 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2606 break; 2607 case Instruction::INT_TO_BYTE: 2608 work_line_->CheckUnaryOp(this, inst, reg_types_.Byte(), reg_types_.Integer()); 2609 break; 2610 case Instruction::INT_TO_CHAR: 2611 work_line_->CheckUnaryOp(this, inst, reg_types_.Char(), reg_types_.Integer()); 2612 break; 2613 case Instruction::INT_TO_SHORT: 2614 work_line_->CheckUnaryOp(this, inst, reg_types_.Short(), reg_types_.Integer()); 2615 break; 2616 2617 case Instruction::ADD_INT: 2618 case Instruction::SUB_INT: 2619 case Instruction::MUL_INT: 2620 case Instruction::REM_INT: 2621 case Instruction::DIV_INT: 2622 case Instruction::SHL_INT: 2623 case Instruction::SHR_INT: 2624 case Instruction::USHR_INT: 2625 work_line_->CheckBinaryOp(this, inst, reg_types_.Integer(), reg_types_.Integer(), 2626 reg_types_.Integer(), false); 2627 break; 2628 case Instruction::AND_INT: 2629 case Instruction::OR_INT: 2630 case Instruction::XOR_INT: 2631 work_line_->CheckBinaryOp(this, inst, reg_types_.Integer(), reg_types_.Integer(), 2632 reg_types_.Integer(), true); 2633 break; 2634 case Instruction::ADD_LONG: 2635 case Instruction::SUB_LONG: 2636 case Instruction::MUL_LONG: 2637 case Instruction::DIV_LONG: 2638 case Instruction::REM_LONG: 2639 case Instruction::AND_LONG: 2640 case Instruction::OR_LONG: 2641 case Instruction::XOR_LONG: 2642 work_line_->CheckBinaryOpWide(this, inst, reg_types_.LongLo(), reg_types_.LongHi(), 2643 reg_types_.LongLo(), reg_types_.LongHi(), 2644 reg_types_.LongLo(), reg_types_.LongHi()); 2645 break; 2646 case Instruction::SHL_LONG: 2647 case Instruction::SHR_LONG: 2648 case Instruction::USHR_LONG: 2649 /* shift distance is Int, making these different from other binary operations */ 2650 work_line_->CheckBinaryOpWideShift(this, inst, reg_types_.LongLo(), reg_types_.LongHi(), 2651 reg_types_.Integer()); 2652 break; 2653 case Instruction::ADD_FLOAT: 2654 case Instruction::SUB_FLOAT: 2655 case Instruction::MUL_FLOAT: 2656 case Instruction::DIV_FLOAT: 2657 case Instruction::REM_FLOAT: 2658 work_line_->CheckBinaryOp(this, inst, reg_types_.Float(), reg_types_.Float(), 2659 reg_types_.Float(), false); 2660 break; 2661 case Instruction::ADD_DOUBLE: 2662 case Instruction::SUB_DOUBLE: 2663 case Instruction::MUL_DOUBLE: 2664 case Instruction::DIV_DOUBLE: 2665 case Instruction::REM_DOUBLE: 2666 work_line_->CheckBinaryOpWide(this, inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2667 reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2668 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2669 break; 2670 case Instruction::ADD_INT_2ADDR: 2671 case Instruction::SUB_INT_2ADDR: 2672 case Instruction::MUL_INT_2ADDR: 2673 case Instruction::REM_INT_2ADDR: 2674 case Instruction::SHL_INT_2ADDR: 2675 case Instruction::SHR_INT_2ADDR: 2676 case Instruction::USHR_INT_2ADDR: 2677 work_line_->CheckBinaryOp2addr(this, inst, reg_types_.Integer(), reg_types_.Integer(), 2678 reg_types_.Integer(), false); 2679 break; 2680 case Instruction::AND_INT_2ADDR: 2681 case Instruction::OR_INT_2ADDR: 2682 case Instruction::XOR_INT_2ADDR: 2683 work_line_->CheckBinaryOp2addr(this, inst, reg_types_.Integer(), reg_types_.Integer(), 2684 reg_types_.Integer(), true); 2685 break; 2686 case Instruction::DIV_INT_2ADDR: 2687 work_line_->CheckBinaryOp2addr(this, inst, reg_types_.Integer(), reg_types_.Integer(), 2688 reg_types_.Integer(), false); 2689 break; 2690 case Instruction::ADD_LONG_2ADDR: 2691 case Instruction::SUB_LONG_2ADDR: 2692 case Instruction::MUL_LONG_2ADDR: 2693 case Instruction::DIV_LONG_2ADDR: 2694 case Instruction::REM_LONG_2ADDR: 2695 case Instruction::AND_LONG_2ADDR: 2696 case Instruction::OR_LONG_2ADDR: 2697 case Instruction::XOR_LONG_2ADDR: 2698 work_line_->CheckBinaryOp2addrWide(this, inst, reg_types_.LongLo(), reg_types_.LongHi(), 2699 reg_types_.LongLo(), reg_types_.LongHi(), 2700 reg_types_.LongLo(), reg_types_.LongHi()); 2701 break; 2702 case Instruction::SHL_LONG_2ADDR: 2703 case Instruction::SHR_LONG_2ADDR: 2704 case Instruction::USHR_LONG_2ADDR: 2705 work_line_->CheckBinaryOp2addrWideShift(this, inst, reg_types_.LongLo(), reg_types_.LongHi(), 2706 reg_types_.Integer()); 2707 break; 2708 case Instruction::ADD_FLOAT_2ADDR: 2709 case Instruction::SUB_FLOAT_2ADDR: 2710 case Instruction::MUL_FLOAT_2ADDR: 2711 case Instruction::DIV_FLOAT_2ADDR: 2712 case Instruction::REM_FLOAT_2ADDR: 2713 work_line_->CheckBinaryOp2addr(this, inst, reg_types_.Float(), reg_types_.Float(), 2714 reg_types_.Float(), false); 2715 break; 2716 case Instruction::ADD_DOUBLE_2ADDR: 2717 case Instruction::SUB_DOUBLE_2ADDR: 2718 case Instruction::MUL_DOUBLE_2ADDR: 2719 case Instruction::DIV_DOUBLE_2ADDR: 2720 case Instruction::REM_DOUBLE_2ADDR: 2721 work_line_->CheckBinaryOp2addrWide(this, inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2722 reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2723 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2724 break; 2725 case Instruction::ADD_INT_LIT16: 2726 case Instruction::RSUB_INT_LIT16: 2727 case Instruction::MUL_INT_LIT16: 2728 case Instruction::DIV_INT_LIT16: 2729 case Instruction::REM_INT_LIT16: 2730 work_line_->CheckLiteralOp(this, inst, reg_types_.Integer(), reg_types_.Integer(), false, 2731 true); 2732 break; 2733 case Instruction::AND_INT_LIT16: 2734 case Instruction::OR_INT_LIT16: 2735 case Instruction::XOR_INT_LIT16: 2736 work_line_->CheckLiteralOp(this, inst, reg_types_.Integer(), reg_types_.Integer(), true, 2737 true); 2738 break; 2739 case Instruction::ADD_INT_LIT8: 2740 case Instruction::RSUB_INT_LIT8: 2741 case Instruction::MUL_INT_LIT8: 2742 case Instruction::DIV_INT_LIT8: 2743 case Instruction::REM_INT_LIT8: 2744 case Instruction::SHL_INT_LIT8: 2745 case Instruction::SHR_INT_LIT8: 2746 case Instruction::USHR_INT_LIT8: 2747 work_line_->CheckLiteralOp(this, inst, reg_types_.Integer(), reg_types_.Integer(), false, 2748 false); 2749 break; 2750 case Instruction::AND_INT_LIT8: 2751 case Instruction::OR_INT_LIT8: 2752 case Instruction::XOR_INT_LIT8: 2753 work_line_->CheckLiteralOp(this, inst, reg_types_.Integer(), reg_types_.Integer(), true, 2754 false); 2755 break; 2756 2757 // Special instructions. 2758 case Instruction::RETURN_VOID_NO_BARRIER: 2759 if (IsConstructor() && !IsStatic()) { 2760 auto& declaring_class = GetDeclaringClass(); 2761 auto* klass = declaring_class.GetClass(); 2762 for (uint32_t i = 0, num_fields = klass->NumInstanceFields(); i < num_fields; ++i) { 2763 if (klass->GetInstanceField(i)->IsFinal()) { 2764 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "return-void-no-barrier not expected for " 2765 << PrettyField(klass->GetInstanceField(i)); 2766 break; 2767 } 2768 } 2769 } 2770 break; 2771 // Note: the following instructions encode offsets derived from class linking. 2772 // As such they use Class*/Field*/AbstractMethod* as these offsets only have 2773 // meaning if the class linking and resolution were successful. 2774 case Instruction::IGET_QUICK: 2775 VerifyQuickFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Integer(), true); 2776 break; 2777 case Instruction::IGET_WIDE_QUICK: 2778 VerifyQuickFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.LongLo(), true); 2779 break; 2780 case Instruction::IGET_OBJECT_QUICK: 2781 VerifyQuickFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.JavaLangObject(false), false); 2782 break; 2783 case Instruction::IGET_BOOLEAN_QUICK: 2784 VerifyQuickFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Boolean(), true); 2785 break; 2786 case Instruction::IGET_BYTE_QUICK: 2787 VerifyQuickFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Byte(), true); 2788 break; 2789 case Instruction::IGET_CHAR_QUICK: 2790 VerifyQuickFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Char(), true); 2791 break; 2792 case Instruction::IGET_SHORT_QUICK: 2793 VerifyQuickFieldAccess<FieldAccessType::kAccGet>(inst, reg_types_.Short(), true); 2794 break; 2795 case Instruction::IPUT_QUICK: 2796 VerifyQuickFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Integer(), true); 2797 break; 2798 case Instruction::IPUT_BOOLEAN_QUICK: 2799 VerifyQuickFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Boolean(), true); 2800 break; 2801 case Instruction::IPUT_BYTE_QUICK: 2802 VerifyQuickFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Byte(), true); 2803 break; 2804 case Instruction::IPUT_CHAR_QUICK: 2805 VerifyQuickFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Char(), true); 2806 break; 2807 case Instruction::IPUT_SHORT_QUICK: 2808 VerifyQuickFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.Short(), true); 2809 break; 2810 case Instruction::IPUT_WIDE_QUICK: 2811 VerifyQuickFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.LongLo(), true); 2812 break; 2813 case Instruction::IPUT_OBJECT_QUICK: 2814 VerifyQuickFieldAccess<FieldAccessType::kAccPut>(inst, reg_types_.JavaLangObject(false), false); 2815 break; 2816 case Instruction::INVOKE_VIRTUAL_QUICK: 2817 case Instruction::INVOKE_VIRTUAL_RANGE_QUICK: { 2818 bool is_range = (inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE_QUICK); 2819 mirror::ArtMethod* called_method = VerifyInvokeVirtualQuickArgs(inst, is_range); 2820 if (called_method != nullptr) { 2821 const char* descriptor = called_method->GetReturnTypeDescriptor(); 2822 const RegType& return_type = reg_types_.FromDescriptor(GetClassLoader(), descriptor, false); 2823 if (!return_type.IsLowHalf()) { 2824 work_line_->SetResultRegisterType(this, return_type); 2825 } else { 2826 work_line_->SetResultRegisterTypeWide(return_type, return_type.HighHalf(®_types_)); 2827 } 2828 just_set_result = true; 2829 } 2830 break; 2831 } 2832 2833 /* These should never appear during verification. */ 2834 case Instruction::UNUSED_3E ... Instruction::UNUSED_43: 2835 case Instruction::UNUSED_F3 ... Instruction::UNUSED_FF: 2836 case Instruction::UNUSED_79: 2837 case Instruction::UNUSED_7A: 2838 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Unexpected opcode " << inst->DumpString(dex_file_); 2839 break; 2840 2841 /* 2842 * DO NOT add a "default" clause here. Without it the compiler will 2843 * complain if an instruction is missing (which is desirable). 2844 */ 2845 } // end - switch (dec_insn.opcode) 2846 2847 /* 2848 * If we are in a constructor, and we had an UninitializedThis type 2849 * in a register somewhere, we need to make sure it wasn't overwritten. 2850 */ 2851 if (track_uninitialized_this) { 2852 bool was_invoke_direct = (inst->Opcode() == Instruction::INVOKE_DIRECT || 2853 inst->Opcode() == Instruction::INVOKE_DIRECT_RANGE); 2854 if (work_line_->WasUninitializedThisOverwritten(this, uninitialized_this_loc, 2855 was_invoke_direct)) { 2856 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 2857 << "Constructor failed to initialize this object"; 2858 } 2859 } 2860 2861 if (have_pending_hard_failure_) { 2862 if (Runtime::Current()->IsAotCompiler()) { 2863 /* When AOT compiling, check that the last failure is a hard failure */ 2864 CHECK_EQ(failures_[failures_.size() - 1], VERIFY_ERROR_BAD_CLASS_HARD); 2865 } 2866 /* immediate failure, reject class */ 2867 info_messages_ << "Rejecting opcode " << inst->DumpString(dex_file_); 2868 return false; 2869 } else if (have_pending_runtime_throw_failure_) { 2870 /* checking interpreter will throw, mark following code as unreachable */ 2871 opcode_flags = Instruction::kThrow; 2872 } 2873 /* 2874 * If we didn't just set the result register, clear it out. This ensures that you can only use 2875 * "move-result" immediately after the result is set. (We could check this statically, but it's 2876 * not expensive and it makes our debugging output cleaner.) 2877 */ 2878 if (!just_set_result) { 2879 work_line_->SetResultTypeToUnknown(this); 2880 } 2881 2882 2883 2884 /* 2885 * Handle "branch". Tag the branch target. 2886 * 2887 * NOTE: instructions like Instruction::EQZ provide information about the 2888 * state of the register when the branch is taken or not taken. For example, 2889 * somebody could get a reference field, check it for zero, and if the 2890 * branch is taken immediately store that register in a boolean field 2891 * since the value is known to be zero. We do not currently account for 2892 * that, and will reject the code. 2893 * 2894 * TODO: avoid re-fetching the branch target 2895 */ 2896 if ((opcode_flags & Instruction::kBranch) != 0) { 2897 bool isConditional, selfOkay; 2898 if (!GetBranchOffset(work_insn_idx_, &branch_target, &isConditional, &selfOkay)) { 2899 /* should never happen after static verification */ 2900 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad branch"; 2901 return false; 2902 } 2903 DCHECK_EQ(isConditional, (opcode_flags & Instruction::kContinue) != 0); 2904 if (!CheckNotMoveExceptionOrMoveResult(code_item_->insns_, work_insn_idx_ + branch_target)) { 2905 return false; 2906 } 2907 /* update branch target, set "changed" if appropriate */ 2908 if (nullptr != branch_line.get()) { 2909 if (!UpdateRegisters(work_insn_idx_ + branch_target, branch_line.get(), false)) { 2910 return false; 2911 } 2912 } else { 2913 if (!UpdateRegisters(work_insn_idx_ + branch_target, work_line_.get(), false)) { 2914 return false; 2915 } 2916 } 2917 } 2918 2919 /* 2920 * Handle "switch". Tag all possible branch targets. 2921 * 2922 * We've already verified that the table is structurally sound, so we 2923 * just need to walk through and tag the targets. 2924 */ 2925 if ((opcode_flags & Instruction::kSwitch) != 0) { 2926 int offset_to_switch = insns[1] | (((int32_t) insns[2]) << 16); 2927 const uint16_t* switch_insns = insns + offset_to_switch; 2928 int switch_count = switch_insns[1]; 2929 int offset_to_targets, targ; 2930 2931 if ((*insns & 0xff) == Instruction::PACKED_SWITCH) { 2932 /* 0 = sig, 1 = count, 2/3 = first key */ 2933 offset_to_targets = 4; 2934 } else { 2935 /* 0 = sig, 1 = count, 2..count * 2 = keys */ 2936 DCHECK((*insns & 0xff) == Instruction::SPARSE_SWITCH); 2937 offset_to_targets = 2 + 2 * switch_count; 2938 } 2939 2940 /* verify each switch target */ 2941 for (targ = 0; targ < switch_count; targ++) { 2942 int offset; 2943 uint32_t abs_offset; 2944 2945 /* offsets are 32-bit, and only partly endian-swapped */ 2946 offset = switch_insns[offset_to_targets + targ * 2] | 2947 (((int32_t) switch_insns[offset_to_targets + targ * 2 + 1]) << 16); 2948 abs_offset = work_insn_idx_ + offset; 2949 DCHECK_LT(abs_offset, code_item_->insns_size_in_code_units_); 2950 if (!CheckNotMoveExceptionOrMoveResult(code_item_->insns_, abs_offset)) { 2951 return false; 2952 } 2953 if (!UpdateRegisters(abs_offset, work_line_.get(), false)) { 2954 return false; 2955 } 2956 } 2957 } 2958 2959 /* 2960 * Handle instructions that can throw and that are sitting in a "try" block. (If they're not in a 2961 * "try" block when they throw, control transfers out of the method.) 2962 */ 2963 if ((opcode_flags & Instruction::kThrow) != 0 && insn_flags_[work_insn_idx_].IsInTry()) { 2964 bool has_catch_all_handler = false; 2965 CatchHandlerIterator iterator(*code_item_, work_insn_idx_); 2966 2967 // Need the linker to try and resolve the handled class to check if it's Throwable. 2968 ClassLinker* linker = Runtime::Current()->GetClassLinker(); 2969 2970 for (; iterator.HasNext(); iterator.Next()) { 2971 uint16_t handler_type_idx = iterator.GetHandlerTypeIndex(); 2972 if (handler_type_idx == DexFile::kDexNoIndex16) { 2973 has_catch_all_handler = true; 2974 } else { 2975 // It is also a catch-all if it is java.lang.Throwable. 2976 mirror::Class* klass = linker->ResolveType(*dex_file_, handler_type_idx, dex_cache_, 2977 class_loader_); 2978 if (klass != nullptr) { 2979 if (klass == mirror::Throwable::GetJavaLangThrowable()) { 2980 has_catch_all_handler = true; 2981 } 2982 } else { 2983 // Clear exception. 2984 DCHECK(self_->IsExceptionPending()); 2985 self_->ClearException(); 2986 } 2987 } 2988 /* 2989 * Merge registers into the "catch" block. We want to use the "savedRegs" rather than 2990 * "work_regs", because at runtime the exception will be thrown before the instruction 2991 * modifies any registers. 2992 */ 2993 if (!UpdateRegisters(iterator.GetHandlerAddress(), saved_line_.get(), false)) { 2994 return false; 2995 } 2996 } 2997 2998 /* 2999 * If the monitor stack depth is nonzero, there must be a "catch all" handler for this 3000 * instruction. This does apply to monitor-exit because of async exception handling. 3001 */ 3002 if (work_line_->MonitorStackDepth() > 0 && !has_catch_all_handler) { 3003 /* 3004 * The state in work_line reflects the post-execution state. If the current instruction is a 3005 * monitor-enter and the monitor stack was empty, we don't need a catch-all (if it throws, 3006 * it will do so before grabbing the lock). 3007 */ 3008 if (inst->Opcode() != Instruction::MONITOR_ENTER || work_line_->MonitorStackDepth() != 1) { 3009 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 3010 << "expected to be within a catch-all for an instruction where a monitor is held"; 3011 return false; 3012 } 3013 } 3014 } 3015 3016 /* Handle "continue". Tag the next consecutive instruction. 3017 * Note: Keep the code handling "continue" case below the "branch" and "switch" cases, 3018 * because it changes work_line_ when performing peephole optimization 3019 * and this change should not be used in those cases. 3020 */ 3021 if ((opcode_flags & Instruction::kContinue) != 0) { 3022 DCHECK_EQ(Instruction::At(code_item_->insns_ + work_insn_idx_), inst); 3023 uint32_t next_insn_idx = work_insn_idx_ + inst->SizeInCodeUnits(); 3024 if (next_insn_idx >= code_item_->insns_size_in_code_units_) { 3025 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Execution can walk off end of code area"; 3026 return false; 3027 } 3028 // The only way to get to a move-exception instruction is to get thrown there. Make sure the 3029 // next instruction isn't one. 3030 if (!CheckNotMoveException(code_item_->insns_, next_insn_idx)) { 3031 return false; 3032 } 3033 if (nullptr != fallthrough_line.get()) { 3034 // Make workline consistent with fallthrough computed from peephole optimization. 3035 work_line_->CopyFromLine(fallthrough_line.get()); 3036 } 3037 if (insn_flags_[next_insn_idx].IsReturn()) { 3038 // For returns we only care about the operand to the return, all other registers are dead. 3039 const Instruction* ret_inst = Instruction::At(code_item_->insns_ + next_insn_idx); 3040 Instruction::Code opcode = ret_inst->Opcode(); 3041 if (opcode == Instruction::RETURN_VOID || opcode == Instruction::RETURN_VOID_NO_BARRIER) { 3042 SafelyMarkAllRegistersAsConflicts(this, work_line_.get()); 3043 } else { 3044 if (opcode == Instruction::RETURN_WIDE) { 3045 work_line_->MarkAllRegistersAsConflictsExceptWide(this, ret_inst->VRegA_11x()); 3046 } else { 3047 work_line_->MarkAllRegistersAsConflictsExcept(this, ret_inst->VRegA_11x()); 3048 } 3049 } 3050 } 3051 RegisterLine* next_line = reg_table_.GetLine(next_insn_idx); 3052 if (next_line != nullptr) { 3053 // Merge registers into what we have for the next instruction, and set the "changed" flag if 3054 // needed. If the merge changes the state of the registers then the work line will be 3055 // updated. 3056 if (!UpdateRegisters(next_insn_idx, work_line_.get(), true)) { 3057 return false; 3058 } 3059 } else { 3060 /* 3061 * We're not recording register data for the next instruction, so we don't know what the 3062 * prior state was. We have to assume that something has changed and re-evaluate it. 3063 */ 3064 insn_flags_[next_insn_idx].SetChanged(); 3065 } 3066 } 3067 3068 /* If we're returning from the method, make sure monitor stack is empty. */ 3069 if ((opcode_flags & Instruction::kReturn) != 0) { 3070 if (!work_line_->VerifyMonitorStackEmpty(this)) { 3071 return false; 3072 } 3073 } 3074 3075 /* 3076 * Update start_guess. Advance to the next instruction of that's 3077 * possible, otherwise use the branch target if one was found. If 3078 * neither of those exists we're in a return or throw; leave start_guess 3079 * alone and let the caller sort it out. 3080 */ 3081 if ((opcode_flags & Instruction::kContinue) != 0) { 3082 DCHECK_EQ(Instruction::At(code_item_->insns_ + work_insn_idx_), inst); 3083 *start_guess = work_insn_idx_ + inst->SizeInCodeUnits(); 3084 } else if ((opcode_flags & Instruction::kBranch) != 0) { 3085 /* we're still okay if branch_target is zero */ 3086 *start_guess = work_insn_idx_ + branch_target; 3087 } 3088 3089 DCHECK_LT(*start_guess, code_item_->insns_size_in_code_units_); 3090 DCHECK(insn_flags_[*start_guess].IsOpcode()); 3091 3092 return true; 3093} // NOLINT(readability/fn_size) 3094 3095const RegType& MethodVerifier::ResolveClassAndCheckAccess(uint32_t class_idx) { 3096 const char* descriptor = dex_file_->StringByTypeIdx(class_idx); 3097 const RegType& referrer = GetDeclaringClass(); 3098 mirror::Class* klass = dex_cache_->GetResolvedType(class_idx); 3099 const RegType& result = klass != nullptr ? 3100 reg_types_.FromClass(descriptor, klass, klass->CannotBeAssignedFromOtherTypes()) : 3101 reg_types_.FromDescriptor(GetClassLoader(), descriptor, false); 3102 if (result.IsConflict()) { 3103 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "accessing broken descriptor '" << descriptor 3104 << "' in " << referrer; 3105 return result; 3106 } 3107 if (klass == nullptr && !result.IsUnresolvedTypes()) { 3108 dex_cache_->SetResolvedType(class_idx, result.GetClass()); 3109 } 3110 // Check if access is allowed. Unresolved types use xxxWithAccessCheck to 3111 // check at runtime if access is allowed and so pass here. If result is 3112 // primitive, skip the access check. 3113 if (result.IsNonZeroReferenceTypes() && !result.IsUnresolvedTypes() && 3114 !referrer.IsUnresolvedTypes() && !referrer.CanAccess(result)) { 3115 Fail(VERIFY_ERROR_ACCESS_CLASS) << "illegal class access: '" 3116 << referrer << "' -> '" << result << "'"; 3117 } 3118 return result; 3119} 3120 3121const RegType& MethodVerifier::GetCaughtExceptionType() { 3122 const RegType* common_super = nullptr; 3123 if (code_item_->tries_size_ != 0) { 3124 const uint8_t* handlers_ptr = DexFile::GetCatchHandlerData(*code_item_, 0); 3125 uint32_t handlers_size = DecodeUnsignedLeb128(&handlers_ptr); 3126 for (uint32_t i = 0; i < handlers_size; i++) { 3127 CatchHandlerIterator iterator(handlers_ptr); 3128 for (; iterator.HasNext(); iterator.Next()) { 3129 if (iterator.GetHandlerAddress() == (uint32_t) work_insn_idx_) { 3130 if (iterator.GetHandlerTypeIndex() == DexFile::kDexNoIndex16) { 3131 common_super = ®_types_.JavaLangThrowable(false); 3132 } else { 3133 const RegType& exception = ResolveClassAndCheckAccess(iterator.GetHandlerTypeIndex()); 3134 if (!reg_types_.JavaLangThrowable(false).IsAssignableFrom(exception)) { 3135 if (exception.IsUnresolvedTypes()) { 3136 // We don't know enough about the type. Fail here and let runtime handle it. 3137 Fail(VERIFY_ERROR_NO_CLASS) << "unresolved exception class " << exception; 3138 return exception; 3139 } else { 3140 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "unexpected non-exception class " << exception; 3141 return reg_types_.Conflict(); 3142 } 3143 } else if (common_super == nullptr) { 3144 common_super = &exception; 3145 } else if (common_super->Equals(exception)) { 3146 // odd case, but nothing to do 3147 } else { 3148 common_super = &common_super->Merge(exception, ®_types_); 3149 if (FailOrAbort(this, 3150 reg_types_.JavaLangThrowable(false).IsAssignableFrom(*common_super), 3151 "java.lang.Throwable is not assignable-from common_super at ", 3152 work_insn_idx_)) { 3153 break; 3154 } 3155 } 3156 } 3157 } 3158 } 3159 handlers_ptr = iterator.EndDataPointer(); 3160 } 3161 } 3162 if (common_super == nullptr) { 3163 /* no catch blocks, or no catches with classes we can find */ 3164 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "unable to find exception handler"; 3165 return reg_types_.Conflict(); 3166 } 3167 return *common_super; 3168} 3169 3170mirror::ArtMethod* MethodVerifier::ResolveMethodAndCheckAccess(uint32_t dex_method_idx, 3171 MethodType method_type) { 3172 const DexFile::MethodId& method_id = dex_file_->GetMethodId(dex_method_idx); 3173 const RegType& klass_type = ResolveClassAndCheckAccess(method_id.class_idx_); 3174 if (klass_type.IsConflict()) { 3175 std::string append(" in attempt to access method "); 3176 append += dex_file_->GetMethodName(method_id); 3177 AppendToLastFailMessage(append); 3178 return nullptr; 3179 } 3180 if (klass_type.IsUnresolvedTypes()) { 3181 return nullptr; // Can't resolve Class so no more to do here 3182 } 3183 mirror::Class* klass = klass_type.GetClass(); 3184 const RegType& referrer = GetDeclaringClass(); 3185 mirror::ArtMethod* res_method = dex_cache_->GetResolvedMethod(dex_method_idx); 3186 if (res_method == nullptr) { 3187 const char* name = dex_file_->GetMethodName(method_id); 3188 const Signature signature = dex_file_->GetMethodSignature(method_id); 3189 3190 if (method_type == METHOD_DIRECT || method_type == METHOD_STATIC) { 3191 res_method = klass->FindDirectMethod(name, signature); 3192 } else if (method_type == METHOD_INTERFACE) { 3193 res_method = klass->FindInterfaceMethod(name, signature); 3194 } else { 3195 res_method = klass->FindVirtualMethod(name, signature); 3196 } 3197 if (res_method != nullptr) { 3198 dex_cache_->SetResolvedMethod(dex_method_idx, res_method); 3199 } else { 3200 // If a virtual or interface method wasn't found with the expected type, look in 3201 // the direct methods. This can happen when the wrong invoke type is used or when 3202 // a class has changed, and will be flagged as an error in later checks. 3203 if (method_type == METHOD_INTERFACE || method_type == METHOD_VIRTUAL) { 3204 res_method = klass->FindDirectMethod(name, signature); 3205 } 3206 if (res_method == nullptr) { 3207 Fail(VERIFY_ERROR_NO_METHOD) << "couldn't find method " 3208 << PrettyDescriptor(klass) << "." << name 3209 << " " << signature; 3210 return nullptr; 3211 } 3212 } 3213 } 3214 // Make sure calls to constructors are "direct". There are additional restrictions but we don't 3215 // enforce them here. 3216 if (res_method->IsConstructor() && method_type != METHOD_DIRECT) { 3217 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "rejecting non-direct call to constructor " 3218 << PrettyMethod(res_method); 3219 return nullptr; 3220 } 3221 // Disallow any calls to class initializers. 3222 if (res_method->IsClassInitializer()) { 3223 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "rejecting call to class initializer " 3224 << PrettyMethod(res_method); 3225 return nullptr; 3226 } 3227 // Check if access is allowed. 3228 if (!referrer.CanAccessMember(res_method->GetDeclaringClass(), res_method->GetAccessFlags())) { 3229 Fail(VERIFY_ERROR_ACCESS_METHOD) << "illegal method access (call " << PrettyMethod(res_method) 3230 << " from " << referrer << ")"; 3231 return res_method; 3232 } 3233 // Check that invoke-virtual and invoke-super are not used on private methods of the same class. 3234 if (res_method->IsPrivate() && method_type == METHOD_VIRTUAL) { 3235 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invoke-super/virtual can't be used on private method " 3236 << PrettyMethod(res_method); 3237 return nullptr; 3238 } 3239 // Check that interface methods match interface classes. 3240 if (klass->IsInterface() && method_type != METHOD_INTERFACE) { 3241 Fail(VERIFY_ERROR_CLASS_CHANGE) << "non-interface method " << PrettyMethod(res_method) 3242 << " is in an interface class " << PrettyClass(klass); 3243 return nullptr; 3244 } else if (!klass->IsInterface() && method_type == METHOD_INTERFACE) { 3245 Fail(VERIFY_ERROR_CLASS_CHANGE) << "interface method " << PrettyMethod(res_method) 3246 << " is in a non-interface class " << PrettyClass(klass); 3247 return nullptr; 3248 } 3249 // See if the method type implied by the invoke instruction matches the access flags for the 3250 // target method. 3251 if ((method_type == METHOD_DIRECT && (!res_method->IsDirect() || res_method->IsStatic())) || 3252 (method_type == METHOD_STATIC && !res_method->IsStatic()) || 3253 ((method_type == METHOD_VIRTUAL || method_type == METHOD_INTERFACE) && res_method->IsDirect()) 3254 ) { 3255 Fail(VERIFY_ERROR_CLASS_CHANGE) << "invoke type (" << method_type << ") does not match method " 3256 " type of " << PrettyMethod(res_method); 3257 return nullptr; 3258 } 3259 return res_method; 3260} 3261 3262template <class T> 3263mirror::ArtMethod* MethodVerifier::VerifyInvocationArgsFromIterator(T* it, const Instruction* inst, 3264 MethodType method_type, 3265 bool is_range, 3266 mirror::ArtMethod* res_method) { 3267 // We use vAA as our expected arg count, rather than res_method->insSize, because we need to 3268 // match the call to the signature. Also, we might be calling through an abstract method 3269 // definition (which doesn't have register count values). 3270 const size_t expected_args = (is_range) ? inst->VRegA_3rc() : inst->VRegA_35c(); 3271 /* caught by static verifier */ 3272 DCHECK(is_range || expected_args <= 5); 3273 if (expected_args > code_item_->outs_size_) { 3274 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid argument count (" << expected_args 3275 << ") exceeds outsSize (" << code_item_->outs_size_ << ")"; 3276 return nullptr; 3277 } 3278 3279 uint32_t arg[5]; 3280 if (!is_range) { 3281 inst->GetVarArgs(arg); 3282 } 3283 uint32_t sig_registers = 0; 3284 3285 /* 3286 * Check the "this" argument, which must be an instance of the class that declared the method. 3287 * For an interface class, we don't do the full interface merge (see JoinClass), so we can't do a 3288 * rigorous check here (which is okay since we have to do it at runtime). 3289 */ 3290 if (method_type != METHOD_STATIC) { 3291 const RegType& actual_arg_type = work_line_->GetInvocationThis(this, inst, is_range); 3292 if (actual_arg_type.IsConflict()) { // GetInvocationThis failed. 3293 CHECK(have_pending_hard_failure_); 3294 return nullptr; 3295 } 3296 if (actual_arg_type.IsUninitializedReference()) { 3297 if (res_method) { 3298 if (!res_method->IsConstructor()) { 3299 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "'this' arg must be initialized"; 3300 return nullptr; 3301 } 3302 } else { 3303 // Check whether the name of the called method is "<init>" 3304 const uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 3305 if (strcmp(dex_file_->GetMethodName(dex_file_->GetMethodId(method_idx)), "<init>") != 0) { 3306 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "'this' arg must be initialized"; 3307 return nullptr; 3308 } 3309 } 3310 } 3311 if (method_type != METHOD_INTERFACE && !actual_arg_type.IsZero()) { 3312 const RegType* res_method_class; 3313 if (res_method != nullptr) { 3314 mirror::Class* klass = res_method->GetDeclaringClass(); 3315 std::string temp; 3316 res_method_class = ®_types_.FromClass(klass->GetDescriptor(&temp), klass, 3317 klass->CannotBeAssignedFromOtherTypes()); 3318 } else { 3319 const uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 3320 const uint16_t class_idx = dex_file_->GetMethodId(method_idx).class_idx_; 3321 res_method_class = ®_types_.FromDescriptor(GetClassLoader(), 3322 dex_file_->StringByTypeIdx(class_idx), 3323 false); 3324 } 3325 if (!res_method_class->IsAssignableFrom(actual_arg_type)) { 3326 Fail(actual_arg_type.IsUnresolvedTypes() ? VERIFY_ERROR_NO_CLASS: 3327 VERIFY_ERROR_BAD_CLASS_SOFT) << "'this' argument '" << actual_arg_type 3328 << "' not instance of '" << *res_method_class << "'"; 3329 // Continue on soft failures. We need to find possible hard failures to avoid problems in 3330 // the compiler. 3331 if (have_pending_hard_failure_) { 3332 return nullptr; 3333 } 3334 } 3335 } 3336 sig_registers = 1; 3337 } 3338 3339 for ( ; it->HasNext(); it->Next()) { 3340 if (sig_registers >= expected_args) { 3341 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation, expected " << inst->VRegA() << 3342 " arguments, found " << sig_registers << " or more."; 3343 return nullptr; 3344 } 3345 3346 const char* param_descriptor = it->GetDescriptor(); 3347 3348 if (param_descriptor == nullptr) { 3349 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation because of missing signature " 3350 "component"; 3351 return nullptr; 3352 } 3353 3354 const RegType& reg_type = reg_types_.FromDescriptor(GetClassLoader(), param_descriptor, false); 3355 uint32_t get_reg = is_range ? inst->VRegC_3rc() + static_cast<uint32_t>(sig_registers) : 3356 arg[sig_registers]; 3357 if (reg_type.IsIntegralTypes()) { 3358 const RegType& src_type = work_line_->GetRegisterType(this, get_reg); 3359 if (!src_type.IsIntegralTypes()) { 3360 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "register v" << get_reg << " has type " << src_type 3361 << " but expected " << reg_type; 3362 return res_method; 3363 } 3364 } else if (!work_line_->VerifyRegisterType(this, get_reg, reg_type)) { 3365 // Continue on soft failures. We need to find possible hard failures to avoid problems in the 3366 // compiler. 3367 if (have_pending_hard_failure_) { 3368 return res_method; 3369 } 3370 } 3371 sig_registers += reg_type.IsLongOrDoubleTypes() ? 2 : 1; 3372 } 3373 if (expected_args != sig_registers) { 3374 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation, expected " << expected_args << 3375 " arguments, found " << sig_registers; 3376 return nullptr; 3377 } 3378 return res_method; 3379} 3380 3381void MethodVerifier::VerifyInvocationArgsUnresolvedMethod(const Instruction* inst, 3382 MethodType method_type, 3383 bool is_range) { 3384 // As the method may not have been resolved, make this static check against what we expect. 3385 // The main reason for this code block is to fail hard when we find an illegal use, e.g., 3386 // wrong number of arguments or wrong primitive types, even if the method could not be resolved. 3387 const uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 3388 DexFileParameterIterator it(*dex_file_, 3389 dex_file_->GetProtoId(dex_file_->GetMethodId(method_idx).proto_idx_)); 3390 VerifyInvocationArgsFromIterator<DexFileParameterIterator>(&it, inst, method_type, is_range, 3391 nullptr); 3392} 3393 3394class MethodParamListDescriptorIterator { 3395 public: 3396 explicit MethodParamListDescriptorIterator(mirror::ArtMethod* res_method) : 3397 res_method_(res_method), pos_(0), params_(res_method->GetParameterTypeList()), 3398 params_size_(params_ == nullptr ? 0 : params_->Size()) { 3399 } 3400 3401 bool HasNext() { 3402 return pos_ < params_size_; 3403 } 3404 3405 void Next() { 3406 ++pos_; 3407 } 3408 3409 const char* GetDescriptor() SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { 3410 return res_method_->GetTypeDescriptorFromTypeIdx(params_->GetTypeItem(pos_).type_idx_); 3411 } 3412 3413 private: 3414 mirror::ArtMethod* res_method_; 3415 size_t pos_; 3416 const DexFile::TypeList* params_; 3417 const size_t params_size_; 3418}; 3419 3420mirror::ArtMethod* MethodVerifier::VerifyInvocationArgs(const Instruction* inst, 3421 MethodType method_type, 3422 bool is_range, 3423 bool is_super) { 3424 // Resolve the method. This could be an abstract or concrete method depending on what sort of call 3425 // we're making. 3426 const uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 3427 3428 mirror::ArtMethod* res_method = ResolveMethodAndCheckAccess(method_idx, method_type); 3429 if (res_method == nullptr) { // error or class is unresolved 3430 // Check what we can statically. 3431 if (!have_pending_hard_failure_) { 3432 VerifyInvocationArgsUnresolvedMethod(inst, method_type, is_range); 3433 } 3434 return nullptr; 3435 } 3436 3437 // If we're using invoke-super(method), make sure that the executing method's class' superclass 3438 // has a vtable entry for the target method. 3439 if (is_super) { 3440 DCHECK(method_type == METHOD_VIRTUAL); 3441 const RegType& super = GetDeclaringClass().GetSuperClass(®_types_); 3442 if (super.IsUnresolvedTypes()) { 3443 Fail(VERIFY_ERROR_NO_METHOD) << "unknown super class in invoke-super from " 3444 << PrettyMethod(dex_method_idx_, *dex_file_) 3445 << " to super " << PrettyMethod(res_method); 3446 return nullptr; 3447 } 3448 mirror::Class* super_klass = super.GetClass(); 3449 if (res_method->GetMethodIndex() >= super_klass->GetVTableLength()) { 3450 Fail(VERIFY_ERROR_NO_METHOD) << "invalid invoke-super from " 3451 << PrettyMethod(dex_method_idx_, *dex_file_) 3452 << " to super " << super 3453 << "." << res_method->GetName() 3454 << res_method->GetSignature(); 3455 return nullptr; 3456 } 3457 } 3458 3459 // Process the target method's signature. This signature may or may not 3460 MethodParamListDescriptorIterator it(res_method); 3461 return VerifyInvocationArgsFromIterator<MethodParamListDescriptorIterator>(&it, inst, method_type, 3462 is_range, res_method); 3463} 3464 3465mirror::ArtMethod* MethodVerifier::GetQuickInvokedMethod(const Instruction* inst, 3466 RegisterLine* reg_line, bool is_range, 3467 bool allow_failure) { 3468 if (is_range) { 3469 DCHECK_EQ(inst->Opcode(), Instruction::INVOKE_VIRTUAL_RANGE_QUICK); 3470 } else { 3471 DCHECK_EQ(inst->Opcode(), Instruction::INVOKE_VIRTUAL_QUICK); 3472 } 3473 const RegType& actual_arg_type = reg_line->GetInvocationThis(this, inst, is_range, allow_failure); 3474 if (!actual_arg_type.HasClass()) { 3475 VLOG(verifier) << "Failed to get mirror::Class* from '" << actual_arg_type << "'"; 3476 return nullptr; 3477 } 3478 mirror::Class* klass = actual_arg_type.GetClass(); 3479 mirror::Class* dispatch_class; 3480 if (klass->IsInterface()) { 3481 // Derive Object.class from Class.class.getSuperclass(). 3482 mirror::Class* object_klass = klass->GetClass()->GetSuperClass(); 3483 if (FailOrAbort(this, object_klass->IsObjectClass(), 3484 "Failed to find Object class in quickened invoke receiver", work_insn_idx_)) { 3485 return nullptr; 3486 } 3487 dispatch_class = object_klass; 3488 } else { 3489 dispatch_class = klass; 3490 } 3491 if (!dispatch_class->HasVTable()) { 3492 FailOrAbort(this, allow_failure, "Receiver class has no vtable for quickened invoke at ", 3493 work_insn_idx_); 3494 return nullptr; 3495 } 3496 uint16_t vtable_index = is_range ? inst->VRegB_3rc() : inst->VRegB_35c(); 3497 if (static_cast<int32_t>(vtable_index) >= dispatch_class->GetVTableLength()) { 3498 FailOrAbort(this, allow_failure, 3499 "Receiver class has not enough vtable slots for quickened invoke at ", 3500 work_insn_idx_); 3501 return nullptr; 3502 } 3503 mirror::ArtMethod* res_method = dispatch_class->GetVTableEntry(vtable_index); 3504 if (self_->IsExceptionPending()) { 3505 FailOrAbort(this, allow_failure, "Unexpected exception pending for quickened invoke at ", 3506 work_insn_idx_); 3507 return nullptr; 3508 } 3509 return res_method; 3510} 3511 3512mirror::ArtMethod* MethodVerifier::VerifyInvokeVirtualQuickArgs(const Instruction* inst, 3513 bool is_range) { 3514 DCHECK(Runtime::Current()->IsStarted() || verify_to_dump_) 3515 << PrettyMethod(dex_method_idx_, *dex_file_, true) << "@" << work_insn_idx_; 3516 3517 mirror::ArtMethod* res_method = GetQuickInvokedMethod(inst, work_line_.get(), is_range, false); 3518 if (res_method == nullptr) { 3519 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Cannot infer method from " << inst->Name(); 3520 return nullptr; 3521 } 3522 if (FailOrAbort(this, !res_method->IsDirect(), "Quick-invoked method is direct at ", 3523 work_insn_idx_)) { 3524 return nullptr; 3525 } 3526 if (FailOrAbort(this, !res_method->IsStatic(), "Quick-invoked method is static at ", 3527 work_insn_idx_)) { 3528 return nullptr; 3529 } 3530 3531 // We use vAA as our expected arg count, rather than res_method->insSize, because we need to 3532 // match the call to the signature. Also, we might be calling through an abstract method 3533 // definition (which doesn't have register count values). 3534 const RegType& actual_arg_type = work_line_->GetInvocationThis(this, inst, is_range); 3535 if (actual_arg_type.IsConflict()) { // GetInvocationThis failed. 3536 return nullptr; 3537 } 3538 const size_t expected_args = (is_range) ? inst->VRegA_3rc() : inst->VRegA_35c(); 3539 /* caught by static verifier */ 3540 DCHECK(is_range || expected_args <= 5); 3541 if (expected_args > code_item_->outs_size_) { 3542 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid argument count (" << expected_args 3543 << ") exceeds outsSize (" << code_item_->outs_size_ << ")"; 3544 return nullptr; 3545 } 3546 3547 /* 3548 * Check the "this" argument, which must be an instance of the class that declared the method. 3549 * For an interface class, we don't do the full interface merge (see JoinClass), so we can't do a 3550 * rigorous check here (which is okay since we have to do it at runtime). 3551 */ 3552 if (actual_arg_type.IsUninitializedReference() && !res_method->IsConstructor()) { 3553 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "'this' arg must be initialized"; 3554 return nullptr; 3555 } 3556 if (!actual_arg_type.IsZero()) { 3557 mirror::Class* klass = res_method->GetDeclaringClass(); 3558 std::string temp; 3559 const RegType& res_method_class = 3560 reg_types_.FromClass(klass->GetDescriptor(&temp), klass, 3561 klass->CannotBeAssignedFromOtherTypes()); 3562 if (!res_method_class.IsAssignableFrom(actual_arg_type)) { 3563 Fail(actual_arg_type.IsUnresolvedTypes() ? VERIFY_ERROR_NO_CLASS : 3564 VERIFY_ERROR_BAD_CLASS_SOFT) << "'this' argument '" << actual_arg_type 3565 << "' not instance of '" << res_method_class << "'"; 3566 return nullptr; 3567 } 3568 } 3569 /* 3570 * Process the target method's signature. This signature may or may not 3571 * have been verified, so we can't assume it's properly formed. 3572 */ 3573 const DexFile::TypeList* params = res_method->GetParameterTypeList(); 3574 size_t params_size = params == nullptr ? 0 : params->Size(); 3575 uint32_t arg[5]; 3576 if (!is_range) { 3577 inst->GetVarArgs(arg); 3578 } 3579 size_t actual_args = 1; 3580 for (size_t param_index = 0; param_index < params_size; param_index++) { 3581 if (actual_args >= expected_args) { 3582 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invalid call to '" << PrettyMethod(res_method) 3583 << "'. Expected " << expected_args 3584 << " arguments, processing argument " << actual_args 3585 << " (where longs/doubles count twice)."; 3586 return nullptr; 3587 } 3588 const char* descriptor = 3589 res_method->GetTypeDescriptorFromTypeIdx(params->GetTypeItem(param_index).type_idx_); 3590 if (descriptor == nullptr) { 3591 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation of " << PrettyMethod(res_method) 3592 << " missing signature component"; 3593 return nullptr; 3594 } 3595 const RegType& reg_type = reg_types_.FromDescriptor(GetClassLoader(), descriptor, false); 3596 uint32_t get_reg = is_range ? inst->VRegC_3rc() + actual_args : arg[actual_args]; 3597 if (!work_line_->VerifyRegisterType(this, get_reg, reg_type)) { 3598 return res_method; 3599 } 3600 actual_args = reg_type.IsLongOrDoubleTypes() ? actual_args + 2 : actual_args + 1; 3601 } 3602 if (actual_args != expected_args) { 3603 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation of " << PrettyMethod(res_method) 3604 << " expected " << expected_args << " arguments, found " << actual_args; 3605 return nullptr; 3606 } else { 3607 return res_method; 3608 } 3609} 3610 3611void MethodVerifier::VerifyNewArray(const Instruction* inst, bool is_filled, bool is_range) { 3612 uint32_t type_idx; 3613 if (!is_filled) { 3614 DCHECK_EQ(inst->Opcode(), Instruction::NEW_ARRAY); 3615 type_idx = inst->VRegC_22c(); 3616 } else if (!is_range) { 3617 DCHECK_EQ(inst->Opcode(), Instruction::FILLED_NEW_ARRAY); 3618 type_idx = inst->VRegB_35c(); 3619 } else { 3620 DCHECK_EQ(inst->Opcode(), Instruction::FILLED_NEW_ARRAY_RANGE); 3621 type_idx = inst->VRegB_3rc(); 3622 } 3623 const RegType& res_type = ResolveClassAndCheckAccess(type_idx); 3624 if (res_type.IsConflict()) { // bad class 3625 DCHECK_NE(failures_.size(), 0U); 3626 } else { 3627 // TODO: check Compiler::CanAccessTypeWithoutChecks returns false when res_type is unresolved 3628 if (!res_type.IsArrayTypes()) { 3629 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "new-array on non-array class " << res_type; 3630 } else if (!is_filled) { 3631 /* make sure "size" register is valid type */ 3632 work_line_->VerifyRegisterType(this, inst->VRegB_22c(), reg_types_.Integer()); 3633 /* set register type to array class */ 3634 const RegType& precise_type = reg_types_.FromUninitialized(res_type); 3635 work_line_->SetRegisterType(this, inst->VRegA_22c(), precise_type); 3636 } else { 3637 // Verify each register. If "arg_count" is bad, VerifyRegisterType() will run off the end of 3638 // the list and fail. It's legal, if silly, for arg_count to be zero. 3639 const RegType& expected_type = reg_types_.GetComponentType(res_type, GetClassLoader()); 3640 uint32_t arg_count = (is_range) ? inst->VRegA_3rc() : inst->VRegA_35c(); 3641 uint32_t arg[5]; 3642 if (!is_range) { 3643 inst->GetVarArgs(arg); 3644 } 3645 for (size_t ui = 0; ui < arg_count; ui++) { 3646 uint32_t get_reg = is_range ? inst->VRegC_3rc() + ui : arg[ui]; 3647 if (!work_line_->VerifyRegisterType(this, get_reg, expected_type)) { 3648 work_line_->SetResultRegisterType(this, reg_types_.Conflict()); 3649 return; 3650 } 3651 } 3652 // filled-array result goes into "result" register 3653 const RegType& precise_type = reg_types_.FromUninitialized(res_type); 3654 work_line_->SetResultRegisterType(this, precise_type); 3655 } 3656 } 3657} 3658 3659void MethodVerifier::VerifyAGet(const Instruction* inst, 3660 const RegType& insn_type, bool is_primitive) { 3661 const RegType& index_type = work_line_->GetRegisterType(this, inst->VRegC_23x()); 3662 if (!index_type.IsArrayIndexTypes()) { 3663 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Invalid reg type for array index (" << index_type << ")"; 3664 } else { 3665 const RegType& array_type = work_line_->GetRegisterType(this, inst->VRegB_23x()); 3666 if (array_type.IsZero()) { 3667 // Null array class; this code path will fail at runtime. Infer a merge-able type from the 3668 // instruction type. TODO: have a proper notion of bottom here. 3669 if (!is_primitive || insn_type.IsCategory1Types()) { 3670 // Reference or category 1 3671 work_line_->SetRegisterType(this, inst->VRegA_23x(), reg_types_.Zero()); 3672 } else { 3673 // Category 2 3674 work_line_->SetRegisterTypeWide(this, inst->VRegA_23x(), 3675 reg_types_.FromCat2ConstLo(0, false), 3676 reg_types_.FromCat2ConstHi(0, false)); 3677 } 3678 } else if (!array_type.IsArrayTypes()) { 3679 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "not array type " << array_type << " with aget"; 3680 } else { 3681 /* verify the class */ 3682 const RegType& component_type = reg_types_.GetComponentType(array_type, GetClassLoader()); 3683 if (!component_type.IsReferenceTypes() && !is_primitive) { 3684 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "primitive array type " << array_type 3685 << " source for aget-object"; 3686 } else if (component_type.IsNonZeroReferenceTypes() && is_primitive) { 3687 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "reference array type " << array_type 3688 << " source for category 1 aget"; 3689 } else if (is_primitive && !insn_type.Equals(component_type) && 3690 !((insn_type.IsInteger() && component_type.IsFloat()) || 3691 (insn_type.IsLong() && component_type.IsDouble()))) { 3692 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "array type " << array_type 3693 << " incompatible with aget of type " << insn_type; 3694 } else { 3695 // Use knowledge of the field type which is stronger than the type inferred from the 3696 // instruction, which can't differentiate object types and ints from floats, longs from 3697 // doubles. 3698 if (!component_type.IsLowHalf()) { 3699 work_line_->SetRegisterType(this, inst->VRegA_23x(), component_type); 3700 } else { 3701 work_line_->SetRegisterTypeWide(this, inst->VRegA_23x(), component_type, 3702 component_type.HighHalf(®_types_)); 3703 } 3704 } 3705 } 3706 } 3707} 3708 3709void MethodVerifier::VerifyPrimitivePut(const RegType& target_type, const RegType& insn_type, 3710 const uint32_t vregA) { 3711 // Primitive assignability rules are weaker than regular assignability rules. 3712 bool instruction_compatible; 3713 bool value_compatible; 3714 const RegType& value_type = work_line_->GetRegisterType(this, vregA); 3715 if (target_type.IsIntegralTypes()) { 3716 instruction_compatible = target_type.Equals(insn_type); 3717 value_compatible = value_type.IsIntegralTypes(); 3718 } else if (target_type.IsFloat()) { 3719 instruction_compatible = insn_type.IsInteger(); // no put-float, so expect put-int 3720 value_compatible = value_type.IsFloatTypes(); 3721 } else if (target_type.IsLong()) { 3722 instruction_compatible = insn_type.IsLong(); 3723 // Additional register check: this is not checked statically (as part of VerifyInstructions), 3724 // as target_type depends on the resolved type of the field. 3725 if (instruction_compatible && work_line_->NumRegs() > vregA + 1) { 3726 const RegType& value_type_hi = work_line_->GetRegisterType(this, vregA + 1); 3727 value_compatible = value_type.IsLongTypes() && value_type.CheckWidePair(value_type_hi); 3728 } else { 3729 value_compatible = false; 3730 } 3731 } else if (target_type.IsDouble()) { 3732 instruction_compatible = insn_type.IsLong(); // no put-double, so expect put-long 3733 // Additional register check: this is not checked statically (as part of VerifyInstructions), 3734 // as target_type depends on the resolved type of the field. 3735 if (instruction_compatible && work_line_->NumRegs() > vregA + 1) { 3736 const RegType& value_type_hi = work_line_->GetRegisterType(this, vregA + 1); 3737 value_compatible = value_type.IsDoubleTypes() && value_type.CheckWidePair(value_type_hi); 3738 } else { 3739 value_compatible = false; 3740 } 3741 } else { 3742 instruction_compatible = false; // reference with primitive store 3743 value_compatible = false; // unused 3744 } 3745 if (!instruction_compatible) { 3746 // This is a global failure rather than a class change failure as the instructions and 3747 // the descriptors for the type should have been consistent within the same file at 3748 // compile time. 3749 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "put insn has type '" << insn_type 3750 << "' but expected type '" << target_type << "'"; 3751 return; 3752 } 3753 if (!value_compatible) { 3754 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected value in v" << vregA 3755 << " of type " << value_type << " but expected " << target_type << " for put"; 3756 return; 3757 } 3758} 3759 3760void MethodVerifier::VerifyAPut(const Instruction* inst, 3761 const RegType& insn_type, bool is_primitive) { 3762 const RegType& index_type = work_line_->GetRegisterType(this, inst->VRegC_23x()); 3763 if (!index_type.IsArrayIndexTypes()) { 3764 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Invalid reg type for array index (" << index_type << ")"; 3765 } else { 3766 const RegType& array_type = work_line_->GetRegisterType(this, inst->VRegB_23x()); 3767 if (array_type.IsZero()) { 3768 // Null array type; this code path will fail at runtime. Infer a merge-able type from the 3769 // instruction type. 3770 } else if (!array_type.IsArrayTypes()) { 3771 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "not array type " << array_type << " with aput"; 3772 } else { 3773 const RegType& component_type = reg_types_.GetComponentType(array_type, GetClassLoader()); 3774 const uint32_t vregA = inst->VRegA_23x(); 3775 if (is_primitive) { 3776 VerifyPrimitivePut(component_type, insn_type, vregA); 3777 } else { 3778 if (!component_type.IsReferenceTypes()) { 3779 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "primitive array type " << array_type 3780 << " source for aput-object"; 3781 } else { 3782 // The instruction agrees with the type of array, confirm the value to be stored does too 3783 // Note: we use the instruction type (rather than the component type) for aput-object as 3784 // incompatible classes will be caught at runtime as an array store exception 3785 work_line_->VerifyRegisterType(this, vregA, insn_type); 3786 } 3787 } 3788 } 3789 } 3790} 3791 3792mirror::ArtField* MethodVerifier::GetStaticField(int field_idx) { 3793 const DexFile::FieldId& field_id = dex_file_->GetFieldId(field_idx); 3794 // Check access to class 3795 const RegType& klass_type = ResolveClassAndCheckAccess(field_id.class_idx_); 3796 if (klass_type.IsConflict()) { // bad class 3797 AppendToLastFailMessage(StringPrintf(" in attempt to access static field %d (%s) in %s", 3798 field_idx, dex_file_->GetFieldName(field_id), 3799 dex_file_->GetFieldDeclaringClassDescriptor(field_id))); 3800 return nullptr; 3801 } 3802 if (klass_type.IsUnresolvedTypes()) { 3803 return nullptr; // Can't resolve Class so no more to do here, will do checking at runtime. 3804 } 3805 ClassLinker* class_linker = Runtime::Current()->GetClassLinker(); 3806 mirror::ArtField* field = class_linker->ResolveFieldJLS(*dex_file_, field_idx, dex_cache_, 3807 class_loader_); 3808 if (field == nullptr) { 3809 VLOG(verifier) << "Unable to resolve static field " << field_idx << " (" 3810 << dex_file_->GetFieldName(field_id) << ") in " 3811 << dex_file_->GetFieldDeclaringClassDescriptor(field_id); 3812 DCHECK(self_->IsExceptionPending()); 3813 self_->ClearException(); 3814 return nullptr; 3815 } else if (!GetDeclaringClass().CanAccessMember(field->GetDeclaringClass(), 3816 field->GetAccessFlags())) { 3817 Fail(VERIFY_ERROR_ACCESS_FIELD) << "cannot access static field " << PrettyField(field) 3818 << " from " << GetDeclaringClass(); 3819 return nullptr; 3820 } else if (!field->IsStatic()) { 3821 Fail(VERIFY_ERROR_CLASS_CHANGE) << "expected field " << PrettyField(field) << " to be static"; 3822 return nullptr; 3823 } 3824 return field; 3825} 3826 3827mirror::ArtField* MethodVerifier::GetInstanceField(const RegType& obj_type, int field_idx) { 3828 const DexFile::FieldId& field_id = dex_file_->GetFieldId(field_idx); 3829 // Check access to class 3830 const RegType& klass_type = ResolveClassAndCheckAccess(field_id.class_idx_); 3831 if (klass_type.IsConflict()) { 3832 AppendToLastFailMessage(StringPrintf(" in attempt to access instance field %d (%s) in %s", 3833 field_idx, dex_file_->GetFieldName(field_id), 3834 dex_file_->GetFieldDeclaringClassDescriptor(field_id))); 3835 return nullptr; 3836 } 3837 if (klass_type.IsUnresolvedTypes()) { 3838 return nullptr; // Can't resolve Class so no more to do here 3839 } 3840 ClassLinker* class_linker = Runtime::Current()->GetClassLinker(); 3841 mirror::ArtField* field = class_linker->ResolveFieldJLS(*dex_file_, field_idx, dex_cache_, 3842 class_loader_); 3843 if (field == nullptr) { 3844 VLOG(verifier) << "Unable to resolve instance field " << field_idx << " (" 3845 << dex_file_->GetFieldName(field_id) << ") in " 3846 << dex_file_->GetFieldDeclaringClassDescriptor(field_id); 3847 DCHECK(self_->IsExceptionPending()); 3848 self_->ClearException(); 3849 return nullptr; 3850 } else if (!GetDeclaringClass().CanAccessMember(field->GetDeclaringClass(), 3851 field->GetAccessFlags())) { 3852 Fail(VERIFY_ERROR_ACCESS_FIELD) << "cannot access instance field " << PrettyField(field) 3853 << " from " << GetDeclaringClass(); 3854 return nullptr; 3855 } else if (field->IsStatic()) { 3856 Fail(VERIFY_ERROR_CLASS_CHANGE) << "expected field " << PrettyField(field) 3857 << " to not be static"; 3858 return nullptr; 3859 } else if (obj_type.IsZero()) { 3860 // Cannot infer and check type, however, access will cause null pointer exception 3861 return field; 3862 } else if (!obj_type.IsReferenceTypes()) { 3863 // Trying to read a field from something that isn't a reference 3864 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "instance field access on object that has " 3865 << "non-reference type " << obj_type; 3866 return nullptr; 3867 } else { 3868 mirror::Class* klass = field->GetDeclaringClass(); 3869 const RegType& field_klass = 3870 reg_types_.FromClass(dex_file_->GetFieldDeclaringClassDescriptor(field_id), 3871 klass, klass->CannotBeAssignedFromOtherTypes()); 3872 if (obj_type.IsUninitializedTypes() && 3873 (!IsConstructor() || GetDeclaringClass().Equals(obj_type) || 3874 !field_klass.Equals(GetDeclaringClass()))) { 3875 // Field accesses through uninitialized references are only allowable for constructors where 3876 // the field is declared in this class 3877 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "cannot access instance field " << PrettyField(field) 3878 << " of a not fully initialized object within the context" 3879 << " of " << PrettyMethod(dex_method_idx_, *dex_file_); 3880 return nullptr; 3881 } else if (!field_klass.IsAssignableFrom(obj_type)) { 3882 // Trying to access C1.field1 using reference of type C2, which is neither C1 or a sub-class 3883 // of C1. For resolution to occur the declared class of the field must be compatible with 3884 // obj_type, we've discovered this wasn't so, so report the field didn't exist. 3885 Fail(VERIFY_ERROR_NO_FIELD) << "cannot access instance field " << PrettyField(field) 3886 << " from object of type " << obj_type; 3887 return nullptr; 3888 } else { 3889 return field; 3890 } 3891 } 3892} 3893 3894template <MethodVerifier::FieldAccessType kAccType> 3895void MethodVerifier::VerifyISFieldAccess(const Instruction* inst, const RegType& insn_type, 3896 bool is_primitive, bool is_static) { 3897 uint32_t field_idx = is_static ? inst->VRegB_21c() : inst->VRegC_22c(); 3898 mirror::ArtField* field; 3899 if (is_static) { 3900 field = GetStaticField(field_idx); 3901 } else { 3902 const RegType& object_type = work_line_->GetRegisterType(this, inst->VRegB_22c()); 3903 field = GetInstanceField(object_type, field_idx); 3904 if (UNLIKELY(have_pending_hard_failure_)) { 3905 return; 3906 } 3907 } 3908 const RegType* field_type = nullptr; 3909 if (field != nullptr) { 3910 if (kAccType == FieldAccessType::kAccPut) { 3911 if (field->IsFinal() && field->GetDeclaringClass() != GetDeclaringClass().GetClass()) { 3912 Fail(VERIFY_ERROR_ACCESS_FIELD) << "cannot modify final field " << PrettyField(field) 3913 << " from other class " << GetDeclaringClass(); 3914 return; 3915 } 3916 } 3917 3918 mirror::Class* field_type_class; 3919 { 3920 StackHandleScope<1> hs(self_); 3921 HandleWrapper<mirror::ArtField> h_field(hs.NewHandleWrapper(&field)); 3922 field_type_class = can_load_classes_ ? h_field->GetType<true>() : h_field->GetType<false>(); 3923 } 3924 if (field_type_class != nullptr) { 3925 field_type = ®_types_.FromClass(field->GetTypeDescriptor(), field_type_class, 3926 field_type_class->CannotBeAssignedFromOtherTypes()); 3927 } else { 3928 DCHECK(!can_load_classes_ || self_->IsExceptionPending()); 3929 self_->ClearException(); 3930 } 3931 } 3932 if (field_type == nullptr) { 3933 const DexFile::FieldId& field_id = dex_file_->GetFieldId(field_idx); 3934 const char* descriptor = dex_file_->GetFieldTypeDescriptor(field_id); 3935 field_type = ®_types_.FromDescriptor(GetClassLoader(), descriptor, false); 3936 } 3937 DCHECK(field_type != nullptr); 3938 const uint32_t vregA = (is_static) ? inst->VRegA_21c() : inst->VRegA_22c(); 3939 static_assert(kAccType == FieldAccessType::kAccPut || kAccType == FieldAccessType::kAccGet, 3940 "Unexpected third access type"); 3941 if (kAccType == FieldAccessType::kAccPut) { 3942 // sput or iput. 3943 if (is_primitive) { 3944 VerifyPrimitivePut(*field_type, insn_type, vregA); 3945 } else { 3946 if (!insn_type.IsAssignableFrom(*field_type)) { 3947 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "expected field " << PrettyField(field) 3948 << " to be compatible with type '" << insn_type 3949 << "' but found type '" << *field_type 3950 << "' in put-object"; 3951 return; 3952 } 3953 work_line_->VerifyRegisterType(this, vregA, *field_type); 3954 } 3955 } else if (kAccType == FieldAccessType::kAccGet) { 3956 // sget or iget. 3957 if (is_primitive) { 3958 if (field_type->Equals(insn_type) || 3959 (field_type->IsFloat() && insn_type.IsInteger()) || 3960 (field_type->IsDouble() && insn_type.IsLong())) { 3961 // expected that read is of the correct primitive type or that int reads are reading 3962 // floats or long reads are reading doubles 3963 } else { 3964 // This is a global failure rather than a class change failure as the instructions and 3965 // the descriptors for the type should have been consistent within the same file at 3966 // compile time 3967 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected field " << PrettyField(field) 3968 << " to be of type '" << insn_type 3969 << "' but found type '" << *field_type << "' in get"; 3970 return; 3971 } 3972 } else { 3973 if (!insn_type.IsAssignableFrom(*field_type)) { 3974 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "expected field " << PrettyField(field) 3975 << " to be compatible with type '" << insn_type 3976 << "' but found type '" << *field_type 3977 << "' in get-object"; 3978 work_line_->SetRegisterType(this, vregA, reg_types_.Conflict()); 3979 return; 3980 } 3981 } 3982 if (!field_type->IsLowHalf()) { 3983 work_line_->SetRegisterType(this, vregA, *field_type); 3984 } else { 3985 work_line_->SetRegisterTypeWide(this, vregA, *field_type, field_type->HighHalf(®_types_)); 3986 } 3987 } else { 3988 LOG(FATAL) << "Unexpected case."; 3989 } 3990} 3991 3992mirror::ArtField* MethodVerifier::GetQuickFieldAccess(const Instruction* inst, 3993 RegisterLine* reg_line) { 3994 DCHECK(IsInstructionIGetQuickOrIPutQuick(inst->Opcode())) << inst->Opcode(); 3995 const RegType& object_type = reg_line->GetRegisterType(this, inst->VRegB_22c()); 3996 if (!object_type.HasClass()) { 3997 VLOG(verifier) << "Failed to get mirror::Class* from '" << object_type << "'"; 3998 return nullptr; 3999 } 4000 uint32_t field_offset = static_cast<uint32_t>(inst->VRegC_22c()); 4001 mirror::ArtField* const f = mirror::ArtField::FindInstanceFieldWithOffset(object_type.GetClass(), 4002 field_offset); 4003 DCHECK_EQ(f->GetOffset().Uint32Value(), field_offset); 4004 if (f == nullptr) { 4005 VLOG(verifier) << "Failed to find instance field at offset '" << field_offset 4006 << "' from '" << PrettyDescriptor(object_type.GetClass()) << "'"; 4007 } 4008 return f; 4009} 4010 4011template <MethodVerifier::FieldAccessType kAccType> 4012void MethodVerifier::VerifyQuickFieldAccess(const Instruction* inst, const RegType& insn_type, 4013 bool is_primitive) { 4014 DCHECK(Runtime::Current()->IsStarted() || verify_to_dump_); 4015 4016 mirror::ArtField* field = GetQuickFieldAccess(inst, work_line_.get()); 4017 if (field == nullptr) { 4018 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Cannot infer field from " << inst->Name(); 4019 return; 4020 } 4021 4022 // For an IPUT_QUICK, we now test for final flag of the field. 4023 if (kAccType == FieldAccessType::kAccPut) { 4024 if (field->IsFinal() && field->GetDeclaringClass() != GetDeclaringClass().GetClass()) { 4025 Fail(VERIFY_ERROR_ACCESS_FIELD) << "cannot modify final field " << PrettyField(field) 4026 << " from other class " << GetDeclaringClass(); 4027 return; 4028 } 4029 } 4030 4031 // Get the field type. 4032 const RegType* field_type; 4033 { 4034 mirror::Class* field_type_class; 4035 { 4036 StackHandleScope<1> hs(Thread::Current()); 4037 HandleWrapper<mirror::ArtField> h_field(hs.NewHandleWrapper(&field)); 4038 field_type_class = can_load_classes_ ? h_field->GetType<true>() : h_field->GetType<false>(); 4039 } 4040 4041 if (field_type_class != nullptr) { 4042 field_type = ®_types_.FromClass(field->GetTypeDescriptor(), field_type_class, 4043 field_type_class->CannotBeAssignedFromOtherTypes()); 4044 } else { 4045 Thread* self = Thread::Current(); 4046 DCHECK(!can_load_classes_ || self->IsExceptionPending()); 4047 self->ClearException(); 4048 field_type = ®_types_.FromDescriptor(field->GetDeclaringClass()->GetClassLoader(), 4049 field->GetTypeDescriptor(), false); 4050 } 4051 if (field_type == nullptr) { 4052 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Cannot infer field type from " << inst->Name(); 4053 return; 4054 } 4055 } 4056 4057 const uint32_t vregA = inst->VRegA_22c(); 4058 static_assert(kAccType == FieldAccessType::kAccPut || kAccType == FieldAccessType::kAccGet, 4059 "Unexpected third access type"); 4060 if (kAccType == FieldAccessType::kAccPut) { 4061 if (is_primitive) { 4062 // Primitive field assignability rules are weaker than regular assignability rules 4063 bool instruction_compatible; 4064 bool value_compatible; 4065 const RegType& value_type = work_line_->GetRegisterType(this, vregA); 4066 if (field_type->IsIntegralTypes()) { 4067 instruction_compatible = insn_type.IsIntegralTypes(); 4068 value_compatible = value_type.IsIntegralTypes(); 4069 } else if (field_type->IsFloat()) { 4070 instruction_compatible = insn_type.IsInteger(); // no [is]put-float, so expect [is]put-int 4071 value_compatible = value_type.IsFloatTypes(); 4072 } else if (field_type->IsLong()) { 4073 instruction_compatible = insn_type.IsLong(); 4074 value_compatible = value_type.IsLongTypes(); 4075 } else if (field_type->IsDouble()) { 4076 instruction_compatible = insn_type.IsLong(); // no [is]put-double, so expect [is]put-long 4077 value_compatible = value_type.IsDoubleTypes(); 4078 } else { 4079 instruction_compatible = false; // reference field with primitive store 4080 value_compatible = false; // unused 4081 } 4082 if (!instruction_compatible) { 4083 // This is a global failure rather than a class change failure as the instructions and 4084 // the descriptors for the type should have been consistent within the same file at 4085 // compile time 4086 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected field " << PrettyField(field) 4087 << " to be of type '" << insn_type 4088 << "' but found type '" << *field_type 4089 << "' in put"; 4090 return; 4091 } 4092 if (!value_compatible) { 4093 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected value in v" << vregA 4094 << " of type " << value_type 4095 << " but expected " << *field_type 4096 << " for store to " << PrettyField(field) << " in put"; 4097 return; 4098 } 4099 } else { 4100 if (!insn_type.IsAssignableFrom(*field_type)) { 4101 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "expected field " << PrettyField(field) 4102 << " to be compatible with type '" << insn_type 4103 << "' but found type '" << *field_type 4104 << "' in put-object"; 4105 return; 4106 } 4107 work_line_->VerifyRegisterType(this, vregA, *field_type); 4108 } 4109 } else if (kAccType == FieldAccessType::kAccGet) { 4110 if (is_primitive) { 4111 if (field_type->Equals(insn_type) || 4112 (field_type->IsFloat() && insn_type.IsIntegralTypes()) || 4113 (field_type->IsDouble() && insn_type.IsLongTypes())) { 4114 // expected that read is of the correct primitive type or that int reads are reading 4115 // floats or long reads are reading doubles 4116 } else { 4117 // This is a global failure rather than a class change failure as the instructions and 4118 // the descriptors for the type should have been consistent within the same file at 4119 // compile time 4120 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected field " << PrettyField(field) 4121 << " to be of type '" << insn_type 4122 << "' but found type '" << *field_type << "' in Get"; 4123 return; 4124 } 4125 } else { 4126 if (!insn_type.IsAssignableFrom(*field_type)) { 4127 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "expected field " << PrettyField(field) 4128 << " to be compatible with type '" << insn_type 4129 << "' but found type '" << *field_type 4130 << "' in get-object"; 4131 work_line_->SetRegisterType(this, vregA, reg_types_.Conflict()); 4132 return; 4133 } 4134 } 4135 if (!field_type->IsLowHalf()) { 4136 work_line_->SetRegisterType(this, vregA, *field_type); 4137 } else { 4138 work_line_->SetRegisterTypeWide(this, vregA, *field_type, field_type->HighHalf(®_types_)); 4139 } 4140 } else { 4141 LOG(FATAL) << "Unexpected case."; 4142 } 4143} 4144 4145bool MethodVerifier::CheckNotMoveException(const uint16_t* insns, int insn_idx) { 4146 if ((insns[insn_idx] & 0xff) == Instruction::MOVE_EXCEPTION) { 4147 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid use of move-exception"; 4148 return false; 4149 } 4150 return true; 4151} 4152 4153bool MethodVerifier::CheckNotMoveResult(const uint16_t* insns, int insn_idx) { 4154 if (((insns[insn_idx] & 0xff) >= Instruction::MOVE_RESULT) && 4155 ((insns[insn_idx] & 0xff) <= Instruction::MOVE_RESULT_OBJECT)) { 4156 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid use of move-result*"; 4157 return false; 4158 } 4159 return true; 4160} 4161 4162bool MethodVerifier::CheckNotMoveExceptionOrMoveResult(const uint16_t* insns, int insn_idx) { 4163 return (CheckNotMoveException(insns, insn_idx) && CheckNotMoveResult(insns, insn_idx)); 4164} 4165 4166bool MethodVerifier::UpdateRegisters(uint32_t next_insn, RegisterLine* merge_line, 4167 bool update_merge_line) { 4168 bool changed = true; 4169 RegisterLine* target_line = reg_table_.GetLine(next_insn); 4170 if (!insn_flags_[next_insn].IsVisitedOrChanged()) { 4171 /* 4172 * We haven't processed this instruction before, and we haven't touched the registers here, so 4173 * there's nothing to "merge". Copy the registers over and mark it as changed. (This is the 4174 * only way a register can transition out of "unknown", so this is not just an optimization.) 4175 */ 4176 if (!insn_flags_[next_insn].IsReturn()) { 4177 target_line->CopyFromLine(merge_line); 4178 } else { 4179 // Verify that the monitor stack is empty on return. 4180 if (!merge_line->VerifyMonitorStackEmpty(this)) { 4181 return false; 4182 } 4183 // For returns we only care about the operand to the return, all other registers are dead. 4184 // Initialize them as conflicts so they don't add to GC and deoptimization information. 4185 const Instruction* ret_inst = Instruction::At(code_item_->insns_ + next_insn); 4186 Instruction::Code opcode = ret_inst->Opcode(); 4187 if (opcode == Instruction::RETURN_VOID || opcode == Instruction::RETURN_VOID_NO_BARRIER) { 4188 SafelyMarkAllRegistersAsConflicts(this, target_line); 4189 } else { 4190 target_line->CopyFromLine(merge_line); 4191 if (opcode == Instruction::RETURN_WIDE) { 4192 target_line->MarkAllRegistersAsConflictsExceptWide(this, ret_inst->VRegA_11x()); 4193 } else { 4194 target_line->MarkAllRegistersAsConflictsExcept(this, ret_inst->VRegA_11x()); 4195 } 4196 } 4197 } 4198 } else { 4199 std::unique_ptr<RegisterLine> copy(gDebugVerify ? 4200 RegisterLine::Create(target_line->NumRegs(), this) : 4201 nullptr); 4202 if (gDebugVerify) { 4203 copy->CopyFromLine(target_line); 4204 } 4205 changed = target_line->MergeRegisters(this, merge_line); 4206 if (have_pending_hard_failure_) { 4207 return false; 4208 } 4209 if (gDebugVerify && changed) { 4210 LogVerifyInfo() << "Merging at [" << reinterpret_cast<void*>(work_insn_idx_) << "]" 4211 << " to [" << reinterpret_cast<void*>(next_insn) << "]: " << "\n" 4212 << copy->Dump(this) << " MERGE\n" 4213 << merge_line->Dump(this) << " ==\n" 4214 << target_line->Dump(this) << "\n"; 4215 } 4216 if (update_merge_line && changed) { 4217 merge_line->CopyFromLine(target_line); 4218 } 4219 } 4220 if (changed) { 4221 insn_flags_[next_insn].SetChanged(); 4222 } 4223 return true; 4224} 4225 4226InstructionFlags* MethodVerifier::CurrentInsnFlags() { 4227 return &insn_flags_[work_insn_idx_]; 4228} 4229 4230const RegType& MethodVerifier::GetMethodReturnType() { 4231 if (return_type_ == nullptr) { 4232 if (mirror_method_.Get() != nullptr) { 4233 mirror::Class* return_type_class = mirror_method_->GetReturnType(can_load_classes_); 4234 if (return_type_class != nullptr) { 4235 return_type_ = ®_types_.FromClass(mirror_method_->GetReturnTypeDescriptor(), 4236 return_type_class, 4237 return_type_class->CannotBeAssignedFromOtherTypes()); 4238 } else { 4239 DCHECK(!can_load_classes_ || self_->IsExceptionPending()); 4240 self_->ClearException(); 4241 } 4242 } 4243 if (return_type_ == nullptr) { 4244 const DexFile::MethodId& method_id = dex_file_->GetMethodId(dex_method_idx_); 4245 const DexFile::ProtoId& proto_id = dex_file_->GetMethodPrototype(method_id); 4246 uint16_t return_type_idx = proto_id.return_type_idx_; 4247 const char* descriptor = dex_file_->GetTypeDescriptor(dex_file_->GetTypeId(return_type_idx)); 4248 return_type_ = ®_types_.FromDescriptor(GetClassLoader(), descriptor, false); 4249 } 4250 } 4251 return *return_type_; 4252} 4253 4254const RegType& MethodVerifier::GetDeclaringClass() { 4255 if (declaring_class_ == nullptr) { 4256 const DexFile::MethodId& method_id = dex_file_->GetMethodId(dex_method_idx_); 4257 const char* descriptor 4258 = dex_file_->GetTypeDescriptor(dex_file_->GetTypeId(method_id.class_idx_)); 4259 if (mirror_method_.Get() != nullptr) { 4260 mirror::Class* klass = mirror_method_->GetDeclaringClass(); 4261 declaring_class_ = ®_types_.FromClass(descriptor, klass, 4262 klass->CannotBeAssignedFromOtherTypes()); 4263 } else { 4264 declaring_class_ = ®_types_.FromDescriptor(GetClassLoader(), descriptor, false); 4265 } 4266 } 4267 return *declaring_class_; 4268} 4269 4270std::vector<int32_t> MethodVerifier::DescribeVRegs(uint32_t dex_pc) { 4271 RegisterLine* line = reg_table_.GetLine(dex_pc); 4272 DCHECK(line != nullptr) << "No register line at DEX pc " << StringPrintf("0x%x", dex_pc); 4273 std::vector<int32_t> result; 4274 for (size_t i = 0; i < line->NumRegs(); ++i) { 4275 const RegType& type = line->GetRegisterType(this, i); 4276 if (type.IsConstant()) { 4277 result.push_back(type.IsPreciseConstant() ? kConstant : kImpreciseConstant); 4278 const ConstantType* const_val = down_cast<const ConstantType*>(&type); 4279 result.push_back(const_val->ConstantValue()); 4280 } else if (type.IsConstantLo()) { 4281 result.push_back(type.IsPreciseConstantLo() ? kConstant : kImpreciseConstant); 4282 const ConstantType* const_val = down_cast<const ConstantType*>(&type); 4283 result.push_back(const_val->ConstantValueLo()); 4284 } else if (type.IsConstantHi()) { 4285 result.push_back(type.IsPreciseConstantHi() ? kConstant : kImpreciseConstant); 4286 const ConstantType* const_val = down_cast<const ConstantType*>(&type); 4287 result.push_back(const_val->ConstantValueHi()); 4288 } else if (type.IsIntegralTypes()) { 4289 result.push_back(kIntVReg); 4290 result.push_back(0); 4291 } else if (type.IsFloat()) { 4292 result.push_back(kFloatVReg); 4293 result.push_back(0); 4294 } else if (type.IsLong()) { 4295 result.push_back(kLongLoVReg); 4296 result.push_back(0); 4297 result.push_back(kLongHiVReg); 4298 result.push_back(0); 4299 ++i; 4300 } else if (type.IsDouble()) { 4301 result.push_back(kDoubleLoVReg); 4302 result.push_back(0); 4303 result.push_back(kDoubleHiVReg); 4304 result.push_back(0); 4305 ++i; 4306 } else if (type.IsUndefined() || type.IsConflict() || type.IsHighHalf()) { 4307 result.push_back(kUndefined); 4308 result.push_back(0); 4309 } else { 4310 CHECK(type.IsNonZeroReferenceTypes()); 4311 result.push_back(kReferenceVReg); 4312 result.push_back(0); 4313 } 4314 } 4315 return result; 4316} 4317 4318const RegType& MethodVerifier::DetermineCat1Constant(int32_t value, bool precise) { 4319 if (precise) { 4320 // Precise constant type. 4321 return reg_types_.FromCat1Const(value, true); 4322 } else { 4323 // Imprecise constant type. 4324 if (value < -32768) { 4325 return reg_types_.IntConstant(); 4326 } else if (value < -128) { 4327 return reg_types_.ShortConstant(); 4328 } else if (value < 0) { 4329 return reg_types_.ByteConstant(); 4330 } else if (value == 0) { 4331 return reg_types_.Zero(); 4332 } else if (value == 1) { 4333 return reg_types_.One(); 4334 } else if (value < 128) { 4335 return reg_types_.PosByteConstant(); 4336 } else if (value < 32768) { 4337 return reg_types_.PosShortConstant(); 4338 } else if (value < 65536) { 4339 return reg_types_.CharConstant(); 4340 } else { 4341 return reg_types_.IntConstant(); 4342 } 4343 } 4344} 4345 4346void MethodVerifier::Init() { 4347 art::verifier::RegTypeCache::Init(); 4348} 4349 4350void MethodVerifier::Shutdown() { 4351 verifier::RegTypeCache::ShutDown(); 4352} 4353 4354void MethodVerifier::VisitStaticRoots(RootCallback* callback, void* arg) { 4355 RegTypeCache::VisitStaticRoots(callback, arg); 4356} 4357 4358void MethodVerifier::VisitRoots(RootCallback* callback, void* arg, const RootInfo& root_info) { 4359 reg_types_.VisitRoots(callback, arg, root_info); 4360} 4361 4362} // namespace verifier 4363} // namespace art 4364