History log of /external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
99bc9fdfb555f1cf8e426329633e735e3020b829 04-May-2015 egdaniel <egdaniel@google.com> Remove canTweakAlphaForCoverage from XP's since batch reads flag.

BUG=skia:

Review URL: https://codereview.chromium.org/1127693002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
36352bf5e38f45a70ee4f4fc132a38048d38206d 26-Mar-2015 mtklein <mtklein@chromium.org> C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}

NOPRESUBMIT=true

BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002

Review URL: https://codereview.chromium.org/1037793002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
0bdeec9640640922eb6b0a9f798bcd85eb898f29 23-Feb-2015 egdaniel <egdaniel@google.com> Remove canApplyCoverage from XP and all related functions in gpu code.

BUG=skia:

Review URL: https://codereview.chromium.org/919683002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
3ad6570e94965d54871eaea8b314f560b82ca792 17-Feb-2015 egdaniel <egdaniel@google.com> Use dst copies in porter duffer XP to correctly render certain blends.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/997c6358d94e188b1a7b89a4f86e24cbe0f5a164

Review URL: https://codereview.chromium.org/914003003
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
b197b8ff31b73ccb20423023e03592df8ae78ea6 17-Feb-2015 egdaniel <egdaniel@google.com> Use SkXfermode as public facing enum for GrPorterDuffXP

BUG=skia:

Review URL: https://codereview.chromium.org/926593005
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
2b816bacc0696f03d88c8060b21eda1e5cc7e8b1 13-Feb-2015 egdaniel <egdaniel@google.com> Revert of Use dst copies in porter duffer XP to correctly render certain blends. (patchset #4 id:60001 of https://codereview.chromium.org/914003003/)

Reason for revert:
Failing GLProgramTest passing in stupid coeffs

Original issue's description:
> Use dst copies in porter duffer XP to correctly render certain blends.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/997c6358d94e188b1a7b89a4f86e24cbe0f5a164

TBR=bsalomon@google.com,joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/923153003
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
997c6358d94e188b1a7b89a4f86e24cbe0f5a164 13-Feb-2015 egdaniel <egdaniel@google.com> Use dst copies in porter duffer XP to correctly render certain blends.

BUG=skia:

Review URL: https://codereview.chromium.org/914003003
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
e36914cb205699526988127a827d1a76c9a98d39 13-Feb-2015 egdaniel <egdaniel@google.com> Pass in ProcOptInfos into willNeedDstCopy on XPs

BUG=skia:

Review URL: https://codereview.chromium.org/912413002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
41d4f09356567ead0216e1a7e4110bd58822b81f 09-Feb-2015 egdaniel <egdaniel@google.com> Move GrXferProcessor subclasses into cpp files

BUG=skia:

Review URL: https://codereview.chromium.org/860383007
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
50785a3d10b53bea5beb6e18431a2449860be237 06-Feb-2015 bsalomon <bsalomon@google.com> Revert of Revert of Move DstCopy on gpu into the GrXferProcessor. (patchset #1 id:1 of https://codereview.chromium.org/901663007/)

Reason for revert:
The revert didn't help the 10.9 bot. Unreverting by reverting the revert (which is basically relanding the original patch which itself was a revert of a revert). Revert.

Original issue's description:
> Revert of Move DstCopy on gpu into the GrXferProcessor. (patchset #11 id:200001 of https://codereview.chromium.org/885923002/)
>
> Reason for revert:
> Testing to see if reverting fixes 10.9 bots.
>
> Original issue's description:
> > Move DstCopy on gpu into the GrXferProcessor.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/74a11753604768bf461b80cabb66060e8564d82c
> >
> > Committed: https://skia.googlesource.com/skia/+/5e1378d0e075a323144ba14e0a4cbcca35eccc69
>
> TBR=joshualitt@google.com,egdaniel@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/21b2c53218ab25f4268e3992e51d916076a2a7ee

TBR=joshualitt@google.com,egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/873723009
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
21b2c53218ab25f4268e3992e51d916076a2a7ee 05-Feb-2015 bsalomon <bsalomon@google.com> Revert of Move DstCopy on gpu into the GrXferProcessor. (patchset #11 id:200001 of https://codereview.chromium.org/885923002/)

Reason for revert:
Testing to see if reverting fixes 10.9 bots.

Original issue's description:
> Move DstCopy on gpu into the GrXferProcessor.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/74a11753604768bf461b80cabb66060e8564d82c
>
> Committed: https://skia.googlesource.com/skia/+/5e1378d0e075a323144ba14e0a4cbcca35eccc69

TBR=joshualitt@google.com,egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/901663007
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
5e1378d0e075a323144ba14e0a4cbcca35eccc69 05-Feb-2015 egdaniel <egdaniel@google.com> Move DstCopy on gpu into the GrXferProcessor.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/74a11753604768bf461b80cabb66060e8564d82c

Review URL: https://codereview.chromium.org/885923002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
4dce32c46675efb901618161771d450241af4307 04-Feb-2015 egdaniel <egdaniel@google.com> Revert "Move DstCopy on gpu into the GrXferProcessor."

This reverts commit 74a11753604768bf461b80cabb66060e8564d82c.

TBR=joshualitt@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/3e9dfdb3784c0cbfecf7589a74aa9aff7ef40abd

Review URL: https://codereview.chromium.org/896163003
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
7adb35559430303a25be37f21af56c0df6c62f2b 04-Feb-2015 egdaniel <egdaniel@google.com> Revert of Revert "Move DstCopy on gpu into the GrXferProcessor." (patchset #1 id:1 of https://codereview.chromium.org/896163003/)

Reason for revert:
failed on my manual revert

Original issue's description:
> Revert "Move DstCopy on gpu into the GrXferProcessor."
>
> This reverts commit 74a11753604768bf461b80cabb66060e8564d82c.
>
> TBR=joshualitt@google.com,bsalomon@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3e9dfdb3784c0cbfecf7589a74aa9aff7ef40abd

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/900913002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
3e9dfdb3784c0cbfecf7589a74aa9aff7ef40abd 04-Feb-2015 egdaniel <egdaniel@google.com> Revert "Move DstCopy on gpu into the GrXferProcessor."

This reverts commit 74a11753604768bf461b80cabb66060e8564d82c.

TBR=joshualitt@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/896163003
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
74a11753604768bf461b80cabb66060e8564d82c 04-Feb-2015 egdaniel <egdaniel@google.com> Move DstCopy on gpu into the GrXferProcessor.

BUG=skia:

Review URL: https://codereview.chromium.org/885923002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
71e236c03e65ff6b48a3d0eb091f814dd3e3a928 20-Jan-2015 egdaniel <egdaniel@google.com> Remove willReadDst from GrFragmentProcessor.

Since only XP's can read dst now, there is no reason to have this query on GrFP.
This also triggered a chain reaction of cleaning up/removing unnecessary code
elsewhere.

BUG=skia:

Review URL: https://codereview.chromium.org/851143003
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
080e673b10ac607305f140ddb245e140ccde40c6 22-Dec-2014 egdaniel <egdaniel@google.com> Add XP to handle the cases where we disable color write.

BUG=skia:

Review URL: https://codereview.chromium.org/787233003
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
9e4ecdc9f86724dcce23dc7546e2f295b901407b 18-Dec-2014 egdaniel <egdaniel@google.com> Add an InvariantOutput for the XPF.

The Invariant output holds information about final post blended color and other
general information like will it blend with dst. Having this new struct allowed
me to also remove some functions that were previously querying subsets of the
invariant output.

BUG=skia:

Review URL: https://codereview.chromium.org/814933002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
8750924a1470e8215b2a344155259b93062d3fa2 17-Dec-2014 egdaniel <egdaniel@google.com> Add Coverage Drawing XP

BUG=skia:

Review URL: https://codereview.chromium.org/808813002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
9b98932adaceb7ad0a617ade16616923f6bffe84 15-Dec-2014 joshualitt <joshualitt@chromium.org> This change will ultimately pull uniform color, and to a much lesser degree uniform coverage, into GPs. There are still some loose ends because drawstate has the ability to override the GP, but fixing these cleanly will have to wait until we have deferred geometry in place and can make attribute / uniform decisions on the fly.

BUG=skia:

Review URL: https://codereview.chromium.org/746423007
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
912ed6ebb8e2813e72ed7a3dec3b6710ba7e7405 15-Dec-2014 tfarina <tfarina@chromium.org> Cleanup: Mark some overridden methods with 'SK_OVERRIDE'.

This fixes errors like this:

../../include/gpu/effects/GrPorterDuffXferProcessor.h:27:25: error:
'name' overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]

BUG=skia:3075
TEST=ninja -C out/Debug skia_lib
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/804813002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
c230414861558ce20b74281b1ca363e56c441832 11-Dec-2014 egdaniel <egdaniel@google.com> Create xfer processor backend.

This includes:
-Having an actual XP stage at the end of the gl pipeline.
-All Blending work is handled by XP until actually setting GL blend states
-GLPrograms test to test XP

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4dffc940c430eec66d4707490eace19c9b3f7904

Review URL: https://codereview.chromium.org/764643004
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
294738268d3a9317282224f03063eb38ad19717c 11-Dec-2014 joshualitt <joshualitt@google.com> Revert of Create xfer processor backend. (patchset #6 id:100001 of https://codereview.chromium.org/764643004/)

Reason for revert:
CL breaks windows DM

Original issue's description:
> Create xfer processor backend.
>
> This includes:
> -Having an actual XP stage at the end of the gl pipeline.
> -All Blending work is handled by XP until actually setting GL blend states
> -GLPrograms test to test XP
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4dffc940c430eec66d4707490eace19c9b3f7904

TBR=bsalomon@google.com,joshualitt@chromium.org,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/789343002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
06f019fc0f809db993b03d7beb2fd5b4e0c58160 10-Dec-2014 joshualitt <joshualitt@google.com> Revert of Fix to set correct output type when blending when we've read dst (patchset #4 id:60001 of https://codereview.chromium.org/791143002/)

Reason for revert:
Breaks DM on windows

Original issue's description:
> Fix to set correct output type when blending when we've read dst
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/733fc2054044377e914559fa4f46db66ab7d9cea

TBR=bsalomon@google.com,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/795783002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
733fc2054044377e914559fa4f46db66ab7d9cea 10-Dec-2014 egdaniel <egdaniel@google.com> Fix to set correct output type when blending when we've read dst

BUG=skia:

Review URL: https://codereview.chromium.org/791143002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
4dffc940c430eec66d4707490eace19c9b3f7904 10-Dec-2014 egdaniel <egdaniel@google.com> Create xfer processor backend.

This includes:
-Having an actual XP stage at the end of the gl pipeline.
-All Blending work is handled by XP until actually setting GL blend states
-GLPrograms test to test XP

BUG=skia:

Review URL: https://codereview.chromium.org/764643004
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
9513143efa734bef0c1a0c7f945022572dbc8518 09-Dec-2014 egdaniel <egdaniel@google.com> Make all blending up to GrOptDrawState be handled by the xp/xp factory.

In this cl the blending information is extracted for the xp and stored in the ODS
which is then used as it currently is. In the follow up cl, an XP backend will be added
and at that point all blending work will take place inside XP's.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7c66342a399b529634bed0fabfaa562db2c0dbd4

Review URL: https://codereview.chromium.org/759713002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
8d95ffa497091d0c9c7cda099684c7bca6714a17 08-Dec-2014 egdaniel <egdaniel@google.com> Revert of Make all blending up to GrOptDrawState be handled by the xp/xp factory. (patchset #7 id:140001 of https://codereview.chromium.org/759713002/)

Reason for revert:
break many gm's

Original issue's description:
> Make all blending up to GrOptDrawState be handled by the xp/xp factory.
>
> In this cl the blending information is extracted for the xp and stored in the ODS
> which is then used as it currently is. In the follow up cl, an XP backend will be added
> and at that point all blending work will take place inside XP's.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7c66342a399b529634bed0fabfaa562db2c0dbd4

TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/766653008
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
7c66342a399b529634bed0fabfaa562db2c0dbd4 08-Dec-2014 egdaniel <egdaniel@google.com> Make all blending up to GrOptDrawState be handled by the xp/xp factory.

In this cl the blending information is extracted for the xp and stored in the ODS
which is then used as it currently is. In the follow up cl, an XP backend will be added
and at that point all blending work will take place inside XP's.

BUG=skia:

Review URL: https://codereview.chromium.org/759713002
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
915187b71d4068f21a15a1b8f4d919e1179d8b74 05-Dec-2014 egdaniel <egdaniel@google.com> Check XpFactory equality in DrawState

BUG=skia:

Review URL: https://codereview.chromium.org/767873006
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h
8bf2bd335f39afc29d7829ad11aa440945c2d37a 05-Dec-2014 egdaniel <egdaniel@google.com> Move GrPorterDuffXferProcessor to include/gpu/effects.

BUG=skia:

Review URL: https://codereview.chromium.org/780263003
/external/skia/include/gpu/effects/GrPorterDuffXferProcessor.h