| 80ea19ca4bdd68c1493666a5fe7e4ce9d43ded8b |
|
12-May-2015 |
reed <reed@google.com> |
Revert of Revert of stop calling SkScalarDiv (patchset #1 id:1 of https://codereview.chromium.org/1138263002/)
Reason for revert:
android patched, blink has rolled
Original issue's description:
> Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/)
>
> Reason for revert:
> need to wait for Blink roll (and patch android)
>
> Original issue's description:
> > stop calling SkScalarDiv
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a
>
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2629697933b5cc975e45d2a45c48f803fc6cbcec
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1135693003
/external/skia/src/core/SkRRect.cpp
|
| 2629697933b5cc975e45d2a45c48f803fc6cbcec |
|
12-May-2015 |
reed <reed@google.com> |
Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/)
Reason for revert:
need to wait for Blink roll (and patch android)
Original issue's description:
> stop calling SkScalarDiv
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1138263002
/external/skia/src/core/SkRRect.cpp
|
| 67d71c898249a7af3523b16c6a69895a63bfae0a |
|
12-May-2015 |
reed <reed@google.com> |
stop calling SkScalarDiv
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1135053002
/external/skia/src/core/SkRRect.cpp
|
| 2a679ae8f5b80a337f67783dbc0a447a9f4312c7 |
|
13-Mar-2015 |
robertphillips <robertphillips@google.com> |
Fix bug with very large round rects with large radii
BUG=463920
Review URL: https://codereview.chromium.org/998903003
/external/skia/src/core/SkRRect.cpp
|
| 11fa2247b747eb75e2f158dc7571d458ed6c0115 |
|
13-Mar-2015 |
reed <reed@chromium.org> |
some utils for rect and matrix
BUG=skia:
Review URL: https://codereview.chromium.org/1003813003
/external/skia/src/core/SkRRect.cpp
|
| fe1b180bee3f254cb74b5cb2ae383050fc316937 |
|
24-Feb-2015 |
robertphillips <robertphillips@google.com> |
Fix radii scaling bug in SkRRect::setNinePatch
BUG=skia:3466
Review URL: https://codereview.chromium.org/951323004
/external/skia/src/core/SkRRect.cpp
|
| 694b0d115d5efcd663c422d316d2cf3abaa1d354 |
|
13-Feb-2015 |
reed <reed@google.com> |
fix more tricky-float cases in SkRRect validate
BUG=458524,458522
Review URL: https://codereview.chromium.org/921163003
/external/skia/src/core/SkRRect.cpp
|
| 454fa71cc31bf45c14e4c0b25502d5332d76c51c |
|
10-Feb-2015 |
reed <reed@chromium.org> |
check for nonfinites in rrects
BUG=457128
Review URL: https://codereview.chromium.org/913743002
/external/skia/src/core/SkRRect.cpp
|
| 8aacf2085673f6302a43d590d4d2890789b87192 |
|
18-Dec-2014 |
mtklein <mtklein@chromium.org> |
Fill SkRRect::fType proactively.
I found no external mentions of SkRRect::kUnknown_Type.
Motivating race found by TSAN:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot/builds/48/steps/dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/801693003
/external/skia/src/core/SkRRect.cpp
|
| 5bcbe91304ec2515208b5218517579f48874e928 |
|
15-Dec-2014 |
reed <reed@google.com> |
Fix rrects that are large enough that we lose/gain a bit when we add the radius to a bounds coordinate.
add test that triggers assert in addRRect
BUG=skia:3239
Review URL: https://codereview.chromium.org/803153003
/external/skia/src/core/SkRRect.cpp
|
| e05fed0d6339c63c8cceff74af0b8d120c07e54c |
|
15-Dec-2014 |
reed <reed@google.com> |
add dumpHex option to rect and rrect, to match path
BUG=skia:
Review URL: https://codereview.chromium.org/801383002
/external/skia/src/core/SkRRect.cpp
|
| e5c1e3cd63e22bb06c24dd051f4d814f24786c08 |
|
27-Jun-2014 |
robertphillips <robertphillips@google.com> |
Fix RRect tranform bug
When a RRect is an oval transforming the rectangle and the radii separately can result in a non-oval result (i.e., due to numerical issues some tiny straight edges may creep in). This CL remedies the situation by computing the new radii directly from the transformed rect.
BUG=skia:2696
R=caryclark@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/354913004
/external/skia/src/core/SkRRect.cpp
|
| b6b02526438d6839481fb40ccf610d28f7652397 |
|
09-Jun-2014 |
bsalomon <bsalomon@google.com> |
Add dump() to SkClipStack to help with debugging.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/311263015
/external/skia/src/core/SkRRect.cpp
|
| 87927284d9f9a01697d541602222a897df6983fa |
|
03-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix SkRRect isEmpty assert
The rectangle could be empty but not all zeroes.
BUG=skia:2379
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
R=robertphillips@google.com
Author: siglesias@igalia.com
Review URL: https://codereview.chromium.org/223213005
git-svn-id: http://skia.googlecode.com/svn/trunk@14041 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| f338d7c860bf0bca82cac793069522311a3dbb1a |
|
17-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add nine patch type to SkRRect.
BUG=skia:2181
Committed: http://code.google.com/p/skia/source/detail?r=13833
R=robertphillips@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/196343015
git-svn-id: http://skia.googlecode.com/svn/trunk@13839 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| bab3fc4c90c4369c5d77d8da86d9f117ee54e0bc |
|
17-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Add nine patch type to SkRRect. (https://codereview.chromium.org/196343015/)
Reason for revert:
causes tests to have infinite loop
Original issue's description:
> Add nine patch type to SkRRect.
>
> BUG=skia:2181
>
> Committed: http://code.google.com/p/skia/source/detail?r=13833
R=robertphillips@google.com, reed@google.com
TBR=reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2181
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/202163004
git-svn-id: http://skia.googlecode.com/svn/trunk@13837 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 761b8e557269bbcd9d8c2030e57666a3d9ccba28 |
|
17-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add nine patch type to SkRRect.
BUG=skia:2181
R=robertphillips@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/196343015
git-svn-id: http://skia.googlecode.com/svn/trunk@13833 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 821397018fdabea6b434ecb96f84fb5449c4025f |
|
10-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
plumbing for GPU fast blur
BUG=skia:2281
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/193193002
git-svn-id: http://skia.googlecode.com/svn/trunk@13735 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 20e3cd2c9fbc049eae8bcedc591c2cc8d4bed656 |
|
05-Nov-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add SkRRect::transform.
Much like SkPath::transform, it transforms an SkRRect based on an
SkMatrix. Unlike SkPath::transform, it will fail for matrices that
contain perspective or skewing.
Required by a future change (https://codereview.chromium.org/48623006)
to speed up drawing large blurry rounded rectangles by using ninepatches.
TODO: This could easily support 90 degree rotations, if desired.
BUG=https://b.corp.google.com/issue?id=11174385
R=reed@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/52703003
git-svn-id: http://skia.googlecode.com/svn/trunk@12132 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 4faa869cdabbdcf4867118b4a1272296baaeeb52 |
|
05-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.
BUG=
R=reed@google.com, mtklein@google.com, senorblanco@chromium.org
Committed: https://code.google.com/p/skia/source/detail?r=12114
Committed: https://code.google.com/p/skia/source/detail?r=12119
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/41253002
git-svn-id: http://skia.googlecode.com/svn/trunk@12130 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 12a23866fe18e800da1d361d000a359ea36696eb |
|
04-Nov-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream."
This reverts commit 6bc22e8ef1ea70a1b58409aa21254358c50f149a.
git-svn-id: http://skia.googlecode.com/svn/trunk@12124 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| b48a59ae81a35642fe715a5cdd6fd758b652bff3 |
|
04-Nov-2013 |
sugoi@google.com <sugoi@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.
BUG=
R=reed@google.com
Committed: https://code.google.com/p/skia/source/detail?r=12114
Review URL: https://codereview.chromium.org/41253002
git-svn-id: http://skia.googlecode.com/svn/trunk@12119 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| eb221268ab1067af7c48e04a75147d4bcca87191 |
|
04-Nov-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r12114 due to https://code.google.com/p/skia/issues/detail?id=1794 ('Assertion failures on various buildbots as of r12114')
git-svn-id: http://skia.googlecode.com/svn/trunk@12115 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 305f78e8c18a26b7ead11758d6a4fa0519932cca |
|
04-Nov-2013 |
sugoi@google.com <sugoi@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/41253002
git-svn-id: http://skia.googlecode.com/svn/trunk@12114 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 4db592c4085afed2be27a208d778f9ee13e671ab |
|
30-Oct-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove contains(x,y) for rects and rrects ... not well defined, and unused
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/51953003
git-svn-id: http://skia.googlecode.com/svn/trunk@12022 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 2cf444f7040614b43af67e368f3aa636ebeaa45a |
|
26-Apr-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8873 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 32c1b66a2c4f26935ba59f3afe3e81600fade78d |
|
25-Apr-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added "SkRRect::contains(const SkRect&) const"
https://codereview.chromium.org/14200044/
git-svn-id: http://skia.googlecode.com/svn/trunk@8854 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 5b33211c5edafde82af781beaa1dbc295000a62f |
|
30-Jan-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Start addressing the clang static analyzer issues
https://codereview.appspot.com/7249043/
git-svn-id: http://skia.googlecode.com/svn/trunk@7469 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 1a60dab449ee8ab3b4c4330a18fae57b5980363e |
|
24-Dec-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6936 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| bcbef579d02e255b9a29b5db2d6804f4bfc76d1c |
|
24-Dec-2012 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkRRect::inset(), which mimics stroking
git-svn-id: http://skia.googlecode.com/svn/trunk@6935 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| c3442d53dabf2a692f4c9efba5e8be7bbb43d3ef |
|
17-Dec-2012 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
move inset out of SkRRect.h for now, and add experimental versions to gm
git-svn-id: http://skia.googlecode.com/svn/trunk@6833 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 37071640f6bdcb1bfb193f85b9ca615b29679425 |
|
17-Dec-2012 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add gm for rrect, and rrect.inset/outset
git-svn-id: http://skia.googlecode.com/svn/trunk@6832 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 4ed0fb768409bf97b79899c3990d8c15f5e9d784 |
|
12-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert 6766, thereby re-landing 6762-6763 now that the bots are ready
git-svn-id: http://skia.googlecode.com/svn/trunk@6770 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 25c1408c3da9ca90509b84f21a1161ef40052bd1 |
|
12-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert 6762-6763, since those require new skps to be generated, and we can't
do that immediately right now... will re-submit when we can.
git-svn-id: http://skia.googlecode.com/svn/trunk@6766 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 68d61ed83ec7b6e98e9623c2f5c9e7b1a32d25bb |
|
12-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make RRect and Oval first-class drawing primitives in SkCanvas.
add RRect as a first-class clip primitive.
Review URL: https://codereview.appspot.com/6923058
git-svn-id: http://skia.googlecode.com/svn/trunk@6762 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 0da23a5184cf8ee658c4f1ac45b798ddf7e73002 |
|
03-Dec-2012 |
tomhudson@google.com <tomhudson@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Tweak an enum declaration to make the clang compiler happy.
This exposes our "unknown type" to users, which is a loss of encapsulation.
TBR=robertphillips
http://codereview.appspot.com/6865050/
git-svn-id: http://skia.googlecode.com/svn/trunk@6641 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| c3d7d90973528527131c72549b10c2a21300e0ac |
|
30-Nov-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6632 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 1c2c2fed075e05837878813d6f8fe6ca8fc7ea00 |
|
30-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix for roll-blocking compiler error in SkRRect.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@6630 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|
| 5985e7c4d13b04d6b819bfff3df44f1dd3eb35b8 |
|
29-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkRoundRect start
https://codereview.appspot.com/6815058/
git-svn-id: http://skia.googlecode.com/svn/trunk@6595 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRRect.cpp
|