3cb3840c9af6f70896cf5565a38d4ee03c02d767 |
|
06-Feb-2015 |
reed <reed@google.com> |
Rename SkCanvasDrawable to SkDrawable, and make public (patchset #2 id:20001 of https://codereview.chromium.org/903993002/)" This reverts commit c4e87724920222a218f31b22612efc5b1ec0ed6c. BUG=skia: TBR= NOTREECHECKS=True Review URL: https://codereview.chromium.org/898343004
/external/skia/src/core/SkRecords.h
|
c4e87724920222a218f31b22612efc5b1ec0ed6c |
|
06-Feb-2015 |
reed <reed@google.com> |
Revert of rename SkCanvasDrawable to SkDrawable, and make public (patchset #2 id:20001 of https://codereview.chromium.org/903993002/) Reason for revert: bug in gyp Original issue's description: > rename SkCanvasDrawable to SkDrawable, and make public > > BUG=skia: > NOTRY=True > ... winbuilder flake > > Committed: https://skia.googlesource.com/skia/+/4ae9eb7463cf2160723407359608f221c0d5e2a6 TBR=robertphillips@google.com,djsollen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/882853006
/external/skia/src/core/SkRecords.h
|
4ae9eb7463cf2160723407359608f221c0d5e2a6 |
|
06-Feb-2015 |
reed <reed@google.com> |
rename SkCanvasDrawable to SkDrawable, and make public BUG=skia: NOTRY=True ... winbuilder flake Review URL: https://codereview.chromium.org/903993002
/external/skia/src/core/SkRecords.h
|
14ed0fd498639d1742e9b25ca4105193fa93b139 |
|
20-Jan-2015 |
mtklein <mtklein@chromium.org> |
Pre-cache fDirection and fConvexity for recorded SkPaths too. http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN/builds/1211/steps/dm/logs/stdio I don't see any big perf hit locally: desk_googlespreadsheetdashed.skp 1.68ms -> 1.74ms 1.04x desk_mobilenews.skp 643us -> 665us 1.04x desk_tigersvg.skp 51.1us -> 52.5us 1.03x desk_jsfiddlehumperclip.skp 37us -> 37.9us 1.02x desk_samoasvg.skp 373us -> 380us 1.02x desk_wordpress.skp 697us -> 708us 1.02x desk_mapsvg.skp 698us -> 708us 1.02x tabl_googleblog.skp 553us -> 560us 1.01x desk_wowwiki.skp 1.31ms -> 1.32ms 1.01x tabl_mozilla.skp 1.44ms -> 1.45ms 1.01x desk_sfgate.skp 156us -> 157us 1.01x desk_chalkboard.skp 376us -> 378us 1x desk_baidu.skp 101us -> 101us 1x desk_gmailthread.skp 231us -> 231us 1x desk_carsvg.skp 379us -> 379us 1x desk_googlehome.skp 38.1us -> 38.1us 1x desk_css3gradients.skp 89.6us -> 89.2us 1x desk_googlespreadsheet.skp 549us -> 546us 0.99x desk_pokemonwiki.skp 8.67ms -> 8.62ms 0.99x tabl_mlb.skp 294us -> 291us 0.99x tabl_gamedeksiam.skp 700us -> 692us 0.99x tabl_worldjournal.skp 143us -> 142us 0.99x desk_blogger.skp 441us -> 436us 0.99x desk_twitter.skp 452us -> 446us 0.99x desk_gws.skp 152us -> 150us 0.99x tabl_gmail.skp 24.2us -> 23.9us 0.99x tabl_sahadan.skp 84.7us -> 83.5us 0.99x tabl_cnn.skp 1.24ms -> 1.22ms 0.99x tabl_ukwsj.skp 543us -> 535us 0.99x desk_yahooanswers.skp 124us -> 123us 0.99x desk_booking.skp 905us -> 891us 0.98x tabl_androidpolice.skp 1.76ms -> 1.73ms 0.98x desk_ugamsolutions.skp 281us -> 276us 0.98x desk_nytimes.skp 209us -> 204us 0.98x tabl_techmeme.skp 98.4us -> 96.1us 0.98x tabl_nofolo.skp 59.2us -> 57.8us 0.98x desk_weather.skp 244us -> 238us 0.98x desk_facebook.skp 546us -> 531us 0.97x desk_linkedin.skp 321us -> 311us 0.97x tabl_digg.skp 801us -> 770us 0.96x tabl_culturalsolutions.skp 332us -> 319us 0.96x desk_amazon.skp 103us -> 99us 0.96x tabl_engadget.skp 610us -> 579us 0.95x tabl_cnet.skp 144us -> 136us 0.95x desk_fontwipe.skp 36.6us -> 34.7us 0.95x desk_ebay.skp 173us -> 164us 0.94x tabl_hsfi.skp 5.95us -> 5.58us 0.94x tabl_deviantart.skp 134us -> 126us 0.94x desk_espn.skp 261us -> 243us 0.93x BUG=skia: Review URL: https://codereview.chromium.org/861853002
/external/skia/src/core/SkRecords.h
|
49aabde6ef80e39f00a2d00487cf5a881987dd81 |
|
05-Jan-2015 |
mtklein <mtklein@chromium.org> |
Clean up dead clear() code in SkRecord. This removes the SkRecords::Clear struct and everything that refers to it. Notice there is nothing actually creating a Clear, which means this is all dead code. Now that all ops obey the clip, I don't think we need the weird inflate-empty-to-epsilon hack for BBH queries. BUG=skia: Review URL: https://codereview.chromium.org/835813002
/external/skia/src/core/SkRecords.h
|
c4fda92f45b9649f233a5b8636618a6431aa59cb |
|
02-Jan-2015 |
reed <reed@chromium.org> |
remove unused drawData BUG=skia: Review URL: https://codereview.chromium.org/830083002
/external/skia/src/core/SkRecords.h
|
f0f14113431ace669f278fdd97b50950f2cf4c80 |
|
12-Dec-2014 |
mtklein <mtklein@chromium.org> |
Cull pushCull and popCull from Skia. These calls are unused and going away. Waiting on crrev.com/796083002. BUG=skia: Review URL: https://codereview.chromium.org/794263002
/external/skia/src/core/SkRecords.h
|
f55c314bfa6db980941f8d0ab485beb2e08589ab |
|
11-Dec-2014 |
mtklein <mtklein@chromium.org> |
Enforce thread-safety of bitmaps in pictures via the type. No runtime difference here, but it makes it impossible to forget to make a shallow copy; you can't get at the full bitmap without it. NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/799603002
/external/skia/src/core/SkRecords.h
|
c54d8db4d169ea5f2af2a9a2349df007bd428475 |
|
10-Dec-2014 |
Florin Malita <fmalita@google.com> |
Remove SkCanvas::drawBitmapMatrix() R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/789033002
/external/skia/src/core/SkRecords.h
|
8eddfb50c0c9e4bcba6384a2ce39852b5fb5becb |
|
04-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip This reverts commit af641a1c10f176cb9617026d3cc93c117a85d13d. BUG=skia: TBR= Review URL: https://codereview.chromium.org/783493002
/external/skia/src/core/SkRecords.h
|
af641a1c10f176cb9617026d3cc93c117a85d13d |
|
03-Dec-2014 |
reed <reed@chromium.org> |
Revert "Change clear() to respect the clip" This reverts commit 3729469d6a12266037b697c2192768545e097ab0. BUG=skia: TBR= Review URL: https://codereview.chromium.org/778563002
/external/skia/src/core/SkRecords.h
|
3729469d6a12266037b697c2192768545e097ab0 |
|
02-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip patch from issue 769703002 at patchset 1 (http://crrev.com/769703002#ps1) BUG=skia: Review URL: https://codereview.chromium.org/772533004
/external/skia/src/core/SkRecords.h
|
af57903f330a0afd0c10244d4a66f64fdbef5d1e |
|
01-Dec-2014 |
mtklein <mtklein@chromium.org> |
Force SkMatrix type while recording too. This switches to a new way of doing this, enforcing the caching with the type recorded rather than having to do it in SkRecorder. Should be more foolproof. Updated SkPath and SkBitmap's equivalents too. ImmutableBitmap was close, but using inheritance now makes the rest of the code less weird. BUG=437511 I'm not sure whether or not this will _fix_ the SkMatrix aspect of that bug. There may be other SkMatrices that we're racing on. It does cover the obvious ones, though, and removing the SkTRacy<> wrapper will allow TSAN to show us any other races. It turned out to be easier to turn missing optional matrices into I early rather than late. I figure this should be harmless. Recording and playback perf both look neutral. Review URL: https://codereview.chromium.org/773433003
/external/skia/src/core/SkRecords.h
|
42ddcd49060f64be57f00e651650154f9b4f3a08 |
|
21-Nov-2014 |
mtklein <mtklein@chromium.org> |
All the small packing tweaks mentioned in the bug. BUG=skia:3144 Review URL: https://codereview.chromium.org/748063002
/external/skia/src/core/SkRecords.h
|
cdeeb095a629b0db9f0ddff09516f2b78255c047 |
|
20-Nov-2014 |
mtklein <mtklein@chromium.org> |
SkRecord: Pack SkRegion::Op and AA bit together. Saves 4 bytes per clip op. BUG=skia: Review URL: https://codereview.chromium.org/741093002
/external/skia/src/core/SkRecords.h
|
6be2aa9a251bf6022570a03140f956655b3ef1da |
|
18-Nov-2014 |
reed <reed@google.com> |
wip for drawables Idea: 1. in its mutable recording state, keep a table of drawables on the side, and store an index in the record list. 2. In "immediate-mode" draw, just call the clients drawable directly (need access to our private list to turn the stored index into a proc) 3. when we "snap", we replace the list of drawables with a list of (sub) pictures, and then during playback of the snapped picture, we invoke a private drawable which just calls "drawPicture" on the index'd subpicture. Review URL: https://codereview.chromium.org/727363003
/external/skia/src/core/SkRecords.h
|
65151754b9fdb6a968d7307764c20655d1b680a0 |
|
16-Oct-2014 |
piotaixr <piotaixr@chromium.org> |
Override SkCanvas::drawImage() in SkRecorder. BUG=skia:2947 Review URL: https://codereview.chromium.org/610003002
/external/skia/src/core/SkRecords.h
|
9b222a5ddd3b39ca191d8443bade6052cdcb713d |
|
18-Sep-2014 |
mtklein <mtklein@chromium.org> |
Simplify a little in SkRecords.h: - ACT_AS_PTR can just expose const methods to get at the pointers. (If the thing stored must stay const, we pass a const T.) - DrawPatch works fine with Record# macros, so use Record5. BUG=skia: R=fmalita@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/585523003
/external/skia/src/core/SkRecords.h
|
29dfaa80f5776904f42b72b387a99e75f8dc5f5f |
|
04-Sep-2014 |
mtklein <mtklein@chromium.org> |
Implement all SkCanvas overrides that SkPictureRecord does. Primarily this is for isDrawingToLayer(). drawData() and onNewSurface() are for completeness. BUG=409138 R=robertphillips@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/545613002
/external/skia/src/core/SkRecords.h
|
ee36952c601723a7069b8c2fc200dd769b8db1b0 |
|
27-Aug-2014 |
mtklein <mtklein@chromium.org> |
Can't hurt to make this SkNoncopyable. BUG=skia: R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/510953002
/external/skia/src/core/SkRecords.h
|
5f0e82204ecca0805a7689cdba5f802458e103f4 |
|
22-Aug-2014 |
mtklein <mtklein@chromium.org> |
Support comment groups in SkRecord. This should fix the failing paint-command-log-nodes.html layout test. BUG=406425 R=tomhudson@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/501533003
/external/skia/src/core/SkRecords.h
|
53fecfb15d254397ab03032b888daa9d15c487b6 |
|
21-Aug-2014 |
mtklein <mtklein@chromium.org> |
Our SkPicture::Analysis visitors should recurse into nested pictures. BUG=skia: R=tomhudson@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/495793002
/external/skia/src/core/SkRecords.h
|
00d5c2c6523321d25b32905ff4822f083a4173ee |
|
21-Aug-2014 |
fmalita <fmalita@chromium.org> |
SkTextBlob Initial implementation. R=bungeman@google.com, jbroman@chromium.org, mtklein@google.com, reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/473633002
/external/skia/src/core/SkRecords.h
|
c551d9fcae98ff7b9d56f315947e89a26632aeec |
|
20-Aug-2014 |
mtklein <mtklein@chromium.org> |
Implement SkPicture::hasText() for SkRecord backend. Plus, some small tweaks to the existing code surrounding it. Just proposals, will undo whatever you don't like. BUG=skia: R=mtklein@google.com, tomhudson@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/494683003
/external/skia/src/core/SkRecords.h
|
6332f1dd20d73a6d8b9564af7c27d09394eb6596 |
|
19-Aug-2014 |
mtklein <mtklein@chromium.org> |
Record concat as setMatrix. Mainly this cuts out a type to have to think about in SkRecord world. It also means all the CTMs are recorded directly in the SkRecord, so we can track the current CTM by pointer rather than by copying. BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/484673003
/external/skia/src/core/SkRecords.h
|
a723b576aed31a6eb2bdda6388e6bd779d04c6b0 |
|
15-Aug-2014 |
mtklein <mtklein@chromium.org> |
SkRecordDraw: incorporate clip into BBH NOTREECHECKS=true BUG=skia: R=robertphillips@google.com, senorblanco@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/474983002
/external/skia/src/core/SkRecords.h
|
6cfa73a29a26edf1d03bca224ad6860396308ffc |
|
13-Aug-2014 |
mtklein <mtklein@chromium.org> |
Start tracking the CTM while filling the BBH in SkRecordDraw. Depends on https://codereview.chromium.org/475473002/ BUG=skia: R=robertphillips@google.com, reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/468193003
/external/skia/src/core/SkRecords.h
|
b3c9d1c33caf325aada244204215eb790c228c12 |
|
12-Aug-2014 |
dandov <dandov@google.com> |
SkCanvas::drawPatch param SkPoint[12] drawPatch now receives as parameter const SkPoint cubics[12] Adjusted derived classes and serialization. Ajusted GM's and benches that take into account combinations of optional parameters, the scale of the patch and 4 different types of patches. Planning on adding the extra functionality of SkPatch in another CL. BUG=skia: R=egdaniel@google.com, reed@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/463493002
/external/skia/src/core/SkRecords.h
|
d5fa1a455aad61f3e99081fe7a9b065cb3b115c6 |
|
09-Aug-2014 |
reed <reed@google.com> |
add drawPicture variant that takes a matrix and paint will need some staging strategy, since chrome and blink have overrides of onDrawPicture R=robertphillips@google.com, fmalita@google.com, bsalomon@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/448793004
/external/skia/src/core/SkRecords.h
|
f4078ad1ec42f549369ac4f639aab18d00afae95 |
|
08-Aug-2014 |
mtklein <mtklein@chromium.org> |
SkRecord: Strip out cull-skipping and y-only drawPosTextH skipping. These optimizations are outclassed by a general bounding-box hierarchy, and are just going to make plugging that into SkRecordDraw more complicated. BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/452983002
/external/skia/src/core/SkRecords.h
|
2347b624678fedf1d2f7ab1d79b9ad70087c3392 |
|
07-Aug-2014 |
reed <reed@google.com> |
change drawPicture in SkRecord to just ref the picture also fix some int/unsigned/size_t warnings BUG=skia: R=mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/449933002
/external/skia/src/core/SkRecords.h
|
963137b75c0a1fe91f35e9826742f36309f5e65d |
|
07-Aug-2014 |
dandov <dandov@google.com> |
Stopped skipping tests in dm of SkPatch by implementing the corresponding drawPath calls on classes that derive from SkCanvas. BUG=skia: R=egdaniel@google.com, bsalomon@google.com, mtklein@google.com, robertphillips@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/429343004
/external/skia/src/core/SkRecords.h
|
5f6102d07982043542343ff0a6c67b1319ac9fc7 |
|
30-Jun-2014 |
Florin Malita <fmalita@chromium.org> |
SaveFlags be-gone Remove the deprecated save(SaveFlags), willSave(SaveFlags) and all traces of kMatrix_SaveFlags/kClip_SaveFlag. BUG=skia:2297 R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/340403003
/external/skia/src/core/SkRecords.h
|
887f3979f0c717e69a8b7d169169bc27eb46d3b5 |
|
17-Jun-2014 |
mtklein <mtklein@chromium.org> |
Add EXPERIMENTAL_beginRecording() for SkRecord-based recording. The interesting stuff is in SkPictureRecorder.{h,cpp}. The rest is mostly moving SkRecord from its own directories into core to avoid circular dependencies in GYP. After plumbing SkRecord all the way through in Picture, I'll delete its old entry point include/record/SkRecording.h. For now it and record.gypi need to stay where they are to keep Chrome building. BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/331573004
/external/skia/src/core/SkRecords.h
|