History log of /external/skia/src/core/SkResourceCache.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
36352bf5e38f45a70ee4f4fc132a38048d38206d 26-Mar-2015 mtklein <mtklein@chromium.org> C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}

NOPRESUBMIT=true

BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002

Review URL: https://codereview.chromium.org/1037793002
/external/skia/src/core/SkResourceCache.cpp
83787d0ff0a2b2f839a4a3ce6dadd033f83fe643 25-Feb-2015 reed <reed@google.com> only notify bitmaps that have been added to the cache

old code:
- calls=2677 hit-rate=3.51139%

new code:
- calls=94 hit-rate=97.8723%

BUG=skia:

Review URL: https://codereview.chromium.org/960563002
/external/skia/src/core/SkResourceCache.cpp
7eeba2587760a0802fd2b90765b4fd0e5e895375 24-Feb-2015 reed <reed@chromium.org> Notify resource caches when pixelref genID goes stale

patch from issue 954443002 at patchset 40001 (http://crrev.com/954443002#ps40001)

BUG=skia:

Review URL: https://codereview.chromium.org/950363002
/external/skia/src/core/SkResourceCache.cpp
90c6bc4e85df2da37f436ea1da203e194c4740e2 19-Feb-2015 mtklein <mtklein@google.com> Revert of notify resource caches when pixelref genID goes stale (patchset #4 id:60001 of https://codereview.chromium.org/825263005/)

Reason for revert:
Crazy failures.

http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/builds/1428/steps/dm/logs/stdio

Original issue's description:
> notify resource caches when pixelref genID goes stale
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4675819b9dbb3ad71ec851776e5de26d342f29fe

TBR=bsalomon@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/936423002
/external/skia/src/core/SkResourceCache.cpp
4675819b9dbb3ad71ec851776e5de26d342f29fe 19-Feb-2015 reed <reed@google.com> notify resource caches when pixelref genID goes stale

BUG=skia:

Review URL: https://codereview.chromium.org/825263005
/external/skia/src/core/SkResourceCache.cpp
1d9e80f02b8260ffe2eb1944042cd79f10e38d43 26-Jan-2015 reed <reed@google.com> check effective cache-size for fixed-budget caches

BUG=skia:

Review URL: https://codereview.chromium.org/876743002
/external/skia/src/core/SkResourceCache.cpp
72c9faab45124e08c85f70ca38536914862d947c 09-Jan-2015 mtklein <mtklein@chromium.org> Fix up all the easy virtual ... SK_OVERRIDE cases.

This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.

for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end

BUG=skia:

Review URL: https://codereview.chromium.org/806653007
/external/skia/src/core/SkResourceCache.cpp
d9aac34eceeb197c5551f38583670be7729dd00a 23-Oct-2014 qiankun.miao <qiankun.miao@intel.com> Add SkMaskCache

BUG=skia:

Review URL: https://codereview.chromium.org/670063004
/external/skia/src/core/SkResourceCache.cpp
171e5b73a862418f4acd61faf8cecfbc8f58694c 22-Oct-2014 fmalita <fmalita@chromium.org> SkResourceCache::Key namespace support.

Add a unique-per-subclass namespace tag to make Keys from different
domains comparable.

Also drop the SkPictureShader cache and convert to using the global
resource cache instead.

R=reed@google.com,mtklein@google.com,robertphillips@google.com

Review URL: https://codereview.chromium.org/668223002
/external/skia/src/core/SkResourceCache.cpp
9d93c2ebb31bf996905532446644f242339a774e 08-Oct-2014 reed <reed@google.com> Add SkCachedData and use it for SkMipMap

This reverts commit 37c5a815d8ea33247968212ef4cc83394ceee1bc.

TBR=mtklein

Review URL: https://codereview.chromium.org/635333002
/external/skia/src/core/SkResourceCache.cpp
37c5a815d8ea33247968212ef4cc83394ceee1bc 03-Oct-2014 reed <reed@google.com> Speculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use it for SkMipMap"

This reverts commit 92561a0b99ad6c08ab7a11dd1872f028199392e9.

crasher in question:
https://code.google.com/p/chromium/issues/detail?id=420178

Review URL: https://codereview.chromium.org/617613003
/external/skia/src/core/SkResourceCache.cpp
92561a0b99ad6c08ab7a11dd1872f028199392e9 02-Oct-2014 reed <reed@google.com> Add SkCachedData and use it for SkMipMap

Review URL: https://codereview.chromium.org/592843003
/external/skia/src/core/SkResourceCache.cpp
30ad5306be25565484a3dd76237984e071b7c4b3 16-Sep-2014 reed <reed@google.com> allow SkBitmapCache to operate on a local instance, for testability

BUG=skia:
R=mtklein@google.com, danakj@chromium.org, piotaixr@chromium.org, junov@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/576763002
/external/skia/src/core/SkResourceCache.cpp
c90e0149ec530075cae7bf51072a16628311855e 15-Sep-2014 reed <reed@google.com> Change SkResourceCache to take a Visitor inside its find().

This reverts commit 595aa05efcb504e85358b8d328ac4a9fa1c46e2e.

BUG=skia:
R=mtklein@google.com, danakj@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/569353002
/external/skia/src/core/SkResourceCache.cpp
595aa05efcb504e85358b8d328ac4a9fa1c46e2e 15-Sep-2014 reed <reed@google.com> Revert of Change SkResourceCache to take a Visitor inside its find(). (patchset #2 id:20001 of https://codereview.chromium.org/567393002/)

Reason for revert:
crashes on android bots, haven't diagnosed yet

Original issue's description:
> Change SkResourceCache to take a Visitor inside its find().
>
> This simplifies the API/contract, in that there are not any exposed
> lock/unlock scopes.
>
>
> patch from issue 572573002
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/dee6a8e67db39fcbde2b3bb09be1d088ebb9db8a

R=mtklein@google.com, danakj@chromium.org
TBR=danakj@chromium.org, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/569303002
/external/skia/src/core/SkResourceCache.cpp
dee6a8e67db39fcbde2b3bb09be1d088ebb9db8a 15-Sep-2014 reed <reed@google.com> Change SkResourceCache to take a Visitor inside its find().

This simplifies the API/contract, in that there are not any exposed
lock/unlock scopes.

patch from issue 572573002

BUG=skia:
R=mtklein@google.com, danakj@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/567393002
/external/skia/src/core/SkResourceCache.cpp
e6cb48382db869f8e194b83aec80fd495be76db7 15-Sep-2014 reed <reed@chromium.org> remove 'experimental' from using hash tables in resourcecache

TBR=

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/567303002
/external/skia/src/core/SkResourceCache.cpp
56b00d9e7aecce7ffc6b915972cc3cbfbe051d7e 11-Sep-2014 reed <reed@google.com> add PurgeResourceCache to track leaks

TBR=halcananry

Author: reed@google.com

Review URL: https://codereview.chromium.org/554263005
/external/skia/src/core/SkResourceCache.cpp
790ffe3feb90370318f42b28eb9c6af6e38cd4f9 11-Sep-2014 danakj <danakj@chromium.org> Make SkBitmapCache remove invalid bitmaps from the SkResourceCache.

This adds SkResourceCache::Remove() which will remove a resource from
its cache. The resource is required to be unlocked at the time Remove()
is called.

Then SkBitmapCache::Find() makes use of this to Remove() bitmaps from
the cache whose pixels have been evicted. This allows the bitmap to be
re-added to the cache with pixels again.

After this change, background a tab (and discarding all the bitmaps'
contents) no longer disables image caching for those discarded images
once the tab is visible again.

BUG=skia:2926
NOTRY=true
R=reed@android.com, tomhudson@google.com, reed@google.com

Author: danakj@chromium.org

Review URL: https://codereview.chromium.org/561953002
/external/skia/src/core/SkResourceCache.cpp
49f085dddff10473b6ebf832a974288300224e60 05-Sep-2014 bsalomon <bsalomon@google.com> "NULL !=" = NULL

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/544233002
/external/skia/src/core/SkResourceCache.cpp
011f39aeb2b9715546eb74d9ebb71be7baf95fde 28-Aug-2014 reed <reed@google.com> rename ScaledImageCache to ResourceCache

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/511283002
/external/skia/src/core/SkResourceCache.cpp