History log of /external/skia/src/core/SkScan_Antihair.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
793a6ddd447f9f7c2a388f74252538e36731f199 15-Apr-2015 reed <reed@google.com> add blitter api for aa-hairlines

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1088143002
/external/skia/src/core/SkScan_Antihair.cpp
f91e676f941c7e9ec91ac298eaa32e4bf8f52762 15-Apr-2015 jcgregorio <jcgregorio@google.com> Revert of add new blit2 methods in support of antialiased hairlines guard flag SK_SUPPORT_LEGACY_BLITANTIH2V2 (patchset #2 id:20001 of https://codereview.chromium.org/1060153003/)

Reason for revert:
DEPS roll is failing, one such example:

http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/73847/steps/ash_unittests%20%28with%20patch%29/logs/stdio

More here:

https://codereview.chromium.org/1091483003

This CL was the only CL in the roll when things started to fail.

Original issue's description:
> add new blit2 methods in support of antialiased hairlines
>
> before:
> 9M 1 528µs 530µs 539µs 607µs 5% ▁▁▁▁▁▁▁▁█▂ 8888 path_hairline_small_AA_quad
>
> after:
> 9M 1 355µs 356µs 358µs 375µs 2% ▂▁▁▁▁▁▁▁▁█ 8888 path_hairline_small_AA_quad
>
> BUG=skia:
>
> does require new baselines (bug chrome is guarded)
>
> Committed: https://skia.googlesource.com/skia/+/dd83031b98db4c6d3d0de2353bf115152a7d1464

TBR=caryclark@google.com,reed@chromium.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1085013003
/external/skia/src/core/SkScan_Antihair.cpp
dd83031b98db4c6d3d0de2353bf115152a7d1464 15-Apr-2015 reed <reed@google.com> add new blit2 methods in support of antialiased hairlines

before:
9M 1 528µs 530µs 539µs 607µs 5% ▁▁▁▁▁▁▁▁█▂ 8888 path_hairline_small_AA_quad

after:
9M 1 355µs 356µs 358µs 375µs 2% ▂▁▁▁▁▁▁▁▁█ 8888 path_hairline_small_AA_quad

BUG=skia:

does require new baselines (bug chrome is guarded)

Review URL: https://codereview.chromium.org/1060153003
/external/skia/src/core/SkScan_Antihair.cpp
5dc6b7d1a8bc591d62366ff83c434ff74f3e10fc 14-Apr-2015 reed <reed@google.com> change hairline procs to take array of points

BUG=skia:

Review URL: https://codereview.chromium.org/1085883002
/external/skia/src/core/SkScan_Antihair.cpp
054eef2b5ca84bf5b03e5ddba0c30055f5e474cc 11-Apr-2015 reed <reed@chromium.org> change hairline procs to take SkPoint by value, more efficient on SSE and NEON

precursor for https://codereview.chromium.org/1074313002/

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1084433002
/external/skia/src/core/SkScan_Antihair.cpp
36352bf5e38f45a70ee4f4fc132a38048d38206d 26-Mar-2015 mtklein <mtklein@chromium.org> C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}

NOPRESUBMIT=true

BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002

Review URL: https://codereview.chromium.org/1037793002
/external/skia/src/core/SkScan_Antihair.cpp
11fa2247b747eb75e2f158dc7571d458ed6c0115 13-Mar-2015 reed <reed@chromium.org> some utils for rect and matrix

BUG=skia:

Review URL: https://codereview.chromium.org/1003813003
/external/skia/src/core/SkScan_Antihair.cpp
72c9faab45124e08c85f70ca38536914862d947c 09-Jan-2015 mtklein <mtklein@chromium.org> Fix up all the easy virtual ... SK_OVERRIDE cases.

This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.

for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end

BUG=skia:

Review URL: https://codereview.chromium.org/806653007
/external/skia/src/core/SkScan_Antihair.cpp
b280646beba5d2d247994f2241b8d0c69a1e031d 05-Jan-2015 fmalita <fmalita@chromium.org> Fix thin rect stroking.

When both edges of a thin (sub-unit) stroke fall within the same pixel, we compute the wrong coverage and also blit the same line twice.

To avoid these issues, tweak the inner/outer hulls to ensure one of the edges is always pixel-aligned.

BUG=skia:3278
R=reed@google.com

Review URL: https://codereview.chromium.org/819253003
/external/skia/src/core/SkScan_Antihair.cpp
b07a94f1cba3976596ae1a7f23d8c2043ba353f3 19-Nov-2014 reed <reed@chromium.org> add roundOut that returns its result

BUG=skia:

Review URL: https://codereview.chromium.org/742663002
/external/skia/src/core/SkScan_Antihair.cpp
9fb00413ec55deb3a4953d4dff2dba3ec5cdb645 06-Jan-2014 mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> SK_SUPPORTED_DEPRECATED_FIXEDROUND around deprecated fixed[round,ceil,floor]

git-svn-id: http://skia.googlecode.com/svn/trunk@12903 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
8f4d2306fa866a26f9448048ff63f692b2ba43aa 17-Dec-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats

To keep the CL (slightly) managable, this does not make any changes to
existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this
time around.

BUG=
R=bsalomon@google.com, caryclark@google.com

Review URL: https://codereview.chromium.org/117053002

git-svn-id: http://skia.googlecode.com/svn/trunk@12712 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
e16efc1882ab34a0bb3ae361a2d37f840044cf87 26-Jan-2013 skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
0e51577a14f903ffeafa117a75954baeb173ffb9 07-Jan-2013 humper@google.com <humper@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> fix warning from scalar --> int32 conversion

BUG=

Review URL: https://codereview.appspot.com/7065050

git-svn-id: http://skia.googlecode.com/svn/trunk@7061 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
ade109f57c64f4fbc048cd77abaf4c539e010557 04-Jan-2013 djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Fix Android compiler warnings.

Review URL: https://codereview.appspot.com/7040053

git-svn-id: http://skia.googlecode.com/svn/trunk@7014 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
c1f6db86dcf478d3c067bfc3fd99174b23d81732 31-Oct-2012 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> catch case where clipping shortened the line down to a single pixel, but our
state variables made us draw twice... with different fractional positions (yikes).

Inspired by http://code.google.com/p/chromium/issues/detail?id=148638
tho not necessarily a fix for that issue (can't repro the issue yet).



git-svn-id: http://skia.googlecode.com/svn/trunk@6220 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
27b40e9f36f567a57ae92860052b36cedacdd4fd 26-Oct-2012 skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6133 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
b03fe429e83d7a32b05a5ee8423e4f62ba6380fa 25-Oct-2012 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> use subclasses instead of function-ptrs for hairline specializations.
1. enables easy grouping of procs, e.g. cap -vs- line
2. easy to extend for more shared state (e.g. gamma table, etc.)



git-svn-id: http://skia.googlecode.com/svn/trunk@6119 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
fbfcd5602128ec010c82cb733c9cdc0a3254f9f3 23-Aug-2012 rmistry@google.com <rmistry@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/)

This CL is part I of IV (I broke down the 1280 files into 4 CLs).
Review URL: https://codereview.appspot.com/6485054

git-svn-id: http://skia.googlecode.com/svn/trunk@5262 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
99b300ed9dcd09db544dd985cdd95a2ea284cb7c 17-Apr-2012 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> chop hairlines against 32K bounds, since that is our limit (currently)
for a fixedpoint implementation.



git-svn-id: http://skia.googlecode.com/svn/trunk@3713 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
10d02b6ba9f626af5a26a82c288e1beb0002914d 16-Apr-2012 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> need to invert the alpha computation for single scanline on innerfill
found by Fuzzer



git-svn-id: http://skia.googlecode.com/svn/trunk@3694 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
bbbe9ed59ee1d3077fa4e6368a4a7294240a5ec6 30-Mar-2012 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> rm obsolete build-flag SK_IGNORE_HAIRLINE_CLIP_FIX



git-svn-id: http://skia.googlecode.com/svn/trunk@3567 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
8a812c252d9206f0d2b1bb691d6b1d45c70e2e8b 30-Mar-2012 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> check for integer-nan (0x8000...) and don't draw those as antihairlines



git-svn-id: http://skia.googlecode.com/svn/trunk@3558 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
0724f4320d4f8c67d26c77594cca7fd030f4be1d 15-Mar-2012 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> don't clamp the stopScale to 0 unless it originally exceeded the clip. This is
a tweak on the fix in 3366, but in that earlier change, I mistakenly changed
> to >=. This CL just restores the compare to >



git-svn-id: http://skia.googlecode.com/svn/trunk@3400 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
9f79ece67d5aa185eeff28b64f93aba08baa8fdd 13-Mar-2012 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> add build option to revert hairline-clipping fix from 3366



git-svn-id: http://skia.googlecode.com/svn/trunk@3376 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
adb2e240188ecd3deef2b31f3836f44968d71d65 12-Mar-2012 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> if we are extending past our clip in antihairlines, don't draw that last
row/col (setting its scale to 0), so we don't violate the clip-rule and
possibly double-draw the last pixel.



git-svn-id: http://skia.googlecode.com/svn/trunk@3366 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
67ba5fa3283185f29c22e9b8daad521de0d00b23 24-Oct-2011 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> fix scalar=fixed by implementing SkRegion form of AntiFillRect



git-svn-id: http://skia.googlecode.com/svn/trunk@2516 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
045e62d715f5ee9b03deb5af3c750f8318096179 24-Oct-2011 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> enable soft clipping (yikes)



git-svn-id: http://skia.googlecode.com/svn/trunk@2515 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
ec3ed6a5ebf6f2c406d7bcf94b6bc34fcaeb976e 28-Jul-2011 epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Automatic update of all copyright notices to reflect new license terms.

I have manually examined all of these diffs and restored a few files that
seem to require manual adjustment.

The following files still need to be modified manually, in a separate CL:

android_sample/SampleApp/AndroidManifest.xml
android_sample/SampleApp/res/layout/layout.xml
android_sample/SampleApp/res/menu/sample.xml
android_sample/SampleApp/res/values/strings.xml
android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java
android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java
experimental/CiCarbonSampleMain.c
experimental/CocoaDebugger/main.m
experimental/FileReaderApp/main.m
experimental/SimpleCocoaApp/main.m
experimental/iOSSampleApp/Shared/SkAlertPrompt.h
experimental/iOSSampleApp/Shared/SkAlertPrompt.m
experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig
experimental/iOSSampleApp/SkiOSSampleApp-Debug.xcconfig
experimental/iOSSampleApp/SkiOSSampleApp-Release.xcconfig
gpu/src/android/GrGLDefaultInterface_android.cpp
gyp/common.gypi
gyp_skia
include/ports/SkHarfBuzzFont.h
include/views/SkOSWindow_wxwidgets.h
make.bat
make.py
src/opts/memset.arm.S
src/opts/memset16_neon.S
src/opts/memset32_neon.S
src/opts/opts_check_arm.cpp
src/ports/SkDebug_brew.cpp
src/ports/SkMemory_brew.cpp
src/ports/SkOSFile_brew.cpp
src/ports/SkXMLParser_empty.cpp
src/utils/ios/SkImageDecoder_iOS.mm
src/utils/ios/SkOSFile_iOS.mm
src/utils/ios/SkStream_NSData.mm
tests/FillPathTest.cpp
Review URL: http://codereview.appspot.com/4816058

git-svn-id: http://skia.googlecode.com/svn/trunk@1982 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
2047f00e4698f83499ab91911999a65c21a951c9 17-May-2011 epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> get tests closer to passing for SKIA_SCALAR=fixed

http://codereview.appspot.com/4532064/



git-svn-id: http://skia.googlecode.com/svn/trunk@1351 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
f7398c3ab61053597541fa0b3cfc710006a3e62b 05-May-2011 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> correctly compute coverage when an antialiased rect covers only 1 column of pixels



git-svn-id: http://skia.googlecode.com/svn/trunk@1256 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
bcc1d33e9453d7749a8691e4c8c6379a02b9bf72 09-Apr-2011 mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> coding style updates



git-svn-id: http://skia.googlecode.com/svn/trunk@1090 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
3a968750b29b3bb15452a4d4ed040c382727a297 07-Apr-2011 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> round the alphamul so we don't overflow a byte



git-svn-id: http://skia.googlecode.com/svn/trunk@1071 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
761fb62b0eb174783316d2a8b933fba896ca6355 04-Apr-2011 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> reenable fast stroked rects, now that we correctly handle non-square scale
also, degenerate non-antialias rectangles now draw properly



git-svn-id: http://skia.googlecode.com/svn/trunk@1049 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
7ff678bc1618dc669648198a7bdca8adfb189505 04-Apr-2011 mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> faster stroke rects



git-svn-id: http://skia.googlecode.com/svn/trunk@1042 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
a3d901099d7d295cd7d9df4114e874d9ccfff447 30-Nov-2009 reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> add unittest for IntersectLine, used by hairlines



git-svn-id: http://skia.googlecode.com/svn/trunk@447 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
e28ff55d980d2992618b6b721c848aba96cf759a 19-Nov-2009 reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> retool clipping in hairlines to catch huge coordinates



git-svn-id: http://skia.googlecode.com/svn/trunk@436 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
28937283e16928a562b3f9e19908db51bbb89ff9 28-Aug-2009 reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> fix gaps in antialiased hairlines (thanks to preda)
expand SampleHairline text to check for clip violations



git-svn-id: http://skia.googlecode.com/svn/trunk@340 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
6c14b43a840c791699747ba4cc0ed5abf2bda218 23-Mar-2009 reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> use static_cast
fix comments



git-svn-id: http://skia.googlecode.com/svn/trunk@135 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
8898363b2ee02e36dfa4bb166b59c09c4e835b0f 23-Mar-2009 reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> add check/hack to avoid drawing outside of the clip for hairlines



git-svn-id: http://skia.googlecode.com/svn/trunk@134 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
3555591c158c242b071c7ec92ad75b6e4cb74af2 16-Mar-2009 reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> add sanity checks to handles extremely large coordinates or filter margins.
Should not hurt features (we hope), but is an easy way to survive malicious
values on a small-memory machine like a handset.



git-svn-id: http://skia.googlecode.com/svn/trunk@123 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp
8a1c16ff38322f0210116fa7293eb8817c7e477e 17-Dec-2008 reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> grab from latest android



git-svn-id: http://skia.googlecode.com/svn/trunk@27 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Antihair.cpp