History log of /external/skia/src/ports/SkFontMgr_android.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
465706820d0d373f76ab4831c286115ee0d86b7a 15-May-2015 robertphillips <robertphillips@google.com> Revert of Font variations. (patchset #26 id:500001 of https://codereview.chromium.org/1027373002/)

Reason for revert:
Appears to be breaking Linux ARM bots:

FAILED:
/usr/local/google/home/mosaic-role/slave/repo_clients/chromium_tot/chromium/src/../../prebuilt/toolchain/armv7a/bin/armv7a-cros-linux-gnueabi-g++
... -o obj/third_party/skia/src/ports/skia_library.SkFontHost_FreeType.o
../../third_party/skia/src/ports/SkFontHost_FreeType.cpp:37:31: fatal error:
freetype/ftmm.h: No such file or directory
#include FT_MULTIPLE_MASTERS_H
^
compilation terminated.

Original issue's description:
> Font variations.
>
> Multiple Master and TrueType fonts support variation axes.
> This implements back-end support for axes on platforms which
> support it.
>
> Committed: https://skia.googlesource.com/skia/+/05773ed30920c0214d1433c07cf6360a05476c97
>
> Committed: https://skia.googlesource.com/skia/+/3489ee0f4fa34f124f9de090d12bdc2107d52aa9

TBR=reed@google.com,mtklein@google.com,djsollen@google.com,halcanary@google.com,bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1139123008
/external/skia/src/ports/SkFontMgr_android.cpp
3489ee0f4fa34f124f9de090d12bdc2107d52aa9 14-May-2015 bungeman <bungeman@google.com> Font variations.

Multiple Master and TrueType fonts support variation axes.
This implements back-end support for axes on platforms which
support it.

Committed: https://skia.googlesource.com/skia/+/05773ed30920c0214d1433c07cf6360a05476c97

Review URL: https://codereview.chromium.org/1027373002
/external/skia/src/ports/SkFontMgr_android.cpp
5ae1312c9faa25531c07e591b4dff6804020f121 13-May-2015 bungeman <bungeman@google.com> Revert of Font variations. (patchset #21 id:400001 of https://codereview.chromium.org/1027373002/)

Reason for revert:
Mac failing to build due to CFNumberType in Chromium Canary.

Original issue's description:
> Font variations.
>
> Multiple Master and TrueType fonts support variation axes.
> This implements back-end support for axes on platforms which
> support it.
>
> Committed: https://skia.googlesource.com/skia/+/05773ed30920c0214d1433c07cf6360a05476c97

TBR=reed@google.com,mtklein@google.com,djsollen@google.com,halcanary@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1128913008
/external/skia/src/ports/SkFontMgr_android.cpp
05773ed30920c0214d1433c07cf6360a05476c97 13-May-2015 bungeman <bungeman@google.com> Font variations.

Multiple Master and TrueType fonts support variation axes.
This implements back-end support for axes on platforms which
support it.

Review URL: https://codereview.chromium.org/1027373002
/external/skia/src/ports/SkFontMgr_android.cpp
e85a754a4ce9b279159270faa6717932f7a8548f 17-Apr-2015 bungeman <bungeman@google.com> Respect declared font style on Android.

Previously the normal/italic style bit was obtained from scanning the
font file. With the new format the style may be stated explicitly, and
this explicit value in the configuration file should override any
information obtained from the font data itself.

This change allows the font element's style attribute to override the
font's style, but retains the default 'auto' setting for backwards
compatibility. Repecting the style bit may become more important with
variation fonts, because it will be up to the configuration writer to
determine what values of the 'slnt' variation should be considered
'normal' or 'italic'.

DOCS_PREVIEW= https://skia.org/?cl=1092093002

Committed: https://skia.googlesource.com/skia/+/673e902c9b9982a167f54f1cc175d8d9cab8bcaf

Review URL: https://codereview.chromium.org/1092093002
/external/skia/src/ports/SkFontMgr_android.cpp
21d3ed52e5eecc41f0ed05acdd3c5ff1189fed75 17-Apr-2015 jcgregorio <jcgregorio@google.com> Revert of Respect declared font style on Android. (patchset #6 id:100001 of https://codereview.chromium.org/1092093002/)

Reason for revert:
Failed on the compile bots.

Original issue's description:
> Respect declared font style on Android.
>
> Previously the normal/italic style bit was obtained from scanning the
> font file. With the new format the style may be stated explicitly, and
> this explicit value in the configuration file should override any
> information obtained from the font data itself.
>
> This change allows the font element's style attribute to override the
> font's style, but retains the default 'auto' setting for backwards
> compatibility. Repecting the style bit may become more important with
> variation fonts, because it will be up to the configuration writer to
> determine what values of the 'slnt' variation should be considered
> 'normal' or 'italic'.
>
> DOCS_PREVIEW= https://skia.org/?cl=1092093002
>
> Committed: https://skia.googlesource.com/skia/+/673e902c9b9982a167f54f1cc175d8d9cab8bcaf

TBR=mtklein@google.com,tomhudson@google.com,scroggo@google.com,bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1082173004
/external/skia/src/ports/SkFontMgr_android.cpp
673e902c9b9982a167f54f1cc175d8d9cab8bcaf 17-Apr-2015 bungeman <bungeman@google.com> Respect declared font style on Android.

Previously the normal/italic style bit was obtained from scanning the
font file. With the new format the style may be stated explicitly, and
this explicit value in the configuration file should override any
information obtained from the font data itself.

This change allows the font element's style attribute to override the
font's style, but retains the default 'auto' setting for backwards
compatibility. Repecting the style bit may become more important with
variation fonts, because it will be up to the configuration writer to
determine what values of the 'slnt' variation should be considered
'normal' or 'italic'.

DOCS_PREVIEW= https://skia.org/?cl=1092093002

Review URL: https://codereview.chromium.org/1092093002
/external/skia/src/ports/SkFontMgr_android.cpp
9d911d5a9323bda1e4a77c46a0c28708dcc2ad38 17-Apr-2015 bungeman <bungeman@google.com> Remove filename from SkFontDescriptor.

No one actually uses it, so remove it. Keep the string id for backward
compatibility.

TBR=reed@google.com
This doesn't change any public API.

Review URL: https://codereview.chromium.org/1057413005
/external/skia/src/ports/SkFontMgr_android.cpp
36352bf5e38f45a70ee4f4fc132a38048d38206d 26-Mar-2015 mtklein <mtklein@chromium.org> C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}

NOPRESUBMIT=true

BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002

Review URL: https://codereview.chromium.org/1037793002
/external/skia/src/ports/SkFontMgr_android.cpp
7fa87cd09f49f1ee9bc27e263038d0f0ae706241 06-Feb-2015 bungeman <bungeman@google.com> Add factory for Android font manager.

This allows users to create an Android font manager with their own set
of fonts, or augment the system set. This will allow for removal of
the current globals which are used for a similar, but more constained,
purpose.

BUG=skia:2817,skia:3314,chromium:407340

Review URL: https://codereview.chromium.org/887113002
/external/skia/src/ports/SkFontMgr_android.cpp
5f213d9627d2eefa7da81cd97f36754f75eb4ae9 27-Jan-2015 bungeman <bungeman@google.com> SkTypeface to use SkStreamAsset.

SkTypeface already requires typeface streams to support SkStreamAsset
in practice, and in practice all users are already supplying them.

Review URL: https://codereview.chromium.org/869763002
/external/skia/src/ports/SkFontMgr_android.cpp
a1193e4b0e34a7e4e1bd33e9708d7341679f8321 21-Jan-2015 scroggo <scroggo@google.com> Make SkStream *not* ref counted.

SkStream is a stateful object, so it does not make sense for it to have
multiple owners. Make SkStream inherit directly from SkNoncopyable.

Update methods which previously called SkStream::ref() (e.g.
SkImageDecoder::buildTileIndex() and SkFrontBufferedStream::Create(),
which required the existing owners to call SkStream::unref()) to take
ownership of their SkStream parameters and delete when done (including
on failure).

Switch all SkAutoTUnref<SkStream>s to SkAutoTDelete<SkStream>s. In some
cases this means heap allocating streams that were previously stack
allocated.

Respect ownership rules of SkTypeface::CreateFromStream() and
SkImageDecoder::buildTileIndex().

Update the comments for exceptional methods which do not affect the
ownership of their SkStream parameters (e.g.
SkPicture::CreateFromStream() and SkTypeface::Deserialize()) to be
explicit about ownership.

Remove test_stream_life, which tested that buildTileIndex() behaved
correctly when SkStream was a ref counted object. The test does not
make sense now that it is not.

In SkPDFStream, remove the SkMemoryStream member. Instead of using it,
create a new SkMemoryStream to pass to fDataStream (which is now an
SkAutoTDelete).

Make other pdf rasterizers behave like SkPDFDocumentToBitmap.

SkPDFDocumentToBitmap delete the SkStream, so do the same in the
following pdf rasterizers:

SkPopplerRasterizePDF
SkNativeRasterizePDF
SkNoRasterizePDF

Requires a change to Android, which currently treats SkStreams as ref
counted objects.

Review URL: https://codereview.chromium.org/849103004
/external/skia/src/ports/SkFontMgr_android.cpp
72c9faab45124e08c85f70ca38536914862d947c 09-Jan-2015 mtklein <mtklein@chromium.org> Fix up all the easy virtual ... SK_OVERRIDE cases.

This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.

for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end

BUG=skia:

Review URL: https://codereview.chromium.org/806653007
/external/skia/src/ports/SkFontMgr_android.cpp
c9232dcda016feb2d30abb51483b3b1862775f84 10-Nov-2014 bungeman <bungeman@google.com> Remove SK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER.

This removes the old guarded code and enables the new api
introduced with "Update fontMgr to take list of bcp47 language tags."
c20386e3937d3d398ac9b35f9c7d997e972ade98 . Blink on Android is
already using the new code.

Review URL: https://codereview.chromium.org/705843004
/external/skia/src/ports/SkFontMgr_android.cpp
4b86bacb0428b07cba01fd46452d5c46e6f21af0 04-Nov-2014 bungeman <bungeman@google.com> Allow all font weights on Android and respect overrides.

This removes the code which forces 400 and 700 weights only,
and also overrides the font weight with the configured weight.

Review URL: https://codereview.chromium.org/694533006
/external/skia/src/ports/SkFontMgr_android.cpp
14df8339841f246a7337a8fb0d90f1b7ee689619 28-Oct-2014 bungeman <bungeman@google.com> Extend SkFontMgr_Custom to cover ttc, otf, pfb.

Adds ability to test ScanFont with Type1 (pfb) fonts
and fonts with multiple faces (ttc).

Committed: https://skia.googlesource.com/skia/+/ee0c2e4fd429424beaa35f29e7f656997ba3f115

Review URL: https://codereview.chromium.org/672723002
/external/skia/src/ports/SkFontMgr_android.cpp
32501a1bd4964576264795ada7e9c3bf572285b3 28-Oct-2014 bungeman <bungeman@google.com> Revert of Extend SkFontMgr_Custom to cover ttc, otf, pfb. (patchset #2 id:20001 of https://codereview.chromium.org/672723002/)

Reason for revert:
Reverting as this appears to be causing issues with color fonts on Android.

Original issue's description:
> Extend SkFontMgr_Custom to cover ttc, otf, pfb.
>
> Adds ability to test ScanFont with Type1 (pfb) fonts
> and fonts with multiple faces (ttc).
>
> Committed: https://skia.googlesource.com/skia/+/ee0c2e4fd429424beaa35f29e7f656997ba3f115

TBR=reed@google.com,halcanary@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/685803003
/external/skia/src/ports/SkFontMgr_android.cpp
ee0c2e4fd429424beaa35f29e7f656997ba3f115 28-Oct-2014 bungeman <bungeman@google.com> Extend SkFontMgr_Custom to cover ttc, otf, pfb.

Adds ability to test ScanFont with Type1 (pfb) fonts
and fonts with multiple faces (ttc).

Review URL: https://codereview.chromium.org/672723002
/external/skia/src/ports/SkFontMgr_android.cpp
5f6094a1eb9bf5bb9fd17ada84a5763de2853eff 27-Oct-2014 bungeman <bungeman@google.com> Match language tags by prefix on Android.

A request for 'zh' should match 'zh-Hans' and 'zh-Hant'.

Review URL: https://codereview.chromium.org/681823003
/external/skia/src/ports/SkFontMgr_android.cpp
c20386e3937d3d398ac9b35f9c7d997e972ade98 23-Oct-2014 bungeman <bungeman@google.com> Update fontMgr to take list of bcp47 language tags.

This will enable clients to pass more than one bcp47 tag to ensure
that the most appropriate font is selected.

BUG=chromium:422180

Review URL: https://codereview.chromium.org/670243002
/external/skia/src/ports/SkFontMgr_android.cpp
a4c4a2d8cd65abb1e5ac20813831cdb9ace6c7ee 20-Oct-2014 bungeman <bungeman@google.com> Replace SkTypeface::Style with SkFontStyle.

Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20

Review URL: https://codereview.chromium.org/488143002
/external/skia/src/ports/SkFontMgr_android.cpp
802ad83dca2efd57fde6c7ba666555ea78b5324c 20-Oct-2014 mtklein <mtklein@google.com> Revert of Replace SkTypeface::Style with SkFontStyle. (patchset #9 id:160001 of https://codereview.chromium.org/488143002/)

Reason for revert:
CrOS GM failures:

[*] 2 ExpectationsMismatch: fontmgr_iter_565.png fontmgr_iter_8888.png

Original issue's description:
> Replace SkTypeface::Style with SkFontStyle.
>
> Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20

TBR=reed@google.com,bungeman@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/667023002
/external/skia/src/ports/SkFontMgr_android.cpp
43b8b36b20ae00e2d78421c4cda1f3f922983a20 20-Oct-2014 bungeman <bungeman@google.com> Replace SkTypeface::Style with SkFontStyle.

Review URL: https://codereview.chromium.org/488143002
/external/skia/src/ports/SkFontMgr_android.cpp
d71b75757335393d9643a5b7a0f2769b6ba52fb6 18-Sep-2014 bungeman <bungeman@google.com> Serialize the font index.

BUG=skia:1186
R=reed@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/567013002
/external/skia/src/ports/SkFontMgr_android.cpp
b374d6a62c0259387d90cad74753d8bad9ee1bea 17-Sep-2014 bungeman <bungeman@google.com> Add onGetFamilyName to SkTypeface.

This speeds up and documents this particular feature of SkTypeface
and also frees up SkFontDescriptor to be used only in serialization.

R=reed@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/574873002
/external/skia/src/ports/SkFontMgr_android.cpp
49f085dddff10473b6ebf832a974288300224e60 05-Sep-2014 bsalomon <bsalomon@google.com> "NULL !=" = NULL

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/544233002
/external/skia/src/ports/SkFontMgr_android.cpp
3b6255493e458c6b2c1412af908581f0bf3f6b70 14-Aug-2014 djsollen <djsollen@google.com> Remove SkPaintOptionsAndroid

Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b

R=reed@google.com, mtklein@google.com, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/447873003
/external/skia/src/ports/SkFontMgr_android.cpp
c15e28a5224a3a0e977d6b2da44ce89302d01186 14-Aug-2014 bsalomon <bsalomon@google.com> Revert of Remove SkPaintOptionsAndroid (patchset #5 of https://codereview.chromium.org/447873003/)

Reason for revert:
Breaks the Chromium build: http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-DRT/builds/2469/steps/BuildContentShell_1/logs/stdio

Original issue's description:
> Remove SkPaintOptionsAndroid
>
> Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com
TBR=djsollen@google.com, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/473543004
/external/skia/src/ports/SkFontMgr_android.cpp
f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b 13-Aug-2014 djsollen <djsollen@google.com> Remove SkPaintOptionsAndroid

R=reed@google.com, mtklein@google.com, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/447873003
/external/skia/src/ports/SkFontMgr_android.cpp
c773390eefe70d13faab147a70bd9319b9ac3afb 13-Aug-2014 tomhudson <tomhudson@chromium.org> Delete the old font management implementation based on SkFontConfigInterface, now that SkFontMgr_Android is live.

BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/445143002
/external/skia/src/ports/SkFontMgr_android.cpp
d3ddea284ec6611a93a6b75e64de39d0bc7e083c 11-Aug-2014 tomhudson <tomhudson@chromium.org> Parses sample code provided by Android project. Attempts to keep FontFamily data structures produced consistent with expectations of previous versions of Skia.

R=bungeman@google.com, djsollen@google.com, palmer@chromium.org, reed@google.com, hcm@google.com, tomhudson@google.com
BUG=400801

Committed: https://skia.googlesource.com/skia/+/07544757c9fcf0f359f1686a3779eb2e75dd5b36

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/446473003
/external/skia/src/ports/SkFontMgr_android.cpp
3e30af2dca04d45bd3f8fb3aa322e0d90306536f 11-Aug-2014 bungeman <bungeman@google.com> Actually use test configuration in SkFontMgr on Android.

BUG=chromium:401954
R=tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/461673002
/external/skia/src/ports/SkFontMgr_android.cpp
4e3523cf546df4079cf769b8ecc8011403420a45 08-Aug-2014 bungeman <bungeman@google.com> Blink layout tests all assume it can provide custom font configuration files on every platform. In moving Android to the font manager, we broke those.

They're ugly, but this patch reinstates them.

R=tomhudson@google.com, djsollen@google.com, reed@google.com
TBR=reed@google.com
BUG=chromium:401954

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/451093002
/external/skia/src/ports/SkFontMgr_android.cpp
da7a944e293d27ec5c7be06b224921ae0058d35a 06-Aug-2014 Derek Sollenberger <djsollen@google.com> Revert "Remove SkPaintOptionsAndroid"

This reverts commit 27fb94999b8eec448423884e1d071e563c4c95d9.

Review URL: https://codereview.chromium.org/450513002
/external/skia/src/ports/SkFontMgr_android.cpp
27fb94999b8eec448423884e1d071e563c4c95d9 06-Aug-2014 Derek Sollenberger <djsollen@google.com> Remove SkPaintOptionsAndroid

Review URL: https://codereview.chromium.org/447873003
/external/skia/src/ports/SkFontMgr_android.cpp
8560cd5396f8902322471b49ac33aa849659228e 06-Aug-2014 bungeman <bungeman@google.com> Fix reference counting on SkStream in SkFontMgr_android.

R=tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/447003002
/external/skia/src/ports/SkFontMgr_android.cpp
65fcd3de3cb9dfd766c460500586eb939e6a6d68 06-Aug-2014 bungeman <bungeman@google.com> Implement SkFontMgr_Android::onMatchFamilyStyleCharacter.

This will allow us to replace SkGetFallbackFamilyNameForChar
and also eventually fix issues with it's reliance on names.

R=djsollen@google.com, tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/427293003
/external/skia/src/ports/SkFontMgr_android.cpp
07cfb20a0b9a14b8daeb56fcf21d810e91387fd1 30-Jul-2014 bungeman <bungeman@google.com> Correct Android FontMgr use of ttc index and remove unused code.

R=djsollen@chromium.org, tomhudson@google.com, djsollen@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/433503003
/external/skia/src/ports/SkFontMgr_android.cpp
3a9142437eacf543f5cde6881cc4534868c80f58 29-Jul-2014 tomhudson <tomhudson@chromium.org> Fix debug output compile error and minor style nits

R=djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/420333002
/external/skia/src/ports/SkFontMgr_android.cpp
8d84c995319dd4a82e4f2054bbd19f968c671ca6 24-Jul-2014 bungeman <bungeman@google.com> SkFontMgr for Android.

Committed: https://skia.googlesource.com/skia/+/4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06

R=djsollen@google.com, tomhudson@google.com, robertphillips@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/414483002
/external/skia/src/ports/SkFontMgr_android.cpp
7b82d0f8e6a69824295aab42e9a346584183614a 23-Jul-2014 robertphillips <robertphillips@google.com> Revert of SkFontMgr for Android. (https://codereview.chromium.org/414483002/)

Reason for revert:
Reverting to unblock DEPS roll.

Original issue's description:
> SkFontMgr for Android.
>
> Committed: https://skia.googlesource.com/skia/+/4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06

R=djsollen@google.com, tomhudson@google.com, bungeman@google.com
TBR=bungeman@google.com, djsollen@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/408143010
/external/skia/src/ports/SkFontMgr_android.cpp
4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06 22-Jul-2014 bungeman <bungeman@google.com> SkFontMgr for Android.

R=djsollen@google.com, tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/414483002
/external/skia/src/ports/SkFontMgr_android.cpp