a9baa652bb329b5a286e1638938f63433701efca |
|
05-Mar-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Revert of Add image as a draw type that can be filtered (patchset #4 id:60001 of https://codereview.chromium.org/960783003/) Reason for revert: Fails on mac for some reason. Also is a bit wrong, but this should not be reason for the failure.. Original issue's description: > Add image as a draw type that can be filtered > > Add image as a draw type that can be filtered. > > This is needed when SkImage is added as an object to be drawn so that > the draw is forwarded to SkBaseDevice. This would be used in making > filters use SkImages. > > BUG=skia:3388 > > Committed: https://skia.googlesource.com/skia/+/fa77eb1e51b9317ff993d1be504ada173b561e5f TBR=reed@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3388 Review URL: https://codereview.chromium.org/980273002
/external/skia/tools/bench_pictures_main.cpp
|
fa77eb1e51b9317ff993d1be504ada173b561e5f |
|
05-Mar-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Add image as a draw type that can be filtered Add image as a draw type that can be filtered. This is needed when SkImage is added as an object to be drawn so that the draw is forwarded to SkBaseDevice. This would be used in making filters use SkImages. BUG=skia:3388 Review URL: https://codereview.chromium.org/960783003
/external/skia/tools/bench_pictures_main.cpp
|
b9eb4ac0f1c29d6fe10ad7ff81ed8326ac1ea043 |
|
03-Feb-2015 |
mtklein <mtklein@chromium.org> |
patch from issue 886233004 at patchset 40001 (http://crrev.com/886233004#ps40001) ... with changes proposed in the review. BUG=skia: Review URL: https://codereview.chromium.org/894013002
/external/skia/tools/bench_pictures_main.cpp
|
24234fe77718a553ccc6ffdea0f2ee3ef414e0b6 |
|
24-Oct-2014 |
bsalomon <bsalomon@google.com> |
Build gpu stats tracking in dev builds. Fix cache stats, add more info. BUG=skia:2889 Review URL: https://codereview.chromium.org/655263005
/external/skia/tools/bench_pictures_main.cpp
|
78c71272fb26852bf3d2ca31785e61d4a598af82 |
|
09-Oct-2014 |
robertphillips <robertphillips@google.com> |
Update old tools to allow MultiPictureDraw rendering I'll post a separate patch for nanobench and dm Review URL: https://codereview.chromium.org/639013003
/external/skia/tools/bench_pictures_main.cpp
|
754f4e98d94d7c9ed76cd128cf983f9323a1885b |
|
18-Sep-2014 |
robertphillips <robertphillips@google.com> |
Add counting of some GL calls I would like this facility for tracking FBO switch improvements. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/553583008
/external/skia/tools/bench_pictures_main.cpp
|
c5ba71d2e5cd426def66fa49dcf003e5b2c98dc7 |
|
04-Sep-2014 |
robertphillips <robertphillips@google.com> |
Change SkPicture::draw to playback R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/540963002
/external/skia/tools/bench_pictures_main.cpp
|
a8d7f0b13cd4c6d773fcf055fe17db75d260fa05 |
|
29-Aug-2014 |
robertphillips <robertphillips@google.com> |
Try out scalar picture sizes This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect. R=reed@google.com, mtklein@google.com, fmalita@google.com, fmalita@chromium.org Author: robertphillips@google.com Review URL: https://codereview.chromium.org/513983002
/external/skia/tools/bench_pictures_main.cpp
|
e94707505e9007c05f67d813bdb2b6eccaf96c06 |
|
12-Aug-2014 |
robertphillips <robertphillips@google.com> |
Update tools for use of picture stats in GPU optimization decision R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/466733004
/external/skia/tools/bench_pictures_main.cpp
|
a8e2e1504b9af6ba791637f228debaa23953064a |
|
29-Jul-2014 |
tfarina <tfarina@chromium.org> |
Cleanup: Rename SkOSPath functions. Mostly for brevity and matches better with Python: Python | Old C++ | New C++ os.path.join | SkOSPath::SkPathJoin | SkOSPath::Join os.path.basename | SkOSPath::SkBasename | SkOSPath::Basename BUG=None TEST=make all R=mtklein@google.com, bsalomon@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/428443002
/external/skia/tools/bench_pictures_main.cpp
|
d3e474e20c6f0f24ddb6b2643e92975d60190daa |
|
27-Jun-2014 |
mtklein <mtklein@chromium.org> |
Deprecate SkPicture::clone(). Chrome will need -DSK_SUPPORT_LEGACY_PICTURE_CLONE. This removes the modes from our tools that use clone(). No bots run these. DM used clone() in a way that we can just share the picture now. I plan to bring back the ability to test multithreaded picture rendering soon. BUG=skia:2378 R=robertphillips@google.com, mtklein@google.com, bsalomon@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/338633011
/external/skia/tools/bench_pictures_main.cpp
|
4d1a364e391a8fd79c9e133d27957761d35068d0 |
|
26-Jun-2014 |
kelvinly <kelvinly@google.com> |
Make SKP bench JSON ouput better BUG=skia: NOTREECHECKS=true R=bensong@google.com, jcgregorio@google.com, bsalomon@google.com, robertphillips@google.com, rmistry@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/329993008
/external/skia/tools/bench_pictures_main.cpp
|
9ac68ee2594f28dfc1bd16a4bf004b1a4f6f228d |
|
20-Jun-2014 |
mtklein <mtklein@chromium.org> |
Move BenchTimer to tools as Timer This breaks a bunch of circular dependencies between tools and gm and bench. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot R=tfarina@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/344213003
/external/skia/tools/bench_pictures_main.cpp
|
9e64b78ff687edd24c55c0e26942411468032d32 |
|
20-Jun-2014 |
mtklein <mtklein@google.com> |
Revert of Move BenchTimer to tools as Timer (https://codereview.chromium.org/344213003/) Reason for revert: GpuTimer broken Original issue's description: > Move BenchTimer to tools as Timer > > This breaks a bunch of circular dependencies between tools and gm and bench. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed R=tfarina@chromium.org, mtklein@chromium.org TBR=mtklein@chromium.org, tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/346753003
/external/skia/tools/bench_pictures_main.cpp
|
4ed75287aed6371c6e4a41ffcc78c8a49c9810ed |
|
20-Jun-2014 |
mtklein <mtklein@chromium.org> |
Move BenchTimer to tools as Timer This breaks a bunch of circular dependencies between tools and gm and bench. BUG=skia: R=tfarina@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/344213003
/external/skia/tools/bench_pictures_main.cpp
|
f168b86d7fafc5c20c87bebc6fd393cb17e120ca |
|
19-Jun-2014 |
tfarina <tfarina@chromium.org> |
Remove Sk prefix from some bench classes. This idea came while commenting on https://codereview.chromium.org/343583005/ Since SkBenchmark, SkBenchLogger and SkGMBench are not part of the Skia library, they should not have the Sk prefix. BUG=None TEST=make all R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/347823004
/external/skia/tools/bench_pictures_main.cpp
|
30e6e2af14e84216b1c113fd7500d0822bc81daa |
|
18-Jun-2014 |
mtklein <mtklein@chromium.org> |
Add basic stacktrace handler using libunwind. This means we will all have to apt-get install libunwind8-dev on Linux. Mac comes with everything we need already. BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/343583005
/external/skia/tools/bench_pictures_main.cpp
|
f01a6c3663970ccd6e1882e76a887e0fda467b77 |
|
18-Jun-2014 |
scroggo <scroggo@google.com> |
In Android framework, make tools depend on jsoncpp Always build the tools with JSON, but either build our own or use the system's. Rename skia_build_json_writer to skia_use_system_jsoncpp, since we now always build with JSON. Remove SK_BUILD_JSON_WRITER, which was only there so we could build without JSON it in the framework. BUG=skia:2448 R=djsollen@google.com, reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/303913002
/external/skia/tools/bench_pictures_main.cpp
|
da4ed3289ec05a7155d5669c90a743a829574ea6 |
|
12-Jun-2014 |
tfarina <tfarina@chromium.org> |
Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin(). BUG=None TEST=make tools tests && out/Debug/tests R=epoger@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/327403002
/external/skia/tools/bench_pictures_main.cpp
|
1c99ea8ed80ca492397717b57e2735869be38c69 |
|
11-Jun-2014 |
tfarina <tfarina@chromium.org> |
Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename(). BUG=None TEST=make tests && out/Debug/tests R=epoger@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/321693002
/external/skia/tools/bench_pictures_main.cpp
|
37c772ae2d96dad9b6e430e9bb6450193a545021 |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reland https://codereview.chromium.org/286903025 BUG=skia: R=bensong@google.com, epoger@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/304613002 git-svn-id: http://skia.googlecode.com/svn/trunk@14966 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
293a4b367ae5b89384c364737ef76099fd3f0101 |
|
27-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of PictureBenchmark JSON logging (https://codereview.chromium.org/286903025/) Reason for revert: Broke some Windows builds; see http://skbug.com/2609 ('certain Windows Build-* bots failing since r14905'). Before re-landing with a fix, please send to some of the trybots that failed the first time. Original issue's description: > Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h > > JSON format described in code, above PictureJSONResultsWriter class > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14906 R=bensong@google.com, jcgregorio@google.com, kelvinly@google.com TBR=bensong@google.com, jcgregorio@google.com, kelvinly@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2609 Author: epoger@google.com Review URL: https://codereview.chromium.org/306483010 git-svn-id: http://skia.googlecode.com/svn/trunk@14910 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
3089004cc88e919526e43a8122a74db8f0a7790b |
|
27-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h JSON format described in code, above PictureJSONResultsWriter class BUG=skia: R=bensong@google.com, jcgregorio@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/286903025 git-svn-id: http://skia.googlecode.com/svn/trunk@14906 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
ba7aedd6eac1e48e1902f81fa8ea93bb28a81c5f |
|
23-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Turn on preprocessing by default (https://codereview.chromium.org/299033002/) Reason for revert: Don't want this enabled by default right now Original issue's description: > Turn on preprocessing by default > > The idea is to commit this late at night and then revert it after all the perf bots are running. It should only effect the GPU configs. > > Committed: http://code.google.com/p/skia/source/detail?r=14860 R=bsalomon@google.com TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Author: robertphillips@google.com Review URL: https://codereview.chromium.org/299123002 git-svn-id: http://skia.googlecode.com/svn/trunk@14861 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
0df2e8d5a67e9d88432fe40a2c2a616184269a82 |
|
23-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Turn on preprocessing by default The idea is to commit this late at night and then revert it after all the perf bots are running. It should only effect the GPU configs. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/299033002 git-svn-id: http://skia.googlecode.com/svn/trunk@14860 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
c873329ae9ff00b0c45f7294172ad2e9b1ec44c8 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update bench to be able to preprocess skps This allows benchmarking of optimization improvements and plumbs in the purging API. The purging is necessary so we don't magically get faster because the saveLayers are always pre-generated. R=jvanverth@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/233663002 git-svn-id: http://skia.googlecode.com/svn/trunk@14154 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
cf2f00872c559c892bb4b466bf678c7667490cce |
|
04-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkDiscardableMemoryPool to abstract class Motivation - we want to keep our public headers small. R=scroggo@google.com, reed@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/223403012 git-svn-id: http://skia.googlecode.com/svn/trunk@14063 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
94d8f1ed6116780346ffa39ed683f1977786434a |
|
18-Dec-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update bench pictures to time image decode & upload costs https://codereview.chromium.org/117583002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12742 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
2c7c7ee47d75e7815ea8db05e924ab55958cb402 |
|
05-Dec-2013 |
halcanary@google.com <halcanary@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Big Cleanup: SkBitmapFactory, SkLazyPixelRef, SkImageCache Removed SkBitmapFactory since no clients were using it. New cache selection mechanism can simply pass a SkDiscardableMemory::Factory into the SkDiscardablePixelRef if non-default SkDiscardableMemory should be used. Removed BitmapFactoryTest. SkDiscardableMemory::Factory interface. Android will need this functionality in the future inside their BitmapFactory. Removed SkLazyPixelRef, since it's functionality is now subsumed into SkDiscardablePixelRef. Removed LazyPixelRef test. Modified SkDiscardablePixelRef to optionally allow it to use a SkDiscardableMemory::Factory. This tiny change makes it a replacement for SkLazyPixelRef. This functioanlity is also necessary for moving Android over to SkDiscardablePixelRef from SkImageRef in a later CL. Added a test for this. SkDecodingImageGenerator::Install can optionally pass a factory in to SkDiscardablePixelRef. Removed SkImageCache, SkLruImageCache, and SkPurgeableImageCache. This functionality can be handled much more cleanly by SkDiscardableMemory. New SkDiscardableMemoryPool class to replace SkLruImageCache. In a later CL, we will replace SkImageRef_GlobalPool (used by android) as well. This is a concrete implementation of SkDiscardableMemory::Factory. Added a test for this. modified gm/factory.cpp to remove dependnce on SkBitmapFactory + SkLruImageCache. Now uses SkDecodingImageGenerator + SkDiscardablePixelRef + SkDiscardableMemoryPool. SkImageDecoder::Target replaces SkBitmapFactory::Target. The DecodeMemoryToTarget function may disappear in the future. Moved SkLazyCachingPixelRef::DecodeProc replaces SkBitmapFactory::DecodeProc. This is a short term change, since another CL changes SkLazyCachingPixelRef to use SkImageGenerator instead of DecodeProc. Modified DrawBitmapRectTest to use SkDiscardablePixelRef instead of SkLazyPixelRef. tools/LazyDecodeBitmap.cpp now uses SkDecodingImageGenerator + SkDiscardablePixelRef instead of a SkBitmapFactory. bench_pictures uses the Global SkDiscardableMemoryPool instead of a global gLruImageCache. R=reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/103033002 git-svn-id: http://skia.googlecode.com/svn/trunk@12515 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
65e508d0b1b0e532e2758a937bd565738dc89941 |
|
02-Aug-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Restore a default timer to bench_pictures. https://codereview.chromium.org/19862002 removed the default timer to display from PictureBenchmark. Restore a default by putting it in the flag description. R=mtklein@google.com Review URL: https://codereview.chromium.org/21567005 git-svn-id: http://skia.googlecode.com/svn/trunk@10516 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
55fd612adfd08f5c64fb728bc37a2cb4ae224656 |
|
31-Jul-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Committed: http://code.google.com/p/skia/source/detail?r=10372 R=borenet@google.com, bungeman@google.com, robertphillips@google.com, scroggo@google.com, sglez@google.com Author: bsalomon@google.com Review URL: https://chromiumcodereview.appspot.com/19862002 git-svn-id: http://skia.googlecode.com/svn/trunk@10473 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
68f2a0df144197d8221f4761285e597f1788e4ff |
|
25-Jul-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This reverts commit 4052fd051db67bd1099fde2c4fe400cfbe1f2426. git-svn-id: http://skia.googlecode.com/svn/trunk@10374 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
47fad70da32b8654c6e37aed27815f16bcc5e2f9 |
|
25-Jul-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
R=borenet@google.com, bungeman@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://chromiumcodereview.appspot.com/19862002 git-svn-id: http://skia.googlecode.com/svn/trunk@10372 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
56799e2ee6b74dacb74babeb5217b65367915ed8 |
|
16-Jul-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add the lazy decoder from PictureFlags to SkImageDecoder R=caryclark@google.com, scroggo@google.com Author: sglez@google.com Review URL: https://chromiumcodereview.appspot.com/19109002 git-svn-id: http://skia.googlecode.com/svn/trunk@10111 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
f1754ec69131801c1a6ed3c704501a9400bbf324 |
|
28-Jun-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Replace SkPicture(SkStream) constructors with a factory. SkPicture: Remove the constructors which take an SkStream as an argument. Rather than having to check a variable for success, the factory will return NULL on failure. Add a protected function for determining if an SkStream is an SKP to share code with SkTimedPicture. In the factory, check for a NULL SkStream. Use a default decoder (from BUG: https://code.google.com/p/skia/issues/detail?id=1325) SkDebuggerGUI: Call SkPicture::CreateFromStream when necessary. Write a factory for creating SkTimedPictures and use it. Use the factory throughout tools. Add include/lazy to utils and effects gyp include_dirs so SkPicture.h can reference SkImageDecoder.h which references SkBitmapFactory.h (in include/lazy). Changes code Chromium uses, so this will require a temporary Skia and then a change to Chromium to use the new Skia code. TODO: Create a decoder that does nothing to be used by pinspect, lua pictures, etc, and allow it to not assert in SkOrderedReadBuffer. R=reed@google.com Review URL: https://codereview.chromium.org/17113004 git-svn-id: http://skia.googlecode.com/svn/trunk@9822 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
7def5e1630d47cdbfa4b58a9c86bc060693c4d79 |
|
31-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Separate core and images project. SkImage calls functions on SkImageDecoder and SkImageEncoder. This is desired behavior, and it is also desired to include SkImage as a part of core. In order to keep core from depending on images, update SkImageDecoder_empty.cpp to implement all of SkImageDecoder and SkImageEncoder. This file will be built by chrome (in https://codereview.chromium.org/15960015). Move force_linking from SkImageDecoder.cpp to its own file. It must be called to force linking with the image decoders if desired. Call the function in tools that need it: sk_image render_pictures render_pdfs sk_hello filter bench_pictures debugger SkImageDecoder: Derive from SkNoncopyable, instead of duplicating its hiding of constructors. skhello: Return rather than trying to write a null SkData to the stream. Revert "Hamfistedly removed core dependence on images" (commit 0f05f682a90bc125323677abf3476e1027d174f5) and "Move SkImage::encode to SkImage_Codec.cpp." (commit 83e47a954d0bf65439f3d9c0c93213063dd70da3.) These two commits were temporary fixes that this change cleans up. SkSnapshot.cpp: Check for a NULL encoder returned by SkImageEncoder::Create. BUG=https://code.google.com/p/skia/issues/detail?id=1275 R=djsollen@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/15806010 git-svn-id: http://skia.googlecode.com/svn/trunk@9364 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
604e0c249ef0e11a1b8bc41195081363fd86d892 |
|
09-Apr-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkFlags now follows proper dashing convention. Two dashes are used for flags with multiple characters, and one dash is used for flags with single characters. In GM, changed '-wp' to '-p' (the command to choose a directory for writing SKPs) to fit with the convention. In render_pictures and bench_pictures, changed the flag for read and write path to have full names (which are consistent) and use the old single character names as their shortcuts. SkCommandLineFlags: Updated the documentation, and only allow -h or --help for help (again, to match the convention). Also enforce the single character limit for the short name, and require the full name to be at least two characters. Provide full names for skhello. BUG=https://code.google.com/p/skia/issues/detail?id=1174 Review URL: https://codereview.chromium.org/12521019 git-svn-id: http://skia.googlecode.com/svn/trunk@8582 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
d9ba9a05d6f5766fdb1378b6ed84c0659009a8da |
|
21-Mar-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Change the name of SkFlags to SkCommandLineFlags. This name is more specific to what it actually does. Also move the code into tools/flags, to (slightly) better organize the massive tools folder. Update the programs that use it to use the new names. No functionality changes. BUG=https://code.google.com/p/skia/issues/detail?id=1173 Review URL: https://codereview.chromium.org/12440067 git-svn-id: http://skia.googlecode.com/svn/trunk@8304 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
bb281f7f963ea9ae6d735ca8430396cfabaa73ca |
|
18-Mar-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Improvements/additions to SkImageCache/SkLazyPixelRef. SkPurgeableImageCache: New image cache that uses virtual memory to store the pixels. Combines features of SkAshmemImageCache (which has been removed) with SkPurgeableMemoryBlock, which has android and Mac versions. SkImageCache: Modified the API. pinCache now returns a status out parameter which states whether the pinned memory retained the old data. This allows allocAndPinCache to only be used for allocations. Add a new debug only interface to purge unpinned data. Updates to documentation, clarifying behavior. Changed CachedStatus to MemoryStatus SkLruImageCache: Implement the new function purgeAllUnpinnedCaches and change implementation of pinCache for the new behavior. SkLazyPixelRef: Rewrite onLockPixels to account for the new behavior of pinCache. BitmapFactoryTest: Test the new SkPurgeableImageCache. Write tests which directly test the SkImageCaches. Create a larger bitmap, since some of the SkImageCaches are designed to handle large bitmaps. bench_ and render_pictures: Consolidate lazy_decode_bitmap into one function. Allow using a flag to specify using the purgeable image cache. Clean up some #includes. Review URL: https://codereview.chromium.org/12433020 git-svn-id: http://skia.googlecode.com/svn/trunk@8207 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
a560d00ba5005ded8094a307ca41365bdf47cd50 |
|
04-Mar-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Provide an option in bench_pictures to count pixel ram. In SkLruImageCache, provide an option to keep all pixels, and document the new behavior. In gm/factory.cpp, set the budget for the Lru image cache to 1, to retain (basically) the old behavior. BUG=https://code.google.com/p/skia/issues/detail?id=1010 Review URL: https://codereview.chromium.org/12378075 git-svn-id: http://skia.googlecode.com/svn/trunk@7972 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
cc690201d2538a7ec2dbec7040064c8d3c42c613 |
|
04-Mar-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add a way to monitor cache hits and misses for deferred decoding. Adds a new flag to bench_pictures in order to do this. Also fix a warning. Review URL: https://codereview.chromium.org/12393046 git-svn-id: http://skia.googlecode.com/svn/trunk@7965 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
161e1ba4c0a82e21c7d68808529699fd2394ad6c |
|
04-Mar-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Created my own flag parser, based off of gflags. Share common code between bench_ and render_ to set up the PictureRenderer. Fix an include error in SkPictureRenderer.h. Simplified parameter passing in render_pictures_main. Switch to using an SkAutoTUnref for the PictureRenderer. I also changed the input format somewhat, so the buildbots need to be updated as well: https://codereview.appspot.com/7441044/ Fixed a bug in PictureBenchmark where calling setTimeIndividualTiles(false) sets the member variable to true. Removed setDeviceType from PictureBenchmark, since only the PictureRenderer needs to know which device type to use. Some changes to the input format: '--logPerIter' no longer takes a 1 or 0. Instead, '--logPerIter' turns it on and '--nologPerIter' turns it off (with off as the default). (Note that this is for bench_pictures; bench still uses the old format) Change '--device' to '--config' and 'bitmap' to '8888' to be the same as gm. Requires '--r' before inputs (to match gm), though there can be multiple inputs following it. Changed --enable-deferred-image-decoding (which no one uses but me yet anyway) to --deferImageDecoding, since the former is incompatible with the flag parser. Changes to behavior: Show a short error message on failure (rather than the explanation of all flags). BUG=https://code.google.com/p/skia/issues/detail?id=1094 Review URL: https://codereview.appspot.com/7230053 git-svn-id: http://skia.googlecode.com/svn/trunk@7961 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
f8d7d2731318cdf510ab68e6b3f5ec68ab22c8e2 |
|
22-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Create SkLazyPixelRef which performs lazy decoding. The new pixel ref behaves similarly to SkImageRef, with some key differences: It does not depend on the images project. It requires an SkImageCache, which handles allocation and caching of the pixel memory. It takes a function signature for decoding which decodes into already allocated pixel memory rather than into an SkBitmap. Add two implementations of SkImageCache: SkLruImageCache and SkAshmemImageCache. Replace SkSerializationHelpers::DecodeBitmap with SkPicture::InstallPixelRefProc, and update sites that referenced it. SkBitmapFactory now sets the pixel ref to a new object of the new class SkLazyPixelRef, provided it has an SkImageCache for caching. Provide an option to do lazy decodes in render_pictures and bench_pictures. SkPicture: Eliminate the default parameters in the constructor. If a proc for decoding bitmaps is installed, use it to decode any encoded data in subpictures. When parsing deserializing subpictures, check for success. When serializing subpictures, pass the picture's bitmap encoder to the subpicture's call to serialize. Update BitmapFactoryTest to test its new behavior. BUG=https://code.google.com/p/skia/issues/detail?id=1008 BUG=https://code.google.com/p/skia/issues/detail?id=1009 Review URL: https://codereview.appspot.com/7060052 git-svn-id: http://skia.googlecode.com/svn/trunk@7835 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
0556ea0ede7066b9b3ed9f03f5a6eb72cd718897 |
|
08-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add support for using ANGLE in bench_pictures. BUG=https://code.google.com/p/skia/issues/detail?id=1012 Other cleanups: Remove setDeviceType from PictureBenchmark, since it is unnecessary. Dereference PictureRenderer::fGrContext when done with it. Make PictureRenderer::fGrContext and PictureRenderer::fGrContextFactory private, since they are not used by subclasses. Review URL: https://codereview.appspot.com/7314063 git-svn-id: http://skia.googlecode.com/svn/trunk@7677 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
d3c208c53eda490ed6445e39f467de288cf22d85 |
|
22-Jan-2013 |
jvanverth@google.com <jvanverth@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Patch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter type. git-svn-id: http://skia.googlecode.com/svn/trunk@7307 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
4e23068b374023d43c4c725138d523721d975892 |
|
15-Jan-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Re-enable inst counting in debug builds. R=robertphillips@google.com Review URL: https://codereview.appspot.com/7098066 git-svn-id: http://skia.googlecode.com/svn/trunk@7206 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
89d15a28b52faed37b1bda1fbcdd1afae4bae457 |
|
07-Jan-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix warnings Review URL: https://codereview.appspot.com/7060053 git-svn-id: http://skia.googlecode.com/svn/trunk@7070 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
457d8a77bed0160519fc5dfb67d0e02f9c3950a2 |
|
18-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove experimental setAsABlur, as it forces the instance to be mutable, and was not adopted by chrome Review URL: https://codereview.appspot.com/6939071 git-svn-id: http://skia.googlecode.com/svn/trunk@6879 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
82ec0b00f380906c1cdeb4b4cc4a355264ab3882 |
|
17-Dec-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow setting a scaleFactor in bench_pictures (and render_pictures). In TiledPictureRenderer and CopyTilesRenderer, do a postTranslate so the translate is not affected by the scale factor. Likewise, use clipRegion for tiled renderer so it will be unaffected by the scale factor. Respect the viewport for record, playbackCreation, and pipe renderers. Review URL: https://codereview.appspot.com/6947072 git-svn-id: http://skia.googlecode.com/svn/trunk@6853 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
cbcef708914f3b5e9bb63ad3d87261378026e29b |
|
13-Dec-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Provide an option to bench drawing individual tiles in bench_pictures. Provides output like the following: running bench [1236 12045] androidpolice.skp tile_256x256: tile [0,0] out of [5,48]: msecs = 1.00 tile_256x256: tile [1,0] out of [5,48]: msecs = 1.50 tile_256x256: tile [2,0] out of [5,48]: msecs = 1.00 tile_256x256: tile [3,0] out of [5,48]: msecs = 1.50 tile_256x256: tile [4,0] out of [5,48]: msecs = 2.50 tile_256x256: tile [0,1] out of [5,48]: msecs = 2.00 tile_256x256: tile [1,1] out of [5,48]: msecs = 3.50 tile_256x256: tile [2,1] out of [5,48]: msecs = 3.50 tile_256x256: tile [3,1] out of [5,48]: msecs = 6.00 tile_256x256: tile [4,1] out of [5,48]: msecs = 2.50 tile_256x256: tile [0,2] out of [5,48]: msecs = 2.00 BUG=https://code.google.com/p/skia/issues/detail?id=1016 Review URL: https://codereview.appspot.com/6937047 git-svn-id: http://skia.googlecode.com/svn/trunk@6805 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
c0d5e549ab8d594a5da8db417db39622e9491fff |
|
13-Dec-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow bench_pictures to have its viewport set on the command line. Instead of drawing the entire (potentially very large) picture, only draw one viewport's worth. example: bench_pictures <skp directory> --viewport 640 480 BUG=https://code.google.com/p/skia/issues/detail?id=1007 Review URL: https://codereview.appspot.com/6943052 git-svn-id: http://skia.googlecode.com/svn/trunk@6799 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
5a34fd3f9876174aea8b22e1b585b4244e71b0b1 |
|
10-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add '--mode clone' option to bench_pictures git-svn-id: http://skia.googlecode.com/svn/trunk@6735 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
fe7b1ed30a75cecfe80d1ba4d1f60295e99aeef0 |
|
29-Nov-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkPictureUtils::GatherPixelRefs() Review URL: https://codereview.appspot.com/6845106 git-svn-id: http://skia.googlecode.com/svn/trunk@6615 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
4a26d9d62a6d762a518c0ca08d43189916b75cf2 |
|
07-Nov-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add a new PictureRenderer that draws the picture then breaks up into tiles. Review URL: https://codereview.appspot.com/6820103 git-svn-id: http://skia.googlecode.com/svn/trunk@6333 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
e3e940cf81dc46d872002ded98c1bd39c2daf1b0 |
|
07-Nov-2012 |
caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add low blur and AAClip options to picture bench. Copy the settings instead of pointing to the original set on the stack. Review URL: https://codereview.appspot.com/6818103 git-svn-id: http://skia.googlecode.com/svn/trunk@6330 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
a36223764466c964ed1035bf6f152ba55168f61e |
|
06-Nov-2012 |
caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add draw filter option to picture_bench Option allows adding a draw filter option per type or for all types. All SkPaint flags may be filtered, plus disabling blur and setting the hint level. Review URL: https://codereview.appspot.com/6816092 git-svn-id: http://skia.googlecode.com/svn/trunk@6318 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
7b53706a7d596a2d8dce6cfe5b543264e5a37239 |
|
06-Nov-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adding SkTileGrid: a new subclass of BBoxHierarchy, optimized for tiled playback. Review URL: https://codereview.appspot.com/6820093 git-svn-id: http://skia.googlecode.com/svn/trunk@6314 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
1aa90cf11e136a722bce71dd77f4bb03cc2b56f8 |
|
06-Nov-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@6306 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
a62da2fee72172a630c2d1dba0e529b357743662 |
|
02-Nov-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
In bench_pictures --multi, maintain thread local caches. Builds on https://codereview.appspot.com/6718046/ by mtklein. Previously, each iteration of drawing a picture started new threads to draw the picture. Since each thread is using thread local storage for the font cache, this means that each iteration had to start with an empty font cache. The newly added MultiCorePictureRenderer, separated from TiledPictureRenderer, now starts the drawing threads at the beginning of the test using an SkThreadPool, and keeps them alive through all iterations, so the font cache can be reused. For now, I have removed the pipe version of the threaded renderer. Updated bench_pictures_main and render_pictures_main to use the new renderer, and to unref a renderer before early exit. Review URL: https://codereview.appspot.com/6777063 git-svn-id: http://skia.googlecode.com/svn/trunk@6285 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
9313ca4bde606a18f29214eea8b8e47312b8fd9c |
|
02-Nov-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adding rtree support to the bench_pictures utility Review URL: https://codereview.appspot.com/6775080 git-svn-id: http://skia.googlecode.com/svn/trunk@6267 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
5a7c6be72b940dde8ff6ad2485a09aecd56a2660 |
|
04-Oct-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add the ability to provide function pointers to SkPicture serialization and deserialization for encoding and decoding bitmaps. Remove kForceFlattenBitmapPixels_Flag, which is no longer used. When an SkOrderedReadBuffer needs to read a bitmap, if it does not have an image decoder, use a dummy bitmap. In GM, add a tolerance option for color differences, used when testing picture serialization, so it can assume two images are the same even though PNG encoding/decoding may have resulted in small differences. Create dummy implementations for SkImageDecoder and SkImageEncoder functions in SkImageDecoder_empty so that a project that does not want to include the images project it can still build. Allow ports to build without images project. In Mac's image encoder, copy 4444 to 8888 before encoding. Add SkWriter32::reservePad, to provide a pointer to write non 4 byte aligned data, padded with zeroes. In bench_ and render_ pictures, pass decode function to SkPicture creation from a stream. BUG=https://code.google.com/p/skia/issues/detail?id=842 Review URL: https://codereview.appspot.com/6551071 git-svn-id: http://skia.googlecode.com/svn/trunk@5818 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
868e1f682eaff0a78ba61b3f1612cc6e7dd9c885 |
|
02-Oct-2012 |
caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix return value for render_pictures Review URL: https://codereview.appspot.com/6590049 git-svn-id: http://skia.googlecode.com/svn/trunk@5779 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
5987f58036574ccf23049b5fe71f29a441d0641d |
|
02-Oct-2012 |
caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
build iOS with 'make all' This builds all skia tests by treating iOS tools as executable applications. A few warnings were fixed as well. Removed old trace draw code and remnants. Review URL: https://codereview.appspot.com/6597063 git-svn-id: http://skia.googlecode.com/svn/trunk@5776 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
c6157be6c0ccd56d3eeb2601e6f1ca2fa403a543 |
|
27-Sep-2012 |
fmalita@google.com <fmalita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Pinspect and bench_pictures are crashing when invoked with no arguments. R=reed@google.com,scroggo@google.com BUG= Review URL: https://codereview.appspot.com/6575052 git-svn-id: http://skia.googlecode.com/svn/trunk@5706 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
2d2b9a0d8c78c62565e8eedeca3c337827d795c1 |
|
20-Sep-2012 |
borenet@google.com <borenet@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove automatic resizing in *_pictures Review URL: https://codereview.appspot.com/6554045 git-svn-id: http://skia.googlecode.com/svn/trunk@5614 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
bcdf2ec50dfd170959cc2db67c49f6dac084be03 |
|
20-Sep-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
In bench_pictures, use a pool of tiles for multicore drawing. Also includes some code cleanup and code sharing. Allow setting the number of threads on the command line. Rename ThreadSafePipeController::playback to ::draw, to be the same as SkPicture so DrawTileToCanvas can take a template parameter. Disallow multithreading with GPU turned on. Display help information with improper tiled arguments. BUG=https://code.google.com/p/skia/issues/detail?id=871 Review URL: https://codereview.appspot.com/6536050 git-svn-id: http://skia.googlecode.com/svn/trunk@5602 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
57837bff3db1f8cf22c2147e1bed49cf718f8b39 |
|
19-Sep-2012 |
borenet@google.com <borenet@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Skip empty directories and input files not ending in .skp in *_pictures Addressing https://code.google.com/p/skia/issues/detail?id=886 Review URL: https://codereview.appspot.com/6531047 git-svn-id: http://skia.googlecode.com/svn/trunk@5597 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
13fd5a15a170c0d024f4907991d8a57d8adf755e |
|
17-Sep-2012 |
borenet@google.com <borenet@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Set DEFAULT_REPEATS to 1 bench defaults to 1 repeat, so bench_pictures should do the same. This is causing the Android build cycles to be *hours* long. Review URL: https://codereview.appspot.com/6490123 git-svn-id: http://skia.googlecode.com/svn/trunk@5575 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
66bcbd12bf075145e0c38f3e36c9f13e65f5e10e |
|
17-Sep-2012 |
borenet@google.com <borenet@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Check for invalid SkPictures - Remove hasRecorded() since nobody uses it. - Add "success" boolean to SkPicture stream constructor - Track failures in render_pictures and bench_pictures Review URL: https://codereview.appspot.com/6493105 git-svn-id: http://skia.googlecode.com/svn/trunk@5573 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
e21795e277aa7942a152c4f9921b7d4bd9076406 |
|
14-Sep-2012 |
borenet@google.com <borenet@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Enable automatic rescaling in bench_pictures bench_pictures with "--device gpu" is failing because we're trying to allocate too much GPU memory. Move the recently-added scaling code into picture_utils and share it between render_pictures and bench_pictures. Review URL: https://codereview.appspot.com/6495125 git-svn-id: http://skia.googlecode.com/svn/trunk@5543 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
a49bffdb034d71f025f4cbc630458f748de72428 |
|
13-Sep-2012 |
borenet@google.com <borenet@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Do not exit on failure to open logFile Temporary solution for write-protected Android devices. Intention is to revert in favor of a more permanent solution. Review URL: https://codereview.appspot.com/6497132 git-svn-id: http://skia.googlecode.com/svn/trunk@5535 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
5239c32d1e1515bef20ec2544811c0f6924f0933 |
|
11-Sep-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add -logPerIter, -timers, and -min to bench_pictures. Additional changes: Add instance count to bench_pictures. Remove various PictureBenchmark subclasses which did not do anything besides have a different PictureRenderer. BUG=https://code.google.com/p/skia/issues/detail?id=856 Review URL: https://codereview.appspot.com/6496109 git-svn-id: http://skia.googlecode.com/svn/trunk@5496 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
0a36f43d5f710c47b63bc4bbfde9bbb7d59a88d1 |
|
10-Sep-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Init graphics in bench_pictures. Should fix http://code.google.com/p/skia/issues/detail?id=858 Review URL: https://codereview.appspot.com/6490100 git-svn-id: http://skia.googlecode.com/svn/trunk@5475 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
9a4125283ad56cea3b986337cb669dde14bf0ed8 |
|
07-Sep-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Report data from bench_pictures in the same fashion as bench. Move SkBenchLogger into separate files and make bench_pictures use it. Remove sk_tools::print_msg, since SkBenchLogger is now used instead. Combine picture_benchmark with bench_pictures, since that is the only project that uses it. Refactor the aggregator for bench timer data into its own class and make bench_pictures use it. Consolidate the various virtual PictureBenchmark::run functions into one for reuse. BUG=https://code.google.com/p/skia/issues/detail?id=822 Review URL: https://codereview.appspot.com/6488086 git-svn-id: http://skia.googlecode.com/svn/trunk@5432 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
58b4ead36c62d8c0256ee4da554f3df2744d904c |
|
31-Aug-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Perform multi core rendering in bench_pictures. Add a flag in SkGPipeWriter for threadsafe drawing. Add a deferred pipe controller to SamplePipeControllers, which can be called to play back in multiple threads. Depends on http://codereview.appspot.com/6459105/ Review URL: https://codereview.appspot.com/6482068 git-svn-id: http://skia.googlecode.com/svn/trunk@5371 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
f4959ab11827bef99e8985031feb457cae1f987a |
|
23-Aug-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implemented power of two tiling. Review URL: https://codereview.appspot.com/6485056 git-svn-id: http://skia.googlecode.com/svn/trunk@5274 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
db9a5fb55f77935774f21e07a04b6d1350ca54cc |
|
21-Aug-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Benchmark results will now print to STDOUT if on not-Android. Review URL: https://codereview.appspot.com/6446164 git-svn-id: http://skia.googlecode.com/svn/trunk@5215 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
a40c20df0e4c5d04acb0841d70127778c0a779ec |
|
20-Aug-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed up SK_SUPPORT_GPU flags. git-svn-id: http://skia.googlecode.com/svn/trunk@5186 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
c81686cd6edba2cfedcfd5ad6a164f160ddfb49f |
|
20-Aug-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added the option to enable GPU rendering on render_ and bench_pictures. git-svn-id: http://skia.googlecode.com/svn/trunk@5183 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
78a35c5f1dcc00b2b442069a94f9e7c996f8d7f9 |
|
20-Aug-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Changed to Yoda style comparisons where appropriate. git-svn-id: http://skia.googlecode.com/svn/trunk@5176 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
fe6391a624f98b1c70581ac86d5733afe11872d3 |
|
20-Aug-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Have GPU based approach workingish. Benchmarks do not work and it is always on. git-svn-id: http://skia.googlecode.com/svn/trunk@5175 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
795cd47342509da7924e703bc5c8503cbf00b10a |
|
02-Aug-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
render_pictures and bench_pictures now use a --mode parameter. This replaces the --tile, --pipe, etc. options from before as they are mutually exclusive. Review URL: https://codereview.appspot.com/6443076 git-svn-id: http://skia.googlecode.com/svn/trunk@4930 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
163b56734fe01c088581895a8e0b65ddf1cb4fa5 |
|
01-Aug-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Merged bench_pictures and render_pictures rendering methods. bench_pictures now uses a class based method for choosing the benchmark type as well. Review URL: https://codereview.appspot.com/6452070 git-svn-id: http://skia.googlecode.com/svn/trunk@4894 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
fc91dc70042dcb6d2868e8822fbab15aa4402375 |
|
26-Jul-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Windows compiler complaint cleanup http://codereview.appspot.com/6441055/ git-svn-id: http://skia.googlecode.com/svn/trunk@4796 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
21e3ed2e9af0e4b5ae813334e631714d198f9d94 |
|
16-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
bench_pictures now has an option for benchmarking record time. Review URL: https://codereview.appspot.com/6350102 git-svn-id: http://skia.googlecode.com/svn/trunk@4632 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
1cbd47c4b1e44658013512a7b1086d8af71237a8 |
|
13-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Preparations for adding options and different render types to render_pictures. Review URL: https://codereview.appspot.com/6345107 git-svn-id: http://skia.googlecode.com/svn/trunk@4603 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
3e8483e0ded180202fcf69a541b8d8d72239855e |
|
13-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Benchmark tiling now better reflects how it is done in Chrome. Namely, the tile backing stores are all the same size. Review URL: https://codereview.appspot.com/6352099 git-svn-id: http://skia.googlecode.com/svn/trunk@4602 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
b5e30abbebd792982b0b3cf8380ec503b41049e4 |
|
12-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Changed cmsecs to msecs to be consistent with bench. We are using wall time and not cpu time and so the proper name for this should probably be outputted. Review URL: https://codereview.appspot.com/6345104 git-svn-id: http://skia.googlecode.com/svn/trunk@4587 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
4916971526d53d873179ba1377e128a3a38a0056 |
|
12-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added a benchmark for measuring picture unflattening time. Review URL: https://codereview.appspot.com/6354097 git-svn-id: http://skia.googlecode.com/svn/trunk@4582 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
a4091ba864207fc3750bbd722edbdd8a94230b0e |
|
10-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Each benchmark that needs a bitmap will now make its own. Before, the bitmaps were created and then passed to the benchmark. However, some benchmarks in the future will not require bitmaps. This will remove the necessity of passing around an extraneous bitmap to those tests. Review URL: https://codereview.appspot.com/6356081 git-svn-id: http://skia.googlecode.com/svn/trunk@4519 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
0665f25b31890cc3923511d7db27de348864bc3c |
|
10-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
bench_pictures can now take percentages for tiling width and height.Review URL: https://codereview.appspot.com/6354074 Review URL: https://codereview.appspot.com/6354074 git-svn-id: http://skia.googlecode.com/svn/trunk@4516 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
59f46b81f8bdd1b524f5cc43bc27603f9604c71a |
|
10-Jul-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed Windows compiler complaints http://codereview.appspot.com/6392044 git-svn-id: http://skia.googlecode.com/svn/trunk@4511 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
2724ae0bb177ce604ee82b912b01fbbae72c1617 |
|
10-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
bench_pictures will now output the number of tiles for a tiled benchmark. Review URL: https://codereview.appspot.com/6387044 git-svn-id: http://skia.googlecode.com/svn/trunk@4507 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
70b4222344fc290ba03922ce246da2b3e980071d |
|
09-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Tiles that extend beyond the picture are now clipped. Review URL: https://codereview.appspot.com/6352078 git-svn-id: http://skia.googlecode.com/svn/trunk@4491 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
cf6c44cf9287af8b425fb0d9d286a6d57ad03897 |
|
09-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added a sgpipe benchmark. Review URL: https://codereview.appspot.com/6349070 git-svn-id: http://skia.googlecode.com/svn/trunk@4490 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
d1dc920097194e3342355185528c84408a9929c8 |
|
09-Jul-2012 |
keyar@chromium.org <keyar@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow specific files and multiple inputs for picture testing tools. Changed the render_pictures, bench_pictures and test_pictures.py so that multiple inputs can be given. Furthermore, specific files can also be specified. Unit tests have also been added for picture_utils.cpp. Review URL: https://codereview.appspot.com/6345054 git-svn-id: http://skia.googlecode.com/svn/trunk@4486 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|
006db0f1b8d85caea7ac37bc1fca133eca74aac8 |
|
27-Jun-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
land https://codereview.appspot.com/6349043/ git-svn-id: http://skia.googlecode.com/svn/trunk@4375 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/bench_pictures_main.cpp
|