| 725a4a71b8f2a5493628d87556c78860f66d2308 |
13-May-2015 |
Kenny Root <kroot@google.com> |
Start handshake before calling hostname verifier, part 2
If the hostname verifier calls SSLSocket#getSession() before the
handshake has been started, it will implicitly start the handshake.
However, it will swallow any errors and return the canonical invalid
SSLSession instead. This makes it extremely difficult to debug issues.
Instead start the handshake before calling into the verifier since we
are guaranteed to be the first caller of #startHandshake() and won't
cause a renegotiation. That will allow us to see the actual
SSLHandshakeException if it occurs.
Follow up for change 317c0a4959df0361431d5fbf7dacc162bfb48cd2
Bug: 21118659
Change-Id: I8c606a78ba8a990b4e0d28880b566867261fefbc
onn/ssl/SSLSocketFactory.java
|
| 423a47bb025e8e15c9c25c4500315f8013637097 |
13-May-2015 |
Kenny Root <kroot@google.com> |
Start handshake before calling hostname verifier
If the hostname verifier calls SSLSocket#getSession() before the
handshake has been started, it will implicitly start the handshake.
However, it will swallow any errors and return the canonical invalid
SSLSession instead. This makes it extremely difficult to debug issues.
Instead start the handshake before calling into the verifier since we
are guaranteed to be the first caller of #startHandshake() and won't
cause a renegotiation. That will allow us to see the actual
SSLHandshakeException if it occurs.
(cherry picked from commit 317c0a4959df0361431d5fbf7dacc162bfb48cd2 in
external/apache-http)
Bug: 14975169
Bug: 17332309
Bug: 17524215
Bug: 17812533
Bug: 18507278
Bug: 19069992
Bug: 19378885
Bug: 19414083
Bug: 19550311
Bug: 19731556
Bug: 19853723
Bug: 20908941
Bug: 21118659
Change-Id: Ie74ec12c8b131c7bf400a07fc91c78da4d5e470f
onn/ssl/SSLSocketFactory.java
|
| 3bdd327f8532a79b83f575cc62e8eb09a1f93f3d |
27-Nov-2014 |
Narayan Kamath <narayan@google.com> |
Move apache specific portions of android.net.http to external/apache-http.
We continue to compile external/apache-http into ext.jar. This contains
a few changes apart fom the classes moving around :
- Makefile changes to build docs and api-stubs for now. A future change
will revert these changes and remove these classes from stubs and
docs.
- Hardcode event IDs in legacyerrorstrings to avoid a dependency between
the frameworks and apache. These strings are on their way out and will
never change anyway.
- Remove imports due to {@link} tags and use {@code} instead.
- Remove an accidental(?) dependency on apache commons code that's a
part of apache-http.
bug: 18027885
Change-Id: I51cd038d846ec7d02c283a4541b10a6a9cf62ecf
onn/ConnectTimeoutException.java
onn/scheme/HostNameResolver.java
onn/scheme/LayeredSocketFactory.java
onn/scheme/SocketFactory.java
onn/ssl/AbstractVerifier.java
onn/ssl/AllowAllHostnameVerifier.java
onn/ssl/BrowserCompatHostnameVerifier.java
onn/ssl/SSLSocketFactory.java
onn/ssl/StrictHostnameVerifier.java
onn/ssl/X509HostnameVerifier.java
onn/ssl/package.html
arams/CoreConnectionPNames.java
arams/HttpConnectionParams.java
arams/HttpParams.java
|