| 4785c51daa895a961cbf85cc6c80ef3bb4a3b331 |
|
26-Jun-2015 |
Brian Attwell <brianattwell@google.com> |
Set package name on ACTION_PICK intent
This prevents the disambiguation dialog from appearing. As
a result, the user no longer has the ability to decide
whether to use their Work or Personal Contacts app. This
prevents the intent from becoming cross-profile.
Bug: 17472472
Change-Id: Ica5a9bf960a016f735caf933da5cc8fa6aa7614c
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 5234be9645f202e94e9e0872efaa6ce9486dbf55 |
|
14-May-2015 |
Brian Attwell <brianattwell@google.com> |
Allow setting photos in managed profile
Bug: 20628786
Change-Id: I42bc27574d40b7725e64743961c250a5682f66f7
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| bdd32641ae2c2bc6214608cc5712dfb2b96e0305 |
|
09-May-2015 |
Brian Attwell <brianattwell@google.com> |
Handle runtime permissions
For now, we handle runtime permissions in the most
hamfisted and maintainable way possible: don't let
any Activity's be fully created unless we get all the
runtime permissions.
Bug: 20066216
Change-Id: Iaab9ad2a8106d34b5e20a1eae1ef7a5560dc49a2
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| a9433713594c990cd3b0ac5a44e316e4b54992b0 |
|
28-Feb-2015 |
Jay Shrauner <shrauner@google.com> |
Fix NPE when copying photo URI
Bug:19564741
Change-Id: I0a4e0ccf2a917d403d1411fc737da293c81aded0
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 4a1c574cd62eb7ca1e0fcc3a61e5378e5e0787fe |
|
27-Jan-2015 |
Brian Attwell <brianattwell@google.com> |
Add Insert.EXTRA_{ACCOUNT,DATA_SET} to API. P #2/2
Bug: 18777272
Change-Id: I17a5b7cb4d4c5a0ba48936a6fc829acaab73f31d
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 67e83223e954ed54898daa5e32400dbff6d3831a |
|
09-Jan-2015 |
Jay Shrauner <shrauner@google.com> |
Local account handling cleanup
Clean up null account handling and update local account detection to allow
for a non-null account to represent a local account.
Bug: 18959158
Change-Id: I0d5f7acb7d9a8d1ba7b6d3a4e0b6584e3646934a
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| b76f86d1a416522bac1f88ec4aa9a574ac58cfb1 |
|
10-Oct-2014 |
Brian Attwell <brianattwell@google.com> |
Fix inserting photos into unwriteable contacts
When someone tries to ATTACH_DATA a photo onto an unwriteable contact,
insert a writeable raw_contact into that contact in order to
make this possible.
Sometimes we need to prompt the user to set their backup account,
which is a bit awkward.
Testing: I manually tried inserting photos into an unwriteable contact,
in the following ways:
* Only having a witeable account on the phone (WhatsApp and nothing else)
* Not having a writeable account on the phone and opting to store locally
* Not having a backup account set, and choosing the default when
inserting a photo
* Not having a backup account set, and not choosing the default when
inserting a photo
* Having a backup account set (this is the case from b/14577185
Bug: 14577185
Change-Id: I9b8b5f5108725e8b69b58fd12f7aaa52d2a7d531
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 66f778ef8118cfb8521e16c1cb0520694d1597ff |
|
01-Jun-2014 |
Jay Shrauner <shrauner@google.com> |
Fix exception when no app to crop photos
Catch ActivityNotFoundException when attempt to crop photo before
setting as contact photo.
Bug:15361188
Change-Id: I37c66cc11b14ec0621464334875f9946a89095ae
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 0b211b11c2049c51baf6c8746d308179f2e5db96 |
|
26-Apr-2014 |
Yorke Lee <yorkelee@google.com> |
am 1a576923: Merge "Check whether the contact exists when saving the contact"
* commit '1a576923d9eaa74f68076227949fdcfade5baa9c':
Check whether the contact exists when saving the contact
|
| 342de108624e4c3c796050624572d2f1f815dcd3 |
|
05-Jun-2013 |
jiezha2x <jiex.z.zhang@intel.com> |
Check whether the contact exists when saving the contact
Step to reproduce it on Nexus 4 with 4.4.2:
1.Launch Gallery app-->Random select one picture-->"Set picture as"
-->"Contact photo"-->Random tap one contact-->"Crop picture"-->
"Just once"-->crop the picture-->press home key
2.Launch People app-->delete the contact which selected in step1-->
press home key-->Launch Gallery app again-->"Save"
When I set a picture cropped for a contact, before doing the save
operation, I delete the contact, now go on doing the save operation,
because the contact does not exist, the RawContacts is null, so the
function createRawContactDeltaList occurs a crash.
Change-Id: Ie6d26ff188790937e16915e636e4b484cacb12a4
Signed-off-by: Zhangjie <jiex.z.zhang@intel.com>
Signed-off-by: guojingx <guojingx.wu@intel.com>
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| de047f43f7b113f256e573fe586b86a18ebd6d80 |
|
18-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix crash in getPhotoPickSize
Handle null or empty cursors.
Bug:12619944
Change-Id: I5cae8c16e29474afbc78a172f39bbb04daec446a
(cherry picked from commit b126f4a7427095468ee66fa4c3b9586f0b889288)
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 6a4db337c716d739c55b0c154eb16770a4b917e4 |
|
04-Mar-2014 |
Jay Shrauner <shrauner@google.com> |
Merge "Fix NPE on non decodable Bitmap" into klp-dev
|
| 1e090bfaee34b45e1127dc1549bae1d60ca75b66 |
|
30-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE on non decodable Bitmap
Fix so don't crash if unable to decode Bitmap that user is attempting to
assign to a contact.
Bug:12819739
Change-Id: I34f31b1e84a76a15d4de92ccd5544ff502743079
(cherry picked from commit 5d170911503c81aca63a9a089aeb0c5664ef0487)
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 946ebfa1d649e9efd17b50d84111996c5c84970b |
|
15-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE on null cursor close
Only query once for photo dimensions. Don't crash if cursor is null.
Use default of 720 if unable to query provider.
Bug:12552331
Change-Id: I2bd5ad3db86316b3e61d719bc44b524de8758387
(cherry picked from commit 409737c0585f374e2cd0ad1fea9128905a276b85)
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| cd321f65f1e50409812976380ad1f0fdb3fa35cb |
|
28-Oct-2013 |
Yorke Lee <yorkelee@google.com> |
Move ContactLoader related code to ContactsCommon
This CL simply moves classes from Contacts into ContactsCommon.
This is needed so that Dialer can use ContactLoader related code
for b/11294679. A ContactLoader will also be needed in the future
to allow InCallUI to download hi-res photos while in call.
Bug: 11294679
Change-Id: Ia033f3ea2406a907a4e71290c9ce810a5583dab8
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 2518abdb0c4a268a8607a4b6247bcde899b2628d |
|
29-Sep-2013 |
Yorke Lee <yorkelee@google.com> |
Fix NPE in AttachPhotoActivity after rotating while cropping
One of the uris was not getting saved to the persisted bundle after
activity destruction.
Bug: 10972558
Change-Id: I9d6174cee18a6cd2786b6fe3ab99a3bdb33129ca
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| adeadcf055fee765df22c479fc0afc9a3e4d5e66 |
|
20-Sep-2013 |
Yorke Lee <yorkelee@google.com> |
Fix security exception when setting contact photo from Downloads
Bug: 10842701
Change-Id: I56936ee7a656a6e5418d15082365f4f38b109221
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 637a38ec9de6b1f434d7a13105f2e747faae5107 |
|
14-Sep-2013 |
Yorke Lee <yorkelee@google.com> |
Make contacts photo pickers compatible with new documents UI
The old contacts photo picker code was using unguaranteed behavior
(that Intent.GET_CONTENT would support MediaStore.EXTRA_OUTPUT) and this
caused it to not work anymore with the new document picker.
This CL changes all usages of files to instead use URIs.
Also, a FileProvider has been added to Contacts, to allow us to pass in
URI pointing to our private cache in intent.setClipData with
Intent.FLAG_GRANT_WRITE_URI_PERMISSION and Intent.FLAG_GRANT_READ_URI_PERMISSION
so we no longer have to reply on the MediaStore.EXTRA_OUTPUT being parsed
and supported. The use of the FileProvider also prevents unauthorized access
to temporary files during the caching process.
Bug: 10745342
Change-Id: Iaee3d7d112dd124a2f5596c4b9704ea75d3b3419
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 738ff8623dc77dd91a1b9023861e924ba5e4c27e |
|
30-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move ValuesDelta to ContactsCommon.
Bug: 6993891
Change-Id: I8b065c55100a152f72cccea5b62f10a8e30161c2
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| aa690d4949b8105e5bcf10569b7cf4fae36741de |
|
29-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Prefactor RawContactDelta.ValuesDelta into top level class.
Making ValuesDelta into top level class so we do not have to move
RawContactDelta into ContactsCommon. ValuesDelta is used by
CustomContactListFilterActivity which needs to be moved.
Bug: 6993891
Change-Id: If7371cf08ac0e14218fb790c96856e971fa613ec
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 428f008513d1591cc08fcfe2cf0c9237fb313241 |
|
14-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move dependencies of AccountTypeManager into ContactsCommon.
Moving dependencies in preparation to move AccountTypeManager.
Bug: 6993891
Change-Id: I804cdbe64b9b8111ed286037943d593e11dc4044
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 47b6f70eadb118d815b4aaf5426c070bd75a38fb |
|
08-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Refactor RawContact to be parcelable.
- Re-work of RawContact to be a real data container and removed un-necessary
dependencies.
- Removed un-necessary circular dependency between RawContact and DataItem.
- Cleaned up and made DataItem more compartmentalized by removing un-related
account methods.
- Implemented Parcelable for RawContact and NamedDataItem.
Bug: 6406182
Change-Id: Icd84f34d85e1349a86e473708cc7f8fece12349f
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 61414c2c4627ab588cc0f54eae5e0c5591f7d8d9 |
|
19-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Fixed bug where contact photo did not scale up when cropped.
- Added scaleUpIfNeeded extra to gallery intents.
- Consolidated gallery "extras" code into common utility method.
Bug: 6678247
Change-Id: I4c2b9fb2a88d203fe06303b470f0eb35a5cc6766
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 45ee872fe7be69c6b3f0c59167eecd11af467812 |
|
22-May-2012 |
Makoto Onuki <omakoto@google.com> |
Don't send view notification before showing quick contact
Instead, do this in the second load. This directly affects the quick contact
startup time.
Bug 6529921
Change-Id: Ief7bda9bd32cb4be0c86c4b79efb35da812721dc
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 4a964d983b65871bcc08fe16baea8cf2e0994061 |
|
11-May-2012 |
Josh Gargus <jjosh@google.com> |
Disable "Create new contact" when setting photo from gallery.
Bug: 5288751
Change-Id: I8c2c56ca44b5bdca56b7b20a1dfe510ec08a76c3
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| ebc17929007ecf12f25b8e90023766e8a083d11e |
|
05-May-2012 |
Josh Gargus <jjosh@google.com> |
Don't stash cropped photos in /sdcard/DCIM.
Every time we choose a new contact photo (either an existing one from
the gallery or a new one from the camera), we write the cropped image
/sdcard/DCIM. As a result, the cropped image (eventually) appears in
the gallery, is uploaded to G+, etc.
The new behavior is to write the cropped photo to a temp directory,
and to clear it when we're done with it.
Revert some of the changes from Ib7037a66; we still need to persist
properties in onSaveInstanceState() in case ContactEditorFragment is
killed while the user interacts with the camera/gallery.
Bug: 6423139
Change-Id: Icf8cb5b4824e3d8757ff483ef128527ac9132e72
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| dd3dc56d035914f80147fd8fa100a849f9215a3d |
|
25-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Remove Listener from ContactLoader as it is never used
Change-Id: Iee791ccd6ce1ebb8a81375e1d60f31fbb91bbb16
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| e5d3f897689c8ba0f275c7679c72eacb190ae9b8 |
|
11-Apr-2012 |
Josh Gargus <jjosh@google.com> |
Fix regression; once again we can apply Gallery photo to contact.
The changes to support hi-res photos in Ic0cabaa5 were not applied to
AttachPhotoActivity. This CL makes the analogous changes, and many other
cleanups besides.
In addition, applying the Gallery photo works even if the AttachPhotoActivity
is killed (eg: when selecting a contact, or when cropping the photo); this
didn't work even before the regression.
The save-contact Intent which invokes the ContactSaveService no longer
needs to specify a callback Activity (it is OK to pass null if you don't
care about getting a callback).
The subclasses of PhotoSelectionHandler have been significantly simplified,
partly by pushing common behavior to the superclass, and also by directly
accessing state in their outer class instead making their own copies.
ContactLoader.Result.getEntityDeltaList() is a new instance method that
replaces more verbose incantations.
New utility class, ContactPhotoUtils. Helps with compressing Bitmaps, and
generating temp-file names used when saving hi-res photos to a contact.
Bug: 6298601
Change-Id: I2fe90c33c9fa81716f263d82ed80c0d6f63c6a7e
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 6fa7384a1a5576ace18159de61af91c8b7c34dc6 |
|
28-Sep-2011 |
Dave Santoro <dsantoro@google.com> |
Allow adding/replacing a photo from contact card.
This involves a large refactoring of the photo handling code that
previously lived in ContactEditorFragment. The bulk of that logic
has been extracted out into PhotoSelectionHandler and
PhotoSelectionActivity classes.
As part of this change, also removed the selection highlighting when
tapping on the current tab header in multi-tab views.
Bug 5294297
Bug 5379389
Change-Id: Ic929e4b4a730d91f768a34367bb76967228ded17
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 0a2a5db3b3633883388953dc98e30c2edd7cae62 |
|
29-Jun-2011 |
Dave Santoro <dsantoro@google.com> |
Contacts App modifications for large photos.
Most of the work is on the provider side - essentially, the
provider will now deal with any size photo, downsizing it as
necessary to fit in a display size and thumbnail size. So
on the client we just need to pass in a larger photo to get a
hi-res display image for the contact.
Also switched a few spots to use the PHOTO_URI (with
openAssetFile) instead of PHOTO_THUMB_URI - more likely
remain.
Change-Id: I6ff8dd5453a9ff787907ab113d6e8aa6a71fcae1
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 6f667b55687bf9193323802e8f3234f0ab254388 |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Turning AccountTypeManager into a "system" service.
It's really not a system service proper. It just
uses the same API and the same dependency injection
mechanism as for system services.
Change-Id: I56e24e0f16642a5ab25e809ee12906d965845379
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|
| 19d51ac4d931c17c8d84b65ed13199c0ccdeb20e |
|
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming an activity class. Removing dead code.
Change-Id: I509fa747441d8d3d5168aa07a4ada4434f02d190
/packages/apps/Contacts/src/com/android/contacts/activities/AttachPhotoActivity.java
|