History log of /packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
ae9c9ec49c460d34f7c649c3a3bf684fc5ef262d 08-Jul-2015 Walter Jang <wjang@google.com> Hide all empty email and phone KindSectionViews expect the last

Bug 22331611

Change-Id: I5c4544ed3cc82982f159f7c1758a1e6cd8868c48
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
995bb4af702a619bda3819daeeaa68c55d9e96bd 06-Jul-2015 Walter Jang <wjang@google.com> Don't delete kind sections when there are >1 emails in the raw contact

* Also fix jank when deleting compact editor input fields
We were animating removal of input fields when there was more
than one field in the raw contact (i.e. Editor.deleteEditor)
but not when hiding entire KindViewSections
(i.e. KindSectionView.setVisibility(GONE)). When animating
KindSectionView removals, we must mark it for deletion
since we need to re-assess the number of KindSectionViews that
are visibile (in order to show icons) before the removal
animation finishes (the visibility is set to GONE at the end
of the animation).

* Prevent nicknames from being deleted

Bug 22228718
Bug 22299522

Change-Id: I28dad184c53e89f067d54675fcb3e7ebac9d971e
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
19d985fd21c6a9652c1b642bb0b4e6903a26d2e6 01-Jul-2015 Walter Jang <wjang@google.com> Group non-phone and email fields together on compact editor

Bug 22228718

Change-Id: I561ee25bad95a716744ba7d74fb6b49463b029da
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
4a9351db3c8385469bad037544d4b60d76504f5e 30-Jun-2015 Walter Jang <wjang@google.com> Fix showing all phone nums and emails for joined contacts

We must delete the entire KindSectionView for emails and
phone numbers for all but the last raw contact that is being
edited.

Also, icons must be updated whenever an editor housed in
a kindview is deleted since we only want to show the icon
once for all the kindviews added to the compact layout
for all the raw contacts in the delta list.

Bug 22203548

Change-Id: If12c4fc10a9c9c09cbcfb86c5bf1472d89f6b890
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
c4cecc7e7534c7f5d887222d9e6f1a43364f7665 25-Jun-2015 Walter Jang <wjang@google.com> Show google account types on editor as "account" instead of "contact"

Also, missed the copy of the account type display lable setting
logic for read-only contacts in ag/712716 so replacing that with
the static utility method.

Bug 18719390
Bug 21637149

Change-Id: I112b32a25d4d3682ca8e58ef327660bd163cb273
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
2d3f31c210ffc617e82e3b41fc32b54ec2a5011a 19-Jun-2015 Walter Jang <wjang@google.com> Show account info for inserts and read-only contact edits

Bug 21637149

Change-Id: I224ab188230f119f49f4ab7ddef4b51c451aa892
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
fa127a1c0ca95139664771edc3d5d97331c93b19 18-Jun-2015 Walter Jang <wjang@google.com> Allow users to edit photos for read-only contacts again

Similar to ag/711429 (for editing read-only names), we set the
photo bitmap from the read-only contact but set the newly created
(and writable) raw contact as the delta underlying the photo editor
view so that if the photo is updated by the user, the new raw
contact is set as changed and not the read-only raw contact.

Bug 21873945

Change-Id: Ibd40f3d708332fe6f87d247773b871d575d7d12e
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
06f73a15ed812d99ea28d836b02a5538bb1200c9 17-Jun-2015 Walter Jang <wjang@google.com> Ignore new raw contact display names when saving contacts

Now that we have logic to ignore the display name
we add to newly created raw contacts (when the
user wants to edit a read-only contact) when
determining whether the user made any edits,
we can enable changing the display on the compact
editor again.

Note, there is one glitch -- the name disappears
on the compact editor after you click more fields
(but only when editing read-only contacts).

Tested scenarios:

1) Edit read-only contact, more fields, back, back

No bogus contact is created and the read-only
name is displayed on both editors.

2) Edit read-only contact, change name on compact
editor, back, re-edit read-only contact, and split

The read-only contact is unchanged and a new
contact with the edited name is created.

3) Edit read-only contact, more fields, change name on
full editor, back, back, re-edit read-only contact,
and split

Same result as (2)

4) Edit read-only contact, add phone on compact
editor, back, re-edit read-only contact, and split

The read-only contact is unchanged and a new
contact with the read-only name and phone number is
created.

5) Edit read-only contact, more fields, add phone on full
editor, back, back, re-edit read-only contact, and split

Same result as (4)

Bug 21858251
Bug 21464081

Change-Id: I9028fee38b8ea7569968654a756eb98025318e69
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
0299c1d4ff397d57dbc87d1bd453077cafbb36b7 17-Jun-2015 Walter Jang <wjang@google.com> Merge "Don't allow read-only photos to be changed in compact editor" into mnc-dev
ab50e6f5cf14e1bdb6cd3598372fefc2fa6b0b83 15-Jun-2015 Walter Jang <wjang@google.com> Don't allow read-only photos to be changed in compact editor

Also don't display compact editor photos for non-editable contacts

Bug 21873945

Change-Id: I7523e9cc7f8342e546659ede6a3dd822d790a259
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
65d3520d3cee5c3c4c4c213adf210d008c0a0409 16-Jun-2015 Walter Jang <wjang@google.com> Don't allow read-only names to be changed in compact editor

Bug 21858251

Change-Id: I3a66d30123ae1a64acbd162f7991a56cf37bcc72
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
398cd4b1fbfa7d2fabfc4addf6a156a841a5aa6a 16-Jun-2015 Walter Jang <wjang@google.com> Pass the preferred name ID into the contact editor

Bug 21870691

Change-Id: I99cc6bf8d90f32469ca7cf105567dcc3edf48e9f
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
c59de249035f7149afa39d020cd2a1b2f972ef68 15-Jun-2015 Walter Jang <wjang@google.com> Don't set super primary name on compact editor unless it changes

Also fix the contact being loaded unnecessarily when transitioning
to the full editor.

Bug 21464081

Change-Id: Ic833f64a073898c8524892428512ce65f2f14625
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
88b0a8cc7c512c5f28dad958da276974c845355c 08-Jun-2015 Walter Jang <wjang@google.com> Revert KindSectionView logic NOT show an empty input field

We don't need to make it optional to show an emtpy input
field since we've changed our minds on not allowing
users to add email and phone numbers on the compact editor.

Bug 21661221

Change-Id: Iec0d3a37a76c787d17922dbc184142dfca98a9de
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
ac679af994faece43536f1e8b2613f30c50300e1 01-Jun-2015 Walter Jang <wjang@google.com> Pass the preferred photo ID into the contact editor

Bug 21498424

Change-Id: I35e8fa3cff4d963f8017bdd596132fe749479a17
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
28c98b7511b4c00b47abcce83a713c9bccf1b74a 02-Jun-2015 Walter Jang <wjang@google.com> Can add mulitple email and phones on compact editor again

Bug 21162602

Change-Id: If484b5f3a0de2d6176863c19519ed63a45aa7c1d
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
a26490b189312af2b73e56a1c9a7da974f7831c6 27-May-2015 Walter Jang <wjang@google.com> Attach aggregation listener to super primary name field

Bug 21435555

Change-Id: I03bb5ee5650491338192796cd8fc132af50a5ce8
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
bf63a6d6a888b3e1b5fb91accf2dadaab4384539 05-May-2015 Walter Jang <wjang@google.com> Fix contact name passing from compact to full editor on inserts

Bug 19624360

Change-Id: I50c415b59c4bad1d08f18f8c2bc7d57ddb73c418
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
41b3ea1c712f01164feb55455f1391564cb76dee 10-Mar-2015 Walter Jang <wjang@google.com> Update compact editor photo to full res when possible

Bug 19655206

Change-Id: If30c7ba83851dcc7c98fa1be4bed92e302ba8245
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
3b21027019af908d9bbbc66785172541fae764e1 04-Mar-2015 Walter Jang <wjang@google.com> Update compact editor photo selection logic

* Look for non-empty super primary
* Look for any non-empty photo
* Use empty super primary (or the fallback ValuesDelta)

Bug 19124091

Change-Id: I2e397600802598d8ef820b0beb9cf85538c6b7a1
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
3a37a1a441dcc02ad93b8ccce15dda9f70caf5e8 04-Mar-2015 Walter Jang <wjang@google.com> Only show 1 phonetic name (per RawContactDelta) on compact editor

Also remove the delete button on the phonetic name
to be consitent with the fully expanded editor.

Bug 19124091

Change-Id: I851943a55d81723af7ec556f4dfef6de4f3d9b5d
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
151f3e6883e5785019f7b5083dc8baf3e305dc18 27-Feb-2015 Walter Jang <wjang@google.com> Try to show the "right" name on the compact contact editor

* If a super primary is set use it on the compact editor
* If a super primary is not set and the compact editor
name value is changed, set it as super primary. But
don't make an unchanged name super primary when expanding
to the full editor. Also unset super primary if
the name field becomes blank.
* On the full editor, set the last changed name to super
primary. Also unset super primary if
the name field becomes blank.

Bug 19124091

Change-Id: I1352f25f4decf31c5aeda20dbef133ce48d5d248
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
36d6a163bc31f76490d3bc0867a56437711bd1f7 20-Feb-2015 Walter Jang <wjang@google.com> Start the fully expanded editor when "More fields" is clicked

Note, StructuredName must be handled specially on inserts when it is
passed to the fully expanded editor when creating a new contact
because normally the contact name is not overriden.

Bug 19124091

Change-Id: I1d2b383c50b42a3624a7a8c18dd3278d7c3b069d
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
d35e5eff8737e757a4179d49dfe9c7db999b4e9d 24-Feb-2015 Walter Jang <wjang@google.com> Get join suggestions for the compact editor name field

Also fix photo height in portrait -- made a mistake in
ag/641233.

Bug 19124091

Change-Id: I988cbcf457002bc6f0996c87a8611fca82bdf78a
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
a5e4bb287ea08f895c84d5de56fcc2483386b306 24-Feb-2015 Walter Jang <wjang@google.com> Use a split screen for the compact contact editor in landscape

Also renamed the compact header since we're not doing the
toolbar over the photo right now.

Bug 19124091

Change-Id: I91032e149252d635d564064a3652df4cc0233c6c
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
0e72ce9d97e0133a5f7cc348eef363bef9395979 23-Feb-2015 Walter Jang <wjang@google.com> Show edit contact photo options is a dialog

* Instead of a ListPopupWindow. This is more consistent with
the behavior of the other edit contact menu options.
* Also add an option menu icon to change the photo to
make this feature more easily accessible and since
users may not realize they can click the photo to
launch the choices dialog.

Bug 19124091

Change-Id: Ia4c37b3093f39d55784323f9a6d7bcf49ee96d16
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
f46abd89a3386cbdadff99e96df826bb27f987e9 21-Feb-2015 Walter Jang <wjang@google.com> Apply the quick contact color to default photos in the compact editor

Bug 19124091

Change-Id: I375fc8c88ab7b1bd452fbeab0e3e6444b83be094
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
1044645b9c2050436f4f0e0c7e5b8da2931879ba 20-Feb-2015 Walter Jang <wjang@google.com> Hide extra empty kind editor on compact contact editor

* Also left align "More fields"
* Only show one structured name
* Be a bit smarter about the profile photo before
we have a real split screen

Bug 19124091

Change-Id: I046ea59437b035d43df045363677a3aaba0dca43
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
3efae4aeae8715fbfcf67c56f123da49330ea01a 18-Feb-2015 Walter Jang <wjang@google.com> First pass on photo support for compact contact editor

Only updates the primary photo for now.

Bug 19124091

Change-Id: I1886888b4cf249da4c483d570b9db6e05564518a
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
b6ca272f26b47ecef8fafe94326c4d553576c521 20-Feb-2015 Walter Jang <wjang@google.com> Add placeholder button for showing fully expanded contact editor

Bug 19124091

Change-Id: I8051b8df460fd0bbc30466d736c7606caaa0837c
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
e720fdeb3ef0892834d7ab9af8cc44dd9eb9be17 17-Feb-2015 Walter Jang <wjang@google.com> Always show email and phone fields

* This fixes showing an almost blank screen when
writing the "me" profile also when adding a new contact.
* Also fixed a bug when writing the "me" profile --
we weren't calling the RawContact.setAccountToLocal
in createNewRawContactDelta in the base editor fragment.

Bug 19124091

Change-Id: I93422047796189b4df060bfa39aa3c84ce47fa25
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
b1c8762a9a398617d54c5c669359e283689e24a0 14-Feb-2015 Walter Jang <wjang@google.com> Fix up names on the compact contact editor

* Don't show a blank structured name if there is a non-empty
value and don't ever show more than one blank structured
name either
* Group phonetic and nicknames together instead of interleaving
with structured names and each other
* Use a KindSectionView for nicknames (for now) so that it
isn't intended so differently from everything else.

Bug 19124091

Change-Id: I50f41c0a0efb39de98a5b96c7da47b6ad6243633
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
cab3dcec1401a32aff583d946b4a9f8af954358f 10-Feb-2015 Walter Jang <wjang@google.com> First pass on showing only non-empty field on compact edit view

Bug 19124091

Change-Id: I49660c326f5829540463295218530f0a2d0fad9d
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java