| 427566a204903098de1b7866d25f711918bb28d9 |
|
09-Jun-2015 |
Andrew Lee <anwlee@google.com> |
Fix CallLogFragment UnitTests.
Run "changeCursor" on the main thread. I'm not precisely sure why
this fixes things, but it appeared before that the data I had on my
local device was being used instead of the test data.
Bug: 21471763
Change-Id: I6bece02e7c6828d54f76b5221ad10cf8f0052aa9
/packages/apps/Dialer/src/com/android/dialer/calllog/GroupingListAdapter.java
|
| 492cd7371c6d8fddc4de85887a4ed9a89d602767 |
|
08-Apr-2015 |
Andrew Lee <anwlee@google.com> |
Replace ListView with RecyclerView in call log.
Yay, finally!
+ Replace ListView with RecyclerView in layout and fragment files.
+ Change GroupingListAdapter to extend RecyclerView.Adapter instead
of BaseAdapter.
+ Change CallLogListItemViews to extend RecyclerView.ViewHolder.
+ Adapt onBindViewHolder and onCreateViewHolder methods in the
CallLogAdapter.
+ Update/rework tests for related classes.
+ Fix a bug in the GroupingListAdapter, where childCount was not
updated for standalone views, and the previously cached group size
was used instead. Set childCount to 1 for standalone views.
- Removed the idea of creating different views for standalone vs
group vs group headers from the adapters. This logic has not been
used for quite some time and all these functions funneled into
createView/bindView methods anyways, so there is no logical
difference. If we need to create custom views in the future, we can
leverage onCreateViewHolder's viewType parameter.
Bug: 19372817
Change-Id: I1b7289340600609669db22d8bc89265240d0b561
/packages/apps/Dialer/src/com/android/dialer/calllog/GroupingListAdapter.java
|
| 07a5e0a68e95bc7e8098bb018004910dc97fa608 |
|
07-Apr-2015 |
Andrew Lee <anwlee@google.com> |
Move copy of GroupingListAdapter to Dialer app.
+ Copied in from com.android.common.widget. This component is pretty
specific to phone number / call log grouping anyways.
+ Changed CallLogAdapter to reference this GroupingListAdapter
instead of the one in the framework library.
+ Changed CallLogGroupBuilder to reference this adapter too.
+ Copy in tests too.
Next step: change GroupingListAdapter to extend RecyclerView.Adapter.
This will preserve existing grouping logic, despite switching to the
new view.
Bug: 19372817
Change-Id: Ic0186ca5fad06a3ae398b9d8f8006210077149dc
/packages/apps/Dialer/src/com/android/dialer/calllog/GroupingListAdapter.java
|