| c98a5bb2d806dde99325a15466a2bf144d216ae8 |
|
29-Oct-2014 |
Yorke Lee <yorkelee@google.com> |
Refactor ActionBarController and tests
The original CL to fix ActionBarControllerTest by using an
ActivityInstrumentationTestCase was too heavyweight and caused flaky
test. It was also indicative of a flaw in the original design that
ActionBar couldn't be mocked out easily.
Refactor the code so that:
1) getActionBar() is no longer needed
2) Respect the invariant that all access to the actionBar goes through the
ActionBarController (see the changes in ListsFragment) so that any change to
the ActionBar's hide offset can be tracked appropriately.
Bug: 17487016
Change-Id: I935b683ddb301ca5d3952889af1381bdbdcc97d3
/packages/apps/Dialer/src/com/android/dialer/widget/ActionBarController.java
|
| a524ae57ec8fce9532ed998c63a5577fce738fd5 |
|
06-Aug-2014 |
Yorke Lee <yorkelee@google.com> |
Fix some action bar logic
* Restore action bar slid state only after onCreateOptionsMenu, when it has
an effect
* ActionBarController is now the only way to make changes to the offset of
the action bar so that it can appropriately restore its state
Bug: 16710397
Change-Id: Id9e0ebe210c89df0be56b32aa3bbd959cce88621
/packages/apps/Dialer/src/com/android/dialer/widget/ActionBarController.java
|
| fd723cae1dc2de0f83ec14639d4431674dd3b82e |
|
19-Jun-2014 |
Sai Cheemalapati <saicheems@google.com> |
Update Emergency Dialer to match Dialer (3/7).
Emergency dialer style updated to match style in Dialer and
InCallUI.
Moved all dialpad resources to PhoneCommon.
Change-Id: I86747a58b196209a4543448ab939236eace7c52a
/packages/apps/Dialer/src/com/android/dialer/widget/ActionBarController.java
|
| 801d88e55c59414cee422ca0433cec8b1c39d1e6 |
|
20-Jun-2014 |
Yorke Lee <yorkelee@google.com> |
Revert "Update Emergency Dialer to match Dialer (2/5)."
This reverts commit 9598b51d20cb27acb8dfd47abf2accb612cddb3c.
Change-Id: I7c2d2b95740888af25b5b257572476b0f20900e3
/packages/apps/Dialer/src/com/android/dialer/widget/ActionBarController.java
|
| 9598b51d20cb27acb8dfd47abf2accb612cddb3c |
|
19-Jun-2014 |
Sai Cheemalapati <saicheems@google.com> |
Update Emergency Dialer to match Dialer (2/5).
Emergency dialer style updated to match style in Dialer and
InCallUI.
Moved all dialpad resources to PhoneCommon.
Change-Id: I69ee95b20b9a6a7007288a754e12ea20763c3842
/packages/apps/Dialer/src/com/android/dialer/widget/ActionBarController.java
|
| 1896344b53ddf6cdaf17dc02a05c45f587879d99 |
|
07-Jun-2014 |
Andrew Lee <anwlee@google.com> |
Revise remove view target positioning.
- Move placement from dialtacts activity layout to the lists fragment,
so that it can be positioned over the tab bar.
- Relocate references to RemoveView/RemoveViewContainer to the lists
fragment from the activity class.
- Set colors using tints, remove old highlight state asset.
- Fade out search bar and recent card when dragging.
Bug: 15434489
Change-Id: I49205c79aeb008a30efc3c2ea417b8836444e203
/packages/apps/Dialer/src/com/android/dialer/widget/ActionBarController.java
|
| 710709da8389d401d3089bbf9836dfca527f15c3 |
|
29-May-2014 |
Yorke Lee <yorkelee@google.com> |
Fix for search UI remaining on screen after call is made
Also slide up the action bar after it is faded out - this is so that
it doesn't remain in the same position and intercept touches
Remove unneeded FragmentTransaction fadeout animation in exitSearchUI
that was causing jank when returning to the favorites screen
Bug: 15120649
Change-Id: Idcf96c2339603af09e1773729994d267158f70a0
/packages/apps/Dialer/src/com/android/dialer/widget/ActionBarController.java
|
| 5253be0d57edd4cdf5fbc0a980188e13e009c083 |
|
22-May-2014 |
Yorke Lee <yorkelee@google.com> |
Add ActionBarController
* Collect all actionBar interactions within DialtactsActivity into
a single controller to ensure that it behaves more deterministically,
and fix some bugs with regards to actionBar interactions.
* Make sure that action bar correctly handles activity recreation
and destruction by saving its state
* Add unit tests and mock classes for ActionBarController
Bug: 14900155
Change-Id: I370831db425e1970b118f5d4fed3ce9297e3610d
/packages/apps/Dialer/src/com/android/dialer/widget/ActionBarController.java
|