43b6d3a4565a557841983b7e07c39f02bfc532a7 |
|
10-Dec-2014 |
Santos Cordon <santoscordon@google.com> |
Migrate voicemail ringtone before initing settings dialog. Voicemail ringtone was not migrated prior to bringing up the voicemail settings dialog. Although the setting would eventually migrate correctly prior to executing the ringtone, it was not early enough to show the right value in the settings dialog. This change causes the migration to happen earlier. Bug: 18677051 Change-Id: Id98911db6954f103b781d44844fa61480383a81f
/packages/services/Telephony/src/com/android/phone/settings/VoicemailRingtonePreference.java
|
2592332454a376141b32eea66c82b60d13ba1103 |
|
05-Dec-2014 |
Andrew Lee <anwlee@google.com> |
Fix order of voicemail ringtone initialization. The order of setting mPhone and using it was wrong before, and causing call settings to crash. Bug: 18232725 Change-Id: I70acb9425b3f59464b6649ca118fa8144ec22ffa
/packages/services/Telephony/src/com/android/phone/settings/VoicemailRingtonePreference.java
|
1ec7c7e0c27729717907f3e40c0bc2ab240e1e29 |
|
04-Dec-2014 |
Andrew Lee <anwlee@google.com> |
Make voicemail vibrate/ringtone MSIM-aware. + Use phone/subIds to set and query for settings. + Migrate old settings. Do not migrate for MSIM devices, because the scenarios for figuring out how to migrate from one setting to multiple settings is a bit convoluted. Falls back to default instead. + Initialize voicemail ringtone preference in call settings. Bug: 18232725 Change-Id: I04a4908c9c38d6228ed3945bc00e9ef75d95b388
/packages/services/Telephony/src/com/android/phone/settings/VoicemailRingtonePreference.java
|
8d66d81ad89e66ccaf688e896286e2a06307a554 |
|
24-Nov-2014 |
Andrew Lee <anwlee@google.com> |
Move Voicemail notification settings into util. This utility localizes related functions/constants in a class, in preparation for adding more functionality to make both voicemail ringtone and vibration settings MSIM-capable, and also handle associated necessary migrations. Besides fixing voicemail notifications (before it did not update when the value is changed), there should be no change in functionality. + Add utility for settings related to voicemail notifications. + Handle get/set ringtone uri in new util. + Handle get/set vibrate in new util. + Make keys for shared preferences independent of preference names. There was an implicit relationship between these before. I think it is safer if the two are not correlated, and the shared preferences key needs to be changed shortly to consider subscription id anyways. + Handle saving ringtone uri in VoicemailRingtonePreference. For now this has no change in behavior, but in a subsequent CL we will save the ringtone by subscription id here. - Don't use default values on VoicemailRingtonePreference; default values use the preference's key as the shared preference key, but we will need to use subscription ids for our keys. Bug: 18232725 Change-Id: Ifb52f47073418c76ad4bcf86c57c0ed75d05d0ca
/packages/services/Telephony/src/com/android/phone/settings/VoicemailRingtonePreference.java
|
78ee0b24e3079f20304746aeb4ab940f2042b256 |
|
29-Oct-2014 |
Andrew Lee <anwlee@google.com> |
Add VoicemailRingtonePreference to contain lookup logic. This allows us to clean up CallFeaturesSetting by putting independent logic within an encapsulated class. Bug: 17019623 Change-Id: Ieb2e274dd65ce35c0332e44ef50a2c5c7ca1f41f
/packages/services/Telephony/src/com/android/phone/settings/VoicemailRingtonePreference.java
|