| c43ea562a0447330b26eeec3c7b1fb935958e985 |
|
08-Feb-2014 |
Prathmesh Prabhu <pprabhu@chromium.org> |
pseudomodem: Some simple style fixes.
Fix where this doesn't hold:
- Two lines between top level classes, functions, class methods.
- No lines between @param/@returns/@raises in docstrings
- One blank line at the end of docstring, unless it's a one line docstring.
- Uniformity: Change to @returns and @raises.
BUG=chromium:339312
TEST=None.
Change-Id: I959aa27875531644fd0f34a54d0046a059dbf164
Reviewed-on: https://chromium-review.googlesource.com/185475
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| c569e99b922542e7ddbbc4cd465fc8328ec16214 |
|
22-Jan-2014 |
Thieu Le <thieule@chromium.org> |
cellular: Refactor pseudomodem mm1.py into constants and errors.
cros/cellular/mm1_constants.py: This module contains ModemManager
specific constants which are used by the pseudomodem and a future
ModemManager proxy.
cros/cellular/pseudomodem/pm_constants.py: Pseudomodem specific
constants (eg. testing interface, state machine names)
cros/cellular/pseudomodem/pm_errors.py: Pseudomodem specific exception
classes.
BUG=chromium:219144
TEST=network_3GDisconnectFailure/control
network_3GDisableWhileConnecting/control.pseudomodem
network_3GFailedConnect/control.pseudomodem
network_3GIdentifiers/control.pseudomodem
network_3GModemControl/control.pseudomodem
network_3GModemPresent/control.pseudomodem
network_3GSafetyDance/control.pseudomodem
network_3GScanningProperty/control
network_3GSmokeTest/control.pseudomodem
network_3GStressEnable/control.pseudomodem
network_CDMAActivate/control
network_ChromeCellularNetworkPresent/control
network_ChromeCellularNetworkProperties/control
network_ChromeCellularSmokeTest/control
network_LTEActivate/control
network_SIMLocking/control
Change-Id: I7b02cf0ee6b1b73fb1eb7fcf0f10068e7515e465
Reviewed-on: https://chromium-review.googlesource.com/183526
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
Commit-Queue: Thieu Le <thieule@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| 6be2bce4a88f601f488643cfec2c1c8831c61091 |
|
07-Jan-2014 |
Prathmesh Prabhu <pprabhu@chromium.org> |
pseudomodem: Improve dbus method logging further.
dbus-python catches exceptions raised when servicing a dbus remote call and
returns error to the remote caller. This hides the exceptions from the user of
the python module.
This CL adds a decorator that logs the return value (or error) of a dbus call
before returning it to the remote caller. This is the second attempt in this
regard. Improvements:
- In the earlier impelementation, we missed out on base class implementations
of the methods decorated with dbus.service.method
This problem is not solved, but the new decorator must be used with the most
concerete implementation of the function.
- We now support logging the returns/errors sent asynchronously.
BUG=chromium:326394
TEST=(1) Run pseudomodem in standalone mode. Make sure you see logs from
SimpleModem::Connect method.
(2) Raise an exception in StateMachine::Step and make sure it gets logged.
(3) Run pseudomodem autotests.
Change-Id: Ic00c03f03e1d902c2bd1b9bebd92f0411608d45b
Reviewed-on: https://chromium-review.googlesource.com/180085
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Thieu Le <thieule@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| 133ca6d66774bf3b8de9e3568afdf7b3340135c2 |
|
06-Dec-2013 |
Prathmesh Prabhu <pprabhu@chromium.org> |
pseudomodem: Improve dbus method logging
dbus-python catches exceptions raised when servicing a dbus remote call and
returns the error to the remote caller. This hides the exceptions from the user
of the python service. This CL add a decorator that logs the return value (or
error) of a dbus call before returning it to the remote caller.
BUG=chromium:326394
TEST=(1) Run pseudomodem in standalone mode.
(2) Raise an exception in StateMachine::Step and make sure it gets logged.
Without this CL, that would have been a silent death.
(3) Run pseudomodem autotests.
Change-Id: I982a41ad028c1dec3066fd715aa7811b64870c19
Reviewed-on: https://chromium-review.googlesource.com/179013
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| 6e5f5087e263d7bf17dda8b8324c6b1648debcb9 |
|
16-Aug-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Add support for 'VendorPcoInfo'.
Added support for reading and debugging the Modem3gpp VendorPcoInfo property.
BUG=chromium:273847
TEST=1. stop modemmanager; pseudomodem.py -f 3GPP -i
2. Use "set pco" to set the pco value.
3. The org.freedesktop.ModemManager1.Modem.Modem3gpp.VendorPcoInfo
property should update to the value set by "set pco". Check
using DBus-Python.
Change-Id: I9c52b4165fd909f81c4cfc71c37e9778c61b741d
Reviewed-on: https://gerrit.chromium.org/gerrit/66052
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| d86715c7469992a66ce5e820491414af88e794cd |
|
18-Jun-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Add basic SIM lock support.
Pseudomodem now supports basic SIM locking. This enables the pseudomodem
to be initialized as locked and allows shill's static behavior to be
tested.
BUG=chromium:249184
TEST=(1) Run './pseudomodem -f 3GPP.' Use mmcli to verify that the
following values match:
- lock: 'none'
- unlock retries: 'unknown'
Run 'connectivity show devices' to verify the following matches:
- Cellular.SIMLockStatus/0/LockEnabled: false
- Cellular.SIMLockStatus/1/LockType:
- Cellular.SIMLockStatus/2/RetriesLeft: 999
(2) Run './pseudomodem -f 3GPP -l'. Use mmcli to verify that the
following values match:
- lock: 'sim-pin'
- unlock retries: 'sim-pin (3), sim-puk (3)'
- state: 'locked'
mmcli should also show display no properties for '3GPP'.
Run 'connectivity show devices' to verify the following matches:
- Cellular.SIMLockStatus/0/LockEnabled: true
- Cellular.SIMLockStatus/1/LockType: sim-pin
- Cellular.SIMLockStatus/2/RetriesLeft: 3
Change-Id: Ic8b5189ae4b86e17c01d1732d9fc09517aa7498a
Reviewed-on: https://gerrit.chromium.org/gerrit/58957
Commit-Queue: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| 5555f62fedfdc36cc8c4911eb24299008d961263 |
|
08-May-2013 |
Arman Uguray <armansito@chromium.org> |
cellular: pseudomodem: Fix Python style issues in pseudomodem/
BUG=chromium:238809
TEST=Running ./utils/run_pylint.py inside the client/cros/cellular/pseudomodem
directory should show no error messages.
Change-Id: I6848ceb6b9b5a0f59e0b1d3acbdfa4410fd1dfbb
Reviewed-on: https://gerrit.chromium.org/gerrit/50419
Commit-Queue: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| de923a7b86b6e3c195bf8173dfcdb81294e558ad |
|
07-May-2013 |
Arman Uguray <armansito@chromium.org> |
cellular: pseudomodem: Make Modem.Reset recycle modem object.
Instead of asynchronously disabling and enabling during reset, the
pseudomodem object will now disappear from the DBus connection and
reappear with a new DBus path, followed by an Enable if necessary. The
Reset call returns immediately while the logic takes place
asynchronously, which is much closer to what the real modem manager
does.
BUG=chromium:238409
TEST=1. network_LTEActivate.
2. Remote trybots.
Change-Id: I3b5df85272a02781028758b5d045204587744c4b
Reviewed-on: https://gerrit.chromium.org/gerrit/50247
Commit-Queue: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| 0b03eab867e84dc28a61595afe02283f4ac6aab0 |
|
27-Mar-2013 |
Arman Uguray <armansito@chromium.org> |
cellular: pseudomodem: Support CDMA without activation.
Pseudo modem manager now supports the
org.freedesktop.ModemManager1.Modem.ModemCdma interface, except it
doesn't implement ActivateAutomatic/ActivateManual.
Also fixed a few minor issues, such as bearer initialization and state
machine clean up.
BUG=chromium:219160
CQ-DEPEND=I1b1d78909287e21eb3fbe462869097809d004a1c
TEST=Run "pseudomodem.py -f CDMA". Shill should pick up the CDMA network.
Perform Enable/Disable/Connect/Disconnect in various orders and make
sure that they succeed (the UI and mmcli should show the correct values
for properties). Also verify that Connect/Disconnect operations
correctly update bearer properties using mmcli.
Change-Id: I1bdc0658f858d81215775880ac6045700609d983
Reviewed-on: https://gerrit.chromium.org/gerrit/50090
Commit-Queue: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| 494cb655cf158c37c6f84c37954b683df8928f0a |
|
26-Apr-2013 |
Arman Uguray <armansito@chromium.org> |
cellular: Add network_LTEActivate
Added network_LTEActivate to test LTE specific service activation
behavior using the psuedo modem manager.
BUG=chromium:217695
TEST=Run network_LTEActivate on any platform. It should pass.
Change-Id: I07292db5e2223ddef7c0f54ef21e8afa2ae538e2
Reviewed-on: https://gerrit.chromium.org/gerrit/49285
Commit-Queue: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| bb73240ac7f1aa11d21ba4484a381a391fc2851f |
|
26-Feb-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Explicitly kill forked pseudomodem process on cleanup.
Sometimes ModemManager restarts itself in a way that prevents it from
being killed by running "stop modemmanager". This happens when the
pseudomodem process doesn't cleanly shut down the forked subprocess it
spawns when run in detached mode by the autotest. The forked subprocess
now exits explicitly after stopping the mainloop.
BUG=chromium-os:39151
TEST=Run network_3GSmokeTest/control.pseudomodem at least two times on a
x86-generic VM running Chromium OS. Make sure the test passes all the
time (especially after and including the 2nd time). Or run it a million
times, it should just pass all the time.
Change-Id: I70190db3ede552eaa4fa1e7298ee895935e35886
Reviewed-on: https://gerrit.chromium.org/gerrit/44054
Reviewed-by: Thieu Le <thieule@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| a5b80d9fdb4d8a54bad447d9e78a6e0b6d4c2d23 |
|
03-Jan-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Refactor state machine cancellation.
This CL adds a Cancel method to necessary state machine classes that
handle the correct state transition upon cancellation. This CL also
removes execute permissions from all files except pseudomodem.py.
BUG=chromium-os:37581
TEST=Run network_3GModemControl/control.pseudomodem.
Change-Id: Ia8b1c767f4b5732044feaf1a986d51bcc680fc61
Reviewed-on: https://gerrit.chromium.org/gerrit/40405
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| 277be76d1c6cc9253cd2f0d83ba368abb0e3488f |
|
21-Nov-2012 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Implement Connect.
This CL adds functionality that allows the pseudomodem to connect to a
network after it has registered with it.
BUG=chromium-os:34605
TEST=Tested the full enable-register-connect cycle by sending dbus
messages to the pseudomodem using dbus-send.
Change-Id: I475287b794276a21841ce05a626da184aab49dca
Reviewed-on: https://gerrit.chromium.org/gerrit/38449
Reviewed-by: Thieu Le <thieule@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Ready: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| 04c3973b70d40f326057c687d647becf1ea54460 |
|
08-Nov-2012 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Implement Enable.
This CL adds partial functionality that allows the pseudomodem to be
enabled without registering to a network. The state machine is
implemented as a step process that uses the modem state as its counter.
A minor change to the dbus_std_ifaces.DBusProperties constructor has
also been included, such that user provided properties are handled more
properly. The class also allows a dbus connection to be set at a later
time when this is not possible during initialization.
BUG=chromium-os:34605
TEST=I tested that the enable state changes function properly by sending
dbus messages to the pseudomodem using dbus-send.
Change-Id: I32d57d3664eb4ef3acb0ef46464736b39e8fd955
Reviewed-on: https://gerrit.chromium.org/gerrit/37589
Commit-Ready: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|
| 3569f0cfc43e7f89366e3bf941d3e09662c21218 |
|
03-Oct-2012 |
Arman Uguray <armansito@chromium.org> |
Started pseudomodem implementation.
This CL includes files that form the basis of the new pseudomodem
utility. 90% of the methods are unimplemented and serve as stubs.
BUG=chromium-os:34605
TEST=pylint
Change-Id: Ic8b95b546b02e4b019a010d031a62506e9784b68
Reviewed-on: https://gerrit.chromium.org/gerrit/36294
Commit-Ready: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/dbus_std_ifaces.py
|