| c43ea562a0447330b26eeec3c7b1fb935958e985 |
|
08-Feb-2014 |
Prathmesh Prabhu <pprabhu@chromium.org> |
pseudomodem: Some simple style fixes.
Fix where this doesn't hold:
- Two lines between top level classes, functions, class methods.
- No lines between @param/@returns/@raises in docstrings
- One blank line at the end of docstring, unless it's a one line docstring.
- Uniformity: Change to @returns and @raises.
BUG=chromium:339312
TEST=None.
Change-Id: I959aa27875531644fd0f34a54d0046a059dbf164
Reviewed-on: https://chromium-review.googlesource.com/185475
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/disable_machine.py
|
| c569e99b922542e7ddbbc4cd465fc8328ec16214 |
|
22-Jan-2014 |
Thieu Le <thieule@chromium.org> |
cellular: Refactor pseudomodem mm1.py into constants and errors.
cros/cellular/mm1_constants.py: This module contains ModemManager
specific constants which are used by the pseudomodem and a future
ModemManager proxy.
cros/cellular/pseudomodem/pm_constants.py: Pseudomodem specific
constants (eg. testing interface, state machine names)
cros/cellular/pseudomodem/pm_errors.py: Pseudomodem specific exception
classes.
BUG=chromium:219144
TEST=network_3GDisconnectFailure/control
network_3GDisableWhileConnecting/control.pseudomodem
network_3GFailedConnect/control.pseudomodem
network_3GIdentifiers/control.pseudomodem
network_3GModemControl/control.pseudomodem
network_3GModemPresent/control.pseudomodem
network_3GSafetyDance/control.pseudomodem
network_3GScanningProperty/control
network_3GSmokeTest/control.pseudomodem
network_3GStressEnable/control.pseudomodem
network_CDMAActivate/control
network_ChromeCellularNetworkPresent/control
network_ChromeCellularNetworkProperties/control
network_ChromeCellularSmokeTest/control
network_LTEActivate/control
network_SIMLocking/control
Change-Id: I7b02cf0ee6b1b73fb1eb7fcf0f10068e7515e465
Reviewed-on: https://chromium-review.googlesource.com/183526
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
Commit-Queue: Thieu Le <thieule@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/disable_machine.py
|
| bcbd42836b870f3e84d851eab4bb64c90cdb6afe |
|
21-Jun-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Make Disable cancel all other state machines.
Calling disable will now cancel active Connect, Register, and Enable
machines.
BUG=chromium:252570
TEST=network_3GModemContro/control.pseudomodem should fail with an
AssertionError when run on x86-alex/butterfly. We will use the dashboard
to track network3g_pseudomodem failures over time to verify.
Change-Id: I1bdb16cdce421588bdd1f725f0909353065283f2
Reviewed-on: https://gerrit.chromium.org/gerrit/59516
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/disable_machine.py
|
| 0ef25f23ab72bee72df78e117121ac0675bc9f49 |
|
15-Jun-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Invoke return callback if disable ends by canceling enable.
The disable call will timeout if it's called while there's an ongoing
enable because it never invokes the return callback. Fix this by
invoking it.
BUG=chromium:247540
TEST=network_3GSmokeTest.pseudomodem shouldn't fail with "timed out
waiting for shill device disable."
Change-Id: I38cef57b93f5c2a104e80846590c72b3ee4a3d44
Reviewed-on: https://gerrit.chromium.org/gerrit/58729
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/disable_machine.py
|
| 5555f62fedfdc36cc8c4911eb24299008d961263 |
|
08-May-2013 |
Arman Uguray <armansito@chromium.org> |
cellular: pseudomodem: Fix Python style issues in pseudomodem/
BUG=chromium:238809
TEST=Running ./utils/run_pylint.py inside the client/cros/cellular/pseudomodem
directory should show no error messages.
Change-Id: I6848ceb6b9b5a0f59e0b1d3acbdfa4410fd1dfbb
Reviewed-on: https://gerrit.chromium.org/gerrit/50419
Commit-Queue: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/disable_machine.py
|
| e94efecceed2a21d35c7a56b306498b53f0fa68e |
|
03-May-2013 |
Arman Uguray <armansito@chromium.org> |
cellular: pseudomodem: Make Modem.Enable asynchronous.
Shill will now receive a completion reply from the pseudo modem manager
only after the enable/disable state machine has run completely.
BUG=chromium:237725
TEST=network_LTEActivate, network_3GSmokeTest.pseudomodem,
network_3GDisableWhileConnecting.pseudomodem
Change-Id: I07be247836a3cc67ed8e3684815b4740d375d728
Reviewed-on: https://gerrit.chromium.org/gerrit/50057
Reviewed-by: Thieu Le <thieule@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/disable_machine.py
|
| a5b80d9fdb4d8a54bad447d9e78a6e0b6d4c2d23 |
|
03-Jan-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Refactor state machine cancellation.
This CL adds a Cancel method to necessary state machine classes that
handle the correct state transition upon cancellation. This CL also
removes execute permissions from all files except pseudomodem.py.
BUG=chromium-os:37581
TEST=Run network_3GModemControl/control.pseudomodem.
Change-Id: Ia8b1c767f4b5732044feaf1a986d51bcc680fc61
Reviewed-on: https://gerrit.chromium.org/gerrit/40405
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/disable_machine.py
|
| b320e28a899a00f6fcc96d28dd0f1e5f46a32032 |
|
19-Dec-2012 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Refactor Disable
This CL modifies the state machine that manages the disable cycle to use
the new object model.
BUG=chromium-os:37233
TEST=network_3GModemControl/control.pseudomodem,
1. stop cromo; stop modemmanager
2. Run /usr/local/autotest/cros/cellular/pseudomodem/pseudomodem.py
3. Verify that the fake mobile network shows up in the UI.
4. Manually disable mobile connectivity through the UI.
5. Verify that mobile connectivity successfully becomes disabled.
6. Verify that shill hasn't crashed.
7. Check the pseudomodem output in the console to verify that the
disable operation proceeded as expected.
Change-Id: I44513e588bf7bc1f2a0a7f6762567aa37a5e09b5
Reviewed-on: https://gerrit.chromium.org/gerrit/40072
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/disable_machine.py
|