| 8d0cfefae24985025a934ea5461a51472c59cfc0 |
|
16-Dec-2015 |
Alex Vakulenko <avakulenko@google.com> |
Fix new schema to match the new server definitions
A new server version now validates the state definitions in
traits as well as commands and some of our sample traits were
not defined properly. Also, the server now requires the 'base'
trait to be complete (and have base.reboot and base.identify
commands defined).
Change-Id: Icc576918895eba642498aa9b8bb1771825562f06
Reviewed-on: https://weave-review.googlesource.com/1971
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
/external/libweave/examples/daemon/speaker/speaker.cc
|
| d6db0498402a32ef8ff5b681cef555e4c4fc2079 |
|
08-Dec-2015 |
Alex Vakulenko <avakulenko@google.com> |
Update example daemons to use the new component/trait APIs
Using AddStateDefinitionsFromJson/AddComponent instead of old and
deprecated AddCommandDefinitions.../AddStateDefinitions... methods.
BUG: 26070118, 25917541
Change-Id: I1f264c737cc19a577a0026e6d6212d63bdc480cf
Reviewed-on: https://weave-review.googlesource.com/1802
Reviewed-by: Alex Vakulenko <avakulenko@google.com>
/external/libweave/examples/daemon/speaker/speaker.cc
|
| c4305600835b91630f9ca4b10ad9070ea55a726c |
|
25-Nov-2015 |
Vitaly Buka <vitalybuka@google.com> |
Replace Get* methods returning unique_ptr with reference alternative
Existing code created temporarily objects and returned them to the
client. It was not efficient and error-prone as client code could
retrieve pointers to internal objects without keeping unique_ptr alive.
Change-Id: I9e17c8d9f66dfc9f52ce9ffc9a31992b16b00461
Reviewed-on: https://weave-review.googlesource.com/1672
Reviewed-by: Alex Vakulenko <avakulenko@google.com>
/external/libweave/examples/daemon/speaker/speaker.cc
|
| 42b0a7b1235eb029f9f678dd54076d7b6b0c5a70 |
|
25-Nov-2015 |
Alex Vakulenko <avakulenko@google.com> |
Make sure example command definitions include 'minimalRole'
Server doesn't work correctly if minimalRole is not specified.
It just fails to forward a command to the device.
Also since Command::GetParameters returns a unique_ptr (rvalue),
it is generally a bad pattern to use cmd->GetParameter()->Get...
especially with dictionary and list values because by the time
the pointer to inner object is used the outer object will be
destroyed and access-after-free errors will occur.
Change-Id: I33fd3fadbf993ce172725d17befef016089fc0a7
Reviewed-on: https://weave-review.googlesource.com/1653
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
/external/libweave/examples/daemon/speaker/speaker.cc
|
| 7e894da1c5fcc4fafa6cc69b612c9c14f78aed51 |
|
23-Nov-2015 |
Alex Vakulenko <avakulenko@google.com> |
Remove object schema parsing in CommandDefinition
The only thing we now care about in CommandDefinition is the
"minimalRole" field. Everything else is a black-box which we just
forward to the server without any semantic parsing.
Also completely removed command visibility support since it no
longer applies to trait/component model.
BUG: 25841230
Change-Id: Ie8fff57ffada289caa7876c2a53150bb116fd65b
Reviewed-on: https://weave-review.googlesource.com/1617
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
/external/libweave/examples/daemon/speaker/speaker.cc
|
| 5ca27be9d483150fc82b4fe4c4a79415843dc9fe |
|
11-Nov-2015 |
Luis Larco <luislarco@google.com> |
Removing trailing whitespace from speaker.cc
Change-Id: I58ee9669136e3e2c3bda4cfec05e7ab5a9dafa70
Reviewed-on: https://weave-review.googlesource.com/1510
Reviewed-by: Johan Euphrosine <proppy@google.com>
/external/libweave/examples/daemon/speaker/speaker.cc
|
| b51b4757445e8611bdba92eae9d09ddb16a07c38 |
|
05-Nov-2015 |
Luis Larco <luislarco@google.com> |
Adding handler for speaker device.
Change-Id: Iff9ae5edc586e6f7e4820e825cc1d0d6ee2202eb
Reviewed-on: https://weave-review.googlesource.com/1471
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
/external/libweave/examples/daemon/speaker/speaker.cc
|