History log of /external/skia/src/gpu/GrBatchAtlas.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
7023a00c35d904e4ccff09c377e9ba26abba6181 22-Feb-2016 jvanverth <jvanverth@google.com> Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
the aforementioned conversion and changes a multiply by a very small
value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002
TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063

Review URL: https://codereview.chromium.org/1713693002
/external/skia/src/gpu/GrBatchAtlas.h
d106c2c64012688f8d1439543d942f8f66a142e0 19-Feb-2016 jvanverth <jvanverth@google.com> Revert of Use unorm shorts for texture coordinates when rendering text. (patchset #3 id:40001 of https://codereview.chromium.org/1713693002/ )

Reason for revert:
Causing issues with text on Mali 400s. Examples: largeglyphblur, imageblurtiled. It appears that there are precision problems.

Original issue's description:
> Use unorm shorts for texture coordinates when rendering text.
>
> There are a couple of reasons for this:
> - Vulkan does not guarantee conversions from integral vertex attributes
> to floating point shader variables
> - This may be faster and more precise on some platforms, as it avoids
> the aforementioned conversion and changes a multiply by a very small
> value to a multiply by a medium-sized value.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002
> TBR=bsalomon@google.com
>
> Committed: https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063

TBR=joshualitt@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1709133003
/external/skia/src/gpu/GrBatchAtlas.h
e507ff0460f4f878214b9454fb5b9ab8d64d8063 19-Feb-2016 jvanverth <jvanverth@google.com> Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
the aforementioned conversion and changes a multiply by a very small
value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/1713693002
/external/skia/src/gpu/GrBatchAtlas.h
ddd22d86455d95941ea21253b210819c1d4a3863 16-Feb-2016 joshualitt <joshualitt@chromium.org> Remove last bit of privacy violation for GrAtlasTextBlob

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1698503002

Review URL: https://codereview.chromium.org/1698503002
/external/skia/src/gpu/GrBatchAtlas.h
5df175ee71164dce97758564f308ab301bfe393a 18-Nov-2015 joshualitt <joshualitt@chromium.org> Make has GrBatchAtlas::ID() inlineable

BUG=skia:

Review URL: https://codereview.chromium.org/1456113002
/external/skia/src/gpu/GrBatchAtlas.h
2b0536f37aa8915b6f58dae0b88b18023cb04d17 06-Nov-2015 robertphillips <robertphillips@google.com> Clean up GrBatchAtlas a bit

The main thrust of this CL is to remove knowledge of the atlas' backing texture from the BatchPlot. It also reduces the API surface of the BatchPlot and shrinks the amount of fields in the BatchAtlas.

Review URL: https://codereview.chromium.org/1413403009
/external/skia/src/gpu/GrBatchAtlas.h
96fcdcc219d2a0d3579719b84b28bede76efba64 27-Aug-2015 halcanary <halcanary@google.com> Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002

Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/gpu/GrBatchAtlas.h
da04e0e80a0113e1d838f7406cd8a8d545b8c02b 19-Aug-2015 joshualitt <joshualitt@chromium.org> Allow setting of GrBatchFontCache atlas sizes

BUG=skia:

Review URL: https://codereview.chromium.org/1255943006
/external/skia/src/gpu/GrBatchAtlas.h
7539856c1b9cbb1886a6a498cc534b77fc83ddb2 17-Aug-2015 bsalomon <bsalomon@google.com> Make GrVertexBatch objects hold their own draws during GrDrawTarget flush

NO_MERGE_BUILDS

Review URL: https://codereview.chromium.org/1286043004
/external/skia/src/gpu/GrBatchAtlas.h
7e97b0bad0d80901a19922323343a19d69f34b0b 01-Aug-2015 joshualitt <joshualitt@chromium.org> Move strike to subrun in GrAtlasTextContext

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/77d89f7dd243a17452d3a5f16a98622993e6bdd9

Review URL: https://codereview.chromium.org/1257253005
/external/skia/src/gpu/GrBatchAtlas.h
da9ccf175430fd9337355334503aedb464676078 31-Jul-2015 joshualitt <joshualitt@google.com> Revert of Move strike to subrun in GrAtlasTextContext (patchset #3 id:40001 of https://codereview.chromium.org/1257253005/)

Reason for revert:
breaking bots

Original issue's description:
> Move strike to subrun in GrAtlasTextContext
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/77d89f7dd243a17452d3a5f16a98622993e6bdd9

TBR=bsalomon@google.com,robertphillips@google.com,jvanverth@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1266253002
/external/skia/src/gpu/GrBatchAtlas.h
77d89f7dd243a17452d3a5f16a98622993e6bdd9 31-Jul-2015 joshualitt <joshualitt@chromium.org> Move strike to subrun in GrAtlasTextContext

BUG=skia:

Review URL: https://codereview.chromium.org/1257253005
/external/skia/src/gpu/GrBatchAtlas.h
8db6fdc465e0f76b1f8eb0d5f799d42b7c2246f5 31-Jul-2015 joshualitt <joshualitt@chromium.org> bump the size of the atlas id to 64 bits

BUG=skia:

Review URL: https://codereview.chromium.org/1253003005
/external/skia/src/gpu/GrBatchAtlas.h
4314e088689dae2fdf8d28415503f710563aaf5c 23-Apr-2015 joshualitt <joshualitt@chromium.org> small fix for perf regression in GrAtlasTextContext.cpp

BUG=skia:

Review URL: https://codereview.chromium.org/1080673005
/external/skia/src/gpu/GrBatchAtlas.h
97202d2821c2b9e997d36146ecb9711e02fd7734 22-Apr-2015 joshualitt <joshualitt@chromium.org> Fix for segfault on destruction of BitmapTextBlob

BUG=skia:

Review URL: https://codereview.chromium.org/1065773005
/external/skia/src/gpu/GrBatchAtlas.h
010db5346e425be8ce659b23b75943ee8ef9d537 21-Apr-2015 joshualitt <joshualitt@chromium.org> Some simple optimizations for improving GrAtlasTextContext perf

BUG=skia:

Review URL: https://codereview.chromium.org/1093083003
/external/skia/src/gpu/GrBatchAtlas.h
8672f4dffa4b298d4cabee6151590ae885d47263 21-Apr-2015 joshualitt <joshualitt@chromium.org> Pack BitmapTextBlob a bit tighter

BUG=skia:

Review URL: https://codereview.chromium.org/1092973004
/external/skia/src/gpu/GrBatchAtlas.h
b4c507e03386f2105e33f0c4c09b4a9d0a23196d 08-Apr-2015 joshualitt <joshualitt@chromium.org> Adding bulk plot reffer to cached textblobs

This change will prevent the atlas from evicting glyphs the TextBlob
needs.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7281c61e7bc689d484dcbda49be3cef4ce4f11c2

Review URL: https://codereview.chromium.org/1050113004
/external/skia/src/gpu/GrBatchAtlas.h
3cf9863bb658d637416c4edbf278b0311dba7478 07-Apr-2015 joshualitt <joshualitt@google.com> Revert of Adding bulk plot reffer to cached textblobs (patchset #7 id:110001 of https://codereview.chromium.org/1050113004/)

Reason for revert:
Breaks linux builder

Original issue's description:
> Adding bulk plot reffer to cached textblobs
>
> This change will prevent the atlas from evicting glyphs the TextBlob
> needs.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7281c61e7bc689d484dcbda49be3cef4ce4f11c2

TBR=bsalomon@google.com,jvanverth@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1061713003
/external/skia/src/gpu/GrBatchAtlas.h
7281c61e7bc689d484dcbda49be3cef4ce4f11c2 07-Apr-2015 joshualitt <joshualitt@chromium.org> Adding bulk plot reffer to cached textblobs

This change will prevent the atlas from evicting glyphs the TextBlob
needs.

BUG=skia:

Review URL: https://codereview.chromium.org/1050113004
/external/skia/src/gpu/GrBatchAtlas.h
7c3a2f834e0ba3f11a3129d5348b393efcc9b0e1 31-Mar-2015 joshualitt <joshualitt@chromium.org> BitmapTextBatch and BitmapTextBlob

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/eed1dae04932483579b02c10f0706127d3f5d984

Review URL: https://codereview.chromium.org/1011403004
/external/skia/src/gpu/GrBatchAtlas.h
c03391e792a55219ddcb033475dc6b80e6a3e2f9 31-Mar-2015 joshualitt <joshualitt@google.com> Revert of BitmapTextBatch and BitmapTextBlob (patchset #18 id:360001 of https://codereview.chromium.org/1011403004/)

Reason for revert:
Breaks a unit test on mac

Original issue's description:
> BitmapTextBatch and BitmapTextBlob
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/eed1dae04932483579b02c10f0706127d3f5d984

TBR=fmalita@chromium.org,reed@google.com,jvanverth@google.com,robertphillips@google.com,bsalomon@google.com,jvanverth@chromium.org,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1050633002
/external/skia/src/gpu/GrBatchAtlas.h
eed1dae04932483579b02c10f0706127d3f5d984 31-Mar-2015 joshualitt <joshualitt@chromium.org> BitmapTextBatch and BitmapTextBlob

BUG=skia:

Review URL: https://codereview.chromium.org/1011403004
/external/skia/src/gpu/GrBatchAtlas.h
5bf99f1ca8f30287803b594d06c60a7b6796ad45 13-Mar-2015 joshualitt <joshualitt@chromium.org> Creation of GrBatchAtlas and Distancefieldpathrenderer batch

BUG=skia:

Review URL: https://codereview.chromium.org/975303005
/external/skia/src/gpu/GrBatchAtlas.h