| 91d6edef35e7275879c30ce16ecb8b6dc73c6e4a |
|
17-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Add RTC_ prefix to (D)CHECKs and related macros.
We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.
Alternative solutions:
* Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable.
* Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce.
* Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable.
* Changes in Chromium for this is obviously not an option.
BUG=chromium:468375
NOTRY=true
Review URL: https://codereview.webrtc.org/1335923002
Cr-Commit-Position: refs/heads/master@{#9964}
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 5e56c5927e097f095aef2e9f7be49fd3d59221e1 |
|
11-Aug-2015 |
Henrik Boström <hbos@webrtc.org> |
DtlsIdentityStoreInterface added and the implementation is called DtlsIdentityStoreImpl (previously named without the -Impl bit and without an interface).
DtlsIdentityStoreImpl is updated to take KeyType into account, something which will be relevant after this CL lands:
https://codereview.webrtc.org/1189583002
The DtlsIdentityService[Interface] classes are about to be removed (to be removed when Chromium no longer implements and uses the interface). This was an unnecessary layer of complexity. The FakeIdentityService is now instead a FakeDtlsIdentityStore.
Where a service was previously passed around, a store is now passed around.
Identity generation is now commonly performed using DtlsIdentityStoreInterface. Previously, if a service was not specified, WebRtcSessionDescriptionFactory could fall back on its own generation code. Now, a store has to be provided for generation to occur.
For more information about the steps being taken to land this without breaking Chromium, see referenced bug.
BUG=webrtc:4899
R=magjed@webrtc.org, tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1176383004 .
Cr-Commit-Position: refs/heads/master@{#9696}
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 0f620f4e318a162e7a251133e7a8ddea5188b9bb |
|
09-Jul-2015 |
tommi <tommi@webrtc.org> |
Make sure we process all pending offer/answer requests before terminating.
This fixes a bug in the WebRtcSessionDescriptionFactory where messages would be dropped or worse yet processed after the factory was deleted.
BUG=chromium:507307
Review URL: https://codereview.webrtc.org/1231823002
Cr-Commit-Position: refs/heads/master@{#9557}
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| d83f4eff84d872da3e38e1a61d669fc407ce7adf |
|
13-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns.
BUG=crbug/464995
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8689
Committed: https://code.google.com/p/webrtc/source/detail?r=8701
Committed: https://code.google.com/p/webrtc/source/detail?r=8706
Review URL: https://webrtc-codereview.appspot.com/42659004
Cr-Commit-Position: refs/heads/master@{#8722}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8722 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 8372888b079b13ac765a33288def5a9d9e1387bd |
|
13-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Revert "Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns."
This reverts commit 45bc01a7172402aa4bb8d457474300533c273413.
TBR=pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/47559004
Cr-Commit-Position: refs/heads/master@{#8711}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8711 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| fde1de93f96e6c624d2762214d2318653acb1853 |
|
13-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns.
BUG=crbug/464995
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8689
Committed: https://code.google.com/p/webrtc/source/detail?r=8701
Review URL: https://webrtc-codereview.appspot.com/42659004
Cr-Commit-Position: refs/heads/master@{#8706}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8706 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 04cd69887d6b81c4046adf0e7ca7f4a4909c7530 |
|
12-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Revert "Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns."
This reverts commit 93604daf0ea1fea1148ce07793bfa538d177c876.
TBR=pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/40329004
Cr-Commit-Position: refs/heads/master@{#8704}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8704 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 93604daf0ea1fea1148ce07793bfa538d177c876 |
|
12-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns.
BUG=crbug/464995
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8689
Review URL: https://webrtc-codereview.appspot.com/42659004
Cr-Commit-Position: refs/heads/master@{#8701}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8701 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| e9413c686ef41c051b820d5650d547caf741b56e |
|
12-Mar-2015 |
mflodman@webrtc.org <mflodman@webrtc.org> |
Revert 8689 "Fix an issue in DtlsIdentityStore when the store is..."
> Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns.
>
> BUG=crbug/464995
> R=pthatcher@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/42659004
TBR=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42729004
Cr-Commit-Position: refs/heads/master@{#8690}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8690 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 2a3942adc6aeac629c56adfebaae002cdff6f186 |
|
12-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Fix an issue in DtlsIdentityStore when the store is destroyed before the worker thread task returns.
BUG=crbug/464995
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42659004
Cr-Commit-Position: refs/heads/master@{#8689}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8689 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 61e00b0bcab899a32f14c1e2e0f4b7f316cc1f03 |
|
04-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Create a in-memory DTLS identity store that keeps a free identity generated in the background.
BUG=4241
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8576
Committed: https://code.google.com/p/webrtc/source/detail?r=8581
Review URL: https://webrtc-codereview.appspot.com/37889004
Cr-Commit-Position: refs/heads/master@{#8605}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8605 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| be77872d2ce7a5faf15d3794635456ee81a5ced1 |
|
04-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Revert "Create a in-memory DTLS identity store that keeps a free identity generated in the background."
Breaking Chromium FYI.
TBR=pthatcher@webrtc.org
This reverts commit 369f68255ffd3d6f3e449e0defeae820cefd4f29.
BUG=4241
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8576
Review URL: https://webrtc-codereview.appspot.com/37889004
Review URL: https://webrtc-codereview.appspot.com/47389004
Cr-Commit-Position: refs/heads/master@{#8583}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8583 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 369f68255ffd3d6f3e449e0defeae820cefd4f29 |
|
04-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Create a in-memory DTLS identity store that keeps a free identity generated in the background.
BUG=4241
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8576
Review URL: https://webrtc-codereview.appspot.com/37889004
Cr-Commit-Position: refs/heads/master@{#8581}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8581 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 8ad96605c1b7e77237358f4fd4c596480ee08738 |
|
03-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Revert "Create a in-memory DTLS identity store that keeps a free identity generated in the background."
Test failure: http://chromegw/i/client.webrtc/builders/Linux32%20Release/builds/3557
This reverts commit df512cc8b73ff519dcdf63a2603ab312d3443402.
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41089004
Cr-Commit-Position: refs/heads/master@{#8579}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8579 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| df512cc8b73ff519dcdf63a2603ab312d3443402 |
|
03-Mar-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Create a in-memory DTLS identity store that keeps a free identity generated in the background.
BUG=4241
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37889004
Cr-Commit-Position: refs/heads/master@{#8576}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8576 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|
| 254840692ef450d94d6a4b075eb139bb34305ec0 |
|
19-Feb-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Add empty files to implement a in-memory DTLS identity store without breaking Chromium build.
BUG=4241
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36199004
Cr-Commit-Position: refs/heads/master@{#8424}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8424 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/dtlsidentitystore_unittest.cc
|