| 6955870806624479723addfae6dcf5d13968796c |
|
13-Jan-2016 |
Peter Kasting <pkasting@google.com> |
Convert channel counts to size_t.
IIRC, this was originally requested by ajm during review of the other size_t conversions I did over the past year, and I agreed it made sense, but wanted to do it separately since those changes were already gargantuan.
BUG=chromium:81439
TEST=none
R=henrik.lundin@webrtc.org, henrika@webrtc.org, kjellander@webrtc.org, minyue@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1316523002 .
Cr-Commit-Position: refs/heads/master@{#11229}
/external/webrtc/talk/media/base/codec.h
|
| 25702cb1628941427fa55e528f53483f239ae011 |
|
08-Jan-2016 |
pkasting <pkasting@chromium.org> |
Misc. small cleanups.
* Better param names
* Avoid using negative values for (bogus) placeholder channel counts (mostly in tests). Since channels will be changing to size_t, negative values will be illegal; it's sufficient to use 0 in these cases.
* Use arraysize()
* Use size_t for counting frames, samples, blocks, buffers, and bytes -- most of these are already size_t in most places, this just fixes some stragglers
* reinterpret_cast<int64_t>(void*) is not necessarily safe; use uintptr_t instead
* Remove unnecessary code, e.g. dead code, needlessly long/repetitive code, or function overrides that exactly match the base definition
* Fix indenting
* Use uint32_t for timestamps (matching how it's already a uint32_t in most places)
* Spelling
* RTC_CHECK_EQ(expected, actual)
* Rewrap
* Use .empty()
* Be more pedantic about matching int/int32_t/
* Remove pointless consts on input parameters to functions
* Add missing sanity checks
All this was found in the course of constructing https://codereview.webrtc.org/1316523002/ , and is being landed separately first.
BUG=none
TEST=none
Review URL: https://codereview.webrtc.org/1534193008
Cr-Commit-Position: refs/heads/master@{#11191}
/external/webrtc/talk/media/base/codec.h
|
| 822bdf978435b8eba9343ea96e9a9bc54b9c7df0 |
|
11-Dec-2015 |
Peter Boström <pbos@webrtc.org> |
Remove cricket::VideoEncoderConfig.
BUG=webrtc:5332
R=noahric@chromium.org, pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1512853007 .
Cr-Commit-Position: refs/heads/master@{#10991}
/external/webrtc/talk/media/base/codec.h
|
| 43edf0ffb91a50e2efa01c7befe4d188a7e30ea2 |
|
21-Nov-2015 |
stefan <stefan@webrtc.org> |
Require negotiation to send transport cc feedback over RTCP.
BUG=4312
Review URL: https://codereview.webrtc.org/1452883002
Cr-Commit-Position: refs/heads/master@{#10735}
/external/webrtc/talk/media/base/codec.h
|
| e62202fedf57b74cc263246c0586ee353978caf8 |
|
21-Apr-2015 |
Shao Changbin <changbin.shao@webrtc.org> |
Support handling multiple RTX but only generate SDP with RTX associated with VP8.
This implementation registers RTX-APT map inside RTP sender and receiver.
While it only generates SDP with RTX associated with VP8 to make it
compatible with previous Chrome versions.
Should add following changes after reaches stable,
* Use RTX-APT map for building and restoring RTP packets.
* Add RTX support for RED or VP9 in Video engine.
* Set RTX payload type for RED inside FecConfig in EndToEndTest.
BUG=4024
R=mflodman@webrtc.org, pbos@webrtc.org, pthatcher@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36889004
Cr-Commit-Position: refs/heads/master@{#9040}
/external/webrtc/talk/media/base/codec.h
|
| 2d25b44f470afdd56513b75d641166f6e7cdcd04 |
|
16-Mar-2015 |
changbin.shao@webrtc.org <changbin.shao@webrtc.org> |
Check associated payload type when negotiate RTX codecs.
At the moment, only payload name is checked when match two RTX codecs.
This will cause wrong behavior of codec negotiation if multiple RTX codecs
are added.
BUG=
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34189004
Cr-Commit-Position: refs/heads/master@{#8727}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8727 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|
| bc6961fe323bf60ee9fa5f6b6569f0f64a80276d |
|
19-Feb-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Make webrtc 50 KB smaller by not inlining Codec.
The Codec class is a big class and objects of the Codec class are passed
around by value. That means that inlined operations would be duplicated
at many places, in particular inside STL.
By not inlining Codec methods, webrtc shrinks by 50 KB in
a Linux x64 clang build.
Total change: -54147 bytes
==========================
+2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110)
-1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003)
-1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789)
-1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598)
-1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550)
-2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820)
-2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474)
-2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927)
-3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654)
-6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369)
-10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582)
-19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067)
BUG=
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40729005
Cr-Commit-Position: refs/heads/master@{#8436}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|
| ff1b1bf0944d42700edadae68bd774835a7a13f0 |
|
20-Jun-2014 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
When creating an answer, takes the codec preference from the offer.
This change is based on RFC3264:
"Although the answerer MAY list the formats in their desired order of preference, it is RECOMMENDED that unless there is a specific reason, the answerer list formats in the same relative order they were present in the offer."
BUG=2868
TEST=unit tests and manually with munge-sdp test
R=juberti@google.com
Review URL: https://webrtc-codereview.appspot.com/14589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6514 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|
| fbd13286dc280eaa69c562e20e11a38cb393da3d |
|
19-Jun-2014 |
buildbot@webrtc.org <buildbot@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
(Auto)update libjingle 69555283-> 69567902
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6497 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|
| b5a22b14648c53874b4b76368a1a2271d985e875 |
|
13-May-2014 |
pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert r6110 and r6109.
Effectively re-landing r6104 as well as r6108 which includes a fix to a
compile error that caused r6104 to be reverted in r6110.
BUG=
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6119 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|
| 17911dca8099707b5c050741a108b95b79a4da66 |
|
12-May-2014 |
buildbot@webrtc.org <buildbot@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
(Auto)update libjingle 66798415-> 66813165
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6110 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|
| d266a2020f9e86a787eada77d458ee75426d68af |
|
12-May-2014 |
pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Initial wiring of new webrtc API in libjingle.
BUG=1788
R=pthatcher@google.com, pthatcher@webrtc.org
TBR=juberti@webrtc.org, mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8549005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6104 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|
| 9c16c39e613ebc5cdfa8ca5818a62ef5c3b18bd7 |
|
01-May-2014 |
jiayl@webrtc.org <jiayl@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Sets the SCTP port codec in the native SessionDescription.
Previously it's only set when a SDP string is parsed into SessionDescription, causing failuring for native client.
BUG=3141
R=juberti@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6036 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|
| 91053e7c5a743f4a92f5079844b0747c927f3bbd |
|
10-Aug-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update libjingle to 50654631.
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2000006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4519 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|
| 28e20752806a492f5a6a5d343c02f9556f39b1cd |
|
10-Jul-2013 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds trunk/talk folder of revision 359 from libjingles google code to
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/base/codec.h
|