| 675d4373f87b2468a334f2ed48bfa4e6946d80f1 |
05-Nov-2015 |
Chih-Hung Hsieh <chh@google.com> |
WIP: Changes after merge commit 'cb3f9bd'
Changes after "git merge cb3f9bd"
* git mv old Android.mk from src/ to webrtc/
* Remove old unused files in src/*.
* Modify webrtc/.gitignore to keep *.mk files.
* Copy old files from master, lost in auto-merge.
src/modules/audio_processing/test/unit_test.cc
src/modules/audio_coding/codecs/isac/fix/test/{Android.mk,kenny.c}
to webrtc, but most of the old test code do not compile with new
webrtc API and are commented out.
* Move src/modules/audio_processing/test/android/apmtest/jni/*.mk to
webrtc/... but the Android.mk files does not work.
Commented out its build target.
* Changes to Android.mk files:
* Change references of src/ to webrtc/.
* Fix include path
* Fix source file list, remove old non-existing files,
add new source files to resolve link errors.
* Add new Android.mk files to build some new static libraries
to link into current Android webrtc .so files.
* Remove unnecessary LOCAL_SHARED_LIBRARIES in Android.mk files
that build static libraries.
* Remove old unnecessary clang workarounds like
-Wno-tautological-pointer-compare
-no-integrated-as
* Fix include path of debug.pb.h in some source files.
* Add -DWEBRTC_POSIX in android-webrtc.mk
* Manually merge Android specific changes in
src/typedefs.h to webrtc/typedefs.h
* Fix trivial syntax error in scoped_ptr.h, calling static_assert.
* Use -std=c++0x in webrtc/system_wrappers/source/Android.mk
* #undef getchaar in spreadsort.hpp
* Verified and not to carry old Android hacks from src/... to webrtc/...
src/system_wrappers/source/android/cpu-features.c
src/modules/interface/module.h
src/modules/audio_coding/codecs/isac/fix/source/filters_neon.c
src/system_wrappers/source/trace_posix.cc
src/typedefs.h
More pathes from Alex Luebs:
* Use new unit test kenny.cc.
Delete old kenny.cc.
Comment out unessential code in kenny.cc to fix link error for now.
* Replace old unit test files with new ones in
webrtc/modules/audio_processing/Android.mk.
Delete old audio_processing/test/unit_test.cc.
* Fix compilation errors in
webrtc/modules/audio_processing/test/audio_processing_unittest.cc
Change-Id: I7bbf776eeb9dcfa21a82dd1f2dec378235cbbc3e
ndroid.mk
|
| 91d6edef35e7275879c30ce16ecb8b6dc73c6e4a |
17-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Add RTC_ prefix to (D)CHECKs and related macros.
We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.
Alternative solutions:
* Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable.
* Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce.
* Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable.
* Changes in Chromium for this is obviously not an option.
BUG=chromium:468375
NOTRY=true
Review URL: https://codereview.webrtc.org/1335923002
Cr-Commit-Position: refs/heads/master@{#9964}
ad.cc
ad_unittest.cc
|
| e9e7896293747b2084e7f018675276f5096cdafc |
09-Sep-2015 |
kwiberg <kwiberg@webrtc.org> |
Turn webrtc::Vad into a pure virtual interface
Review URL: https://codereview.webrtc.org/1317243005
Cr-Commit-Position: refs/heads/master@{#9899}
nclude/vad.h
ock/mock_vad.h
ad.cc
|
| 12cfc9b4dacd6942377df1f29a64bdbec591920e |
08-Sep-2015 |
kwiberg <kwiberg@webrtc.org> |
Fold AudioEncoderMutable into AudioEncoder
It makes more sense to combine the two interfaces, since there wasn't
a clear line separating them. The result is a combined interface with
just over a dozen methods, half of which need to be implemented by
every subclass, while the other half have sensible (and trivial)
default implementations and are implemented only by the few subclasses
that need non-default behavior.
Review URL: https://codereview.webrtc.org/1322973004
Cr-Commit-Position: refs/heads/master@{#9894}
nclude/vad.h
ock/mock_vad.h
ad.cc
|
| dce40cf804019a9898b6ab8d8262466b697c56e0 |
24-Aug-2015 |
Peter Kasting <pkasting@google.com> |
Update a ton of audio code to use size_t more correctly and in general reduce
use of int16_t/uint16_t.
This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects.
This was be reviewed and approved in pieces:
https://codereview.webrtc.org/1224093003
https://codereview.webrtc.org/1224123002
https://codereview.webrtc.org/1224163002
https://codereview.webrtc.org/1225133003
https://codereview.webrtc.org/1225173002
https://codereview.webrtc.org/1227163003
https://codereview.webrtc.org/1227203003
https://codereview.webrtc.org/1227213002
https://codereview.webrtc.org/1227893002
https://codereview.webrtc.org/1228793004
https://codereview.webrtc.org/1228803003
https://codereview.webrtc.org/1228823002
https://codereview.webrtc.org/1228823003
https://codereview.webrtc.org/1228843002
https://codereview.webrtc.org/1230693002
https://codereview.webrtc.org/1231713002
The change is being landed as TBR to all the folks who reviewed the above.
BUG=chromium:81439
TEST=none
R=andrew@webrtc.org, pbos@webrtc.org
TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher
Review URL: https://codereview.webrtc.org/1230503003 .
Cr-Commit-Position: refs/heads/master@{#9768}
nclude/webrtc_vad.h
ad.cc
ad_core.c
ad_core.h
ad_core_unittest.cc
ad_filterbank.c
ad_filterbank.h
ad_filterbank_unittest.cc
ad_sp.c
ad_sp.h
ad_sp_unittest.cc
ad_unittest.cc
ad_unittest.h
ebrtc_vad.c
|
| b297c5a01f88219da26cffe433804963d1b70f0f |
23-Jul-2015 |
pkasting <pkasting@chromium.org> |
Miscellaneous changes split from https://codereview.webrtc.org/1230503003 .
These are mostly trivial changes and are separated out just to reduce the
diff on that change to the minimum possible.
Note explanatory comments on patch set 1.
BUG=none
TEST=none
Review URL: https://codereview.webrtc.org/1235643003
Cr-Commit-Position: refs/heads/master@{#9617}
ad_core_unittest.cc
ad_filterbank_unittest.cc
ad_sp_unittest.cc
ad_unittest.cc
|
| 728d9037c016c01295177fa700fc7927f0bb80bb |
11-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Reformat existing code. There should be no functional effects.
This includes changes like:
* Attempt to break lines at better positions
* Use "override" in more places, don't use "virtual" with it
* Use {} where the body is more than one line
* Make declaration and definition arg names match
* Eliminate unused code
* EXPECT_EQ(expected, actual) (but use (actual, expected) for e.g. _GT)
* Correct #include order
* Use anonymous namespaces in preference to "static" for file-scoping
* Eliminate unnecessary casts
* Update reference code in comments of ARM assembly sources to match actual current C code
* Fix indenting to be more style-guide compliant
* Use arraysize() in more places
* Use bool instead of int for "boolean" values (0/1)
* Shorten and simplify code
* Spaces around operators
* 80 column limit
* Use const more consistently
* Space goes after '*' in type name, not before
* Remove unnecessary return values
* Use "(var == const)", not "(const == var)"
* Spelling
* Prefer true, typed constants to "enum hack" constants
* Avoid "virtual" on non-overridden functions
* ASSERT(x == y) -> ASSERT_EQ(y, x)
BUG=none
R=andrew@webrtc.org, asapersson@webrtc.org, henrika@webrtc.org, juberti@webrtc.org, kjellander@webrtc.org, kwiberg@webrtc.org
Review URL: https://codereview.webrtc.org/1172163004
Cr-Commit-Position: refs/heads/master@{#9420}
ad_unittest.cc
|
| c3deaa30d51dc6336365f0fee3843419fa8616f9 |
28-May-2015 |
Bjorn Volcker <bjornv@webrtc.org> |
common_audio/vad: Removes head allocation failure check
Related to https://webrtc-codereview.appspot.com/51919004/ where Create() was changed. This CL removes a useless malloc failure check.
BUG=441, 3347
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/51109004
Cr-Commit-Position: refs/heads/master@{#9312}
nclude/webrtc_vad.h
ebrtc_vad.c
|
| de4703c5d1290da22feeb708fe915179884e210f |
27-May-2015 |
Bjorn Volcker <bjornv@webrtc.org> |
Refactor common_audio/vad: Create now returns the handle directly instead of an error code
Changed the WebRtcVad_Create() function to the more conventional format of returning the handle directly instead of an error code to take care of.
In addition NULL was changed to nullptr in the files where it applied.
Affected components:
* AGC
* VAD
* NetEQ
BUG=441, 3347
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/51919004
Cr-Commit-Position: refs/heads/master@{#9291}
nclude/webrtc_vad.h
ad.cc
ad_unittest.cc
ebrtc_vad.c
|
| 61a4b04f4004edb91e9ee6b76d4d01971a795ed6 |
13-Apr-2015 |
Bjorn Volcker <bjornv@chromium.org> |
Refactor common_audio/vad: Removed usage of trivial macro WEBRTC_SPL_MUL_16_16(a, b)
The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)
BUG=3348,3353
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43129004
Cr-Commit-Position: refs/heads/master@{#8986}
ad_filterbank.c
|
| 3fbf99c44a30f09d4e3402e192067d053ced5c55 |
25-Mar-2015 |
Bjorn Volcker <bjornv@webrtc.org> |
Refactor common_audio/vad: Removed usage of WEBRTC_SPL_MUL_16_16_RSFT
The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))
where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)
The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes
BUG=3347, 3348, 3353
TESTED=locally on Linux for both fixed and floating point and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44799004
Cr-Commit-Position: refs/heads/master@{#8857}
ad_core.c
ad_filterbank.c
ad_gmm.c
ad_sp.c
|
| d25c0340516339718fa06f72ca41d93c7870cac8 |
26-Jan-2015 |
bjornv@webrtc.org <bjornv@webrtc.org> |
Refactor common_audio/vad: Removed usage of macro WEBRTC_SPL_MUL_16_16()
BUG=3348,3353
TESTED=Locally on Mac and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8152 4adac7df-926f-26a2-2b94-8c16560cd09d
ad_filterbank.c
ad_gmm.c
ad_sp.c
|
| ff1a3e36bdd023fc2d3bef9af6b161ce144ffd6b |
10-Dec-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org> |
Make an AudioEncoder subclass for comfort noise
BUG=3926
R=bjornv@webrtc.org, kjellander@webrtc.org, kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7857 4adac7df-926f-26a2-2b94-8c16560cd09d
nclude/vad.h
ock/mock_vad.h
|
| 8aa4d2d2cd46bca6da7e071583482dd7ed0e2d0c |
30-Oct-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org> |
Creating a C++ wrapper class for VAD
Also adding a mock. This work is part of an ongoing effort to
encapsulate encoders in AudioEncoder classes. The CNG encoder will also
be implemented as an AudioEncoder class, and will also contain a VAD
C++ wrapper.
BUG=3926
R=bjornv@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27839004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7570 4adac7df-926f-26a2-2b94-8c16560cd09d
nclude/vad.h
ock/mock_vad.h
ad.cc
|
| bc1a4578e0a8dd98182efb166f6f03d09ca9091d |
13-Oct-2014 |
bjornv@webrtc.org <bjornv@webrtc.org> |
common_audio: Removed macro WEBRTC_SPL_RSHIFT_W16
Replaced the trivial right shift macro at remaining 4 places and removed from signal_processing.
Affected components:
* vad
* aecm
BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7434 4adac7df-926f-26a2-2b94-8c16560cd09d
ad_core.c
|
| 047a46f8b49e7100d7727377c89f109542125b9c |
26-Aug-2014 |
pbos@webrtc.org <pbos@webrtc.org> |
Remove Android.mk build files.
These files are generally not maintained and break, some contain files
that don't exist anymore and do not build anymore. If we need to add
some of these back we should really set up a bot for them.
R=andrew@webrtc.org, glaznev@webrtc.org, henrike@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/15249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6974 4adac7df-926f-26a2-2b94-8c16560cd09d
ndroid.mk
|
| 65f933899b815b6c09f8ca7beefeace09ee3ae70 |
30-Apr-2014 |
andrew@webrtc.org <andrew@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Fix constness of AudioBuffer accessors.
Don't return non-const pointers from const accessors and deal with the
spillover. Provide overloaded versions as needed.
Inspired by kwiberg:
https://webrtc-codereview.appspot.com/12379005/
R=bjornv@webrtc.org, kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6030 4adac7df-926f-26a2-2b94-8c16560cd09d
nclude/webrtc_vad.h
ad_core.c
ad_core.h
ad_sp.c
ad_sp.h
ebrtc_vad.c
|
| 2a796720f8b2b4e6fbcbf58e687781e412e4dc38 |
22-Apr-2014 |
bjornv@webrtc.org <bjornv@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
common_audio: VADFree() now returns void
* Files in audio_coding are not affected since they never use the return value.
* voice_detection in audio_processing does.
* Updated vad_unittest.cc
BUG=441
TESTED=trybots
R=andrew@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12059005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5948 4adac7df-926f-26a2-2b94-8c16560cd09d
nclude/webrtc_vad.h
ad_unittest.cc
ebrtc_vad.c
|
| aa30bb7ef5b02c9026dc2c036a0bed9999ae4cf2 |
27-May-2013 |
pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Include files from webrtc/.. paths in common_audio/
BUG=1662
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1535005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4107 4adac7df-926f-26a2-2b94-8c16560cd09d
nclude/webrtc_vad.h
ad_core.c
ad_core.h
ad_core_unittest.cc
ad_filterbank.c
ad_filterbank.h
ad_filterbank_unittest.cc
ad_gmm.c
ad_gmm.h
ad_gmm_unittest.cc
ad_sp.c
ad_sp.h
ad_sp_unittest.cc
ad_unittest.cc
ad_unittest.h
ebrtc_vad.c
|
| 3004c79c6ad0ca4b4df27d0ca76c2eb29735e267 |
07-May-2013 |
pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Fix clang errors in non-GYP_DEFINES=clang=1 build
BUG=1623
R=stefan@webrtc.org, tina.legrand@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1368004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3968 4adac7df-926f-26a2-2b94-8c16560cd09d
ad_filterbank_unittest.cc
|
| 342353780d411d1fd9eed5cd5e42782100a1d724 |
01-May-2013 |
andrew@webrtc.org <andrew@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Consolidate common_audio into a single target.
In principle should reduce gyp processing time, but the difference was not measurable. In any case, it's a good simplification that aligns with having a single common_video target.
R=bjornv@webrtc.org, kma@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1375004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3928 4adac7df-926f-26a2-2b94-8c16560cd09d
ad.gypi
|
| 6e788df19ef1e37049717757218fe1e74bbce1c2 |
16-Apr-2013 |
pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Remove vim/emacs modelines from .gypi files
BUG=1655
Review URL: https://webrtc-codereview.appspot.com/1326005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3857 4adac7df-926f-26a2-2b94-8c16560cd09d
ad.gypi
|
| a3c82bf6673a2e0367bcb89a287cdc9ec0c37a53 |
19-Jan-2013 |
wjia@webrtc.org <wjia@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Remove '<(library)' in gyp files.
This will remove all usage of '<(library)' in all webrtc gyp files.
Review URL: https://webrtc-codereview.appspot.com/1049005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3392 4adac7df-926f-26a2-2b94-8c16560cd09d
ad.gypi
|
| f3adba499ea3c809bcde26681753c485a531bbb1 |
15-Nov-2012 |
leozwang@webrtc.org <leozwang@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Add Android include path so that header files can follow google style
BUG=1011
TEST=bot
Review URL: https://webrtc-codereview.appspot.com/930018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3107 4adac7df-926f-26a2-2b94-8c16560cd09d
ndroid.mk
|
| 14b43beb7ce4440b30dcea31196de5b4a529cb6b |
22-Oct-2012 |
andrew@webrtc.org <andrew@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Move src/ -> webrtc/
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
ndroid.mk
nclude/webrtc_vad.h
ad.gypi
ad_core.c
ad_core.h
ad_core_unittest.cc
ad_filterbank.c
ad_filterbank.h
ad_filterbank_unittest.cc
ad_gmm.c
ad_gmm.h
ad_gmm_unittest.cc
ad_sp.c
ad_sp.h
ad_sp_unittest.cc
ad_unittest.cc
ad_unittest.h
ebrtc_vad.c
|