| 6955870806624479723addfae6dcf5d13968796c |
|
13-Jan-2016 |
Peter Kasting <pkasting@google.com> |
Convert channel counts to size_t.
IIRC, this was originally requested by ajm during review of the other size_t conversions I did over the past year, and I agreed it made sense, but wanted to do it separately since those changes were already gargantuan.
BUG=chromium:81439
TEST=none
R=henrik.lundin@webrtc.org, henrika@webrtc.org, kjellander@webrtc.org, minyue@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1316523002 .
Cr-Commit-Position: refs/heads/master@{#11229}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|
| 46ea3ce5802f76bdd9177ec495cbc581bf021313 |
|
07-Jan-2016 |
henrika <henrika@webrtc.org> |
AudioDeviceTest.StartPlayoutOnTwoInstances now verifies two active playing streams
TBR=tkchin_webrtc
BUG=b/25343768
Review URL: https://codereview.webrtc.org/1527143007 .
Cr-Commit-Position: refs/heads/master@{#11165}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|
| c729032b1b31e9064a37d3f862bcf60e3651bdff |
|
02-Dec-2015 |
henrika <henrika@webrtc.org> |
Resolves issue with multiple calls to audio unit initialization
BUG=webrtc:5166
R=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1472833002 .
Cr-Commit-Position: refs/heads/master@{#10865}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|
| 98f53510b222f71fdd8b799b2f33737ceeb28c61 |
|
28-Oct-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
system_wrappers: rename interface -> include
BUG=webrtc:5095
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1413333002 .
Cr-Commit-Position: refs/heads/master@{#10438}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|
| 91d6edef35e7275879c30ce16ecb8b6dc73c6e4a |
|
17-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Add RTC_ prefix to (D)CHECKs and related macros.
We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.
Alternative solutions:
* Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable.
* Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce.
* Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable.
* Changes in Chromium for this is obviously not an option.
BUG=chromium:468375
NOTRY=true
Review URL: https://codereview.webrtc.org/1335923002
Cr-Commit-Position: refs/heads/master@{#9964}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|
| 86d907cffda803ee34ee68f9833c1980d1b9f7a6 |
|
07-Sep-2015 |
henrika <henrika@webrtc.org> |
Refactor the AudioDevice for iOS and improve the performance and stability
This CL contains major modifications of the audio output parts for WebRTC on iOS:
- general code cleanup
- improves thread handling (added thread checks, remove critical section, atomic ops etc.)
- reduces loopback latency of iPhone 6 from ~90ms to ~60ms ;-)
- improves selection of audio parameters on iOS
- reduces complexity by removing complex and redundant delay estimates
- now instead uses fixed delay estimates if for some reason the SW EAC must be used
- adds AudioFineBuffer to compensate for differences in native output buffer size and
the 10ms size used by WebRTC. Same class as is used today on Android and we have unit tests for
this class (the old code was buggy and we have several issue reports of crashes related to it)
Similar improvements will be done for the recording sid as well in a separate CL.
I will also add support for 48kHz in an upcoming CL since that will improve Opus performance.
BUG=webrtc:4796,webrtc:4817,webrtc:4954, webrtc:4212
TEST=AppRTC demo and iOS modules_unittests using --gtest_filter=AudioDevice*
R=pbos@webrtc.org, tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1254883002 .
Cr-Commit-Position: refs/heads/master@{#9875}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|
| 41eeff49fa0c44afefa581189805a9bda0db2182 |
|
25-Aug-2015 |
Peter Kasting <pkasting@google.com> |
More iOS compile fixes.
BUG=chromium:81439
TEST=none
TBR=niklas.enbom
Review URL: https://codereview.webrtc.org/1314463003 .
Cr-Commit-Position: refs/heads/master@{#9770}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|
| deb4875b74bdafb0b11b8df383b5ee1692d89dea |
|
25-Aug-2015 |
Peter Kasting <pkasting@google.com> |
Fix typos in https://codereview.webrtc.org/1230503003/ not caught by trybots.
BUG=chromium:81439
TEST=none
TBR=niklas.enbom
Review URL: https://codereview.webrtc.org/1308693007 .
Cr-Commit-Position: refs/heads/master@{#9769}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|
| dce40cf804019a9898b6ab8d8262466b697c56e0 |
|
24-Aug-2015 |
Peter Kasting <pkasting@google.com> |
Update a ton of audio code to use size_t more correctly and in general reduce
use of int16_t/uint16_t.
This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects.
This was be reviewed and approved in pieces:
https://codereview.webrtc.org/1224093003
https://codereview.webrtc.org/1224123002
https://codereview.webrtc.org/1224163002
https://codereview.webrtc.org/1225133003
https://codereview.webrtc.org/1225173002
https://codereview.webrtc.org/1227163003
https://codereview.webrtc.org/1227203003
https://codereview.webrtc.org/1227213002
https://codereview.webrtc.org/1227893002
https://codereview.webrtc.org/1228793004
https://codereview.webrtc.org/1228803003
https://codereview.webrtc.org/1228823002
https://codereview.webrtc.org/1228823003
https://codereview.webrtc.org/1228843002
https://codereview.webrtc.org/1230693002
https://codereview.webrtc.org/1231713002
The change is being landed as TBR to all the folks who reviewed the above.
BUG=chromium:81439
TEST=none
R=andrew@webrtc.org, pbos@webrtc.org
TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher
Review URL: https://codereview.webrtc.org/1230503003 .
Cr-Commit-Position: refs/heads/master@{#9768}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|
| ba35d05a4918b3efa7ab88674781aadb48017ff8 |
|
14-Jul-2015 |
henrika <henrika@webrtc.org> |
Cleanup of iOS AudioDevice implementation
TBR=tkchin
BUG=webrtc:4789
TEST=modules_unittests --gtest_filter=AudioDeviceTest* and AppRTCDemo
Review URL: https://codereview.webrtc.org/1206783002 .
Cr-Commit-Position: refs/heads/master@{#9578}
/external/webrtc/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
|