| 0c7e9f540b282d60b94081f601a1694054d8646e |
|
29-Dec-2015 |
Taylor Brandstetter <deadbeef@webrtc.org> |
Removing webrtc::PortAllocatorFactoryInterface.
ICE servers are now passed directly into PortAllocator,
making PortAllocatorFactoryInterface redundant. This CL also
moves SetNetworkIgnoreMask to PortAllocator.
R=phoglund@webrtc.org, pthatcher@webrtc.org, tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1520963002 .
Cr-Commit-Position: refs/heads/master@{#11139}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 653b8e02f22c9b6ba38be1cf4c0fa101894a9407 |
|
11-Nov-2015 |
deadbeef <deadbeef@webrtc.org> |
Reland of Adding the ability to change ICE servers through SetConfiguration. (patchset #1 id:1 of https://codereview.webrtc.org/1424803004/ )
Reason for revert:
Relanding with compile warning fixed.
Original issue's description:
> Revert of Adding the ability to change ICE servers through SetConfiguration. (patchset #7 id:120001 of https://codereview.webrtc.org/1391013007/ )
>
> Reason for revert:
> Caused compiler warning, breaking Chrome FYI bots.
>
> Original issue's description:
> > Adding the ability to change ICE servers through SetConfiguration.
> >
> > Added a SetIceServers method to PortAllocator. Also added a new
> > PeerConnection Initialize method that takes a PortAllocator, in the
> > hope that we can get rid of PortAllocatorFactoryInterface, since the
> > only substantial thing a factory does is convert the webrtc:: ICE
> > servers to cricket:: versions.
> >
> > Committed: https://crrev.com/d3b26d94399ff539db375a9b84010ee75479d4cf
> > Cr-Commit-Position: refs/heads/master@{#10420}
>
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/18a944bf0ac9eed872dc009bd58e6bc12c946303
> Cr-Commit-Position: refs/heads/master@{#10421}
TBR=pthatcher@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1414313003
Cr-Commit-Position: refs/heads/master@{#10609}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 9af97f89103d8f1f77b52a6ae77b8b7bcdc23f71 |
|
10-Nov-2015 |
Guo-wei Shieh <guoweis@webrtc.org> |
WebRTC should generate default private address even when adapter enumeration is disabled.
Introduce a DefaultAddressProvider such that rtc::Network can't access other part of NetworkManager.
This also removes the hack of generating the loopback address. The dependency has been removed by https://codereview.chromium.org/1417023003/
BUG=webrtc:5061
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1411253008 .
Cr-Commit-Position: refs/heads/master@{#10590}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 18a944bf0ac9eed872dc009bd58e6bc12c946303 |
|
27-Oct-2015 |
deadbeef <deadbeef@webrtc.org> |
Revert of Adding the ability to change ICE servers through SetConfiguration. (patchset #7 id:120001 of https://codereview.webrtc.org/1391013007/ )
Reason for revert:
Caused compiler warning, breaking Chrome FYI bots.
Original issue's description:
> Adding the ability to change ICE servers through SetConfiguration.
>
> Added a SetIceServers method to PortAllocator. Also added a new
> PeerConnection Initialize method that takes a PortAllocator, in the
> hope that we can get rid of PortAllocatorFactoryInterface, since the
> only substantial thing a factory does is convert the webrtc:: ICE
> servers to cricket:: versions.
>
> Committed: https://crrev.com/d3b26d94399ff539db375a9b84010ee75479d4cf
> Cr-Commit-Position: refs/heads/master@{#10420}
TBR=pthatcher@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1424803004
Cr-Commit-Position: refs/heads/master@{#10421}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| d3b26d94399ff539db375a9b84010ee75479d4cf |
|
27-Oct-2015 |
deadbeef <deadbeef@webrtc.org> |
Adding the ability to change ICE servers through SetConfiguration.
Added a SetIceServers method to PortAllocator. Also added a new
PeerConnection Initialize method that takes a PortAllocator, in the
hope that we can get rid of PortAllocatorFactoryInterface, since the
only substantial thing a factory does is convert the webrtc:: ICE
servers to cricket:: versions.
Review URL: https://codereview.webrtc.org/1391013007
Cr-Commit-Position: refs/heads/master@{#10420}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 0c4e06b4c6107a1b94f764e279e4fb4161e905b0 |
|
07-Oct-2015 |
Peter Boström <pbos@webrtc.org> |
Use suffixed {uint,int}{8,16,32,64}_t types.
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 98db68fdaa12c5bfca8b0004eba24d034f32de71 |
|
29-Sep-2015 |
honghaiz <honghaiz@webrtc.org> |
If gather_continually is set to true, keep the last port allocator session running while stopping all existing process of getting ports (when p2ptransportchannel first becomes writable).
BUG=5034
Review URL: https://codereview.webrtc.org/1359363003
Cr-Commit-Position: refs/heads/master@{#10110}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| cbecd358e032021eac11fb13e04ec7f070d4f407 |
|
23-Sep-2015 |
deadbeef <deadbeef@webrtc.org> |
Reland of TransportController refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/1358413003/ )
Reason for revert:
This CL just landed: https://codereview.chromium.org/1323243006/
Which fixes the FYI bots for the original CL, and breaks them for this revert.
Original issue's description:
> Revert of TransportController refactoring. (patchset #6 id:100001 of https://codereview.webrtc.org/1350523003/ )
>
> Reason for revert:
> This CL causes problems with the WebRTC-in-Chromium FYI bots. Presumably it needs to be done in several steps, where removed files are emptied instead of removed in the first step.
>
> Original issue's description:
> > TransportController refactoring.
> >
> > Getting rid of TransportProxy, and in its place adding a
> > TransportController class which will facilitate access to and manage
> > the lifetimes of Transports. These Transports will now be accessed
> > solely from the worker thread, simplifying their implementation.
> >
> > This refactoring also pulls Transport-related code out of BaseSession.
> > Which means that BaseChannels will now rely on the TransportController
> > interface to create channels, rather than BaseSession.
> >
> > Committed: https://crrev.com/47ee2f3b9f33e8938948c482c921d4e13a3acd83
> > Cr-Commit-Position: refs/heads/master@{#10022}
>
> TBR=pthatcher@webrtc.org,deadbeef@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/a81a42f584baa0d93a4b93da9632415e8922450c
> Cr-Commit-Position: refs/heads/master@{#10024}
TBR=pthatcher@webrtc.org,torbjorng@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1361773005
Cr-Commit-Position: refs/heads/master@{#10036}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| a81a42f584baa0d93a4b93da9632415e8922450c |
|
23-Sep-2015 |
torbjorng <torbjorng@webrtc.org> |
Revert of TransportController refactoring. (patchset #6 id:100001 of https://codereview.webrtc.org/1350523003/ )
Reason for revert:
This CL causes problems with the WebRTC-in-Chromium FYI bots. Presumably it needs to be done in several steps, where removed files are emptied instead of removed in the first step.
Original issue's description:
> TransportController refactoring.
>
> Getting rid of TransportProxy, and in its place adding a
> TransportController class which will facilitate access to and manage
> the lifetimes of Transports. These Transports will now be accessed
> solely from the worker thread, simplifying their implementation.
>
> This refactoring also pulls Transport-related code out of BaseSession.
> Which means that BaseChannels will now rely on the TransportController
> interface to create channels, rather than BaseSession.
>
> Committed: https://crrev.com/47ee2f3b9f33e8938948c482c921d4e13a3acd83
> Cr-Commit-Position: refs/heads/master@{#10022}
TBR=pthatcher@webrtc.org,deadbeef@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1358413003
Cr-Commit-Position: refs/heads/master@{#10024}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 47ee2f3b9f33e8938948c482c921d4e13a3acd83 |
|
23-Sep-2015 |
deadbeef <deadbeef@webrtc.org> |
TransportController refactoring.
Getting rid of TransportProxy, and in its place adding a
TransportController class which will facilitate access to and manage
the lifetimes of Transports. These Transports will now be accessed
solely from the worker thread, simplifying their implementation.
This refactoring also pulls Transport-related code out of BaseSession.
Which means that BaseChannels will now rely on the TransportController
interface to create channels, rather than BaseSession.
Review URL: https://codereview.webrtc.org/1350523003
Cr-Commit-Position: refs/heads/master@{#10022}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 7cbd188c5ed7df80bb737bd4ada94422730e2d89 |
|
18-Sep-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Remove GICE (again).
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1353713002 .
Cr-Commit-Position: refs/heads/master@{#9979}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| d12140a68efdcffa1c2c18f25149905e9dae1a9c |
|
10-Sep-2015 |
guoweis <guoweis@webrtc.org> |
Revert change which removes GICE.
There are still dependencies on this functionality.
TBR=pthatcher@webrtc.org
BUG=526399
Review URL: https://codereview.webrtc.org/1336553003
Cr-Commit-Position: refs/heads/master@{#9920}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 13d35f6ffc71c1a649a902369a6fa5637d05d9b0 |
|
27-Aug-2015 |
Guo-wei Shieh <guoweis@webrtc.org> |
Add check to prevent TURN usage if the protocol is not allowed.
There are 2 ways to design this.
1. TCP Only mode: this means that we disable all UDP protocols across board.
2. disallow TURN over UDP. Along with DISABLE_UDP, DISABLE_STUN, we should achieve the same result.
I'm going with #2.
BUG=webrtc:4784
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1311153003 .
Cr-Commit-Position: refs/heads/master@{#9791}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 2159b89fa2cb55beeef38f72bd45e217f3d33d4e |
|
22-Aug-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.
This reverts commit 5bdafd44c86ee46bd7e040f19828324583418b33.
Original CL: https://codereview.webrtc.org/1263663002/
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1303393002 .
Cr-Commit-Position: refs/heads/master@{#9761}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 5bdafd44c86ee46bd7e040f19828324583418b33 |
|
21-Aug-2015 |
minyuel <minyue@webrtc.org> |
Revert "Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.""
This reverts commit 081f34b564e1a26ffbbe9515eba1fef7c736fdde.
Original code review see
https://codereview.webrtc.org/1291363005
The revert is due to a suspicion of "Reland "Remove GICE..." being the cause of failure on Linux memcheck, see
https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4137
TBR=pthatcher@webrtc.org,
BUG=
Review URL: https://codereview.webrtc.org/1308753003 .
Cr-Commit-Position: refs/heads/master@{#9756}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| fe3bc9d5aeffed8bbfb34c330d8b991abd1a1aba |
|
20-Aug-2015 |
Guo-wei Shieh <guoweis@webrtc.org> |
Relanding "Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied."
Migrated from https://codereview.webrtc.org/1275703006/ which causes test failures for android. On android, loopback interface was used as local interface to generate candidates. Add a test case to make sure this won't be broken in the future.
Also observed some failures under content_browsertests in chromium.fyi bot but can't repro locally. Might just be temporary test issue.
BUG=webrtc:4517
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1299333003 .
Cr-Commit-Position: refs/heads/master@{#9746}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 081f34b564e1a26ffbbe9515eba1fef7c736fdde |
|
20-Aug-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots."
This reverts commit 475243a134be003aab30bb17294ca6c664d0ef81.
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1291363005 .
Cr-Commit-Position: refs/heads/master@{#9738}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 370c8848ad38d54457a960e0ebe94f8adf370e23 |
|
19-Aug-2015 |
Guo-wei Shieh <guoweis@webrtc.org> |
Revert "Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied."
This reverts commit 0a2955f227666efd87b2a303a69c083ef801c528.
Revert "In the past, P2PPortAllocator.enable_multiple_routes is the indicator whether we should bind to the any address. It's easy to translate that into a port allocator flag in P2PPortAllocator's ctor. Going forward, we have to depend on an asynchronous permission check to determine whether gathering local address is allowed or not, hence the current way of passing it through constructor approach won't work any more. The asynchronous check will trigger SignalNetowrksChanged so we could only check that inside DoAllocate."
This reverts commit ba9ab4cd8d2e8fbc068dc36b5e6f6331d7deeccf.
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1288843003 .
Cr-Commit-Position: refs/heads/master@{#9729}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 0a2955f227666efd87b2a303a69c083ef801c528 |
|
18-Aug-2015 |
Guo-wei Shieh <guoweis@webrtc.org> |
Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied.
BUG=webrtc:4517
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1275703006 .
Cr-Commit-Position: refs/heads/master@{#9726}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| fa301809b698017455847f45cc7e0dfa1bdfed35 |
|
11-Aug-2015 |
pthatcher <pthatcher@webrtc.org> |
Revert "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.
This reverts commit 3449faa553ec94c52ef2d0949867befb60992c88.
TBR=deadbeef@webrtc.org, juberti@webrtc.org
NOPRESUBMIT=true
Review URL: https://codereview.webrtc.org/1274273005
Cr-Commit-Position: refs/heads/master@{#9698}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 3449faa553ec94c52ef2d0949867befb60992c88 |
|
10-Aug-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever).
R=deadbeef@webrtc.org, juberti@webrtc.org
Review URL: https://codereview.webrtc.org/1263663002 .
Cr-Commit-Position: refs/heads/master@{#9692}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 73ba7a690fb562e7eef76ef50a751f7da0564394 |
|
14-Apr-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Remove PORTALLOCATOR_ENABLE_BUNDLE, PortAllocatorSessionProxy, PortAllocatorSessionMuxer, and PortProxy.
R=decurtis@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46809004
Cr-Commit-Position: refs/heads/master@{#8999}
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| f358aea7bff8091c608e1afd8cf395ec2702ff76 |
|
18-Feb-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Fix WebRTC IP leaks.
WebRTC binds to individual NICs and listens for incoming Stun packets. Sending stun through this specific NIC binding could make OS route the packet differently hence exposing non-VPN public IP.
The fix here is
1. to bind to any address (0:0:0:0) instead. This way, the routing will be the same as how chrome/http is.
2. also, remove the any all 0s addresses which happens when we bind to all 0s.
BUG=4276
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39129004
Cr-Commit-Position: refs/heads/master@{#8418}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8418 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 0ba1533fdbe4a098723da8262f1374d71c3a1806 |
|
10-Jan-2015 |
pthatcher@webrtc.org <pthatcher@webrtc.org> |
Added support for an Origin header in STUN messages.
For WebRTC there are instances where it may be desirable to provide
information to the STUN/TURN server about the website that initiated
a peer connection. This modification allows an origin string to be
included in the MediaConstraints object provided by the browser, which
is then passed as a STUN header in communications with the server.
A separate change will be submitted to the Chromium project that
uses and is dependent on this change, implementing IETF draft
http://tools.ietf.org/html/draft-johnston-tram-stun-origin-02
Originally a patch from skobalt@gmail.com.
(https://webrtc-codereview.appspot.com/12839005/edit)
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8035 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 269fb4bc90b79bebbb8311da0110ccd6803fd0a8 |
|
28-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
move xmpp and p2p to webrtc
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and
webrtc/p2p. Also makes libjingle use those version instead of the one in the talk folder.
BUG=3379
Review URL: https://webrtc-codereview.appspot.com/26999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7549 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| 28100cb38896fe298b6df11ffd31838d9faf5b8a |
|
18-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Reverts r7459 "Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p."
BUG=N/A
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7472 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/portallocator.h
|
| d1ba6d9cbfc44618d2c553ff7851948c730ae37b |
|
15-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p.
BUG=3379
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27709005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7459 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/portallocator.h
|