8d15bd6dabae829d27443e17f2f02cfbe6fa6525 |
|
07-Oct-2015 |
ivica <ivica@webrtc.org> |
Reland of Collecting encode_time_ms for each frame (patchset #1 id:1 of https://codereview.webrtc.org/1383283005/ ) Reason for revert: The reverted commit didn't affect the tests, but the one before: https://codereview.webrtc.org/1385563005/ I've run the test that was failing (EndToEndTest.AssignsTransportSequenceNumbers) locally multiple times, and it works fine (finishes successfully in 150-170ms). Original issue's description: > Revert of Collecting encode_time_ms for each frame (patchset #13 id:220001 of https://codereview.webrtc.org/1374233002/ ) > > Reason for revert: > Breaks EndToEndTest.AssignsTransportSequenceNumbers in video_engine_tests > on several bots: > http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5507 > http://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/4815 > http://build.chromium.org/p/client.webrtc/builders/Win%20SyzyASan/builds/3272 > http://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4414 > > It seems very unfortunate that it breaks on _exactly_ the bot configs that aren't covered by the CQ trybots. > > Original issue's description: > > Collecting encode_time_ms for each frame. > > > > Also, in Sample struct, replacing double with the original type. > > It makes more sense to save the original data as truthful as possible, and then > > convert it to double later if necessary (in the plot script). > > > > Committed: https://crrev.com/092b13384e57b33e2003d9736dfa1f491e76f938 > > Cr-Commit-Position: refs/heads/master@{#10184} > > TBR=sprang@webrtc.org,pbos@webrtc.org,mflodman@webrtc.org,asapersson@webrtc.org,ivica@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/810447972425e890bc7911af27f894b86e9b7e6f > Cr-Commit-Position: refs/heads/master@{#10185} TBR=sprang@webrtc.org,pbos@webrtc.org,mflodman@webrtc.org,asapersson@webrtc.org,kjellander@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.webrtc.org/1390163002 Cr-Commit-Position: refs/heads/master@{#10195}
/external/webrtc/webrtc/video/full_stack_plot.py
|
810447972425e890bc7911af27f894b86e9b7e6f |
|
06-Oct-2015 |
kjellander <kjellander@webrtc.org> |
Revert of Collecting encode_time_ms for each frame (patchset #13 id:220001 of https://codereview.webrtc.org/1374233002/ ) Reason for revert: Breaks EndToEndTest.AssignsTransportSequenceNumbers in video_engine_tests on several bots: http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5507 http://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/4815 http://build.chromium.org/p/client.webrtc/builders/Win%20SyzyASan/builds/3272 http://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4414 It seems very unfortunate that it breaks on _exactly_ the bot configs that aren't covered by the CQ trybots. Original issue's description: > Collecting encode_time_ms for each frame. > > Also, in Sample struct, replacing double with the original type. > It makes more sense to save the original data as truthful as possible, and then > convert it to double later if necessary (in the plot script). > > Committed: https://crrev.com/092b13384e57b33e2003d9736dfa1f491e76f938 > Cr-Commit-Position: refs/heads/master@{#10184} TBR=sprang@webrtc.org,pbos@webrtc.org,mflodman@webrtc.org,asapersson@webrtc.org,ivica@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.webrtc.org/1383283005 Cr-Commit-Position: refs/heads/master@{#10185}
/external/webrtc/webrtc/video/full_stack_plot.py
|
092b13384e57b33e2003d9736dfa1f491e76f938 |
|
06-Oct-2015 |
ivica <ivica@webrtc.org> |
Collecting encode_time_ms for each frame. Also, in Sample struct, replacing double with the original type. It makes more sense to save the original data as truthful as possible, and then convert it to double later if necessary (in the plot script). Review URL: https://codereview.webrtc.org/1374233002 Cr-Commit-Position: refs/heads/master@{#10184}
/external/webrtc/webrtc/video/full_stack_plot.py
|
5d6a06c1d29a2061bcf4b321ffceab477a404d51 |
|
17-Sep-2015 |
ivica <ivica@webrtc.org> |
Refactoring full stack and loopback tests Refactoring full stack, video and screenshare tests to use the same code basis for parametrization and initialization. This patch is done on top of recently commited full stack graphs CL https://codereview.webrtc.org/1289933003/, but virtually no changes have been made to full_stack_plot.py nor to the VideoAnalyzer in full stack, except moving it to video_quality_test.cc. Also, full_stack_samples.cc (build target) was removed and replaced with -output_filename and -duration cmdline arguments in video_loopback and screenshare_loopback. The important things to review: - video_quality_test.h Is the structure of Params good? (examples of usage can be found in full_stack.cc, video_loopback.cc and screenshare_loopback.cc) - video_quality_test.cc Is the initialization correct? The case for using Analyzer and using local renderer are different, can they be further merged? - webrtc_tests.gypi Reproducing the different bitrate settings the full stack and loopback tests had was a little bit tricky. To support both simultaneously, I added BitrateConfig to the Params struct, as well as separate start_bitrate and target_bitrate flags for loopback tests. Note: Side-by-side diff for video_quality_test.cc compares that file directly with the old full_stack.cc, so changes to VideoAnalyzer are clearly visible. Note: Recent CL I've committed added -num_temporal_layers and -sl_discard_threshold args to loopback tests. This was removed here. Support for streams and SVC will be added in a CL following this one. Review URL: https://codereview.webrtc.org/1308403003 Cr-Commit-Position: refs/heads/master@{#9969}
/external/webrtc/webrtc/video/full_stack_plot.py
|
05cfcd34693d86de7a1a481f071eae561361588a |
|
07-Sep-2015 |
ivica <ivica@webrtc.org> |
Full stack graphs Updating full stack test to optionally save metadata for each frame and save it to a file with given filename (controlled from the new full_stack_samples executable). Adding a Python script that reads the output generated by full stack test and plots the graph(s). Review URL: https://codereview.webrtc.org/1289933003 Cr-Commit-Position: refs/heads/master@{#9874}
/external/webrtc/webrtc/video/full_stack_plot.py
|