| b1cf03160fa7e7bc6e5cf138db07a7e1ab2ecb26 |
|
17-Oct-2015 |
Marco Nelissen <marcone@google.com> |
Move overflow checks into SkipCutBuffer
Previously SkipCutBuffer would check its input parameters to ensure
they were sane, however since bogus values might be the result of
overflows, and overflow protection was recently turned on for
libstagefright, the compiler's overflow checks were performed before
SkipCutBuffer's, resulting in abort rather than just ignoring the
bogus values.
Moving the multiplication by framesize into SkipCutBuffer fixes this.
Change-Id: I1ad6744bb045a5212701bbf6ee44eecb5f318210
/frameworks/av/include/media/stagefright/SkipCutBuffer.h
|
| e1054e74bb02ad4789bfce1e3a04f04825a572db |
|
19-Oct-2015 |
Marco Nelissen <marcone@google.com> |
Revert "Move overflow checks into SkipCutBuffer"
This reverts commit 6867e1a1e25d4ec5344eae070f0fbc284bb92876.
Change-Id: I90d479dac014c72ffa7151a30e79e68d9ce967ac
/frameworks/av/include/media/stagefright/SkipCutBuffer.h
|
| 6867e1a1e25d4ec5344eae070f0fbc284bb92876 |
|
17-Oct-2015 |
Marco Nelissen <marcone@google.com> |
Move overflow checks into SkipCutBuffer
Previously SkipCutBuffer would check its input parameters to ensure
they were sane, however since bogus values might be the result of
overflows, and overflow protection was recently turned on for
libstagefright, the compiler's overflow checks were performed before
SkipCutBuffer's, resulting in abort rather than just ignoring the
bogus values.
Moving the multiplication by framesize into SkipCutBuffer fixes this.
Change-Id: I82497a05af17c91a8d271882f7354fae6497382a
/frameworks/av/include/media/stagefright/SkipCutBuffer.h
|
| a6cdabf38b29ee98bdb3e874b4e2978dbc409624 |
|
18-Sep-2013 |
Marco Nelissen <marcone@google.com> |
Fully reset SkipCutBuffer state in clear()
b/8543366
Change-Id: I1b90d56ba3d672fd12b4ee91fa9ba24c665126ed
/frameworks/av/include/media/stagefright/SkipCutBuffer.h
|
| 8b71241ce7353731ab75322c46e090ee35014a33 |
|
27-Apr-2012 |
Marco Nelissen <marcone@google.com> |
Fix mono gapless playback for decoders that output stereo
The old AAC decoder always outputs stereo, even for mono source material, so we
need to use the number of channels of the output when calculating the number of
bytes to skip, not the number of channels in the source.
This makes OMXCodec skip the right amount of data, and prevents NuPlayer from
writing half a frame and then asserting when the AudioSink doesn't accept it.
Also move use of the SkipCutBuffer from NuPlayer to ACodec, so that it also
works when using the new Java APIs, and make SkipCutBuffer derive from RefBase.
b/774846
Change-Id: I34df9fea3e6730617eae559afaa556f4085ef0a0
/frameworks/av/include/media/stagefright/SkipCutBuffer.h
|
| cb5b766bb0a3ed992998a5bd66de0ee1d2223b81 |
|
29-Mar-2012 |
Marco Nelissen <marcone@google.com> |
Add ABuffer support to SkipCutBuffer
Add support for ABuffer to SkipCutBuffer, and make it (re)allocate an
appropriately sized buffer when needed, rather then relying on the
caller to tell it ahead of time how big the buffers are going to be.
Change-Id: I8b5c9ba5dd2fc13ef8870b7d4fe93a1bfdc7a626
/frameworks/av/include/media/stagefright/SkipCutBuffer.h
|
| a98478bfbcc0f7fb4b164d3dce40ca96df75667d |
|
21-Mar-2012 |
Marco Nelissen <marcone@google.com> |
Support gapless playback for mp3 and m4a
Gapless playback for appropriately tagged mp3 and m4a files.
Currently this is implemented in OMXCodec, which most players
use, but should be easy to support in other players as well by
using the SkipCutBuffer utility class.
Change-Id: I748c669adc1cfbe5ee9a7dea2fad945d48882551
/frameworks/av/include/media/stagefright/SkipCutBuffer.h
|