History log of /frameworks/base/location/tests/locationtests/src/android/location/GpsStatusTest.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
76a620f0482ba54a4921c7c7e7eeb8ea87c12d3e 27-Feb-2016 Lifu Tang <lifu@google.com> Addressed the review comments from API Council

Following are the review comments from API Council:

(Places below that reference "s/foo/bar/" below are suggesting that "foo" be
replaced with "bar".)

GnssClock
-- Class docs should not refer to "GPS" at the top level
-- s/InNs/Nanos/
-- s/Sec/Second/

GnssMeasurement
-- s/In// for "InUnitname"
-- s/Sec/Second/
-- s/Ms/Millis/
-- s/Deg/Degrees/
-- STATUS_GPS_LOCATION_DISABLED -> STATUS_GNSS_LOCATION_DISABLED

GnssMeasurementsEvent.Callback
-- "returns" -> "reports" in the method docs as the methods return void

LocationManager
-- register/unregisterGnssMeasurementEventCallback ->
register/unregisterGnssMeasurementsEventCallback (plural)

GnssNavigationMessage
-- MESSAGE_TYPE_ constants -> change to just TYPE_; the "MESSAGE" is redundant
with the class name
-- is a signed byte/short ok based on the standard here? If not consider using
int in the public api

GnssStatus
-- Make sure @IntDef exists for the constellation type
-- Please append unit types for values returned to match GnssMeasurement methods

GnssStatusCallback
-- Please document time base/units for the time parameter of onFirstFix

Bug: 27385557
Change-Id: Ifed6a2eca3fd7ba89b3ded6964a70376235af8f4
/frameworks/base/location/tests/locationtests/src/android/location/GpsStatusTest.java
6bde4683ae1f70f7b5e53f853b6a7479bcebd5d5 31-Jan-2015 destradaa <destradaa@google.com> Reduce memory usage of GpsStatus objects.

A simple GpsStatus object uses 9K of space, given that it initializes an array
of 255 GpsSatellite objects.
This change reduces the memory footprint in the average case, and keeps the
semantics of the API and its GpsSatellite sibling objects without any changes.
In a best case scenario it brings the memory usage per object to 1K.
It's likely in most cases that only 20-50 satellites will be in view. So the
usage should not exceeed half of the original memory usage.
It was considered to keep the internal array but a SparseArray provided bigger
memory savings in the test scenario of ~700B.

Change-Id: Ie2d2144d776a74d4904a08c0d6c5aec6d3bba7cc
/frameworks/base/location/tests/locationtests/src/android/location/GpsStatusTest.java