| 45b0ea2a10e79b580aabb411126d8d6b79c9da95 |
|
31-May-2016 |
Chris Banes <chrisbanes@google.com> |
Fix action mode animation on recreations
Currently if an action mode is started in onCreate()
it will fade in. This isn't ideal though, especially
since Activities are recreated routinely with
multi-window and resizable Activities. In that instance
we fade it in on every recreate.
This CL fixes this in both the decor and toolbar action
modes to only fade in if the decor has been laid out.
BUG: 29036694
Change-Id: Id75ac73bcf00bc15c91734a03195332dc118578c
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| bfc9bd50c5c7e6874dc6f32a5d81620398a5c1e5 |
|
26-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
ActionMode fixes found in testing
- Fix onSupportActionModeFinished() being called twice.
Caused by double wrapping the callback which means that
each call is called twice.
- Fix onPrepareActionMode not being called. Caused by setting
the current action mode too late.
BUG: 28378961
BUG: 28392319
Change-Id: I7e41f1396c7230a37880c8c812d4622e969e032b
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 0b30bc953eb10599ed2c055534bf0d44a856bcfd |
|
22-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Ensure window decor is installed for AppCompat
am: d3c6a16226
* commit 'd3c6a162266698b98df2fa7793d9fe4d8ee8935b':
Ensure window decor is installed for AppCompat
Change-Id: I5479df1cccb8b95db9d5d33b9a4f9adfc52776a5
|
| d3c6a162266698b98df2fa7793d9fe4d8ee8935b |
|
21-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Ensure window decor is installed for AppCompat
When AppCompat installs its subdecor, we should
make sure that the window has installed its decor.
BUG: 28313462
Change-Id: I46608bf28d19bf57c750674587fe4259b6418ad7
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| e2ab9873e9196e5e980af29bc3f4b8ba9d6713d8 |
|
21-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Merge "Add vectors within resources back behind an API" into mnc-ub-dev
am: 4a747ca817
* commit '4a747ca817a3ed6160771f0e559240a0f7f4f0cb':
Add vectors within resources back behind an API
Change-Id: Ie759675975f5fd8e594d2e13465780f8324006d9
|
| 4a747ca817a3ed6160771f0e559240a0f7f4f0cb |
|
21-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Merge "Add vectors within resources back behind an API" into mnc-ub-dev
|
| ddb17bc519bc20ed5728300e817064f7d007eacf |
|
18-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Merge "Re-apply Day/Night to all Activities" into mnc-ub-dev
am: c12e7b7
* commit 'c12e7b796da9cd734298b79579b5243a00951970':
Re-apply Day/Night to all Activities
Change-Id: I88e8da79e9dd6d17c85b36636d5745c095fe9cec
|
| 5fa121a1f51114f3a2f6d705139e83c0e0aea610 |
|
18-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Add vectors within resources back behind an API
This adds back in the functionality removed in
Iad401718e51da15fddbd7ff88e41743dca40ad04, but
behind an API, defaulting to disabled.
Removing functionality wasn't good, but we needed
to do it. This enables developers to use the functionality
again, but having to explicitly opt in with the
associated caveats.
BUG: 28186451
Change-Id: Ic99b6319fdd58a5a6ece19b2fbf88c148bfd0618
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 862ce3b5a8789281e0510da9195bc8ea22581706 |
|
18-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Re-apply Day/Night to all Activities
Currently config changes will wipe an Activities
day night configuration. This CL fixes it by
re-applying it to the configuration.
BUG: 28111150
Change-Id: I4d68cd69bab2895c1e747388a0f7fa0c6f1ce01e
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 3c91608a3d108b9440f6ccc2f4a05d212c5b34a6 |
|
13-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Don\'t clear out ActionBar instance in onDestroy()
am: b5cadf5
* commit 'b5cadf52287f99f80edfe519aefe4a2881e61fac':
Don't clear out ActionBar instance in onDestroy()
Change-Id: I1616baabaf5b762c448aece84d152bb030a50640
|
| b5cadf52287f99f80edfe519aefe4a2881e61fac |
|
12-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Don't clear out ActionBar instance in onDestroy()
Technically this is correct, but it deviates from
the framework and causes issues for developers using
multi window (since they have to do a null check).
BUG: 28123702
Change-Id: Ic80b050a04667dec660354ae1ab751fab4a15d98
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| ea88ed0416b351bd4406f09412280bdcc4a52291 |
|
04-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Back out TintResources changes DO NOT MERGE ANYWHERE
They were causing memory and configuration issues
therefore we need to back it out. This will revert
the functionality of being able to reference vector
drawables from within resources, but it's a necessary
cost.
We still need TintResources, but it's now back to being
a wrapper object which does not cause any issues.
BUG: 27877272
BUG: 27808232
Change-Id: Iad401718e51da15fddbd7ff88e41743dca40ad04
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 60cc94cdf2f9dfd10f2fe0b3fa0fa438d51df271 |
|
04-Apr-2016 |
Chris Banes <chrisbanes@google.com> |
Back out TintResources changes
They were causing memory and configuration issues
therefore we need to back it out. This will revert
the functionality of being able to reference vector
drawables from within resources, but it's a necessary
cost.
We still need TintResources, but it's now back to being
a wrapper object which does not cause any issues.
BUG: 27877272
BUG: 27808232
Change-Id: Iad401718e51da15fddbd7ff88e41743dca40ad04
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| e3f831f7e879aee02f5bd6e265c4a670c0366208 |
|
22-Feb-2016 |
Chris Banes <chrisbanes@google.com> |
Fix fragments to android.R.id.content not be removable
Caused by the way that AppCompat switches the content
view for its own. It transplants any views already
added to the window content view into its own, which
works. Fragment though keeps a reference to its
container view though, which is then incorrect.
Fixed by making sure that any call to findViewById()
installs AppCompat's sub-decor. Ensuring that any
fragments added to a container via an ID, already
have the sub-decor installed.
BUG: 27286333
Change-Id: Ia1bfc4f69620b4dbbe5e4625b268f1a2d7789e3a
(cherry picked from commit 8c3845ebb7e8198950510cd7a08bc8e66e2195fe)
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 8c3845ebb7e8198950510cd7a08bc8e66e2195fe |
|
22-Feb-2016 |
Chris Banes <chrisbanes@google.com> |
Fix fragments to android.R.id.content not be removable
Caused by the way that AppCompat switches the content
view for its own. It transplants any views already
added to the window content view into its own, which
works. Fragment though keeps a reference to its
container view though, which is then incorrect.
Fixed by making sure that any call to findViewById()
installs AppCompat's sub-decor. Ensuring that any
fragments added to a container via an ID, already
have the sub-decor installed.
BUG: 27286333
Change-Id: Ia1bfc4f69620b4dbbe5e4625b268f1a2d7789e3a
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 80164058c98abaec2960102bfb65d0a9b74dbcd7 |
|
12-Feb-2016 |
Chris Banes <chrisbanes@google.com> |
Merge "Tint wrap all Views when running on < v21" into mnc-ub-dev
am: 2aa5f24e18
* commit '2aa5f24e1840309c61b58d10e632e7115c5ea8c1':
Tint wrap all Views when running on < v21
|
| 2aa5f24e1840309c61b58d10e632e7115c5ea8c1 |
|
12-Feb-2016 |
Chris Banes <chrisbanes@google.com> |
Merge "Tint wrap all Views when running on < v21" into mnc-ub-dev
|
| a777694569b333a4459606db6bc94a9e80fd25f3 |
|
10-Feb-2016 |
Chris Banes <chrisbanes@google.com> |
Rename AppCompat + Preferences Theme styleable
When two libraries have the same named styleable, it's
a bit ambiguous which one is actually used. Some build
tools break too. Fixed by making sure that each libraries
styleable is uniquely named.
BUG: 27105780
Change-Id: I1156efcb71fb9dde3458e03c68ed891f170ad575
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 604c6317360c5f744cfebb7c23b243358aef58e0 |
|
12-Feb-2016 |
Chris Banes <chrisbanes@google.com> |
Tint wrap all Views when running on < v21
This allows vector resources to be automatically
inflated when they used as a part of a DrawableContainer,
on any view (currently it only works on AppCompat's own
widgets).
Also tidied up the themeing test to actually check theme
values rather than relying on class checks of the Context.
Change-Id: Ie9be91ddf8aa2853dafda5d9f9838cae02d3b783
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 913fa29fdd3a0c593a46f2c2d2d23b66810024f5 |
|
10-Feb-2016 |
Chris Banes <chrisbanes@google.com> |
Rename AppCompat + Preferences Theme styleable
When two libraries have the same named styleable, it's
a bit ambiguous which one is actually used. Some build
tools break too. Fixed by making sure that each libraries
styleable is uniquely named.
BUG: 27105780
Change-Id: I1156efcb71fb9dde3458e03c68ed891f170ad575
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 85035fae2e7f292a529dc70e8d41cebc799e7d4f |
|
02-Feb-2016 |
Chris Banes <chrisbanes@google.com> |
Pass through AppCompat's menu to onProvideKeyboardShortcuts
Change-Id: Ie9b8cb3933c14e372010d4ff9589dd9370c61602
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 740e50456ff7aa7b93d40e7bdc59f8a619197ed5 |
|
26-Jan-2016 |
Chris Banes <chrisbanes@google.com> |
Allow setSupportActionBar() to take a null param
Also tidied up AppCompat[Activity|Delegate] annotations
BUG: 26779292
Change-Id: I50908aba7bcb632073efa2de5af2d9e03ecce0ae
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 733d0b2acb07ede7455b9d020901a10586053923 |
|
04-Jan-2016 |
Chris Banes <chrisbanes@google.com> |
Fix ToolbarActionBar invalidating destroyed Activities
BUG: 26375399
Change-Id: I4e4298748b9040b8ee307bbf1c09450618bdd494
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| ff7f258a9b0781de5c6325358c7075128bf05a91 |
|
07-Dec-2015 |
Chris Banes <chrisbanes@google.com> |
Re-add DayNight functionality to AppCompat
There are now a number of themes with the prefix
Theme.AppCompat.DayNight which support automatic
light/dark switching based on the time.
There are now two main APIs to enable these themes
to work. AppCompatDelegate.setDefaultNightMode() allows
setting of the night mode globally within an app.
setLocalNightMode() allows overriding of the default
for the specfic host component instance.
Change-Id: If0349165fc9163deb2bab974ea63939edc00c6dd
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 56594b0cf74a9f71c52980044283ddb0e9e6f47c |
|
09-Dec-2015 |
Yuichi Araki <yaraki@google.com> |
Remove unnecessary log from AppCompatDialog
Dialog's LayoutInflater is a copy of the Activity's, and we show the log
only when the Factory is not from AppCompat's.
Bug: 26101356
Change-Id: I66934e22650aff1a428ffe9b6cf206548cdc0b8f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 481ff5b456cc4ce7c75f03808ed344de4bdbf5ce |
|
24-Nov-2015 |
Chris Banes <chrisbanes@google.com> |
Enable View theming before the subdecor is installed
There's no need to check, it's fine to enable it
before
BUG: 25856648
Change-Id: I5ccb5c91302c462850f07c7b9d5aa2042899c383
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 625c9c3db9bb6f6b92ca35b74f26a61a04ec8cd7 |
|
09-Nov-2015 |
Chris Banes <chrisbanes@google.com> |
Allow AppCompat to work with long-press-back-menu gesture
Certain OEMs have re-mapped a long-press on the back
button to the menu button. AppCompat will currently
show the options menu and instantly dismiss it. This
CL adds supports so that it isn't dismissed if it was
opened from a long-press of the back button.
BUG: 25582858
Change-Id: I69c4160c03349dfae716430c87aeca5c91aa0453
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 66698bb15ba0f873aa1c2290cc50d6bb839a474a |
|
26-Oct-2015 |
Chris Banes <chrisbanes@google.com> |
Flatten AppCompat class hierarchy
This allows us to do two things:
1) Move away from using public @hidden classes
everywhere.
2) Workaround silly OEM bugs.
BUG: 18218511
Change-Id: I7582e242c7564c32feeb044fc9eff6bfb5c56536
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| d3a70c7dfb3292c72f9bee4cd47a632fc01d5231 |
|
21-Oct-2015 |
Chris Banes <chrisbanes@google.com> |
Swallow exception caused by dismissing action mode
BUG: 23467286
Change-Id: I3057e7cc772a6fd40609fa41a5de38d3f25342a5
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 7e4e8b664820f773bc96e37ee1d2bbf500d64e69 |
|
12-Oct-2015 |
Chris Banes <chrisbanes@google.com> |
Add AppCompatDrawableManager
Refactored from TintManager, AppCompatDrawableManager
is now architectured differently. It is now a singleton
which keeps multi-map of cached tints.
This is to enable the new InflateDelegate extension point,
which will allows libraries (and eventually apps) to hook
into the compat drawable inflation.
While this CL looks large, it's mostly just updating method
calls to match the new parameters.
BUG: 24852773
Change-Id: Ic9f5ecc6fd0208d2f7a8a686f077f16588020516
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 62ab25d71ccfa775a8bd2add7b41277bc4e14bbc |
|
05-Oct-2015 |
Chris Banes <chrisbanes@google.com> |
Use ParcelableCompat for CREATOR creation
Should fix BadParcelableException issues due to
using the wrong available class loader.
BUG: 24253575
Change-Id: Ia259559f15500203eff99c6eb6928339bd940278
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 2f769dc974bd526d945efe8a644f3f89112e08fe |
|
09-Sep-2015 |
Chris Banes <chrisbanes@google.com> |
Fix back button not working with empty menu
Happens on ICS+. Caused by AppCompat letting dispatchKeyEvent()
to bubble up to PhoneWindow when the menu is empty. PhoneWindow's
KEYCODE_BACK handling then steals all events, not allowing the
Activity to onBackPressed().
Fixed by making AppCompat handle all KEYCODE_MENU events.
BUG: 23379766
Change-Id: I1d9bd25cb117cd19d1af9967964c0c1da67ddec4
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| b034e4ad40bff78a848d9ed91754e3f9f3492f11 |
|
07-Sep-2015 |
Chris Banes <chrisbanes@google.com> |
Fix action modes crashing on rotation
Caused by the new action mode animations. On the animation
end they try to remove the PopupWindow which no longer exists
in the WM. Fixed by copying over some code from PhoneWindow
which short circuits the animation in onDetachedFromWindow().
BUG: 23467286
Change-Id: Ic98188583c333703305db8af77b83e8956841477
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 558c37532c876cef3db0ead5f3da42812fe1756d |
|
26-Aug-2015 |
Chris Banes <chrisbanes@google.com> |
Remove theme check
It's not needed now
Change-Id: I4a45e6fdfe10a7de3127df96b422a57983ee8ff6
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 0df7523d5586db69bd4960d9e72b2c24c12b73a0 |
|
26-Aug-2015 |
Chris Banes <chrisbanes@google.com> |
resolved conflicts for merge of 1c9cc133 to mnc-ub-dev
Change-Id: I7c03f041d7b8aefd057030002fd0089bad684dff
|
| a4b5c35036e68c7551dd77641ceec17b92c6368d |
|
19-Aug-2015 |
Chris Banes <chrisbanes@google.com> |
Fix AppCompatDialogFragment crashing
We now model PhoneWindow in when it reads the theme
window flags. Added a unit test too
BUG: 23336734
Change-Id: I990bd91d29d1009e0e18f976c7b3c542782660e6
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| f761a99e6c7061129288c34d72349898a6485158 |
|
21-Aug-2015 |
Chris Banes <chrisbanes@google.com> |
am 6e11ea48: am 791ed0f8: am da01c7e8: Merge "Fix button on Gingerbread when using Toolbar" into mnc-dev
* commit '6e11ea48524977152af85bcd69b7bf43c5d76545':
Fix button on Gingerbread when using Toolbar
|
| c9b517a68ed7070d4edcdd5be818540d81b43db0 |
|
20-Aug-2015 |
Chris Banes <chrisbanes@google.com> |
Fix button on Gingerbread when using Toolbar
BUG: 23379766
Change-Id: I64e4a42e1f10a3f7726258f768ea45e1da3a6781
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 91a95c4599d0d5fa936b81396c71210ae7e68e54 |
|
05-Aug-2015 |
Chris Banes <chrisbanes@google.com> |
Throw exception if setContentView() is called improperly
Currently we will just crash with a random message
if setContentView() is called before super.onCreate().
We now throw a nicer exception message.
Change-Id: I1f0928ae3f25e1e2b50663f827b60ef7d9648632
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| d2f8851a0a27ea6a2ddf5a88097f3d10eed38485 |
|
03-Aug-2015 |
Chris Banes <chrisbanes@google.com> |
Fix crash caused when clicking on list menu item
Caused by an recursion on the closePanel() method,
which leads to a crash. Fixed by using the correct
Window.Callback to dispatch to.
BUG: 22879253
Change-Id: Ia352b67975a90e32c7c9b36cb79a6986bef7fbb9
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 8ba0fdde8e91fd59808ce3453eef079e54915ce8 |
|
28-Jul-2015 |
Chris Banes <chrisbanes@google.com> |
Fix ActionMode not being inset correctly
Caused by the new action mode animations delaying
the call to setVisibility(VISIBLE), without delaying
the call to requestApplyInsets. This means that the
resulting call to onApplyInsets() happens with the action
mode view being GONE.
BUG: 22651908
Change-Id: I6e8ad429fccb8f73abd339d821a1d792b6f2d565
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| beb1c4e9453c0cd6153f85872ee912e4b0cef42c |
|
22-Jul-2015 |
Chris Banes <chrisbanes@google.com> |
am 66bc56b8: Merge "Fix detection of root view within inflate() call" into lmp-mr1-ub-dev
* commit '66bc56b89cb906e4a152ef574b2de44693049e04':
Fix detection of root view within inflate() call
|
| 66bc56b89cb906e4a152ef574b2de44693049e04 |
|
22-Jul-2015 |
Chris Banes <chrisbanes@google.com> |
Merge "Fix detection of root view within inflate() call" into lmp-mr1-ub-dev
|
| 871e1fd7971cf8802beb5c2323d4257f2b278c22 |
|
21-Jul-2015 |
Chris Banes <chrisbanes@google.com> |
am c63438dc: Merge "Fix KEYCODE_MENU not being dispatched to an Activity" into lmp-mr1-ub-dev
* commit 'c63438dce2904355f08ad2b57a8386d474b309be':
Fix KEYCODE_MENU not being dispatched to an Activity
|
| 4d95686e7ade79bfb1081047e90de4bf2affbbca |
|
20-Jul-2015 |
Chris Banes <chrisbanes@google.com> |
Fix KEYCODE_MENU not being dispatched to an Activity
Also fix onPanelClosed() not being called, by moving
the related logic closer to that of PhoneWindow.
BUG: 22596497
Change-Id: Ia1b66b92646aceb49ed58b913c05984e81503124
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| d95c99933cb57a5678afeff01d91269be61e2502 |
|
08-Jul-2015 |
Chris Banes <chrisbanes@google.com> |
Fix detection of root view within inflate() call
This CL expandes the simplistic isAttachedToWindow()
check with additional checks on the parents.
BUG: 21792119
Change-Id: Ie69e7c681bb4a8bed5fd03fe80843a53ece15f28
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 6e511d12ff3a713dc56a3b8a50b246b9a0fe6cdf |
|
25-Jun-2015 |
Doris Liu <tianliu@google.com> |
Merge "Add enter/exit animation for window provided CAB - support version" into mnc-dev
|
| c04ae73a9793cdad7784fd543f3b7ad32cc8dbed |
|
24-Jun-2015 |
Doris Liu <tianliu@google.com> |
Add enter/exit animation for window provided CAB - support version
Bug: 21886856
Change-Id: I9a88ef337adf27b728185cb6fc27328b338a7818
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 4e0a0984e80ced79b8aa3cf71fc261044ecc08a6 |
|
23-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
am 5ba742a3: Merge "Fix leak for MenuInflater + setSupportActionBar" into lmp-mr1-ub-dev
* commit '5ba742a37d06a0961f20e41c18cc6f8f4d5fd514':
Fix leak for MenuInflater + setSupportActionBar
|
| 5ba742a37d06a0961f20e41c18cc6f8f4d5fd514 |
|
23-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Merge "Fix leak for MenuInflater + setSupportActionBar" into lmp-mr1-ub-dev
|
| 4f5b17adf5017c497b20decab1ba308e088d7ac1 |
|
22-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
am 56606fdf: Merge "Improve "does not support current theme" exception" into lmp-mr1-ub-dev
* commit '56606fdfdbdf57b691d76a0234b83e6a3788069f':
Improve "does not support current theme" exception
|
| 725df1cf793a42aa8f1175c69668419b92f3512f |
|
22-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Improve "does not support current theme" exception
BUG: 21950315
Change-Id: Ic4b378ab8712e4f045365e0bd18c5f52cc229964
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 5ecdb2c5042da49d36d7cda3fa08f1d9151a1fbd |
|
22-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix leak for MenuInflater + setSupportActionBar
Caused when there are multiple calls to
setSupportActionBar(). getMenuInflater() will
instantiate and keep an instance to the first
Toolbar (and it's container, etc).
BUG: 21638877
Change-Id: I4c79b4832534b06e7ab2819e78e303dde4a7d76a
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 2a5e18155a210d06ebb142059746becb31f67945 |
|
18-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Merge commit '62d9aaed' into manualmerge
Change-Id: I22d22d6a496759a98b81c3f1bf1c226b48fa8e17
|
| 9a767d6b502f9289c58216f4e3c622ec2c5dfbd6 |
|
18-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
am 1d0e76a0: Fix List Menu not responding to dpad events
* commit '1d0e76a0ba8bfc5e280203a56e10be95dd959a51':
Fix List Menu not responding to dpad events
|
| 62d9aaed232f8669e79a01ae1c4f6d077ba59984 |
|
18-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Merge "Fix memory leak in ToolbarActionBar" into lmp-mr1-ub-dev
|
| 1d0e76a0ba8bfc5e280203a56e10be95dd959a51 |
|
18-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix List Menu not responding to dpad events
We were not giving the view a chance to consume
the KeyEvents.
Change-Id: If7a78db824a3ec5c2e3032fef5805bfbda85e881
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 8d4765883ff24f0f79bf64fea23d4687d50cec85 |
|
18-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix memory leak in ToolbarActionBar
Caused when there are multiple calls to
setSupportActionBar() (i.e. fragments). ToolbarActionBar
currently just wraps the Window's current Callback. Which
means that for every setSupportActionBar() call, we're
re-wrapping a ToolbarActionBar Window.Callback wrapper.
This CL fixes it by making sure that we always wrap the
correct 'root' Window.Callback.
BUG: 21914909
Change-Id: I8f21b94d60eb488630b1fe7377ba62d3608accef
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 96a9d498bc35b27ec24ae419ca9127e9fe3dbb7d |
|
10-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
am 0ef64908: Merge "Fix options list menu when Toolbar doesn\'t have items" into lmp-mr1-ub-dev
* commit '0ef64908166d67a58e073d36e783c775f6512b35':
Fix options list menu when Toolbar doesn't have items
|
| eba6361c28fad482737765413aed1290da67f2da |
|
08-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Add hasWindowFeature() to AppCompatDelegate
BUG: 17879624
Change-Id: I3d2aa9d542ae116fdbe9dd3673bd126f434946d0
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| c7102743e3f30a50c4725c336b5f019f6e7b91c4 |
|
08-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Add hasWindowFeature() to AppCompatDelegate DO NOT MERGE
BUG: 17879624
Change-Id: I3d2aa9d542ae116fdbe9dd3673bd126f434946d0
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 8122ad54f129c2214631fad86cabda82815cc0d8 |
|
08-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix window decor Action Bar init
BUG: 21575069
Change-Id: I2e9919c36f221c968bc38c8d7ba4e476f41b45f7
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 88c0ac5649d6b82c882e2de4bc4f043b107a4428 |
|
02-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Move our Window flags handling closer to PhoneWindow
Fixes some issues around stack overflows for certain
flag combinations.
BUG: 21575069
Change-Id: I6f6c98863f7cfb4510cbeeb8a1be6e16c6de509f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 6094d733a9bcc923491937532255f79eb23fab90 |
|
09-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix options list menu when Toolbar doesn't have items
When using a ToolbarActionBar, and there are 0 non-actions
items, it will return null in onCreatePanelView. This then
means that the 'window' will show it's list menu. As the
'window' doesn't know what is an action item or not,
it shows all items.
This CL fixes it by disabling the window list menu view
when a ToolbarActionBar is used. ToolbarActionBar's own
list menu view is unaffected.
BUG: 21718389
Change-Id: I8e8cb7915cc27abcf1e06a0ef09ac14129c4adce
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 1282e55f13234e9275cd76d3e02559e1eabf12e3 |
|
08-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix window decor Action Bar init
BUG: 21575069
Change-Id: I2e9919c36f221c968bc38c8d7ba4e476f41b45f7
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 85d77caf73c0bfe957304951f94f88650a064efb |
|
08-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Merge "Move our Window flags handling closer to PhoneWindow DO NOT MERGE" into lmp-mr1-ub-dev
|
| 559fa14454cc053127b3b96c0e63c48c06937e38 |
|
03-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Revert the previous fix for stealing KEYCODE_MENU
We now just steal those events if we can actually
handle them.
BUG: 20529185
Change-Id: I09119b9efcd24e15b39990a22a7da55257ebfd96
(cherry picked from commit a6624356b85f8a31c5d951c92ce39ef1070fd9db)
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| a6624356b85f8a31c5d951c92ce39ef1070fd9db |
|
03-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Revert the previous fix for stealing KEYCODE_MENU DO NOT MERGE
We now just steal those events if we can actually
handle them.
BUG: 20529185
Change-Id: I09119b9efcd24e15b39990a22a7da55257ebfd96
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 0c4414fd7d27eef2a3545cb36db29070f8a3ea77 |
|
02-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Move our Window flags handling closer to PhoneWindow DO NOT MERGE
Fixes some issues around stack overflows for certain
flag combinations.
BUG: 21575069
Change-Id: I6f6c98863f7cfb4510cbeeb8a1be6e16c6de509f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| c291e9cf854ce5e131e0cff9485b61703dfc132b |
|
15-May-2015 |
Chris Banes <chrisbanes@google.com> |
am da4f4e9b: Merge "Re-add deprecated app:theme functionality" into lmp-mr1-ub-dev
* commit 'da4f4e9b73c2bd1b843d999e2b07ed71b0fc93df':
Re-add deprecated app:theme functionality
|
| 484705a5e6fdc1f6ef746b822716a45f82652ab9 |
|
14-May-2015 |
Chris Banes <chrisbanes@google.com> |
Re-add deprecated app:theme functionality
BUG: 21128917
Change-Id: Ib922c8c9fe218859c8ca15d625ef58ec8d46fb56
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| d25af35061a9f20d59b25329d613c62c20184dad |
|
04-May-2015 |
Chris Banes <chrisbanes@google.com> |
Window.Callback passthrough fixes
We currently do not proxy onMenuOpened or onPanelClosed
events to the Activity because we overload the FEATURE_ACTION_BAR
ID internally. From v11+, those methods in Activity do special
handling and try and init it's own Action Bar (which usually results
in a crash).
To fix this, we now use our own special feature IDs:
FEATURE_SUPPORT_ACTION_BAR and FEATURE_SUPPORT_ACTION_BAR_OVERLAY.
Meaning, we can now pass the calls through without the default impl
blowing up.
We still accept the normal window feature IDs for requestWindowFeature()
but we log an info message.
BUG: 20816353
Change-Id: Ieea6d451279469b9de7bd96a17e5338600fdf9d8
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 0e4289d8af2b80828e4f68f77a9dbafa24319d48 |
|
05-May-2015 |
Chris Banes <chrisbanes@google.com> |
am 959ed6af: Merge "Add ViewCompat.isAttachedToWindow()" into lmp-mr1-ub-dev
* commit '959ed6af05f77e9924fc908176c733d6e3260c8e':
Add ViewCompat.isAttachedToWindow()
|
| ce611065e0a3f766381c7eee6106e24d9d58adc5 |
|
05-May-2015 |
Chris Banes <chrisbanes@google.com> |
am ce0734df: Merge "Don\'t inherit a parent\'s context if view is layout root" into lmp-mr1-ub-dev
* commit 'ce0734df1fffcd9c85530ae236a2a4aa7047ce7b':
Don't inherit a parent's context if view is layout root
|
| f6610f183f0afe6e392dea804474f722d82083fd |
|
04-May-2015 |
Chris Banes <chrisbanes@google.com> |
Add ViewCompat.isAttachedToWindow()
BUG: 20695142
Change-Id: Ibdff3d24721e9ed94de9c00813fe9528a734267d
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| e183f2600fb31c69eceacc1c263cd56f12489a65 |
|
01-May-2015 |
Chris Banes <chrisbanes@google.com> |
Don't inherit a parent's context if view is layout root
Previously AppCompat would make an inflated view
inherit a parent's context, regardless of whether it
was the root view. This is different to the framework
functionality which only allows children to inherit.
BUG: 20695142
Change-Id: I9ec90654a08824f7ee64b73ba76bdc0ee3ea28fc
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 9ce997cacea4174be69c927244e14b1eddb24192 |
|
28-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
am 535c5737: Fix StackOverflowError if wrong theme features are enabled
* commit '535c5737ba868a622d7783d57f7078ab285717c0':
Fix StackOverflowError if wrong theme features are enabled
|
| 535c5737ba868a622d7783d57f7078ab285717c0 |
|
28-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Fix StackOverflowError if wrong theme features are enabled
BUG: 20650250
Change-Id: I2761c3184c5eb58f9c2383dc959728efd0002699
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 6b3b79ba1d58edad9b8e9246674af56cc34fce73 |
|
27-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
am 8d2f1762: Merge "Don\'t allow an Action Bar to be created for floating windows" into lmp-mr1-ub-dev
* commit '8d2f17620af0015114d2a740b6cb9dfb6e88adfb':
Don't allow an Action Bar to be created for floating windows
|
| a9279663ecb98b85bf95a5ba1ebc145756fc13a2 |
|
27-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Don't allow an Action Bar to be created for floating windows
BUG: 20624627
Change-Id: I9d3505b03d099ff8e09558094136094ad2e26213
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| f5829201b976fc650789accc22f325a2541ed478 |
|
13-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Action Mode fixes - M edition
- CABs from floating windows now display correctly
- We now let TYPE_FLOATING framework CABs through to
the window (when enabled)
BUG: 20171499
BUG: 20022929
Change-Id: I56b6f16ee62fc8f0f210da480ad1577863321470
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 547a80d347e0dc9751bbe3cf91f947477145bdba |
|
13-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Action Mode fixes
- Added a switch to disable native CAB handling
- They now use the correct theme
- Using a better way to intercept framework CABs
- We now only intercept on v14+.
BUG: 20171499
BUG: 20022929
BUG: 20208108
Depends on Iacffdf908b98739770f13665732d7755b14b9a25
Change-Id: Ia64beb77ba0a08186e4cdea4544cd9880bf4a4d9
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| d8b7157eae680353a2821dca3c9e52b3aaf737a5 |
|
05-Mar-2015 |
Chris Banes <chrisbanes@google.com> |
Fix AppCompat's Dialogs being larger than the framework impls
Due to the fact that we measure at a lower level, so
we need to take padding higher in the hierarchy
into account.
BUG: 19509863
Change-Id: Icf0be74c2791383571b4d90e2d759e18139826da
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 2cccf609662389d6a23dbc0711d5fb2e826e8c63 |
|
18-Feb-2015 |
Chris Banes <chrisbanes@google.com> |
Rename and move all of the tint widgets
They're public so shouldn't live in the internal package.
I've also stopped setting the setting the platform widget styles
(e.g. android:editTextStyle) and instead provide our own versions.
On Lollipop, we set these the default framework styles.
This fixes the times where the framework widgets are used but with
the untinted material style (e.g. Preferences).
BUG: 19407610
BUG: 19300319
Change-Id: I5dbdee240cbf28d4dc9b05f5c56b386d83b18df3
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| c3365672ee81bc515194d70f4239f8946dfc0b22 |
|
20-Feb-2015 |
Chris Banes <chrisbanes@google.com> |
Merge "Add AppCompat AlertDialog" into lmp-mr1-ub-dev
|
| 19eaf14cb3cca613f984a32be2fab2534427fb29 |
|
05-Feb-2015 |
Chris Banes <chrisbanes@google.com> |
Add AppCompat AlertDialog
Material themed, working back to API 7. Needed
because of AlertDialog's themes/styles are private.
BUG: 19192875
Change-Id: I4c6bf11be127c705389f0cb79df4a983d638f6f3
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 498356fea126122c3e3720a419969055cb889428 |
|
11-Feb-2015 |
Chris Banes <chrisbanes@google.com> |
Fix support Fragment inflation from layouts
Seems that the recent refactoring broke Fragment inflation.
The problem is that FragmentActivity needs it's onCreateView()
called on all API levels, rather than delegating to
Activity.onCreateView()
BUG: 19340311
Change-Id: Ifd45967e1def086a11203913fa1acb23e32191a2
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| a73cf65dff6d7fa58907e614f95e1d3679de0a79 |
|
04-Feb-2015 |
Chris Banes <chrisbanes@google.com> |
Ensure Buttons have a disabled text color state
BUG: 19252982
Change-Id: Iacb4416e01468678cb0997340128f19fe2015927
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 0f58401dc72db8ea2a201e3c0220f6529f2a7b33 |
|
04-Feb-2015 |
Chris Banes <chrisbanes@google.com> |
Add AppCompat specific windowNoTitle attribute
More useful now that we support Dialogs. Also reworked
the sub decor code to match more closely to the framework.
BUG: 19194408
Change-Id: If48a338e583dddedfd620993aed92bca5e253781
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 436e191f80e197712dd1a7f1f7c61acfff8b1f04 |
|
22-Jan-2015 |
Chris Banes <chrisbanes@google.com> |
Ensure we dismiss the options menu on item click
BUG: 19104258
Change-Id: I72937d5882c5a476ea1688b1b8564e356271ef1f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| 16e8d4dd91083260223c007c797e46bc8f631055 |
|
23-Dec-2014 |
Chris Banes <chrisbanes@google.com> |
Material Dialog themes
Lots of changes needed for this, building upon the
refactoring CL. AppCompatDelegate can now handle Dialogs
as well as Activitys (which was easy after the refactor).
This was needed so that we can install a custom decor
for Dialogs.
Also added borderless button styles as they were
needed for Dialogs.
Change-Id: I88a7e4de5de85477982e401c832aeae732f81647
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|
| f3ad1351d8b40ec5defe35e79d3430ad3c384b6d |
|
27-Nov-2014 |
Chris Banes <chrisbanes@google.com> |
Refactor AppCompat's Activity structure
- The activity delegates now have a public abstract class
called AppCompatDelegate. Any Activity can create one,
but they must call through to the delegate at certain
lifecycle methods.
- Related, I've reduced the number of manual lifecycle
calls needed by using Window.Callback where possible.
- Activities can implement the the new AppCompatActivityCallback
interface to receive certain callbacks.
- AppCompatActivity does all of this automatically
- ActionBarActivity is now a deprecated alias for AppCompatActivity
- Removed support for the v4 Drawer Toggle
- Remove our internal callback in favor of using Window.Callback
directly
BUG: 18547959
Change-Id: I8ece4372fa2abbc5b5246544643fafe0e22874be
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplV7.java
|