History log of /hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
6af064b77bfdc84a6f425a7c9d0941fad11f4489 22-Apr-2016 Sreenath Sharma <sreenath.sharma@broadcom.com> WiFi HAL: memory leak fix

- freeing of allocated memory after use by invoking release method
- addition of NULL checking for handling allocation failures
- fixing of existing compilation warnings
- code cleanup

BUG=28274383

Change-Id: Iea00bd7dd0a7c02f551b88137cbdbf84dfd39ebb
Signed-off-by: Sreenath Sharma <sreenath.sharma@broadcom.com>
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
f02f545dd490b658110fb837f4905050b3ed9c52 16-Jul-2015 Vinit Deshpande <vinitd@google.com> Fix couple of issues with unregistering event handlers

First, on Hammerhead, we don't unregister GOOGLE_DEBUG_RING_EVENT
if driver command fails - that's not correct.

Also fixed a one-off error in unregistering event handlers.

Bug: 22523219

Change-Id: Idaf27bc14f13d21e18cec512db8f8c3590895c66
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
496e6ab2147ee8bae2aa93cdd13cab2f129079f4 07-Jul-2015 Ashwin <ashwin.bhat@broadcom.com> Fix for system crash caused by accessing memory w/o permissions

Fix a buffer overflow access that caused a SEGV_ACCERR

Change-Id: Id38ac0637696128ee66039e8b4c5e8d73ec945a1
Signed-off-by: Ashwin <ashwin.bhat@broadcom.com>
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
a0a6b2113b44aa39f25635f291fba929c98070bd 02-Jul-2015 Navtej Singh Mann <navtejsingh@google.com> fix unregister command on failure and log restructuring

bug:22174291
Change-Id: I621f92a3604f9a30279c4fe25cd606432df1839e
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
fef13c11034313585be68c32322b9a53c43a37b2 12-Jun-2015 Ashwin <ashwin.bhat@broadcom.com> RSSI monitor changes

RSSI monitor is used to set RSSI thresholds to driver and rx
events when thresholds are crossed. also includes some code cleanup

Change-Id: Ia55ded489ed5d4232e6fea0ffdcfc824522613b1
Signed-off-by: Ashwin <ashwin.bhat@broadcom.com>
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
ec74fa4fcb49a35e6af54e086e63692b37d21b02 22-Apr-2015 Vinit Deshpande <vinitd@google.com> Reduce logs from gscan

Made some logs verbose to reduce log clutter

Bug: 20416721

Change-Id: Id8bebe26740ec91b21e1478f92eae8fa2b4d4446
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
082cb621b1dd1ad150a747d5010fed0888ae416c 06-Aug-2014 Vinit Deshpande <vinitd@google.com> Fix a crash in Broadcom's HAL

Scan command registers for two events, but then unregisters only for one
leaving a dangling pointer which results in crashes.

Bug: 16820118

Change-Id: Ie5599a4928f3a122c3a3ef538db9ca31c7ca8a22
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
68d1fb64d52132a52bcad3450d6783939d8d9726 05-Aug-2014 Vinit Deshpande <vinitd@google.com> Workaround for RTT driver bugs

Sometimes there are no results in an RTT event; when this happens
there is no HAL callback ever, and no new requests can be generated.
To avoid this, we just treat this as no RTT data event.

Also, there is no clean up code here; so events are returned for the
first command, working around that by adding cleanup code. Renamed
all incorrect instances of GSCAN event handlers with RTT event handlers.

Also fixed some log entries - as they incorrectly say 'scan started'.

Bug: 16637086

Change-Id: I7da27d12b0d8e82f5fcba16fa14e3c444ac1b5ae
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
28237f92de2634ec1d529c63b2d61d80e7485c83 31-Jul-2014 Vinit Deshpande <vinitd@google.com> Fix a deadlock in event/command interaction

There are two locks, one in HAL which takes care of adding/removing event
handlers from a common data structure; and another in the Framework
which synchronizes access to WifiNative. Commands and events grab these
locks in opposite order, and hence can cause deadlock.

This change fixes the deadlock by holding on to the HAL lock only for
a short time. This is achieved by refcounting the commands so they
don't have to be destroyed while holding locks.

Bug: 16660861


Change-Id: I35f9f688c8c1ddb2116b228c52e0bb1125df0568
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
115bcffc16c53e9552c09a6792666c52a633b4f2 06-Jun-2014 Ashwin <ashwin.bhat@broadcom.com> Implement RTT API in wifi HAL

Change-Id: I25181c40de7cce0ea97ee069739486f799f2a727
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
bb8a4d506769d7dc8b33445c6725a40b7523063c 02-Jun-2014 Vinit Deshpande <vinitd@google.com> Add mutual exclusion to wifi HAL infrastructure

This change restricts free access from multiple threads to event buffers.
Mutual exclusion is added to avoid crashes and corruption that may
happen because of simultaneous access from a command and an event.

Access to commands from multiple threads is still not protected. But
thankfully, framework takes care of it.

Bug: 15188917
Change-Id: I41e294f01a85097e30078f603b113da9a319ba83
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
642bfbe829f5438db3d99ce4678bcb770359a632 23-May-2014 Vinit Deshpande <vinitd@google.com> More Libnl fixes for Broadcom's WifiHAL

We don't look for sequence match on event messages; also removed
references to netlink-types which is from an older version.

This change also reduces NUM_SCANS_TO_CACHE from 10 to 4 in order to
work around a driver bug.

Change-Id: I09de75b00a79635b0921a9fb1c2939438bc13287
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
0aa072e53060866de1ddf6510e797470c08fd1a4 08-May-2014 Vinit Deshapnde <vinitd@google.com> Build fixes for sources merged from KWD

KWD doesn't have shared libnl; but L does; hence some build changes

Change-Id: Idbd0f852f9bcfe12f76e194808fa85df3653a011
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp
1a526434ae215b48970501ccb463d4e77af39c9e 09-Apr-2014 Vinit Deshapnde <vinitd@google.com> Moving Wifi HAL to hardware

This change moves all Wifi HAL headers to libhardware_legacy; and moves
hal implementation under hardware/<vendor>/wlan. This way different
vendors will be able to tailor implementation to their drivers.

Change-Id: I55789bb6788ab694f4896aa36d76f7887b32dad6
/hardware/broadcom/wlan/bcmdhd/wifi_hal/common.cpp