History log of /system/bt/btif/co/bta_hh_co.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
32d66694e9f782a0e9dfa423015284a573f8975c 30-May-2016 Andre Eisenbach <eisenbach@google.com> HID: Check for EINTR in uhid_event() and fix return value evaluation

uhid_event() returns 0 in the normal case. Commit 3a2c2d61
results in the polling thread to be exited.

Bug: 28942565
Change-Id: Id0aff2958bc7c2704ba340aa0ff7848afb8dcf80
/system/bt/btif/co/bta_hh_co.c
fce80bb003601cf576c62d3cb9a5499790841545 17-May-2016 Pavlin Radoslavov <pavlin@google.com> Add a log message to capture NULL pointer in l2c_link_hci_disc_comp()

Added a log message inside l2c_link_hci_disc_comp() to help capture
a NULL pointer p_lcb->p_fixed_ccbs[xx] that triggers SIGSEGV crash.
Also, updated the typedef of bdstr_t and moved it to
file "btcore/include/bdaddr.h"

Bug: 28765514
Change-Id: Iacd9376cfb9e18b58e18865581da8edad9f68821
/system/bt/btif/co/bta_hh_co.c
574dcfb73e3741d715f7d4394fe5d3bd587cb0d2 12-May-2016 Pavlin Radoslavov <pavlin@google.com> Restart failed system calls interrupted with errno of EINTR

In number of places we don't handle properly system calls failures
when the errno is EINTR (i.e., the system call was interrupted
by a signal). In all our use cases, the system calls should be
restarted. The handling of the following system calls (as used in the code)
has been updated/fixed:

poll, send, recv, sendmsg, nanosleep, epoll_wait
read - mostly (e.g., socket-like fds)
write - mostly (e.g., socket-like fds)
select, accept, connect

Bug: 28471477
Bug: 28658141
Change-Id: I03e6f0f67e33876780fb6d02c33eb84547ba8f95
/system/bt/btif/co/bta_hh_co.c
b7ff701b6c892bbdcea3773fc7caa9317d2b07d7 15-Jan-2016 Nitin Shivpure <nshivpur@codeaurora.org> HID: Fix to show mouse pointer movements on UI

As per the UHID implementation, UHID_OPEN & UHID_CLOSE
can be ignored, but it is useful for power-management.
Since these events are handled on hid host, ready_for_data
needs to be set to TRUE. Previously the hid reports were not
sent to kernel UHID driver leading to no mouse pointer movement
on UI of DUT.

Bug: 27852645
Change-Id: I708f5be4240f07826c6eefc5404af3e42f80cfa4
/system/bt/btif/co/bta_hh_co.c
763930636d0af0123fe5728a504ec5e625d638a5 19-Feb-2016 Andre Eisenbach <eisenbach@google.com> Revert "Fix data reporting state when using HID device"

Original commit breaks Fugu remote (amongst other things).

This reverts commit 44efbb13a748a276de994456cffc02e8e9da03b0.

Change-Id: Ifa4ab421e0b14f59988d2e3ac7f338f0844aaa2d
/system/bt/btif/co/bta_hh_co.c
44efbb13a748a276de994456cffc02e8e9da03b0 18-Dec-2015 Loic Poulain <loic.poulain@intel.com> Fix data reporting state when using HID device

Start and Stop are called on HID driver probe/unprobe.
Open/Close are called when driver is interesed/not-interested
in data reports, typically when user-space open/close the input
device. So we can have several open/close calls for one start/stop
cycle.

https://www.kernel.org/doc/Documentation/hid/hid-transport.txt

Problem is that current implementation disables data reporting on close
but never enables it on open. This patch fixes this issue to match the
expected behavior.

Change-Id: Id5d4627dba389338b06df60a6e1d993ac3e3e5ec
Signed-off-by: Loic Poulain <loic.poulain@intel.com>
Signed-off-by: Zhiquan Liu <zhiquan.liu@intel.com>
/system/bt/btif/co/bta_hh_co.c
3a2c2d61f4c8769ea9c1615208a6daf2fa162084 10-Nov-2015 Myles Watson <mylesgw@google.com> Retry HID Polling when EINTR is returned

While I'm here
- use __func__ consistently in btif_hh_poll_event_thread.
- remove braces around a single line

BUG: 24647083
Change-Id: I80b99ff0d3ba6336f5ab7a517269fdf63df59b37
Signed-off-by: Myles Watson <mylesgw@google.com>
/system/bt/btif/co/bta_hh_co.c
66af0202c42c5dedceab594e86cc3d11a361c0fe 19-Sep-2015 Andre Eisenbach <eisenbach@google.com> am c7cb8f07: am ef7d8cb8: Change UHID socket to be non-blocking

* commit 'c7cb8f0715263404ab78f864933567e5e870ab49':
Change UHID socket to be non-blocking
ef7d8cb8b012e77c9b0c596c5ad4b0ffb7e5dde9 18-Sep-2015 Andre Eisenbach <eisenbach@google.com> Change UHID socket to be non-blocking

On some platforms, the logs indicate that the BTU task is stalled by
UHID driver when writing the HID descriptor to the kernel. This patch
converts the UHID socket to non-blocking to avoid stalling the main
BTU task.

Bug: 23978964
Change-Id: I5a7a3e106fb2c967d68f077faedcd4fe62bbd912
/system/bt/btif/co/bta_hh_co.c
ca9951975b00742644566eaf522653576b9418c7 22-Jul-2015 Amirhossein Simjour <asimjour@google.com> am 6d9c7c90: am 04e684f8: Merge "Fix for uhid_event size check" into mnc-dr-dev

* commit '6d9c7c90381c4bb94eeada7226f63f1ee3297a85':
Fix for uhid_event size check
0eb8abd0c213cb162e8b2ba2274d222619421b85 20-Jul-2015 Amirhossein Simjour <asimjour@google.com> Fix for uhid_event size check

The uhid_event function used to expect that the return value of each
read function call to match with the size of the struct uhid_event.
Since the header file doesn't match the kernel driver, these two size
don't always match. The exact size check is replaced with expecting
the minimum required size.

Bug: 20108348
Change-Id: Ib61537092b109296f8290d802b68fc2efe78888c
/system/bt/btif/co/bta_hh_co.c
cab5fc179730ce6910989307680b275195876c4d 02-Jun-2015 Arman Uguray <armansito@google.com> gn-build: Remove all -Wno-unused-* flags from build files

This CL removes the -Wno-unused-variable, -Wno-unused-value, and
-Wno-unused-function flags from all GN build and Android.mk files
(except in test/ & tools/, which are not built using GN yet). Compile
warnings, caused by the newly enabled flags, have been fixed throughout
the code base.

Bug: 21570302

Change-Id: I1c128b62256faa17668124798341005bcd0f7315
/system/bt/btif/co/bta_hh_co.c
38798e1b7cc7873aa849c3c7c58902f713d909be 19-Nov-2014 Hemant Gupta <hemantg@codeaurora.org> HID: Handle closing of uhid driver in case failure

This patch handles closure of the uhid driver in case of following:
- Due to concurrency of disconnection from a conencted device
and an incoming connection request from another device, the error
code for the ACL disconnection becomes HCI_ERR_HOST_REJECT_SECURITY
in the stack.
- On reception of disconnection with that error codes, the uhid driver
was not closed from the btif layer leading to issues in reconnection
with same device that got disconnected.

Change-Id: I13c83757051850cc631aa1c24a036a2e1a4d0087
/system/bt/btif/co/bta_hh_co.c
87072892dc006f4c037aae0a346eda6c18e6b8ba 19-Nov-2014 Hemant Gupta <hemantg@codeaurora.org> HID: Handle closing of uhid driver in case failure

This patch handles closure of the uhid driver in case of following:
- Due to concurrency of disconnection from a conencted device
and an incoming connection request from another device, the error
code for the ACL disconnection becomes HCI_ERR_HOST_REJECT_SECURITY
in the stack.
- On reception of disconnection with that error codes, the uhid driver
was not closed from the btif layer leading to issues in reconnection
with same device that got disconnected.

Change-Id: I13c83757051850cc631aa1c24a036a2e1a4d0087
/system/bt/btif/co/bta_hh_co.c
b246a1a750c5a337faaa6033b39e78c8bdd4c2fb 10-Apr-2015 Prerepa Viswanadham <dham@google.com> Merge commit '4bf68bf020c7fd1aabcdc4b5d8f5fbb8bacdec9d' into merge_work

Change-Id: Ibc6d6e691b7f97611d16f96220346dfd6ffbbf52
933926c92e1378cc76bc9c149107e670c4872d4e 03-Apr-2015 Scott James Remnant <keybuk@google.com> Fix missing #includes needed for glibc

Some standard library functions are used while relying on bionic headers
including the headers the functions were actually declared on. Add those
missing #includes so that bluetooth.default.so will compile on glibc.

Change-Id: Ied9f89ce5a05911fca63f6bfe1b8cc8196ab3b1c
/system/bt/btif/co/bta_hh_co.c
3e59b5b6f2ce1295e3e2711afcd2cdf0dd7e22b6 01-Apr-2015 Etan Cohen <etancohen@google.com> Fix build issues in bluedroid on master

Change-Id: I0d3e93ea61dd03505fe9db902ed90bdd4141cab2
/system/bt/btif/co/bta_hh_co.c
9d52f88bfc07556cb01ab3055f5b1242c9b467aa 19-Aug-2014 Sharvil Nanavati <sharvil@google.com> Eliminate unused arguments to btif_config and clarify variable names
/system/bt/btif/co/bta_hh_co.c
b95c4ef4ac9e86953050a7ae6b3b4260df935713 16-Aug-2014 Sharvil Nanavati <sharvil@google.com> Switch over from an XML based file format to .INI-style conf files

This change moves us to using a single file format for all configuration
throughout bluedroid. I've provided a transcoder that converts the
previous config file to the new format so settings will be preserved.

In a future revision of bluedroid, we should remove the transcoder and
drop our dependency on tinyxml2.
/system/bt/btif/co/bta_hh_co.c
433fe016392c7ae003033530f1b3994f2ddad313 17-Oct-2014 Chaojing Sun <cjsun@broadcom.com> Cache HOGP HID report map

HID reports from a bonded device can be missed when Bluetooth is
restarted HOGP report discovery is still active. Caching the
report information and loading it back when the stack resets
will ensure incoming HID reports can be processed immediately.

Bug: 17999991
Change-Id: I4608935f8749537d6b05625b894445a21f844ee0
/system/bt/btif/co/bta_hh_co.c
e8c3d75b75493911ebf0f99c83676359657178f7 04-May-2014 Sharvil Nanavati <sharvil@google.com> Logging cleanup: BTIF and APPL.

Change-Id: I5b1214642bbb4b9aecc0fd2c899a6ec2c9793286
/system/bt/btif/co/bta_hh_co.c
7a25994c7b99c02a8d9e3bd258767c1bdeb84f50 10-Apr-2014 Hemant Gupta <hemantg@codeaurora.org> HID: Reduce poll time to 50 ms for polling from uhid driver

This patch reduces poll time for data received from uhid driver to 50 ms
from existing 500 ms. Without this change bta thread was getting blocked upto
max 500 ms when HID is disconnected, which caused delay in sending
of AVDTP Media packets during A2DP and HID concurrent test cases resulting
in audio break on BT headset during HID disconnection as closing of uhid
polling thread is done from BTA context.

Change-Id: I033e2d81e895831555bbfdff1f93fad5f2cc5e59
/system/bt/btif/co/bta_hh_co.c
5cd8bff2dd0337cb52bf48f312e3d2d55a8882fb 01-Feb-2014 Mike J. Chen <mjchen@google.com> Major warnings cleanup

Mostly fixing unused parameter warnings.
A few other warnings also fixed like possible use of
unitialized variables (no real issue found, just compiler couldn't
follow the path), signed vs unsigned warning.

Also fixed some typos, indent issues, removal of dead code, etc.

Change-Id: I95eb887aefc4d559d7921f71a0af5f3bfb01ac01
Signed-off-by: Mike J. Chen <mjchen@google.com>
/system/bt/btif/co/bta_hh_co.c
e4c9b7504492795c924f857eea95f1b80310b667 11-Dec-2013 Zhihai Xu <zhihaixu@google.com> Bluetooth does not provide unique identifier for HID devices

use remote device MAC address as the ID in uhid device.
make the format backward compatible with BlueZ.

bug:12083633
Change-Id: I6edfe94e67b806dbb68820e0ce5582ad3c04753f
/system/bt/btif/co/bta_hh_co.c
390c94dc0f9deee917f52caaf3f8bb9f79aa98b4 16-May-2013 Ganesh Ganapathi Batta <ganeshg@broadcom.com> Removed COD check for unbond and UNPAIRED_EVT

PC supporting HID Device would not have Peripheral as
its MAJOR COD. So COD check for major peripheral device was removed
in case of UNBOND and while receiving UNPAIRED_EVT. Additonal checking
is done when virtual unplug evt is received to remove bonding only for
HID Devic with MAJOR COD as Peripheral or if its a locally initiated
VUP.

Change-Id: I5343919463e48babc9cd03e05ff92a3f93f6d26d
/system/bt/btif/co/bta_hh_co.c
ead3cde4bac0c3e32cd31f149093f004eef8ceeb 06-Feb-2013 Ganesh Ganapathi Batta <ganeshg@broadcom.com> Initial version of BLE support for Bluedroid

Change-Id: I9825a5cef9be2559c34c2a529b211b7d471147cf
/system/bt/btif/co/bta_hh_co.c
689d66b6559dcb3a0ad7f6cc33b6129e50910253 13-Dec-2012 The Android Open Source Project <initial-contribution@android.com> Snapshot 9fd57cbacd95e89602f430244c35bbc67f08b6d2

Change-Id: Ibc3a4bf4161d286c7cfab89a19c676eb5cc9224f
/system/bt/btif/co/bta_hh_co.c
5738f83aeb59361a0a2eda2460113f6dc9194271 13-Dec-2012 The Android Open Source Project <initial-contribution@android.com> Snapshot cdeccf6fdd8c2d494ea2867cb37a025bf8879baf

Change-Id: Ia2de32ccb97a9641462c72363b0a8c4288f4f36d
/system/bt/btif/co/bta_hh_co.c