History log of /system/bt/hci/src/packet_fragmenter.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
92e0f19ff01e610a561ce27017e44b70ca246fc4 03-Feb-2016 Matadeen Mishra <matade@codeaurora.org> L2CAP: Handle invalid HCI packets

- Handled Buffer over flow for uint16_t
- Discard invalid HCI packets from Codenomican test
tool as data length and actual data not matching
during reassembly

Use case:
Execute L2CAP test suit from Defensics Codenomican

Steps:
1. Pair and connect DUT to Codenomican tool
2. Execute L2CAP test suit from Defensics Codenomican

Failure:
Crash observed on DUT and Codenomican tool stuck in execution.

Root cause:
Codenomican tool sending invalid HCI packets to DUT and
there are no checks to handle buffer over flow and other invalid data
from Codenomican tool.

Bug: 29498064
Change-Id: I6f93c80244fc39d607ad285185136bbbca83d7ae
/system/bt/hci/src/packet_fragmenter.c
49a86709488e5cfd5e23759da18bf9613e15b04d 08-Jul-2015 Marie Janssen <jamuraa@google.com> build: LOG_TAG consistency, include order, build fixes

Fix the order of includes across a bunch of files, and declare LOG_TAG
at the top of every file in which it is used.

Consistently use bt_ as a LOG_TAG prefix.
Fix issues with LOG macro usage.
Remove unused includes and double-includes (when in related .h)

Add includes as necessary to compile cleanly (problems surfaced by
reordering includes)

Change-Id: Ic55520c8302b06bbc1942c10c448b20844669da6
/system/bt/hci/src/packet_fragmenter.c
49120dc867c7818511b5afec461dfc97d17eef58 08-Jul-2015 Marie Janssen <jamuraa@google.com> build: Fix LOG_TAG define breakage, macro usage

Fixes build breakages related to r.android.com/156982

Change-Id: Ib1143c41fe05a17c296226998afdb41a8cb6294a
/system/bt/hci/src/packet_fragmenter.c
db554581079863974af8e1289646f5deea6fc044 26-Jun-2015 Marie Janssen <jamuraa@google.com> build: Update osi log functions, use consistently

Update the LOG_* functions to take a tag argument which makes them more
consistent with the Android Log.*(TAG, s) common syntax and removes
some #define-dependency with osi/include/log.h.

Also update to never use Android log functions directly.

Also contains minor cleanup of some header includes.

Bug: 21569831
Change-Id: If07385cafbea062232ecdbc7c673f908d5ef8921
/system/bt/hci/src/packet_fragmenter.c
3e59b5b6f2ce1295e3e2711afcd2cdf0dd7e22b6 01-Apr-2015 Etan Cohen <etancohen@google.com> Fix build issues in bluedroid on master

Change-Id: I0d3e93ea61dd03505fe9db902ed90bdd4141cab2
/system/bt/hci/src/packet_fragmenter.c
0f9b91e150e153229235c163861198e23600e636 12-Mar-2015 Sharvil Nanavati <sharvil@google.com> Use fully qualified path for OSI includes.
/system/bt/hci/src/packet_fragmenter.c
05d0366413bedc16b4189b9e74395fe4b11ba41a 05-Nov-2014 Zach Johnson <zachoverflow@google.com> Add a hash function for bluetooth addresses

Also includes simple tests for it + disambiguates
including hash_function.h throughout the stack.
/system/bt/hci/src/packet_fragmenter.c
aa3a0114b6f018d0dd296d5bdb113d2f881cbc51 05-Nov-2014 Zach Johnson <zachoverflow@google.com> Add key equality function option for hash_map

This will allow us to do deeper equality on things like
bluetooth addresses where the actual pointers are different
but the values of the bluetooth addresses are the same.
/system/bt/hci/src/packet_fragmenter.c
4a04780fd423d3c6673e9355af90ab60f31d9533 27-Dec-2014 Zach Johnson <zachoverflow@google.com> Canonicalize HCI logtags with bt_ prefix
/system/bt/hci/src/packet_fragmenter.c
44802768c447ab480d4227b3a852a97d923b816d 24-Dec-2014 Sharvil Nanavati <sharvil@google.com> Add platform-independent logging macros to OSI.

These macros should replace ALOG* and the various trace macros
used throughout bluedroid. This change eliminates all uses of the
ALOG* macros in favor of the new ones.
/system/bt/hci/src/packet_fragmenter.c
79ecab5d0418fde77e9afcdd451bd713af73e180 31-Oct-2014 Chris Manton <cmanton@google.com> Move controller module to device directory
/system/bt/hci/src/packet_fragmenter.c
30e58068c1adaac7c5ccb3aa9cfb045d41d2a10e 27-Sep-2014 Zach Johnson <zachoverflow@google.com> Refactor btm_devctl reset sequence

* Controller bring up on blockable thread now
* Removed some duplicate and commands during controller bring up
* The code to make commands for controller bring up is smaller and better
/system/bt/hci/src/packet_fragmenter.c
43b9ddb63f2efac8b3113df975e479663301a5b7 18-Sep-2014 Zach Johnson <zachoverflow@google.com> Fix packet fragmenter so it doesn't request acl sizes unless it's actually an ACL packet

During the startup process, commands are sent before the ACL sizes are fetched.
With the change that we now assert the acl sizes are fetched when you request
them from the controller, the assertion was being triggered during that phase.

When I was rebasing the waiting changes and also making the assertion change,
I should have been more careful to test this. mea culpa

Also simplifies that code path just a bit.
/system/bt/hci/src/packet_fragmenter.c
bf8193bc81cc077e3acd245cacbe8e3789c4b9ff 08-Sep-2014 Zach Johnson <zachoverflow@google.com> HCI layer cleanup

- x_interface_t started to get annoyingly verbose, changed to x_t
- buffer_allocator is standalone now, no longer part of bte_main
- new controller_t to handle controller start up and hold controller state
- new hci_packet_factory to make packets, and hci_packet_parser
to read information out of packets.
/system/bt/hci/src/packet_fragmenter.c
1e0ede7f5522a853fc39d4f183e508ed38f01636 28-Aug-2014 Zach Johnson <zachoverflow@google.com> Move HCI over to the osi allocators, and fix the tests accordingly
/system/bt/hci/src/packet_fragmenter.c
fe18b71ad98bd4da1389b6898b97294482ac1f13 26-Aug-2014 Zach Johnson <zachoverflow@google.com> Clean up scattered naive hash functions
/system/bt/hci/src/packet_fragmenter.c
fbbd42b1fc1aae7a106f46275ab1fd86452cce78 16-Aug-2014 Zach Johnson <zachoverflow@google.com> Refactor HCI layer

Refactor the HCI layer for better testability.
A future CL will add a HAL implementation for multi channel transport.

Since btsnoop and vendor are modified, it's not easy to incrementally introduce these changes.
/system/bt/hci/src/packet_fragmenter.c