| 8a3f68edbcf7fe59380609588787baa54cbd9bdd |
|
11-Jan-2016 |
Samuel Tan <samueltan@google.com> |
shill: make remote service monitoring RPC-mechanism-specific
Code that monitors remote RPC endpoints is RPC-mechanism-specific,
so it should live in RPC-mechanism-specific source files.
Move all code that creates D-Bus service watchers from Manager
into ChromeosManagerDBusAdaptor, and remove expectations for
service watcher creation/deletion from Manager unittests. Remove
CreateRPCServiceWatcher from ControlInterface, since we leave the
details of creating the RPC service watcher to the RPC adaptors.
Also, create a ChromeosManagerDBusAdaptor unittest, along with the
classess necessary to support these unittests (DBusServiceWatcherFactory,
MockDBusServiceWatcherFactory, MockDBusServiceWatcher), to test for the
creation/deletion of D-Bus service watchers that is now done in
this adaptor.
While there, remove an unnecssary comment from icmp_session_factory.cc.
BUG: 26489902
TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=true
TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=false
Change-Id: I31be9ead90e0e538247401042c5b5012a924c0dd
/system/connectivity/shill/control_interface.h
|
| 646c7e891789ea8abadd9e88bdd625d8bea2536d |
|
29-Dec-2015 |
Samuel Tan <samueltan@google.com> |
shill: stop using ChromeosDBusDaemon
Replace the use of ChromeosDBusDaemon with ChromeosDaemon,
and move D-Bus initialization code into ChromeosDBusControl.
This will allow us to easily plug in another RPC interface
(Binder) into shill by adding another ControlInterface
implementation that handles that RPC mechanism's initialization.
BUG: 26359493
Change-Id: I0ffe1e080601d7c4544fa6c73bad0f34b4a984ed
TEST: shill compiles on Android and unit tests pass.
TEST: shill compiles on ChromeOS and unit tests pass.
TEST: weave provisioning succeeds on Brillo dragonboard build.
/system/connectivity/shill/control_interface.h
|
| f2daaf991f4256c93b9cad9e409fb644cd670509 |
|
13-Sep-2015 |
Peter Qiu <zqiu@google.com> |
Cleanup dbus-c++ files
Remove unused dbus-c++ adaptor/proxy files.
While there, remove the unused proxy interface
DBusServiceProxyInterface, it was needed for dbus-c++ only.
Bug: None
TEST=USE="asan clang wimax pppoe" FEATURES=test emerge-$BOARD shill
Change-Id: Iccd3501a276740f9836b59294d3a93653e05a92f
/system/connectivity/shill/control_interface.h
|
| a330ecd23b1ce4112fd7a28f4b2a062b8df10735 |
|
02-Sep-2015 |
Peter Qiu <zqiu@google.com> |
shill: rename PermissionBrokerProxyInterface to FirewallProxyInterface
Use FirewallProxyInterface to abstract firewall functionalities. This
allows us to use different implementations (permission_broker or
firewalld) based on the target platform.
BUG=b:23756495
TEST=unittest
Change-Id: Ieeb0a56ce22efeebf3db9c775678bab1aeeea05d
Reviewed-on: https://chromium-review.googlesource.com/296833
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/control_interface.h
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/control_interface.h
|
| 607796ab5bd9488a9ce4f74aeb48eefdbc7f8b46 |
|
27-Aug-2015 |
Peter Qiu <zqiu@google.com> |
shill: include DBusPropertiesProxy creation for cellular only
DBusPropertiesProxy is compiled for cellular only. So move the
creation API under cellular as well.
While there, remove unnecessary blank lines between #if clauses.
BUG=chromium:517680
TEST=USE="-cellular" FEATURES=test emerge-$BOARD shill
CQ-DEPEND=CL:295772
Change-Id: Iff256a40653d85bdb0db44f60af9d8f54139bd19
Reviewed-on: https://chromium-review.googlesource.com/295766
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 05d87e34869f44473edc1eec25d2fe1110d777a7 |
|
15-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: Cellular: cleanup proxy interfaces
Remove dbus-c++ dependency from cellular proxy interfaces.
The changes include:
- Replace DBusPropertiesMap with KeyValueStore.
- Replace DBus::Path with std::string.
- Initialize proxies using service's well known name (service_name)
instead of service owner's name (owner), since there can only
be one owner per service and it is easier to use service_name with
the new proxy setup.
- Replace DBus::Struct with std::tuple.
An upcoming CL will implement proxies using chromeos dbus, and integrate
them into ChromeosDBusControl.
BUG=chromium:517680
TEST=USE="chromeos_dbus asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: I041369f69e7160a471efc8f90eef1d909df1a776
Reviewed-on: https://chromium-review.googlesource.com/293796
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 3b86eb2bd80b06ccf240368375e78718d94a3a7f |
|
12-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: update proxy creation APIs for chromeos dbus
Update APIs to account for proxies that monitor on its service
availability. And remove unnecessary arguments, such as well known
service name and path.
Also use chromeos::dbus_utils::Property instead of dbus::Property,
which supports more complex type such as variant diciontary. And
do not register unused properties.
BUG=chromium:517680
TEST=unittests, wifi_matfunc tests
Change-Id: Id5873dfa73da68cc56394edac7fa97144ae47e89
Reviewed-on: https://chromium-review.googlesource.com/292927
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 820012496f8c171a7c5da4a4904a6ee93bfea2e9 |
|
31-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: use control interface to create DHCPCD listener
Provide an abstraction for DHCPCDListener, so it can be created using
control interface. This will remove dbus-c++ dependency from
DHCPProvider.
BUG=chromium:513791
TEST=USE="chromeos asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: Icd47fd982a3f6b96183ad9ee742bb1116b023d86
Reviewed-on: https://chromium-review.googlesource.com/289947
Reviewed-by: Paul Stewart <pstew@chromium.org>
Trybot-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/control_interface.h
|
| f4c5cbc4e9f69b5f5a3240b045b5ec882d60290a |
|
29-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: add proxy creation APIs to control interface
The goal is to use ControlInterface instead of ProxyFactory for
proxy creations, so that appropriate proxies can be created based
on the type of the control interface.
Upcoming CLs will migrate codes to use control interface for proxy
creations.
BUG=chromium:513791
TEST=unittests
Change-Id: Ie74a738d483ea444b16cff9e2765523d248593b7
Reviewed-on: https://chromium-review.googlesource.com/289540
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/control_interface.h
|
| a794cd60a7339d576ea2eed263a4f0a20fb255af |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level files a-e: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: Idb7252202e142098999fe0672712aded7d369259
Reviewed-on: https://chromium-review.googlesource.com/278038
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 127b341755731bd6ecc19e44b63c23c79e0b7cd1 |
|
16-Oct-2014 |
Prabhu Kaliamoorthi <kaliamoorthi@chromium.org> |
shill: Third party VPN driver and DBus bindings
This CL adds Third party VPN driver and DBus bindings to Shill daemon
BUG=chromium:407541
TEST=Compilation test, basic functionality test with autotest framework and trybots (beaglebone-paladin, lumpy-paladin, falco-paladin, daisy-paladin, x86-generic-paladin, amd64-generic-paladin)
Change-Id: I98095a784843df325fc41dc25498938cd1ec9e75
Reviewed-on: https://chromium-review.googlesource.com/223690
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Prabhu Kaliamoorthi <kaliamoorthi@chromium.org>
Tested-by: Prabhu Kaliamoorthi <kaliamoorthi@chromium.org>
/system/connectivity/shill/control_interface.h
|
| c45688bb3881f0c2216e6ec0e19ebda0be33e871 |
|
03-Jul-2014 |
Ben Chan <benchan@chromium.org> |
shill: Fix header guards to conform to coding style.
BUG=chromium:385849
TEST=Tested the following:
1. `USE='cellular wimax' FEATURES=test emerge-$BOARD platform2`
2. `cpplint.py --filter=-build/include_order shill/*.h` reports no
'build/header_guard' issue.
Change-Id: I1a3972a1f88e5001550eccd561633bd4e5c5faba
Reviewed-on: https://chromium-review.googlesource.com/206680
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 8a5322984f2d81bcbfd8d44c59747a11bd9b904b |
|
17-Jun-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: Fix most of warnings from cpplint
Fix most cpplinter's warnings. On a few occasisions, the warnings
produced were false-positives, so added explicit // NOLINT comment
overrides.
There were a few instances of disallowed non-const reference usage
(reported as runtime/reference error by cpplint) for
"DBus::Error &error" which should potentially be changed
to pointers to comply with C++ coding style but I will let Shill
owners do that since there is quite a few of those and the
change isn't brain-dead simple...
BUG=None
TEST=platform2 still compiles and all unit tests pass.
Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e
Reviewed-on: https://chromium-review.googlesource.com/204164
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/control_interface.h
|
| d778352fce7021fc197aa6003c0a2d0662f3e799 |
|
10-Aug-2012 |
Christopher Wiley <wiley@chromium.org> |
shill: Rename MLOG to LOG
Redefine the LOG macro to route messages through MLOG. Changed
mock_log.cc to actively look for messages with the MemoryLog prefix and
remove it, thus greatly simplifying testing.
BUG=chromium-os:31145
TEST=Builds, unit tests still pass
Change-Id: I458f40048375ac8848f7a009d9a6f6b7f52f6744
Reviewed-on: https://gerrit.chromium.org/gerrit/29942
Commit-Ready: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/control_interface.h
|
| a9b1fedcad9d354ff7b0a6a7e4cfd58fa7133084 |
|
29-Feb-2012 |
Darin Petkov <petkov@chromium.org> |
shill: Setup .Task RPC service for incoming VPN communication.
This will be used by OpenVPN, for example, to communicate back to shill
connection information (IP, DNS, etc.).
The RPC class model mostly follows the existing RPC adaptor classes (Manager,
Service, etc.).
Task is a bit overloaded and confusing in the context of shill so calling the
RPC object RPCTask instead. Also, the current intent is for this object to just
handle RPC service calls. Once the initial VPN implementation is in we may
decide to rename and refactor these objects.
BUG=chromium-os:26993
TEST=unit test
Change-Id: Ie294524b954c4a589c07ad285c7703cbbf9157d6
Reviewed-on: https://gerrit.chromium.org/gerrit/17047
Reviewed-by: Darin Petkov <petkov@chromium.org>
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Sam Leffler <sleffler@chromium.org>
Commit-Ready: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 34af218abe6a99144ffe01332ce36fbad94f2628 |
|
22-Aug-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Use flimflam-esque storage ids
Devices:
device_<MAC>
IPConfig:
ipconfig_<MAC of associated device>_0
Services:
ethernet_<MAC of associated device>
wifi_<MAC of associated device>_<SSID>_<mode>_<security>
cellular_<MAC of associated device>_<Network_name>
BUG=chromium-os:17744
TEST=unit
Change-Id: Ibf061f9c184e7c86f5afcf97d48e321fc74bde1c
Reviewed-on: http://gerrit.chromium.org/gerrit/6412
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 5dec5f4e469a24f1ad508a210d1d23f228bc09a3 |
|
22-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Enable Device objects to persist themselves to disk
BUG=chromium-os:17254
TEST=unit
Change-Id: Ia00bc2658e0fe03e13e399d7afab81cc09aa0195
Reviewed-on: http://gerrit.chromium.org/gerrit/5309
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/control_interface.h
|
| c6c6c13e2543bd3ff5beae067b0320647fe1e141 |
|
30-Jun-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Wire IPConfig objects to dbus
BUG=chromium-os:17154
TEST=unit tests
STATUS=Verified
Change-Id: If4344b1df2806dcff914fe1e79d6f0d7705a6eb3
Reviewed-on: http://gerrit.chromium.org/gerrit/3494
Reviewed-by: Darin Petkov <petkov@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 52cd19bfd52226611d924930f1178307f79d5fdc |
|
30-Jun-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Add Profile objects
Add a mostly-empty Profile object and all the wiring to hook it up to DBus
BUG=chromium-os:17154
TEST=unit tests
Change-Id: I16bf488969f071dd91c31ef454c7e10a81f9afe7
Reviewed-on: http://gerrit.chromium.org/gerrit/3423
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/control_interface.h
|
| d7732e4b308836ed21723c1ab412f640f02abdf1 |
|
20-May-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Wire shill to dbus
Refactor necessary classes into their own headers and such as well.
BUG=chromium-os:15578
TEST=unit tests, shill --foreground on device
Change-Id: Ib9c5a0e9dab779ecc44c1d0144035f5a09e1086e
Reviewed-on: http://gerrit.chromium.org/gerrit/1307
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 9be4a9d1e87d64f850f15061123b2a4334477fa2 |
|
17-May-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] the beginnings of the data model
Flesh out Manager a little, to add vectors of Device* and Service* and ways to look through them.
BUG=chromium-os:15347
TEST=unit tests
Change-Id: Iae5280f56bf58cf1580f0b87c465f4905459f07a
Reviewed-on: http://gerrit.chromium.org/gerrit/966
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 413a3191a9a177c90e60fa24d5e86eac739549cf |
|
10-May-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Add wpa_supplicant API spec to shill. Also, change 'proxy' -> 'adaptor'
Add the XML description of the wpa_supplicant DBus API, so we can
generate client (proxy object) bindings for it. to use these
bindings, #include "shill/supplicant_cli.h" and then inherit from the
appropriate class in the fi::w1::wpa_supplicant1 namespace.
For example, for the WPA supplicant "Network" interface:
class SupplicantNetworkProxy : public fi::w1::wpa_supplicant1::Network_proxy {
public:
SupplicantNetworkProxy() {}
virtual ~SupplicantNetworkProxy() {}
// All signal handlers are abstract in the base class; implement them all here
virtual void PropertiesChanged(
const std::map< std::string, ::DBus::Variant >& properties) {
return;
}
// Methods are all implemented for you, as are accessors for properties.
};
BUG=chromium-os:15092
TEST=build
Change-Id: I55e42148bc64965317e7223c852707ed6359b0bc
Reviewed-on: http://gerrit.chromium.org/gerrit/572
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/control_interface.h
|
| 75897df1154ac38b7a4512a687241ad6a197ee40 |
|
27-Apr-2011 |
Paul Stewart <pstew@chromium.org> |
Add initial sketch to shill repository
BUG=chromium-os:12066
TEST=command-line
Change-Id: If1d01bf78fca80de4cc8a26e096e1967293d9738
Review URL: http://codereview.chromium.org//6575006
/system/connectivity/shill/control_interface.h
|
| 05697993041f71fef9fc8f541619ec595a6a388f |
|
23-Feb-2011 |
Paul Stewart <pstew@chromium.org> |
Reset to empty dir
Change-Id: I3ffe83089f84e5fec7b6d3e15b5236d2277f49f2
/system/connectivity/shill/control_interface.h
|
| aa101a783bb53314fc3e466f0701eec0074386f1 |
|
23-Feb-2011 |
Paul Stewart <pstew@chromium.org> |
Shill, the connection manager
First checkin into new repository.
TEST=Run from command line
BUG=chromium-os:12065
/system/connectivity/shill/control_interface.h
|