| 304afb43643faa19fa3a599a59fbb1574c0a06ef |
|
19-Sep-2015 |
mukesh agrawal <quiche@google.com> |
shill: migrate CryptoUtilProxy to ProcessManager
We want to remove ProcessKiller, since ProcessKiller
depends on glib. So migrate CryptoUtilProxy away
from ProcessKiller.
Bug: None
BUG=chromium:528079
TEST=unit tests
Change-Id: I45d196c9a2e53f8f9258c3dc03515f6e68e14708
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 13d581fa047118d065f41eb1d0da203cf0a49b07 |
|
15-Aug-2015 |
mukesh agrawal <quiche@chromium.org> |
shill: migrate CryptoUtilProxy to libchromeos' base64
On some platforms, we don't have glib available. Update
CryptoUtilProxy to use libchromeos' base64, so that this
code can compile on those platforms.
BUG=b:23003526
TEST=unit tests
Change-Id: I4728b9cba0df79c15856928ca1b621ac3cdf4030
Reviewed-on: https://chromium-review.googlesource.com/293881
Trybot-Ready: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 3b30ca58d13cf66b75ba0729b222ddc42ae68b33 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level unit tests: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I86c072b89281e0de18928b47860b99d779af061a
Reviewed-on: https://chromium-review.googlesource.com/278037
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| cddd2d09878704128d35ddfeec862109b7d7fdc9 |
|
11-Nov-2014 |
Alex Deymo <deymo@chromium.org> |
Include the implemented header first in all projects.
The Google C++ style guide dictates that foo.cc and foo_unittest.cc
should include foo.h in the first place, so missing headers in foo.h
are detected with a compile error of the module implementing them and
not when another module uses them.
This CL sweeps across all the .cc file in platform2 enforcing this.
BUG=None
TEST=cbuildbot amd64-generic
Change-Id: I41835835caba13f54c3c844ecf552eb0e47efa9d
Reviewed-on: https://chromium-review.googlesource.com/228894
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| cc225ef3b77b5e098cc12c661a947e1737480777 |
|
30-Sep-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace NULL with nullptr.
BUG=None
TEST=`USE=wimax FEATURES=test emerge-$BOARD shill`
Change-Id: I30ab47ff32dcadad09ae7a2baf4d4123a6ef0d8e
Reviewed-on: https://chromium-review.googlesource.com/220657
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| be0849f4474f6e97496550187bc4256bf0a91d2b |
|
16-Aug-2014 |
Ben Chan <benchan@chromium.org> |
shill: Drop static specifier on constants in anonymous namespace.
BUG=None
TEST=`FEATURES=test emerge-$BOARD platform2`
Change-Id: Ic1e97a75efa16061e371573c6bf89f7d40b7efd5
Reviewed-on: https://chromium-review.googlesource.com/212800
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| e4c6aff3afa8eec213691e6ab1941d6dd6463ce0 |
|
30-Jul-2014 |
Utkarsh Sanghi <usanghi@chromium.org> |
shill, libchromeos, lorgnette: move minijail to libchromeos
Move the c++ wrapper of minijail out of lorgnette
and into libchromeos
BUG=None
TEST=emerge-lumpy libchromeos && USE="shill lorgnette" emerge-lumpy
platform2 --test
Change-Id: Idc796ffb042b1ed6b5a4d322d501eab5bff7fc55
Reviewed-on: https://chromium-review.googlesource.com/210553
Reviewed-by: Utkarsh Sanghi <usanghi@chromium.org>
Commit-Queue: Utkarsh Sanghi <usanghi@chromium.org>
Tested-by: Utkarsh Sanghi <usanghi@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 83bd64b869bef72ec734b96eb9cf291b9a9ac2c4 |
|
30-Jul-2014 |
Utkarsh Sanghi <usanghi@chromium.org> |
shill, libchromeos: Move the minijail c++ bindings
This CL moves the c++ binding for minijail from shill
into libchromeos
BUG=None
TEST=emerge-lumpy libchromeos && FEATURES=test emerge-lumpy platform2
CQ-DEPEND=CL:210408
Change-Id: Ia087ffbf4f54e08fff450f0e2b7984e9eb3448e3
Reviewed-on: https://chromium-review.googlesource.com/210379
Tested-by: Utkarsh Sanghi <usanghi@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Bertrand Simonnet <bsimonnet@chromium.org>
Commit-Queue: Utkarsh Sanghi <usanghi@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| a41ab517725d036b63420f8445550246f8f50b99 |
|
23-Jul-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: Sort headers alphabetically (build/include_alpha)
We are going to enable build/include_alpha linter warning soon,
so in preparation for this, fixed the warnings in shill.
BUG=None
TEST=cpplint.py --filter=-build/include_order,+build/include_alpha shill/*
Change-Id: I113ed7f9dd3f465a3f660599320cdb434e7cc214
Reviewed-on: https://chromium-review.googlesource.com/209636
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 8a5322984f2d81bcbfd8d44c59747a11bd9b904b |
|
17-Jun-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: Fix most of warnings from cpplint
Fix most cpplinter's warnings. On a few occasisions, the warnings
produced were false-positives, so added explicit // NOLINT comment
overrides.
There were a few instances of disallowed non-const reference usage
(reported as runtime/reference error by cpplint) for
"DBus::Error &error" which should potentially be changed
to pointers to comply with C++ coding style but I will let Shill
owners do that since there is quite a few of those and the
change isn't brain-dead simple...
BUG=None
TEST=platform2 still compiles and all unit tests pass.
Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e
Reviewed-on: https://chromium-review.googlesource.com/204164
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 6937b6aa246cd82d06994ca885c69ddf92ac29bb |
|
03-Dec-2013 |
Yunlian Jiang <yunlian@google.com> |
shill: remove unused const variables
BUG=chromium:324986
TEST=emerge-x86-generic platform2
the warnings are disappeared.
Change-Id: Ib6b7fb69a87f8315e3fac0eef726dc9d67e8bad7
Reviewed-on: https://chromium-review.googlesource.com/178544
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 67e425e5af9b28ffff2c17f879e70f9f6a4e10e9 |
|
03-May-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Fix race on crypto-util shim death
Fix a race between the death of the shim and crypto_util_proxy callers.
CryptUtilProxy was incorrectly calling its result handler before the
shim was completely dead, leading linked calls to fail *sometimes*.
BUG=chromium:236083
TEST=Manual. VerifyAndEncryptData no longer fails with valid input.
Change-Id: I50c72b3609b51a2a8f3b624bc8eac7d7372283f3
Reviewed-on: https://gerrit.chromium.org/gerrit/50000
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| b3e70d2ca1cfb02effd82c6f95f2869d22201860 |
|
27-Apr-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Only call shim result callback from clean shim state
Fix a bug where VerifyAndEncryptData fails when the Verify callback
cannot start an Encrypt operation because the shim is supposedly still
working. The shim has actually returned a complete result in this case,
but we're calling into the crypto_util_proxy before giving it a chance
to clean up the shim state.
While we're here, check the correct error in the Manager when we fail to
link Verify and Encrypt shim operations.
TEST=Unit tests.
BUG=chromium:236083
Change-Id: I00366d55afa1c3dd228d40662e2baacac7d79eb0
Reviewed-on: https://gerrit.chromium.org/gerrit/49490
Commit-Queue: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 956400a700b5ad9236c30774ca7d47d63ebe530a |
|
05-Apr-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Append NULL to end of crypto-util arguments
Fix a crash in minijail after we fork off the shim by properly
formatting its argument strings.
TEST=By hand: call Manager.VerifyDestination with any data, observe that
the shim starts and at least looks at the data before exitting,
rather than crashing mysteriously.
BUG=chromium:227074
Change-Id: I547151bdb07c7656249220caff388dc36c53b8c7
Reviewed-on: https://gerrit.chromium.org/gerrit/47447
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 0d05c11a21752aa82c598977bdd409a41d51cb55 |
|
20-Mar-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Add crypto_util shim
Add a shim to delegate cryptographic verification of destinations.
TEST=Unit tests pass. Co-commit with an autotest that verifies OpenSSL
operations.
BUG=chromium:221169
CQ-DEPEND:CL:46308
Change-Id: I564732224cd3f30411f7330198bd3c5fc99c289e
Reviewed-on: https://gerrit.chromium.org/gerrit/46051
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 5447d2e616b657a36ef878ae35c77f7d2f4d2c8e |
|
20-Mar-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Base64 encode/decode crypto_util arguments
Initially, I thought this would be easier to do in the shim, where
things might play nicely with OpenSSL. However, it turns out that the
OpenSSL API for base64 encoding/decoding is far more painful that it's
worth. Add a convenient wrapper around the raw GLib calls so that
people have less opportunity to shoot themselves in the foot.
BUG=chromium-os:221168
TEST=Unit tests pass.
Change-Id: I69732af03fdf729519783a3440213ef6adf8a630
Reviewed-on: https://gerrit.chromium.org/gerrit/46049
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|
| 5a3f23a122566b53e230b1132c0241411016386a |
|
21-Feb-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Delegate credential verification operations to a shim
Define a protocol buffer interface to a shim, and suppport
asynchronously piping the arguments for credential verification and data
signing into the shim. Read results back from the shim asynchronously
as well.
BUG=chromium-os:39055
TEST=Unit tests. Added some more.
Change-Id: I5e0e25b9639bf5e6237c4c35d0be14b129951809
Reviewed-on: https://gerrit.chromium.org/gerrit/44239
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy_unittest.cc
|