| 8a3f68edbcf7fe59380609588787baa54cbd9bdd |
|
11-Jan-2016 |
Samuel Tan <samueltan@google.com> |
shill: make remote service monitoring RPC-mechanism-specific
Code that monitors remote RPC endpoints is RPC-mechanism-specific,
so it should live in RPC-mechanism-specific source files.
Move all code that creates D-Bus service watchers from Manager
into ChromeosManagerDBusAdaptor, and remove expectations for
service watcher creation/deletion from Manager unittests. Remove
CreateRPCServiceWatcher from ControlInterface, since we leave the
details of creating the RPC service watcher to the RPC adaptors.
Also, create a ChromeosManagerDBusAdaptor unittest, along with the
classess necessary to support these unittests (DBusServiceWatcherFactory,
MockDBusServiceWatcherFactory, MockDBusServiceWatcher), to test for the
creation/deletion of D-Bus service watchers that is now done in
this adaptor.
While there, remove an unnecssary comment from icmp_session_factory.cc.
BUG: 26489902
TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=true
TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=false
Change-Id: I31be9ead90e0e538247401042c5b5012a924c0dd
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| a04c6448da585d8bef65b8bbd44711fd7882c917 |
|
07-Jan-2016 |
Samuel Tan <samueltan@google.com> |
shill: add BinderControl and stub/skeleton adaptor implementations
Add BinderControl, an RPC control module for Binder on shill.
Add stub adaptor implementations for shill RPC interfaces that
we do not support on Binder (Profile, IPConfig, and RPCTask), and
skeleton implementations for RPC interfaces we do support
(Device, Manager, and Service).
Also:
- Rename the ENABLE_ANDROID_BINDER flag to ENABLE_BINDER, since
the binder file naming convention does not include an android
prefix.
- Rename the |callbacks| argument in IService.aidl to |callback|
so this argument name matches those in the other .aidl files.
BUG: 25160005
Change-Id: I2a5c71b8a302d2a7243d1c8e2eba90e4c5022f8a
TEST: shill compiles on Android and all unit tests pass.
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| 646c7e891789ea8abadd9e88bdd625d8bea2536d |
|
29-Dec-2015 |
Samuel Tan <samueltan@google.com> |
shill: stop using ChromeosDBusDaemon
Replace the use of ChromeosDBusDaemon with ChromeosDaemon,
and move D-Bus initialization code into ChromeosDBusControl.
This will allow us to easily plug in another RPC interface
(Binder) into shill by adding another ControlInterface
implementation that handles that RPC mechanism's initialization.
BUG: 26359493
Change-Id: I0ffe1e080601d7c4544fa6c73bad0f34b4a984ed
TEST: shill compiles on Android and unit tests pass.
TEST: shill compiles on ChromeOS and unit tests pass.
TEST: weave provisioning succeeds on Brillo dragonboard build.
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| 03e6719bae1e0903d94853b896673a033196bcf5 |
|
13-Oct-2015 |
Alex Vakulenko <avakulenko@google.com> |
shill: Rename "chromeos" -> "brillo" in include paths and namespaces
libchromeos is transitioning to libbrillo and chromeos namespaces
and include directory is changing to brillo.
Bug: 24872993
TEST=built for aosp and brillo, all unit tests pass on dragonboard
Change-Id: I804311e49ee780ca96e05f6a581e8c95709d4e1d
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| f2daaf991f4256c93b9cad9e409fb644cd670509 |
|
13-Sep-2015 |
Peter Qiu <zqiu@google.com> |
Cleanup dbus-c++ files
Remove unused dbus-c++ adaptor/proxy files.
While there, remove the unused proxy interface
DBusServiceProxyInterface, it was needed for dbus-c++ only.
Bug: None
TEST=USE="asan clang wimax pppoe" FEATURES=test emerge-$BOARD shill
Change-Id: Iccd3501a276740f9836b59294d3a93653e05a92f
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| a330ecd23b1ce4112fd7a28f4b2a062b8df10735 |
|
02-Sep-2015 |
Peter Qiu <zqiu@google.com> |
shill: rename PermissionBrokerProxyInterface to FirewallProxyInterface
Use FirewallProxyInterface to abstract firewall functionalities. This
allows us to use different implementations (permission_broker or
firewalld) based on the target platform.
BUG=b:23756495
TEST=unittest
Change-Id: Ieeb0a56ce22efeebf3db9c775678bab1aeeea05d
Reviewed-on: https://chromium-review.googlesource.com/296833
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| 607796ab5bd9488a9ce4f74aeb48eefdbc7f8b46 |
|
27-Aug-2015 |
Peter Qiu <zqiu@google.com> |
shill: include DBusPropertiesProxy creation for cellular only
DBusPropertiesProxy is compiled for cellular only. So move the
creation API under cellular as well.
While there, remove unnecessary blank lines between #if clauses.
BUG=chromium:517680
TEST=USE="-cellular" FEATURES=test emerge-$BOARD shill
CQ-DEPEND=CL:295772
Change-Id: Iff256a40653d85bdb0db44f60af9d8f54139bd19
Reviewed-on: https://chromium-review.googlesource.com/295766
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| 526ed5f13bac449210b290ca027be8599bc5ea83 |
|
25-Aug-2015 |
Peter Qiu <zqiu@google.com> |
shill: chromeos_dbus: use separate dbus connection for proxies
Without a separate bus connection for proxies, certain broadcast
signal messages will get filtered out by the bus. Refer to
crbug.com/446837 for more info.
BUG=chromium:517680
TEST=Restart modemmanager, verify modem device is created by shill
Change-Id: Iba06ee397655d3ee646331ec7d18cdd5f0a038a7
Reviewed-on: https://chromium-review.googlesource.com/295561
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| 05d87e34869f44473edc1eec25d2fe1110d777a7 |
|
15-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: Cellular: cleanup proxy interfaces
Remove dbus-c++ dependency from cellular proxy interfaces.
The changes include:
- Replace DBusPropertiesMap with KeyValueStore.
- Replace DBus::Path with std::string.
- Initialize proxies using service's well known name (service_name)
instead of service owner's name (owner), since there can only
be one owner per service and it is easier to use service_name with
the new proxy setup.
- Replace DBus::Struct with std::tuple.
An upcoming CL will implement proxies using chromeos dbus, and integrate
them into ChromeosDBusControl.
BUG=chromium:517680
TEST=USE="chromeos_dbus asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: I041369f69e7160a471efc8f90eef1d909df1a776
Reviewed-on: https://chromium-review.googlesource.com/293796
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| c00d1fa87127a33bd1e1a7cf049a54a9cca49d68 |
|
14-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: update chromeos dbus adaptors
Following are the changes to the adaptor:
- Remove the support for ObjectManager for now to avoid any testing
complications.
- Register adaptor to the bus synchronously to avoid possible race
conditions.
- Unregister adaptor on its destruction to allow object path to be
reusable and prevent memory leak on the bus.
While there, update Manager interface xml to provide raw message
in the method handler. This allows the handler to be synchronous,
since we don't need to verify claimer's name via DBus watcher
anymore (message sender is used as claimer name). Also update
Manager's usage of DeviceClaimer.
BUG=chromium:517680
TEST=unittests, wifi_matfunc tests
Change-Id: Ia1f306227cae3b27285d80fc7931538e59978e4a
Reviewed-on: https://chromium-review.googlesource.com/293562
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| 820012496f8c171a7c5da4a4904a6ee93bfea2e9 |
|
31-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: use control interface to create DHCPCD listener
Provide an abstraction for DHCPCDListener, so it can be created using
control interface. This will remove dbus-c++ dependency from
DHCPProvider.
BUG=chromium:513791
TEST=USE="chromeos asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: Icd47fd982a3f6b96183ad9ee742bb1116b023d86
Reviewed-on: https://chromium-review.googlesource.com/289947
Reviewed-by: Paul Stewart <pstew@chromium.org>
Trybot-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| 0d8b91f88c68ae95840ce2eae1f058a4a53684f7 |
|
31-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: stub implementation for ChromeosDBusControl proxy creation APIs
BUG=chromium:513791
TEST=USE="asan clang chromeos_dbus" FEATURES=test emerge-$BOARD shill
Change-Id: I34757a133851faac18718a25308491f4f4add688
Reviewed-on: https://chromium-review.googlesource.com/289913
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| 24b34a0263ade24d39dfe41a7422bfcd0148fda6 |
|
30-Jun-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: decouple daemon interface and its service exporter
Provide a basic abstraction for shill's daemon interface, without
any dependency for the underlying MessageLoop and technology use to
expose its services.
Implement a DBus daemon using chromeos::DBusServiceDaemon to expose
shill's services through DBus. The message loop (MessageLoopForIO)
is encapsulated in the daemon. So we will need to remove the message
loop dependency in shill (EventDispatcher) when this code becomes active.
BUG=chromium:505477
TEST=USE="chromeos_dbus asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: Iccfc6bb4dc11654d9b673a2f1307f0e98f031fb4
Reviewed-on: https://chromium-review.googlesource.com/282655
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|
| 72e7e252c0594c2d58d2d8d64e4eede24608240e |
|
27-Jun-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: initial support for chromeos DBus adaptors
Implement a new control interface ChromeosDBusControl for creating
chromeos DBus adaptors.
Also create the chromeos DBus adaptor for Device object. Adaptors
for other objects will be added in future CLs.
All new DBus related files are stored under dbus/. The goal is to
modularize RPC specific codes, so we can easily plugin different RPC
module in the future.
BUG=chromium:503753
TEST=USE="chromeos_dbus asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: Ifb47fed498dc264b7a55704d07791cf8387db0a6
Reviewed-on: https://chromium-review.googlesource.com/282334
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dbus/chromeos_dbus_control.h
|