| e569b214bad42ec2be75ac1db2ca9b15563fdc61 |
|
15-Jan-2016 |
Samuel Tan <samueltan@google.com> |
shill: wrap manager AP/Station mode methods in preprocessor conditionals
Wrap the definitions and all callsites of Manager methods
SetupApModeInterface(), SetupStationModeInterface(), and
OnApModeSetterVanished() with preprocessor conditionals\
so that these methods will only be present and used in
Brillo builds that do not disable WiFi.
BUG: None
Change-Id: I2a4bef5142bedd6fa70163ebb9ea6121e7cbff1e
TEST: shill compiles and unit tests pass.
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| 8a3f68edbcf7fe59380609588787baa54cbd9bdd |
|
11-Jan-2016 |
Samuel Tan <samueltan@google.com> |
shill: make remote service monitoring RPC-mechanism-specific
Code that monitors remote RPC endpoints is RPC-mechanism-specific,
so it should live in RPC-mechanism-specific source files.
Move all code that creates D-Bus service watchers from Manager
into ChromeosManagerDBusAdaptor, and remove expectations for
service watcher creation/deletion from Manager unittests. Remove
CreateRPCServiceWatcher from ControlInterface, since we leave the
details of creating the RPC service watcher to the RPC adaptors.
Also, create a ChromeosManagerDBusAdaptor unittest, along with the
classess necessary to support these unittests (DBusServiceWatcherFactory,
MockDBusServiceWatcherFactory, MockDBusServiceWatcher), to test for the
creation/deletion of D-Bus service watchers that is now done in
this adaptor.
While there, remove an unnecssary comment from icmp_session_factory.cc.
BUG: 26489902
TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=true
TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=false
Change-Id: I31be9ead90e0e538247401042c5b5012a924c0dd
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| 0dfe24bcb8ba42e48035d9cc268d7bf92c99ce1b |
|
08-Jan-2016 |
Samuel Tan <samueltan@google.com> |
shill: remove EmitStateChanged() from ManagerAdaptorInterface
Remove this method since it is it is not actually used.
BUG: 25160005
Change-Id: I96ac23affb1a50e5a3ec4284be80c5e406f24594
TEST: shill compiles and unit tests pass
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| d13249c35eb0c5281c422a3c17a252b5cc8c865d |
|
27-Oct-2015 |
Peter Qiu <zqiu@google.com> |
Restore interface mode back to station when AP mode setter vanished
This allows shill to manage the WiFi interface when AP mode setter
(apmanager) crashed.
While there, hide the code under WiFi compiler flag as well. Since
these two APIs are only applicable when WiFi is enabled.
Bug: 25111635
TEST=Manual test on Brillo devices:
TEST=1. bootup device in WiFi bootstrapping mode (interface in AP mode)
TEST=2. kill apmanager, verify WiFi interface is set to station mode
TEST=newly added unit tests
Change-Id: I83a8d3916eb6cb006631a607957aff34ed5809ff
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| 95522afb22e28fdf981ac9161e4400df909ff3e3 |
|
29-Sep-2015 |
Peter Qiu <zqiu@google.com> |
dbus: expose APIs for configuring WiFi interface mode
The new APIs are added to org.chromium.flimflam.Manager interface,
and they're supported on Brillo devices only.
Bug: 25111635
TEST=Manual test on Brillo board
Change-Id: I04e8854e1842a25f59a1d1e4dc5cab31f1916aca
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| 03e6719bae1e0903d94853b896673a033196bcf5 |
|
13-Oct-2015 |
Alex Vakulenko <avakulenko@google.com> |
shill: Rename "chromeos" -> "brillo" in include paths and namespaces
libchromeos is transitioning to libbrillo and chromeos namespaces
and include directory is changing to brillo.
Bug: 24872993
TEST=built for aosp and brillo, all unit tests pass on dragonboard
Change-Id: I804311e49ee780ca96e05f6a581e8c95709d4e1d
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| 44131eb6da54ef61b8b3031a4d7f38ef6e1a7f50 |
|
23-Sep-2015 |
Peter Qiu <zqiu@google.com> |
Use message sender as claimer name for Manager::ReleaseInterface
Manager::ClaimInterface was updated to use message sender as claimer
name, but Manager::ReleaseInterface wasn't (missed during Chrome OS
D-Bus migration). So update it to make it consistent.
Bug: 24317304
TEST=1. Boot up a wolf device using image with "peerd wifi_bootstrapping"
TEST= USE flag.
TEST=2. Verify shill is not managing "wlan0" device using ./list-devices
TEST=3. "stop buffet", verify shill is managing "wlan0" device
Change-Id: I057a9bbce25e895a58b5850ff8998363f3316e30
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| b0d2f64a672a970a7dc1f846c36c0cd411177662 |
|
18-Sep-2015 |
Rebecca Silberstein <silberst@google.com> |
shill: do not persist disable for prohibited technologies
When technologies are disabled or enabled, they should explicitly be
stored in the profile to make the selection persistent across restarts.
Prohibited technologies should be disabled only when the technology is
prohibited. This should not persist across shill restarts, especially
when the technology is no longer prohibited. Updated existing unit
test and added new unit test to check for correct persist/nonpersist calls.
Bug: 24142276
TEST=ran unit tests and checked manually with:
1 - check /var/cache/shill/default.profile for Powered=true on wifi device
2 - dbus-send --system --print-reply --fixed --dest=org.chromium.flimflam / \
org.chromium.flimflam.Manager.SetProperty string:ProhibitedTechnologies \
variant:string:wifi
3 - dbus-send --system --print-reply --fixed --dest=org.chromium.flimflam / \
org.chromium.flimflam.Manager.SetProperty string:ProhibitedTechnologies \
variant:string:""
4 - check /var/cache/shill/default.profile for Powered=true on wifi device
Change-Id: I286e140641e9be4785a55f300c746e9d93a4b889
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| 271ffbf00b83a3d28cf0381ee7702fb3a184780c |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
shill: chromeos_dbus: emit RPC identifier with correct type
Fix couple instances where RPC identifier is being emitted as a string
instead of dbus::ObjectPath (most likely introduced by copy-paste).
BUG=chromium:527641
TEST=unittests
Change-Id: Ibf0cd2e51c02e190590b038b1af6bee57596aba6
Reviewed-on: https://chromium-review.googlesource.com/297182
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| c00d1fa87127a33bd1e1a7cf049a54a9cca49d68 |
|
14-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: update chromeos dbus adaptors
Following are the changes to the adaptor:
- Remove the support for ObjectManager for now to avoid any testing
complications.
- Register adaptor to the bus synchronously to avoid possible race
conditions.
- Unregister adaptor on its destruction to allow object path to be
reusable and prevent memory leak on the bus.
While there, update Manager interface xml to provide raw message
in the method handler. This allows the handler to be synchronous,
since we don't need to verify claimer's name via DBus watcher
anymore (message sender is used as claimer name). Also update
Manager's usage of DeviceClaimer.
BUG=chromium:517680
TEST=unittests, wifi_matfunc tests
Change-Id: Ia1f306227cae3b27285d80fc7931538e59978e4a
Reviewed-on: https://chromium-review.googlesource.com/293562
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| ca813a0b80215425cb615c544ba426b22c5c6969 |
|
16-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: update KeyValueStore to/from chromeos::VariantDictionary conversion
Simplify KeyValuStore/chromeos::VariantDictionary conversion function
now that we're using chromeos::VariantDictionary for KeyValueStore's
internal data storage.
Also remove the similar functions in PropertyStore, and redirect all
references to the new functions. This allows these functions to be used
by RPC proxy interfaces APIs.
BUG=chromium:510238
TEST=USE="asan clang chromeos_dbus" FEATURES=test emerge-$BOARD shill
Change-Id: I926981f6823b0179112f2987cf028fe0edb829f3
Reviewed-on: https://chromium-review.googlesource.com/286144
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|
| 69b6a95f893d2b21d66ca66a068ae9b1f3cd5470 |
|
02-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: add chromeos DBus adaptor for Manager
Add RegisterAsync method to ManagerAdaptorInterface to allow
DBus service daemon to request the ownership of the DBus service
only after Manager interface registration is completed. The same
requirement is not needed for other DBus adaptors.
BUG=chromium:503753
TEST=USE="chromeos_dbus asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: I7f5e6fe58014dd20187897cb230a210b9b0b22e4
Reviewed-on: https://chromium-review.googlesource.com/283150
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dbus/chromeos_manager_dbus_adaptor.cc
|