| 15d5431798155cc83a3fcb8abe0d1a2d5128f7b6 |
|
09-Oct-2015 |
Rebecca Silberstein <silberst@google.com> |
RE-LAND: shill: use DhcpProperties for dhcpv4 config
In some deployments, DHCP properties need to be specified for DHCP
requests. These properties will be set via the PropertyStore and stored
in the user profile (per service) and the default profile.
To implement this, the manager and service classes will each have an
instance of DhcpProperties to track the property settings stored in the
applicable profile. When a device creates a dhcp_config object to
configure the dhcpcd options, it will merge any applicable
DhcpProperties values set in the default and user profiles.
Users were previously able to set the hostname for DHCP requests using
the Manager.Hostname property. This value is now included in the new
DhcpProperties object. Two options are currently supported:
DhcpProperties.Hostname and DhcpProperties.VendorClass.
This change also includes new tests for the new object and the
affiliated functions. Existing tests were also updated to cover this
new functionality.
Bug: 24162121
TEST="FEATURES=test emerge-daisy shill"
TEST=compiled for brillo
Change-Id: I045ab0dbf866ea0084a8f77b28bfff24970bb92c
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| f95fe0f32645a56ba4a1dfb2dfbcaabf80b0b3f2 |
|
31-Oct-2015 |
Rebecca Silberstein <silberst@google.com> |
Revert "shill: use DhcpProperties for dhcpv4 config"
This reverts commit 5ac8c7b32241582e2e39469297de6b7cab2c7d19.
Change-Id: I7b8e747aca30a2d09dc474d2c5ef31ffcccf8032
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| 5ac8c7b32241582e2e39469297de6b7cab2c7d19 |
|
09-Oct-2015 |
Rebecca Silberstein <silberst@google.com> |
shill: use DhcpProperties for dhcpv4 config
In some deployments, DHCP properties need to be specified for DHCP
requests. These properties will be set via the PropertyStore and stored
in the user profile (per service) and the default profile.
To implement this, the manager and service classes will each have an
instance of DhcpProperties to track the property settings stored in the
applicable profile. When a device creates a dhcp_config object to
configure the dhcpcd options, it will merge any applicable
DhcpProperties values set in the default and user profiles.
Users were previously able to set the hostname for DHCP requests using
the Manager.Hostname property. This value is now included in the new
DhcpProperties object. Two options are currently supported:
DhcpProperties.Hostname and DhcpProperties.VendorClass.
This change also includes new tests for the new object and the
affiliated functions. Existing tests were also updated to cover this
new functionality.
Bug: 24162121
TEST="USE="asan clang" FEATURES=test emerge-samus shill"
Change-Id: I9e25ced863661cfd73164faf9032df25b208c6c2
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| 8ee1c83abf0050cb808fe154babe934546e77821 |
|
12-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: dhcp: use ProcessManager to manage dhcpcd processes
This removes the glib dependency for spawning/monitoring dhcpcd processes.
While there, fix a typo in process manager.
This is a part of series CLs that convert shill over to MessageLoopForIO
and chromeos dbus.
BUG=chromium:516841
TEST=unittests
Change-Id: I192fcc68c51e78da60431635abd7b3439fadd5b0
Reviewed-on: https://chromium-review.googlesource.com/292963
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| 820012496f8c171a7c5da4a4904a6ee93bfea2e9 |
|
31-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: use control interface to create DHCPCD listener
Provide an abstraction for DHCPCDListener, so it can be created using
control interface. This will remove dbus-c++ dependency from
DHCPProvider.
BUG=chromium:513791
TEST=USE="chromeos asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: Icd47fd982a3f6b96183ad9ee742bb1116b023d86
Reviewed-on: https://chromium-review.googlesource.com/289947
Reviewed-by: Paul Stewart <pstew@chromium.org>
Trybot-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| 0bfabaae654ba3bf597a303b7517a0e14fd65089 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: dhcp: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I504db9cd6fdc8ed6700f77e1da459115c5d48cf4
Reviewed-on: https://chromium-review.googlesource.com/278073
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| d1c7b413bf7e1f264d1acfdfb2f698413f6cf352 |
|
12-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: DHCPCDProxy: Ignore messages from unbound PIDs
When an interface is destroyed, shill and dhcpcd race to destroy
configuration. The situation that this CL resolves is one where
dhcpcd still has an outstanding signal that is delivered to the
DHCPCDProxy after the PID has been unbound from the DHCPProvider.
This CL maintains a short set of previously unbound PIDs that
can be used to dismiss messages from recently departed dhcpcd
instances without triggering an error message.
While here, correct the DHCPConfig unit test to use a mocked
DHCPProvider instead of a real one, and move testing of the
Bind and Unbind methods to the DHCPProvider unit test where it
makes more sense.
BUG=chromium:498908
TEST=Unit tests + "rmmod asix; modprobe asix" # Reload ethernet
TEST="grep 'Unknown DHCP client PID' /var/log/messages"
Change-Id: Ic55b0b2281651fd78a7e6fccb1b0fc2e7e520bcb
Reviewed-on: https://chromium-review.googlesource.com/277138
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| b255a76b77bbe54ed0ed8b50ba05a959acfda180 |
|
10-Jun-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: DHCPv6 configuration support
This feature is compiled out by default, can be turned on with
added "dhcpv6" USE flag.
The DHCPv6 client will request both ia_na (Non-temporary Address)
and ia_pd (Prefix Delegation) options from the DHCPv6 server. Since
each option is considered a separate request with a separate lease,
the client will maintain one lease for both options, with lease time
set to the shorter one.
BUG=chromium:492764
TEST=USE="asan clang" emerge-$BOARD shill
CQ-DEPEND=CL:276648
Change-Id: Ic97277a9ab9b2b1b3a848e047e36df20d187af56
Reviewed-on: https://chromium-review.googlesource.com/276649
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| 8e0151e84f077cc9c0646d5bafd925ed235a1c12 |
|
04-Jun-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: refactor DHCPConfig
To better support DHCPv6 configurations, move IPv4 specific code
from DHCPConfig to the newly created DHCP4Config. The idea is to
have the base class DHCPConfig supports the basic interaction with
dhcpcd daemon, and the derived class (IP specific) for processing
events and parsing IP configurations.
An upcoming CL will add a new class DHCP6Config for processing
IPv6 configurations.
BUG=chromium:496302
TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill
TEST=Run network_Dhcp* client tests and wifi_matfunc suite
Change-Id: I1f23ec46a52b42fccf7bbc8906c5f5e506f2d1c8
Reviewed-on: https://chromium-review.googlesource.com/275274
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dhcp/dhcp_provider.h
|
| 675d0b0f04936050a357722f52dc078a3ab671d8 |
|
03-Jun-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: move dhcp codes to dhcp directory
Number of files related to dhcp will increase significantly after
refactoring DHCPConfig and adding support for DHCPv6. So move
these files to a dedicated directory.
BUG=chromium:496302
TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: I7f47365158fc5e1d902946dc3403720402f9b6ad
Reviewed-on: https://chromium-review.googlesource.com/275019
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dhcp/dhcp_provider.h
|