| 5edcb5c2e3c071bc2466bb112a0e4a93fd7433f3 |
|
24-Sep-2015 |
Samuel Tan <samueltan@google.com> |
shill: remove unnecessary declarations of ::testing::Throw
::testing::Throw is not used in any of shill's unit tests, so
remove the "using" statements for Throw from the unittest
source files.
BUG: None
Change-Id: Icb6cde9121374f8b1615c51f43d3fc251ede17a4
TEST: Compile shill and run unit tests.
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| bad1c10ffd2d4ac14f7bd9f4ef6a8982e711f566 |
|
19-Sep-2015 |
mukesh agrawal <quiche@google.com> |
shill: remove references to GLib
There are a number of references to GLib (the object),
even though no one uses GLib in a substantive way.
Remove these obsolete references.
Bug: 23386647
TEST=unit tests
Change-Id: I8d574980bc8e853c8b87ef64b581d64a71491201
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| e5fe58dedad8d7fb509eb7eac82e77f8cc86ebc0 |
|
13-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: use updated supplicant proxy creation APIs
This eliminates the need for DBusManager, since supplicant process
proxy will monitor for its own service availability.
Since we don't have to re-initialize process proxy during start/stop,
interface proxy will be used instead of process proxy to indicate if
we connected to supplicant or not.
BUG=chromium:517680
TEST=unittests, wifi_matfunc tests
Change-Id: If641bfd78b74f3bbd59ca7816c4435981b0cbfbd
Reviewed-on: https://chromium-review.googlesource.com/292967
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| 608ec29525f553d51f0a92e84176e3d4b45930a9 |
|
31-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: use ControlInterface to create proxy objects
So that appropriate proxy objects can be created based on the type of
the control interface.
While there, remove ProxyFactory related files.
BUG=chromium:513791
TEST=USE="asan clang cellular wimax dhcpv6" FEATURES=test emerge-$BOARD shill
Change-Id: I465b0807ab4ccacac3891638db41384f43ef83c5
Reviewed-on: https://chromium-review.googlesource.com/289855
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| fc5236388674c3ae04255d98f5a3e93b789be185 |
|
14-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: cleanup proxy interfaces for supplicant
Remove dbus-c++ dependencies from supplicant proxy interfaces and the
classes that uses supplicant proxy interfaces. Mainly the usage of
dbus-c++ specific types: DBus::Path (replaced by std::string) and
map<string, DBus::Variant> (replaced by KeyValueStore) types.
Also update the proxy interface APIs to return boolean status instead
of passing on the DBus exception errors. Ideally, we would like to
return an error object back to the caller as well, but that would require
a method to convert dbus errors to shill errors (additional errors to
cover all possible DBus errors). And currently, those errors are used
for logging purpose only (with an exception in RemoveNetwork), where it
is already done inside the proxy APIs.
BUG=chromium:570966
TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill
TEST=Run wifi_matfunc tests
Change-Id: I227b5adc2306873480414db7d4e625bc1cc4f21b
Reviewed-on: https://chromium-review.googlesource.com/285632
Trybot-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| 7e779d87abbba4d9e50ef28513a27c7bbd5cd550 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: ethernet: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I2477041b9267ca58c94cfc15749be6bc2c992655
Reviewed-on: https://chromium-review.googlesource.com/278074
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| 8e0151e84f077cc9c0646d5bafd925ed235a1c12 |
|
04-Jun-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: refactor DHCPConfig
To better support DHCPv6 configurations, move IPv4 specific code
from DHCPConfig to the newly created DHCP4Config. The idea is to
have the base class DHCPConfig supports the basic interaction with
dhcpcd daemon, and the derived class (IP specific) for processing
events and parsing IP configurations.
An upcoming CL will add a new class DHCP6Config for processing
IPv6 configurations.
BUG=chromium:496302
TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill
TEST=Run network_Dhcp* client tests and wifi_matfunc suite
Change-Id: I1f23ec46a52b42fccf7bbc8906c5f5e506f2d1c8
Reviewed-on: https://chromium-review.googlesource.com/275274
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| 675d0b0f04936050a357722f52dc078a3ab671d8 |
|
03-Jun-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: move dhcp codes to dhcp directory
Number of files related to dhcp will increase significantly after
refactoring DHCPConfig and adding support for DHCPv6. So move
these files to a dedicated directory.
BUG=chromium:496302
TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: I7f47365158fc5e1d902946dc3403720402f9b6ad
Reviewed-on: https://chromium-review.googlesource.com/275019
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| 1a72f5444e077ed21b8e085b17d7f9f1bc44fa5e |
|
15-Apr-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: compiler option support for wifi and wired 802.1x
This allows shill to be compiled without wifi and wired 802.1x independently.
The supplicant related code will not be compiled when both wifi and wired
802.1x compiler option are disabled.
BUG=chromium:475665
TEST=USE="asan clang -wifi" FEATURES=test emerge-$BOARD shill
USE="asan clang -wired_8021x" FEATURES=test emerge-$BOARD shill
USE="asan clang -wifi -wired_8021x" FEATURES=test emerge-$BOARD shill
USE="asan clang" FEATURES=test emerge-$BOARD shill
Default shill (including both wifi and wired 802.1x):
Passes wifi_matfunc test suite
shill without wifi
No wifi connectivity
Have ethernet connectivity
Passes network_8021xWiredAuthentication test
shill without wired 802.1x
Have wifi and ethernet connectivity
Fail network_8021xWiredAuthentication test
shill without both wifi and wired 802.1x
No wifi connectivity
Have ethernet connectivity
Fail network_8021xWiredAuthentication test
CQ-DEPEND=CL:265614
Change-Id: I6abaa150657f6ca0f6d5c37229fde9a2c0bb36aa
Reviewed-on: https://chromium-review.googlesource.com/265774
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| 65a5672a129759458b87427488957cbbdb87e469 |
|
03-Feb-2015 |
Garret Kelly <gdk@chromium.org> |
shill: connect Ethernet to PPPoEService
Add a new property (Ethernet.PPPoE) to Ethernet devices which allows
them to be put into PPPoE mode. In PPPoE mode, a PPPoEService is
constructed and used in place of an EthernetService.
BUG=chrome-os-partner:32173
TEST=FEATURES=test USE="vpn cellular pppoe" emerge-x86-generic shill
Change-Id: I9d3c1c9eb542b55b9069c5ceeb99203dfd59a422
Reviewed-on: https://chromium-review.googlesource.com/246590
Reviewed-by: Paul Stewart <pstew@chromium.org>
Trybot-Ready: Garret Kelly <gdk@chromium.org>
Commit-Queue: Garret Kelly <gdk@chromium.org>
Tested-by: Garret Kelly <gdk@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| 0951ccbfca977a9cf218b2e4308aa26fb4d06ef9 |
|
10-Dec-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
Update libchrome to r307740 and fix build errors
Updated libchrome, libchrome_crypto, metrics, feedback to the
latest revisions from Chrome (r307740).
Fixed build breaks due to the changes in upstream code:
- scope_ptr no longer needs explicit PassAs<T>() calls.
- scope_ptr<T> no longer has implicit conversion to T*.
Must use scope_ptr<T>::get() instead.
- base/file_util.h moved to base/files/file_util.h
- ARRAYSIZE_UNSAFE() removed in favor of arraysize()
- base::AppendToFile() and base::WriteFileDescriptor() now
return bool instead of the number of bytes written.
- dbus::Bus::AddFilterFunction() now returns void.
- C++11 features are enabled in libchromeos, so all targets
linking with it now have to support C++11
- OVERRIDE macro is removed in favor of native C++11
'override' keyword.
BUG=chromium:416628, chromium:411508
TEST=Build the world on x86, x64, ARM. The following builders
were tried:
x86-generic-full amd64-generic-full arm-generic-full
amd64-generic-asan daisy-full nyan-full pre-cq-group
daisy-release-group sandybridge-release-group
pineview-release-group
CQ-DEPEND=CL:234450,CL:234980
Change-Id: I374bebe2211d533c4431c82efb8be1cdcb1f405d
Reviewed-on: https://chromium-review.googlesource.com/234440
Reviewed-by: Bertrand Simonnet <bsimonnet@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| 3de88a00f446215b3299fe5834d4f120863e3ac7 |
|
05-Dec-2014 |
Paul Stewart <pstew@chromium.org> |
shill: Ethernet: Retain EthernetService for life
Make the EthernetService held by the Ethernet device remain valid
for the lifetime of the Device. This allows Ethernet services to
be configured whether or not a link is available. To modify this
lifetime, it is necessary to break the reference loop between the
Ethernet device and its Service.
Instead of calling RegisterService and DeregisterService with the
EthernetService, toggle the visibility and autoconnect properties
to allow the service to disconnect and regain L2 connectivity as
link appears and disappears.
BUG=chromium:439176
TEST=The following:
- Unit tests with ASAN
- The following autotests:
+ network_Dhcp*
+ network_VPNConnect
- Manual:
+ Start shill with Ethernet connected, disconnect, reconnect
+ Start shill with Ethernet USB disconnected, connect USB (with Ethernet attached)
+ Start shill with Ethernet USB disconnected, connect USB with Ethernet detached,
then connect Ethernet
+ Monitor "list-services" to make sure the Ethernet service is only visible
(and connects) when both USB and Ethernet are connected.
Change-Id: I7f0ef8397606b69990b8dc03be75f6166aa5c017
Reviewed-on: https://chromium-review.googlesource.com/233770
Trybot-Ready: Paul Stewart <pstew@chromium.org>
Reviewed-by: Peter Qiu <zqiu@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| da69ecfa906572120eb4f6c405e7d4be38dc9701 |
|
19-Nov-2014 |
Ben Chan <benchan@chromium.org> |
shill: supplicant: Move supplicant code to its own sub-directory.
This CL is part of a series of CLs, which aim to reorganzie shill's flat
source code structure into a more modular form by moving technology
specific code into their own sub-directories.
BUG=chromium:433419
TEST=`FEATURES=test emerge-$BOARD shill`
TEST=`USE='clang asan' FEATURES=test emerge-$BOARD shill`
Change-Id: I119663a90062f7faf3038a2455d53d4ae8c5e297
Reviewed-on: https://chromium-review.googlesource.com/230750
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|
| 87602518c59af2f9e8288d81a1f877dd80f24433 |
|
08-Nov-2014 |
Ben Chan <benchan@chromium.org> |
shill: ethernet: Move ethernet code to its own sub-directory.
This CL is part of a series of CLs, which aim to reorganzie shill's flat
source code structure into a more modular form by moving technology
specific code into their own sub-directories.
BUG=chromium:433419
TEST=`FEATURES=test emerge-$BOARD shill`
TEST=`USE='clang asan' FEATURES=test emerge-$BOARD shill`
Change-Id: I9a716161c9c4f8f608d815748bde6781d83d1b34
Reviewed-on: https://chromium-review.googlesource.com/229871
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/ethernet/ethernet_unittest.cc
|